From patchwork Tue Oct 5 01:27:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 1977 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id 1wJDLfxEXGHsUQAAIUCqbw (envelope-from ) for ; Tue, 05 Oct 2021 08:28:44 -0400 Received: from proxy7.mail.ord1c.rsapps.net ([172.28.255.1]) by director11.mail.ord1d.rsapps.net with LMTP id kC6NLPxEXGG7BQAAvGGmqA (envelope-from ) for ; Tue, 05 Oct 2021 08:28:44 -0400 Received: from smtp4.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy7.mail.ord1c.rsapps.net with LMTPS id wBknLPxEXGFCQAAAknS3pQ (envelope-from ) for ; Tue, 05 Oct 2021 08:28:44 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp4.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: c7a4027e-25d7-11ec-b198-0024e87f2f2c-1-1 Received: from [216.105.38.7] ([216.105.38.7:50384] helo=lists.sourceforge.net) by smtp4.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id B9/B5-14141-CF44C516; Tue, 05 Oct 2021 08:28:44 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mXjXr-0002Mv-Qh; Tue, 05 Oct 2021 12:27:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjXp-0002Mf-K4 for openvpn-devel@lists.sourceforge.net; Tue, 05 Oct 2021 12:27:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vAejStvVfrxDwhGy8gzR7gDTNhfd4NfMNtfckg3V4Rw=; b=LRT1LZx0WI5X+AWzPr07bw5hwS GfXH2dux8Fu7MeuiFEs2WSJgqYIFWWzgFh356wifColQORi9UhVftNxG60q5rYL2pOXw4TUe8LPzG ajYMQWdcto4lVpdrfO3INBaXp09wET9/g8+i8u9yoU6PJjfRWpZNW3jQiY4VskUArcT0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=vAejStvVfrxDwhGy8gzR7gDTNhfd4NfMNtfckg3V4Rw=; b=V rAvzs86quqQNsHp5jrlEANBOLigj2/PU7RJnI+7IKhfJI2RY//U2eoUC3OySWBaRUPPqjwpw7NELC XT5/QgAUs0yfWWjI0GdA3hZENcPoTEBKV2UK47+zXgpSqcmELu+vdl8VTrm9QmLO8916hfk4A9cyx yJW70L+AB9Xwbz64=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mXjXk-0004sq-Mz for openvpn-devel@lists.sourceforge.net; Tue, 05 Oct 2021 12:27:41 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Tue, 5 Oct 2021 14:27:36 +0200 Message-Id: <20211005122736.4060-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Historically we always had -Wno-unused-parameter and -Wno-unused-function enabled along with -Wall. When we made -Wall a default option, we carried the other two along and made them default too (in 2018). Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1mXjXk-0004sq-Mz Subject: [Openvpn-devel] [PATCH] configure: remove useless -Wno-* from default CFLAGS X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Historically we always had -Wno-unused-parameter and -Wno-unused-function enabled along with -Wall. When we made -Wall a default option, we carried the other two along and made them default too (in 2018). Now the code is much cleaner compared to the past and we do not really require -Wno-unused-parameter and -Wno-unused-function anymore. Actually they may hide really unused functions that we'd need to cleanup. For this reason remove -Wno-unused-parameter and -Wno-unused-function for good from the default CFLAGS. Any new warning should rather be fixed than hidden. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7c2ead6a..a37dc762 100644 --- a/configure.ac +++ b/configure.ac @@ -1224,8 +1224,6 @@ AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [ ) ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-stringop-truncation]) -ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-function]) -ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-parameter]) ACL_CHECK_ADD_COMPILE_FLAGS([-Wall]) if test "${enable_pedantic}" = "yes"; then