From patchwork Tue Nov 30 22:20:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 2093 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id kPBcE5s+p2E6DwAAIUCqbw (envelope-from ) for ; Wed, 01 Dec 2021 04:21:31 -0500 Received: from proxy7.mail.ord1c.rsapps.net ([172.28.255.1]) by director10.mail.ord1d.rsapps.net with LMTP id 0CQbE5s+p2GkaAAApN4f7A (envelope-from ) for ; Wed, 01 Dec 2021 04:21:31 -0500 Received: from smtp12.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy7.mail.ord1c.rsapps.net with LMTPS id 0DPaEps+p2GwZQAAknS3pQ (envelope-from ) for ; Wed, 01 Dec 2021 04:21:31 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp12.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 1192aaf2-5288-11ec-b2a1-bc305bf03e5c-1-1 Received: from [216.105.38.7] ([216.105.38.7:59326] helo=lists.sourceforge.net) by smtp12.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5A/27-15205-A9E37A16; Wed, 01 Dec 2021 04:21:31 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1msLmv-0002SY-D4; Wed, 01 Dec 2021 09:20:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1msLmu-0002PG-FP for openvpn-devel@lists.sourceforge.net; Wed, 01 Dec 2021 09:20:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i/9dW/X4QOmuzXqLTAzY5XwMhQHrwYmS/9IhJxMJt6Y=; b=HMibTJnNg85bUTrGcxUqdbOP9a nQVZRYkc7dx/nMS2jpLEsyVLC2NT7eZFrph/vLBfoIa3FiqR7Jejf6TsgyXxS3QiKWHL19ZK7KIUg COZcUVkJZkhneztrwWL63jgTLDP1fi88W7Cexj56Hack6xUbTjHfGchsnhaw+8gbjUg8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i/9dW/X4QOmuzXqLTAzY5XwMhQHrwYmS/9IhJxMJt6Y=; b=ABIpcM+wm6jwDhEoAQ9Jl6VBkG W0/l9gk9xzpXrJ0x8Wu+r0fau9dlV5VDGFQhAr9tVtECEGfjTZbQWcj1CGgGo5wAFmkUuJnBlsUZd v9GYKDSQ5sOA81zBVhH3NFM2B4cUscTquxxUlOC1munJBpkgKDpEtTWPeC3y6bXQxBaA=; Received: from mail-ed1-f51.google.com ([209.85.208.51]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1msLms-0006h0-HW for openvpn-devel@lists.sourceforge.net; Wed, 01 Dec 2021 09:20:28 +0000 Received: by mail-ed1-f51.google.com with SMTP id o20so98222957eds.10 for ; Wed, 01 Dec 2021 01:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=i/9dW/X4QOmuzXqLTAzY5XwMhQHrwYmS/9IhJxMJt6Y=; b=qkyZBeyHtPdd4ttcj/VsU0UXT6pSAmi4zvYslft8e6Y86mlEqK/KEXp25GzwZY1o7I N4se82Yph2kf5WDDkpibqxPyuQtXhsCah5Rv03TUgH7xY+WBiOI5KKnrH8P1yq8q4Usf hDfbNkpNx9SG00QQab2tsVK9FdMkcjBWeTUUTDcSJ8B/OcC/16Su3FBPeOlGD2kkr7vi MXRmNmGfgt2X3LscCYRgyb2lWLN2wfalZIPS+mGsu6z5mQhOYdOk3qEKwOYhAClPiq6A JoIte12l40iGzpDHhAHsxj/UalTFYm683HS6rzCCSucPZ01JjAOnYwrXYgaqwCQbv3ht OZ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=i/9dW/X4QOmuzXqLTAzY5XwMhQHrwYmS/9IhJxMJt6Y=; b=PxrG0utjPbUT2qCsNtnfOcBdMpYq4vO+WbITy20UuKM7rJfe5/VDTzY0fSrSjQDxaZ MobqRMbAf0MgV6/meO3IhEpP1M1aOgn6i7DNsCo3iPMC/Op3HmI6hWz+Bc3M4exISzmy i+jUqOwkjarQZocPszOZfeFG4zgJlDtx7qbxcnMsR1UwZFPI1PKPJ68OQW2Qf8KHkY2e HN1z4zfnHv6RyCAmdA/zQoL5/4F9R7i+L2v4q3loXfmYfRmQwqztolbWX13jJ5ENS726 SKj7lziNfoglqZu0DP8NAiNnFhVcfHA41Ny9HTAXxtdDJSPfoCQjAoqLsfkjP2Gli+Iy 2BHA== X-Gm-Message-State: AOAM5320awCUsxMaDxe6ThmVyHKZl3mV6MwH3DnJWkRsVDRiDhwxoSjw Pv28Yyf02GiHnFsJ/qdQMfckpjzL5JQ= X-Google-Smtp-Source: ABdhPJxpwUPoAndl0xUJ6+7FmynfqbyqbOTxf6QxiUw98KqdkmyElXJCwxsdpokBl3CXUFso4UsDaw== X-Received: by 2002:a05:6402:4311:: with SMTP id m17mr6870548edc.103.1638350419909; Wed, 01 Dec 2021 01:20:19 -0800 (PST) Received: from LAPTOP-4L3N7KFS.localdomain (nat3.panoulu.net. [185.38.2.3]) by smtp.gmail.com with ESMTPSA id hv13sm10931813ejc.75.2021.12.01.01.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 01:20:19 -0800 (PST) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Wed, 1 Dec 2021 11:20:02 +0200 Message-Id: <20211201092002.162-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov Commit 95993a1df3 ("Refactored SSL initialisation functions") has declared openssl_set_mydata_index(void) function but hasn't added definition. There hasn't been need in this function for 10 years, so it can be safely removed. Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.51 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.51 listed in wl.mailspike.net] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1msLms-0006h0-HW Subject: [Openvpn-devel] [PATCH master+release/2.5] ssh_openssl.h: remove unused declaration X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Lev Stipakov Commit 95993a1df3 ("Refactored SSL initialisation functions") has declared openssl_set_mydata_index(void) function but hasn't added definition. There hasn't been need in this function for 10 years, so it can be safely removed. Found by MSVC. Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- src/openvpn/ssl_openssl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/ssl_openssl.h b/src/openvpn/ssl_openssl.h index 2eeb716c..46338c24 100644 --- a/src/openvpn/ssl_openssl.h +++ b/src/openvpn/ssl_openssl.h @@ -54,6 +54,4 @@ struct key_state_ssl { */ extern int mydata_index; /* GLOBAL */ -void openssl_set_mydata_index(void); - #endif /* SSL_OPENSSL_H_ */