From patchwork Tue Dec 7 05:50:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2121 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.28.255.1]) by backend41.mail.ord1d.rsapps.net with LMTP id qG2AFDCRr2HHOwAAqwncew (envelope-from ) for ; Tue, 07 Dec 2021 11:52:00 -0500 Received: from proxy6.mail.ord1c.rsapps.net ([172.28.255.1]) by director11.mail.ord1d.rsapps.net with LMTP id SElGLTCRr2FSdAAAvGGmqA (envelope-from ) for ; Tue, 07 Dec 2021 11:52:00 -0500 Received: from smtp12.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy6.mail.ord1c.rsapps.net with LMTPS id cDvmLDCRr2GTKAAA9sKXow (envelope-from ) for ; Tue, 07 Dec 2021 11:52:00 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp12.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: fe5a9594-577d-11ec-b2a1-bc305bf03e5c-1-1 Received: from [216.105.38.7] ([216.105.38.7:44884] helo=lists.sourceforge.net) by smtp12.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5A/B4-15205-F219FA16; Tue, 07 Dec 2021 11:51:59 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mudg9-00029B-6t; Tue, 07 Dec 2021 16:50:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mudg6-000291-VQ for openvpn-devel@lists.sourceforge.net; Tue, 07 Dec 2021 16:50:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eCIUOqSlFAXk+Dk0jszs9F7oxpMAqviyB6UF4+rMMAo=; b=Gdzk2QElNdLJlus3b+k6p60nmL BKc8TaFX7VArn2ceVUs2LxPrDD7OSGz6Oksm2BP68BzLIqDLpIXtzfDwDZBQImOSxfmF4wL25DLyC KDBBVV1qfz24ZCEPMC7pAPzpFa0vCgqViNz3moXrMK6LjQVOwBnC94iYuijyW33InEd0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=eCIUOqSlFAXk+Dk0jszs9F7oxpMAqviyB6UF4+rMMAo=; b=H ydUFgbx9A+TcOc3wx144921WKwes0jlMyEjyVbFj+U2UCNJZhqvazLy8U37zdYst5389qBpYutVim D5eXu8Pw+5tEicGsLhBQ2i5BEPSKk2RS01h31wHNR4olsnhtl9TP1YenF4G7uMIpUaUOuv9cKF9i2 nGSQUBi5LZGKKJBs=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mudg1-007Zli-IQ for openvpn-devel@lists.sourceforge.net; Tue, 07 Dec 2021 16:50:54 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1mudfn-000IZV-HP for openvpn-devel@lists.sourceforge.net; Tue, 07 Dec 2021 17:50:35 +0100 Received: (nullmailer pid 3274774 invoked by uid 10006); Tue, 07 Dec 2021 16:50:35 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Tue, 7 Dec 2021 17:50:35 +0100 Message-Id: <20211207165035.3274728-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This ifdef is redundant. Signed-off-by: Arne Schwabe --- src/openvpn/ssl_openssl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index ab9a8f347..724664bb9 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1964,13 +1964,11 @@ key_state_w [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1mudg1-007Zli-IQ Subject: [Openvpn-devel] [PATCH] Remove ENABLE_CRYPTO_OPENSSL ifdef inside ENABLE_CRYPTO_OPENSSL ifdef X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This ifdef is redundant. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/ssl_openssl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index ab9a8f347..724664bb9 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1964,13 +1964,11 @@ key_state_write_plaintext(struct key_state_ssl *ks_ssl, struct buffer *buf) int ret = 0; perf_push(PERF_BIO_WRITE_PLAINTEXT); -#ifdef ENABLE_CRYPTO_OPENSSL ASSERT(NULL != ks_ssl); ret = bio_write(ks_ssl->ssl_bio, BPTR(buf), BLEN(buf), "tls_write_plaintext"); bio_write_post(ret, buf); -#endif /* ENABLE_CRYPTO_OPENSSL */ perf_pop(); return ret;