From patchwork Mon Dec 13 05:28:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 2159 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.31.255.6]) by backend41.mail.ord1d.rsapps.net with LMTP id GG2WERh1t2GtIQAAqwncew (envelope-from ) for ; Mon, 13 Dec 2021 11:30:16 -0500 Received: from proxy8.mail.iad3b.rsapps.net ([172.31.255.6]) by director11.mail.ord1d.rsapps.net with LMTP id 0HatKRh1t2EJbQAAvGGmqA (envelope-from ) for ; Mon, 13 Dec 2021 11:30:16 -0500 Received: from smtp8.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy8.mail.iad3b.rsapps.net with LMTPS id MHwYIhh1t2E6fwAAoCsc3g (envelope-from ) for ; Mon, 13 Dec 2021 11:30:16 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp8.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=lichtenheld.com X-Suspicious-Flag: YES X-Classification-ID: f3756236-5c31-11ec-888b-5254005eee35-1-1 Received: from [216.105.38.7] ([216.105.38.7:57204] helo=lists.sourceforge.net) by smtp8.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id D8/43-10780-71577B16; Mon, 13 Dec 2021 11:30:15 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mwoCO-00037F-Dg; Mon, 13 Dec 2021 16:29:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mwoCM-000370-M1 for openvpn-devel@lists.sourceforge.net; Mon, 13 Dec 2021 16:29:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3HjstGQmLxTOZvX1KUAUleizvqQ0V2QrLdtKk+Yv/Nk=; b=QKqF2WqNSSJf/Jojp85JZN52oS gFVFLfXGOOKv4/OOwxPiXwaIHuV9bjTqvHP6qTHR8J344fh3MFZQgyhQyFiHIZ2pAOB1uS9K9QGb4 m+8vuMQxUbp6MuJp2KNoX4/fkvmk4kHaiq1p0pPIhvcG7Pn/En5L29kZg7kTGHGmlUeo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=3HjstGQmLxTOZvX1KUAUleizvqQ0V2QrLdtKk+Yv/Nk=; b=D A6V64I9MG/75+MH4HNrsnuc6AI030tEN/SuleoH0O8y/S+x/XvHui8+vVVqLOWH7ta7m409S0UxSK vKbZlJn+oTkRg7MUdn6l1MTDc/RUTV5nRS84H4lmC6oRcNefy+cdk7PMcTDvGJelzGh+doSNFFCRd 9L5Geqn6IDGOQI7A=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mwoCM-00EMMT-4q for openvpn-devel@lists.sourceforge.net; Mon, 13 Dec 2021 16:29:11 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4JCRlz0xFnzQjmp; Mon, 13 Dec 2021 17:29:03 +0100 (CET) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Mon, 13 Dec 2021 17:28:41 +0100 Message-Id: <20211213162841.15763-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The information provided by this is minimal and it makes it more difficult to provide deterministic builds. There are work-arounds for that but I think it is easier to just remove it completely. Allows the build to pass with -Wdate-time -Werror. Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1mwoCM-00EMMT-4q Subject: [Openvpn-devel] [PATCH] Make build deterministic, remove __DATE__ X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox The information provided by this is minimal and it makes it more difficult to provide deterministic builds. There are work-arounds for that but I think it is easier to just remove it completely. Allows the build to pass with -Wdate-time -Werror. Signed-off-by: Frank Lichtenheld Acked-By: Arne Schwabe Acked-by: Antonio Quartulli --- src/openvpn/options.c | 1 - src/tapctl/main.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index ac13412a..79f453d4 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -105,7 +105,6 @@ const char title_string[] = #endif #endif " [AEAD]" - " built on " __DATE__ ; #ifndef ENABLE_SMALL diff --git a/src/tapctl/main.c b/src/tapctl/main.c index a3d3966a..d60df275 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -44,7 +44,6 @@ const TCHAR title_string[] = TEXT(PACKAGE_NAME) TEXT(" ") TEXT(PACKAGE_VERSION) - TEXT(" built on ") TEXT(__DATE__) ; static const TCHAR usage_message[] =