From patchwork Sat Jan 20 05:41:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 204 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director2.mail.ord1d.rsapps.net ([172.30.191.6]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id I+SFOYBxY1qYWwAAgoeIoA for ; Sat, 20 Jan 2018 11:42:40 -0500 Received: from proxy17.mail.ord1d.rsapps.net ([172.30.191.6]) by director2.mail.ord1d.rsapps.net (Dovecot) with LMTP id y7JfOYBxY1pJMQAAgYhSiA ; Sat, 20 Jan 2018 11:42:40 -0500 Received: from smtp36.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy17.mail.ord1d.rsapps.net (Dovecot) with LMTP id LJk4JIBxY1p5EgAAWC7mWg ; Sat, 20 Jan 2018 11:42:40 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp36.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=karger-me.20150623.gappssmtp.com; dmarc=none (p=nil; dis=none) header.from=karger.me X-Classification-ID: ede4b166-fe00-11e7-9ba4-525400c11307-1-1 Received: from [216.34.181.88] ([216.34.181.88:40974] helo=lists.sourceforge.net) by smtp36.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2C/49-23468-081736A5; Sat, 20 Jan 2018 11:42:40 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1ecwCw-00057a-3H; Sat, 20 Jan 2018 16:41:30 +0000 Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ecwCv-00057T-8l for openvpn-devel@lists.sourceforge.net; Sat, 20 Jan 2018 16:41:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2EP9zta4uvIrglGv7N0gKb9xMIQhgv69f4wLps99stA=; b=YT2gbeHcuXPHM3vsZzUtjxrPuN GlotRQ02RStzeO8O35Kt/lDDdWzp7vCSY8xdwnQPi9xfggO5TinSAIDJ6/rC3w1aua2wwbai77mjJ tWicGMT19E5ENCt4z6vz844o+LKnDU4GZMJcDbOstX41hoXyuqUkUkaCMqwQ6k+Hbf4U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2EP9zta4uvIrglGv7N0gKb9xMIQhgv69f4wLps99stA=; b=KQifxfC8hm01dG0K2nP9GvLZk2 J5oD/gIeu5onKW5IhZvZrVWdRGYwox7Q/JBvtUtj1ilre61s0MpfBou2EafdMnCRfs6bNXNLhUwHW Kp5IOdtci85iIpeZ4RAfp2kw9vr+mK3PI2xK5+QFfIQ7fSNE70YkGSM+ZqOzUr82cIPQ=; Received: from mail-wm0-f68.google.com ([74.125.82.68]) by sfi-mx-1.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1ecwCr-0005iU-Hb for openvpn-devel@lists.sourceforge.net; Sat, 20 Jan 2018 16:41:29 +0000 Received: by mail-wm0-f68.google.com with SMTP id i186so8799411wmi.4 for ; Sat, 20 Jan 2018 08:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karger-me.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=2EP9zta4uvIrglGv7N0gKb9xMIQhgv69f4wLps99stA=; b=eOC7+r3cAhXQeF30sipjbYgROGBxJY8vv4RdRCD2AyAEkpyKeI09TOv2cn2neMlSlV mHDHN3li6tISVTYRDp0O5cqUiZliLNKMcqgZdcuqCAzfSizSN8lGjwm4dmenutcFnR85 PU4c/xSNS6AHqGNsNK4hzIgCqBzwzev9zry5WNArtfbQ3/2FYmwHJ3PPz0UZK5LlCNHy fQX8yVoujeb3NEagrVC2dxXkuVR/muKoowJIHkVXiuAMhcUhZxgCjCQr370qe4mRcQGz naQm7DL8Wf9kD0hesw5N+v8QKgbAhr0AWTpP0n7VQFCf7/L19ilwkZiYr9VK/amaCCOf BwVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2EP9zta4uvIrglGv7N0gKb9xMIQhgv69f4wLps99stA=; b=IUgHQbo1lacA8OtuHFGOjpYM4avTyPJ8P9pvxHE/SZXHOxuX/iLKie7S0PWhrKhT4s qynilniQf+mFJXM4u/Gu1nr1XZOF50TKH+5UK0dibRMsn6/bd4MvWrmzq5FLWvBpSsgw XDAlvwlZ8BxmO6YlKbmKaVIA0D307Kdnqp/QLj8sEY7u2FBWqlV75y+L7uVZwIgm4oBj twtq8bEFRd2eY/nnKjh3uYTlTDyEtbxhOl/cFJzB9xgu735EGfVVLwQRL2xj0QKomcJs 1TBiGrd3GtSXOybqH9BLQ8uV5eKKNwjZ+XRGdahOEaWOlFsTaWU6orgjn62A5aMZ3AzQ pQVg== X-Gm-Message-State: AKwxytfxOZv7xqG9viE6sCQEBlR+0p6kaxQaJbF1mZAHdphbhgsgMo18 5qSDHKe7dyCfquEisXHHgHPEy1KPOH8= X-Google-Smtp-Source: AH8x225iC5gyYlcYG6/bs3iBmIH9yE7UM9InLecFDgcPhP2D63eHdXvQv8FfJUjM8841867mF3pfgA== X-Received: by 10.80.148.248 with SMTP id t53mr4701990eda.180.1516466479180; Sat, 20 Jan 2018 08:41:19 -0800 (PST) Received: from vesta.fritz.box ([2001:985:e54:1:b14e:834e:d73e:5c7]) by smtp.gmail.com with ESMTPSA id b12sm7880901eda.81.2018.01.20.08.41.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Jan 2018 08:41:18 -0800 (PST) From: Steffan Karger To: openvpn-devel@lists.sourceforge.net Date: Sat, 20 Jan 2018 17:41:14 +0100 Message-Id: <20180120164114.12478-1-steffan@karger.me> X-Mailer: git-send-email 2.14.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.68 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1ecwCr-0005iU-Hb Subject: [Openvpn-devel] [PATCH] Enable extra compiler warnings by default X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This by default enables the compiler warnings any could previously enable using the --enable-strict configure option. I think it is okay to do so now, because we've taken care of many warnings in the more standard builds. (Most of those were totally harmless, but they prevented us from spotting new more serious mistakes.) Those who prefer a more silent build can use --disable-strict to revert to the old default behaviour. Signed-off-by: Steffan Karger --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 2c1937e5..2b5fa533 100644 --- a/configure.ac +++ b/configure.ac @@ -209,9 +209,9 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], + [AS_HELP_STRING([--disable-strict], [enable strict compiler warnings (debugging option) @<:@default=yes@:>@])], , - [enable_strict="no"] + [enable_strict="yes"] ) AC_ARG_ENABLE(