From patchwork Wed Jan 26 13:14:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 2259 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.31.255.6]) by backend41.mail.ord1d.rsapps.net with LMTP id KHNcJiPk8WEjLgAAqwncew (envelope-from ) for ; Wed, 26 Jan 2022 19:15:31 -0500 Received: from proxy18.mail.iad3b.rsapps.net ([172.31.255.6]) by director14.mail.ord1d.rsapps.net with LMTP id KBRWOyPk8WG4AQAAeJ7fFg (envelope-from ) for ; Wed, 26 Jan 2022 19:15:31 -0500 Received: from smtp20.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy18.mail.iad3b.rsapps.net with LMTPS id sF/ENSPk8WHlSAAA3NpJmQ (envelope-from ) for ; Wed, 26 Jan 2022 19:15:31 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp20.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 3c8bb334-7f06-11ec-b03e-525400497f28-1-1 Received: from [216.105.38.7] ([216.105.38.7:46132] helo=lists.sourceforge.net) by smtp20.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id AB/F4-22355-224E1F16; Wed, 26 Jan 2022 19:15:31 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nCsQi-0006xe-BN; Thu, 27 Jan 2022 00:14:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nCsQh-0006xY-48 for openvpn-devel@lists.sourceforge.net; Thu, 27 Jan 2022 00:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4QRvGwA+qI7/zmhVXNniqIm+1OOHEO43CjOKStSj1gM=; b=YM6QLOiklxHxJ+vyDmvHnr1WFj znT/YhzrtMJTxVzdzSgLvxx7uddBj6Jivi7cHY3+e3j2GGdTLpMe6d5a4/eLWjHVgokrsv9YO7U9f bult8jqmiSraH1ADpsWDA0i5J67zUqbtvkMBqL/vWkygpRxUuxEBb8DcPk8TTXw53qzM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=4QRvGwA+qI7/zmhVXNniqIm+1OOHEO43CjOKStSj1gM=; b=f 2ufdolMlSCyVej/5JR+dg7JbZiheADEvW697IQA4xzRq18qVjvnC/I3lLc0tYaOwR+7guDUkcfP1M jerQxbs6/euIMoKC8Ge/dwi9xaOrCzDVTQmvBINPUus9efntUdoO0TKucVOk8UhY/ylUKlp8Zeq1I cvs0nz/CO0t5TUL8=; Received: from mail-qt1-f177.google.com ([209.85.160.177]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1nCsQe-00FItS-A9 for openvpn-devel@lists.sourceforge.net; Thu, 27 Jan 2022 00:14:21 +0000 Received: by mail-qt1-f177.google.com with SMTP id e16so1169916qtq.6 for ; Wed, 26 Jan 2022 16:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QRvGwA+qI7/zmhVXNniqIm+1OOHEO43CjOKStSj1gM=; b=OvUqDUk9s/8NiR85yGYRT+IAg5qqyAflob6hmluIylSs06J3vH0ai4qN+S+j0F5NGq 6Pn2B05pDyn3H9vLJqo1nIXKMyM08ghlQX0MHWu8WQvKyMg6oBzBJk6vtA4WNsQDlcMG U4zYWCr3oSbc7I3CbpSkGfN2slrrHpFbJfPI4LPnQcIz8IaIR/xtKxNeczv4DzFeWMdu sk8EkduDpk9X2m3VVIKhXzhGr3soC9m8ACkvjBllhB86kHgtdpexLEfKJXB3OfItJ7tK ZZTNszOI+hdcWn1K7gsu6U5Hb3oRg1et0+g/9WUN3lLuhSZ3k7V+PCZgjR2GPrSgMn/T kBGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QRvGwA+qI7/zmhVXNniqIm+1OOHEO43CjOKStSj1gM=; b=NNhAs6+Qp56l00GW55oVkkTRji/R/Q05zYvIg5go3Y762BNMBrmDklaQVUId++KeSG dv6toNI8ysKBS6cTf6ylK1Ak/6tJ71Ntn6lLI1glqDhPbmrPAl9rqDhdNFXjAmsWE7hq yHQbsqy2Bkb2k2zV+NerWKBOGmuPYO2uX08fxXPc5X8LiiPlHZLYGz81EGuFyPdg236S wOpT8THnWaHNmzxfKJkkOV740rUHbdpB0FAXJ5yMLrwV8gA6qoXzygbfIDmH2IAEl1a9 ydQP9BlEs2Ifq2AWhfUvP8wp/XiDoE3ScsQqBjka8oOBX3Br8ZWRIB803dqriLoTPa1O yVtQ== X-Gm-Message-State: AOAM5310IvmwquZb+Mk9UVLjRPC6zZhIdHPT4khza3GtSteV5G3gZf8z sRA7rxBC78sQzF/2/vJIymp7UAdB3ak= X-Google-Smtp-Source: ABdhPJyHrVkV6guAWJ0HwkjFf7gz9eHuk70USGga+G9enlzpYlJp5PsFDYT5VEpWuz+w+CdXJac4Sg== X-Received: by 2002:ac8:5cc9:: with SMTP id s9mr914766qta.507.1643242454355; Wed, 26 Jan 2022 16:14:14 -0800 (PST) Received: from uranus.home.sansel.ca (bras-vprn-tnhlon4053w-lp130-03-70-53-19-97.dsl.bell.ca. [70.53.19.97]) by smtp.gmail.com with ESMTPSA id m22sm487634qtk.37.2022.01.26.16.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 16:14:13 -0800 (PST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Wed, 26 Jan 2022 19:14:10 -0500 Message-Id: <20220127001410.7587-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Reported-by: Arne Schwabe Signed-off-by: Selva Nair --- src/openvpn/pkcs11_openssl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/openvpn/pkcs11_openssl.c b/src/openvpn/pkcs11_openssl.c index a82b4b32..c4f88816 100644 --- a/src/openvpn/pkcs11_openssl.c +++ b/src/openvpn/pkcs11_openssl.c @@ -89,7 +89,14 @@ set_ps [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.160.177 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.160.177 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Headers-End: 1nCsQe-00FItS-A9 Subject: [Openvpn-devel] [PATCH] pkcs11_openssl.c: check EVP_get_digestbyname() != NULL X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair Reported-by: Arne Schwabe Signed-off-by: Selva Nair Acked-by: Antonio Quartulli --- src/openvpn/pkcs11_openssl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/openvpn/pkcs11_openssl.c b/src/openvpn/pkcs11_openssl.c index a82b4b32..c4f88816 100644 --- a/src/openvpn/pkcs11_openssl.c +++ b/src/openvpn/pkcs11_openssl.c @@ -89,7 +89,14 @@ set_pss_params(CK_RSA_PKCS_PSS_PARAMS *pss_params, XKEY_SIGALG sigalg, pss_params->mgf = mdtypes[i].mgf_id; /* determine salt length */ - int mdsize = EVP_MD_size(EVP_get_digestbyname(sigalg.mdname)); + const EVP_MD *md = EVP_get_digestbyname(sigalg.mdname); + if (!md) + { + msg(M_WARN, "WARN: set_pss_params: EVP_get_digestbyname returned NULL " + "for mdname = <%s>", sigalg.mdname); + goto cleanup; + } + int mdsize = EVP_MD_get_size(md); int saltlen = -1; if (!strcmp(sigalg.saltlen, "digest")) /* same as digest size */