From patchwork Sun Feb 13 13:31:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2281 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id YHh4BDejCWLJCgAAqwncew (envelope-from ) for ; Sun, 13 Feb 2022 19:32:55 -0500 Received: from proxy9.mail.ord1d.rsapps.net ([172.30.191.6]) by director8.mail.ord1d.rsapps.net with LMTP id YH+dDzejCWLgIgAAfY0hYg (envelope-from ) for ; Sun, 13 Feb 2022 19:32:55 -0500 Received: from smtp36.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy9.mail.ord1d.rsapps.net with LMTPS id iJs2DzejCWJnFwAA7h+8OQ (envelope-from ) for ; Sun, 13 Feb 2022 19:32:55 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp36.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: a619f5ec-8d2d-11ec-b41f-525400c11307-1-1 Received: from [216.105.38.7] ([216.105.38.7:40592] helo=lists.sourceforge.net) by smtp36.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 91/FE-05864-633A9026; Sun, 13 Feb 2022 19:32:54 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nJPHk-0006Js-8p; Mon, 14 Feb 2022 00:32:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nJPHa-0006JU-Ud for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 00:31:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dt0zi0+jcq2cEGo1lbGISoHO35eQ8kS6ingmDJVbWYI=; b=mf/OkkCFQWsvn/SOM4sf5oTDBo efcmh1iVkaxPoLYVFuxHZLOJtQP2A2POfEdCMB6ChUf6oNKd+xy9ZEQQjo1AuivMHB0ydjwz4Wpz7 fhjRz9RpccQLE6zajsEY5uqNeQf1Wwf0ePhii4OUxQcFcVs2zz2BXXyTm+FxR5U4CC5Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=dt0zi0+jcq2cEGo1lbGISoHO35eQ8kS6ingmDJVbWYI=; b=D ruCIOO2a4FCn2VjM/xRR1RYIw/00zvYySZjKc3AOF6P+ahVR2Z6ckEFzG1ZalYlPyGAxglYkq5ONl xLyON9jws6R0jquptpilLaQkuKTbtSCuAaI9fjMml8Q3v1VlOtW3SMJBlQIE01A/5zmr/+rZOpVWc P4KsoCEmNcQXmrmI=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nJPHU-000sK3-TF for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 00:31:54 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1nJPHI-000LUY-VA for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 01:31:40 +0100 Received: (nullmailer pid 3741398 invoked by uid 10006); Mon, 14 Feb 2022 00:31:40 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Mon, 14 Feb 2022 01:31:40 +0100 Message-Id: <20220214003140.3741349-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Arne Schwabe --- src/openvpn/ssl_common.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h index 42b63cd0..10a3f730 100644 --- a/src/openvpn/ssl_common.h +++ b/src/openvpn/ssl_common.h @@ -522, 9 +522,10 @@ struct tls_session # [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1nJPHU-000sK3-TF Subject: [Openvpn-devel] [PATCH] Add better documentation for CAS_* states X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/ssl_common.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h index 42b63cd0..10a3f730 100644 --- a/src/openvpn/ssl_common.h +++ b/src/openvpn/ssl_common.h @@ -522,9 +522,10 @@ struct tls_session #define KEY_SCAN_SIZE 3 -/* client authentication state, CAS_SUCCEEDED must be 0 since - * non multi code path still checks this variable but does not initialise it - * so the code depends on zero initialisation */ +/* multi state (originally client authentication state (=CAS)) + * CAS_NOT_CONNECTED must be 0 since non multi code paths still check + * this variable but do not explicitly initialise it and depend + * on zero initialisation */ /* CAS_NOT_CONNECTED is the initial state for every context. When the *first* * tls_session reaches S_ACTIVE, this state machine moves to CAS_PENDING (server) @@ -532,11 +533,11 @@ struct tls_session * connect scripts/plugins */ enum multi_status { CAS_NOT_CONNECTED, - CAS_WAITING_AUTH, /**< TLS connection established but deferred auth not finished */ - CAS_PENDING, - CAS_PENDING_DEFERRED, - CAS_PENDING_DEFERRED_PARTIAL, /**< at least handler succeeded, no result yet*/ - CAS_FAILED, + CAS_WAITING_AUTH, /**< Initial TLS connection established but deferred auth is not yet finished */ + CAS_PENDING, /**< Options import (Connect script/plugin, ccd,...) */ + CAS_PENDING_DEFERRED, /**< Waiting on an async option import handler */ + CAS_PENDING_DEFERRED_PARTIAL, /**< at least handler succeeded but another is still pending */ + CAS_FAILED, /**< Option import failed or explicitly denied the client */ CAS_WAITING_OPTIONS_IMPORT, /**< client with pull or p2p waiting for first time options import */ CAS_CONNECT_DONE, };