From patchwork Sun Feb 13 13:33:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2282 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id EFudFYWjCWKECwAAqwncew (envelope-from ) for ; Sun, 13 Feb 2022 19:34:13 -0500 Received: from proxy18.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net with LMTP id uJoxIYWjCWLjRwAApN4f7A (envelope-from ) for ; Sun, 13 Feb 2022 19:34:13 -0500 Received: from smtp32.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy18.mail.ord1d.rsapps.net with LMTPS id aNDJIIWjCWKVeQAATCaURg (envelope-from ) for ; Sun, 13 Feb 2022 19:34:13 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp32.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: d4df88ec-8d2d-11ec-8e0b-52540099eaf5-1-1 Received: from [216.105.38.7] ([216.105.38.7:60048] helo=lists.sourceforge.net) by smtp32.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 59/25-18540-483A9026; Sun, 13 Feb 2022 19:34:13 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nJPJ5-0001tv-6a; Mon, 14 Feb 2022 00:33:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nJPJ3-0001tp-Cu for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 00:33:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yf42qt46vWdsmd+We+dbDhnANWD2CfB/I6fr/AvDw70=; b=Fm6W8pndnbJrbwa/CCLBNx99Fw PJNIf7p6RJXcHzp3nibJa4wh6KqJTfMg0uxxXK3xxKc2d4l9aq5ebWtjKOEBL/GehRwmhm8ioker/ bfzYLUPRUUbq1Cneyy52X2RLmwUjZO9e6CGbcC6zWbi2An3KzS21tiTg1hkeLeM87gLs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=yf42qt46vWdsmd+We+dbDhnANWD2CfB/I6fr/AvDw70=; b=W tJJy8E511XZVWFTAPINNuSiF+Lkf8JX0mj0BoJDnYolmk0uKHzX6aZmE9oIm7wi1NKkIBTy82+RUT MRBCuoE5s2K4zdc8TWhVGyAWfjjipFJXKvJY03dGeknlAbW8N8zbXIJswXZpRBz77wbxz+BiLzMDJ axKS7aKrJCjaA9Hc=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nJPJ1-000sVR-L8 for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 00:33:28 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1nJPIv-000LV4-7A for openvpn-devel@lists.sourceforge.net; Mon, 14 Feb 2022 01:33:21 +0100 Received: (nullmailer pid 3741628 invoked by uid 10006); Mon, 14 Feb 2022 00:33:21 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Mon, 14 Feb 2022 01:33:21 +0100 Message-Id: <20220214003321.3741582-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: --- tests/unit_tests/openvpn/test_crypto.c | 28 ++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/tests/unit_tests/openvpn/test_crypto.c b/tests/unit_tests/openvpn/test_crypto.c index 7fb9d624..ca170547 100644 --- a/tests/unit_tests/openvpn/test_crypto.c +++ b/tests/unit_tests/openvpn [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1nJPJ1-000sVR-L8 Subject: [Openvpn-devel] [PATCH] Add unit test for mssfix with compression involved X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox --- tests/unit_tests/openvpn/test_crypto.c | 28 ++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) Acked-by: Gert Doering diff --git a/tests/unit_tests/openvpn/test_crypto.c b/tests/unit_tests/openvpn/test_crypto.c index 7fb9d624..ca170547 100644 --- a/tests/unit_tests/openvpn/test_crypto.c +++ b/tests/unit_tests/openvpn/test_crypto.c @@ -426,6 +426,34 @@ test_mssfix_mtu_calculation(void **state) assert_int_equal(f.mss_fix, 927); } } +#ifdef USE_COMP + o.comp.alg = COMP_ALG_LZO; + + /* Same but with compression added. Compression adds one byte extra to the + * payload so the payload should be reduced by compared to the no + * compression calculation before */ + for (int i = 990;i <= 1010;i++) + { + /* 992 - 1008 should end up with the same mssfix value all they + * all result in the same CBC block size/padding and <= 991 and >=1008 + * should be one block less and more respectively */ + o.ce.mssfix = i; + frame_calculate_dynamic(&f, &kt, &o, NULL); + if (i <= 991) + { + assert_int_equal(f.mss_fix, 910); + } + else if (i >= 1008) + { + assert_int_equal(f.mss_fix, 942); + } + else + { + assert_int_equal(f.mss_fix, 926); + } + } + o.comp.alg = COMP_ALG_UNDEF; +#endif /* tls client, auth SHA1, cipher AES-256-GCM */ o.authname = "SHA1";