From patchwork Wed May 18 04:10:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Mikkelsen X-Patchwork-Id: 2474 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id yFvYCPgEhWI0NQAAqwncew (envelope-from ) for ; Wed, 18 May 2022 10:38:48 -0400 Received: from proxy3.mail.ord1d.rsapps.net ([172.30.191.6]) by director7.mail.ord1d.rsapps.net with LMTP id aMFkEvgEhWIFFAAAovjBpQ (envelope-from ) for ; Wed, 18 May 2022 10:38:48 -0400 Received: from smtp22.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.ord1d.rsapps.net with LMTPS id 4IgCEvgEhWKAWgAA7WKfLA (envelope-from ) for ; Wed, 18 May 2022 10:38:48 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp22.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=transactionware.com X-Suspicious-Flag: YES X-Classification-ID: 393a4f42-d6b8-11ec-abac-5254001a15c2-1-1 Received: from [216.105.38.7] ([216.105.38.7:59698] helo=lists.sourceforge.net) by smtp22.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 4D/0A-14080-6F405826; Wed, 18 May 2022 10:38:47 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nrKo9-0008L6-Ak; Wed, 18 May 2022 14:37:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nrKo7-0008Ks-By for Openvpn-devel@lists.sourceforge.net; Wed, 18 May 2022 14:37:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=To:Date:Message-Id:Subject:Mime-Version: Content-Transfer-Encoding:Content-Type:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sCC5m71urPBzlO3HKprtGsBHYkNdWwX0hKpPw/w2NSM=; b=a1bJFEoOm+IJ8DAdLG7CE5Le4R rc6x25lNEnBvY6cft796wahbT060p5gMWGk1KVE5jzL7Nc0Bvzrwjo50RqcrIrVBqncYnn5S+9XJA 3wB4508Rc7UqL+Xs7mhgT0S+Z/QLeLxtIKtK1vhc+cWTIw4qHlbrtY2pu+lKE1RkUGg4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=To:Date:Message-Id:Subject:Mime-Version:Content-Transfer-Encoding: Content-Type:From:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sCC5m71urPBzlO3HKprtGsBHYkNdWwX0hKpPw/w2NSM=; b=YQ2f+IdJN7pvfDpi0S4ALn9Mey 5Denz1ECASzKJb3Zr62SWnseoEV1JdfSWbGPYVhh2C3AgmOrhglHgFvBHct6x8s7MAluibx7mLlT0 JoD98e6EphBiw4AQih+jAC8xoaG/Qhh3UzA+B4GovSgBHo8b8GLYUpINBz5tmK/bs63w=; Received: from mail.transactionware.com ([203.14.245.7] helo=mail3.transactionware.com) by sfi-mx-1.v28.lw.sourceforge.com with smtp (Exim 4.94.2) id 1nrKo3-006zZU-IS for Openvpn-devel@lists.sourceforge.net; Wed, 18 May 2022 14:37:47 +0000 Received: (qmail 51389 invoked by uid 907); 18 May 2022 14:10:54 -0000 Received: from i5E86455C.versanet.de (HELO smtpclient.apple) (94.134.69.92) (smtp-auth username janm, mechanism plain) by mail3.transactionware.com (qpsmtpd/0.84) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPSA; Thu, 19 May 2022 00:10:54 +1000 From: Jan Mikkelsen Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Message-Id: <2735E502-7F1F-48E9-8011-6740251E81DE@transactionware.com> Date: Wed, 18 May 2022 16:10:47 +0200 To: Openvpn-devel@lists.sourceforge.net X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, The file doc/man-sections/cipher-negotiation.rst is missing from the from the openvpn-2.5.6 source tarball, making it hard to rebuild the openvpn(8) man page from source. That file is also missing from the "openvpn_sections" assignment in doc/Makefile, meaning that the openvpn(8) man page won't get rebuilt if the man-sections/cipher-negotiation.rst file changes. Content analysis details: (0.4 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Headers-End: 1nrKo3-006zZU-IS Subject: [Openvpn-devel] [PATCH] cipher-negotiation.rst missing from doc/Makefile.am X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Hi, The file doc/man-sections/cipher-negotiation.rst is missing from the from the openvpn-2.5.6 source tarball, making it hard to rebuild the openvpn(8) man page from source. That file is also missing from the "openvpn_sections" assignment in doc/Makefile, meaning that the openvpn(8) man page won't get rebuilt if the man-sections/cipher-negotiation.rst file changes. The underlying problem seems to be that doc/Makefile.am has not been updated according to the directions in the file: # NOTE: Remember to add source .rst files to $(dist_noinst_DATA) below # This could be automated with GNU Make, but we need BSD Make support This has been forgotten for doc/man-sections/cipher-negotiation.rst. Trivial patch attached. I reported this as a bug a while ago, but I’m not sure they get noticed. For reference: https://community.openvpn.net/openvpn/attachment/ticket/1461 Thanks, Jan M. --- doc/Makefile.am.orig 2022-04-07 12:46:47.384178000 +0200 +++ doc/Makefile.am 2022-04-07 12:47:10.961292000 +0200 @@ -25,6 +25,7 @@ openvpn_sections = \ man-sections/advanced-options.rst \ + man-sections/cipher-negotiation.rst \ man-sections/client-options.rst \ man-sections/connection-profiles.rst \ man-sections/encryption-options.rst \