From patchwork Wed May 18 14:10:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Openvpn-devel] cipher-negotiation.rst missing from doc/Makefile.am X-Patchwork-Submitter: Jan Mikkelsen X-Patchwork-Id: 2474 Message-Id: <2735E502-7F1F-48E9-8011-6740251E81DE@transactionware.com> To: Openvpn-devel@lists.sourceforge.net Date: Wed, 18 May 2022 16:10:47 +0200 From: Jan Mikkelsen List-Id: Hi, The file doc/man-sections/cipher-negotiation.rst is missing from the from the openvpn-2.5.6 source tarball, making it hard to rebuild the openvpn(8) man page from source. That file is also missing from the "openvpn_sections" assignment in doc/Makefile, meaning that the openvpn(8) man page won't get rebuilt if the man-sections/cipher-negotiation.rst file changes. The underlying problem seems to be that doc/Makefile.am has not been updated according to the directions in the file: # NOTE: Remember to add source .rst files to $(dist_noinst_DATA) below # This could be automated with GNU Make, but we need BSD Make support This has been forgotten for doc/man-sections/cipher-negotiation.rst. Trivial patch attached. I reported this as a bug a while ago, but I’m not sure they get noticed. For reference: https://community.openvpn.net/openvpn/attachment/ticket/1461 Thanks, Jan M. --- doc/Makefile.am.orig 2022-04-07 12:46:47.384178000 +0200 +++ doc/Makefile.am 2022-04-07 12:47:10.961292000 +0200 @@ -25,6 +25,7 @@ openvpn_sections = \ man-sections/advanced-options.rst \ + man-sections/cipher-negotiation.rst \ man-sections/client-options.rst \ man-sections/connection-profiles.rst \ man-sections/encryption-options.rst \