From patchwork Sat Feb 10 23:19:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 233 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director3.mail.ord1d.rsapps.net ([172.27.255.55]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id k4XuDw4ZgFqdPQAAgoeIoA for ; Sun, 11 Feb 2018 05:21:02 -0500 Received: from proxy14.mail.iad3a.rsapps.net ([172.27.255.55]) by director3.mail.ord1d.rsapps.net (Dovecot) with LMTP id G6FkCg4ZgFpYJgAAkXNnRw ; Sun, 11 Feb 2018 05:21:02 -0500 Received: from smtp30.gate.iad3a ([172.27.255.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy14.mail.iad3a.rsapps.net (Dovecot) with LMTP id GpzfBw4ZgFq0OQAA1+b4IQ ; Sun, 11 Feb 2018 05:21:02 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp30.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (key not found in DNS) header.d=karger-me.20150623.gappssmtp.com; dmarc=none (p=nil; dis=none) header.from=karger.me X-Classification-ID: 42336b20-0f15-11e8-83b7-bc305bf63980-1-1 Received: from [216.34.181.88] ([216.34.181.88:5424] helo=lists.sourceforge.net) by smtp30.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 05/8A-31759-D09108A5; Sun, 11 Feb 2018 05:21:01 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1ekoja-0003PR-BL; Sun, 11 Feb 2018 10:19:46 +0000 Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.194] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ekojY-0003PK-CV for openvpn-devel@lists.sourceforge.net; Sun, 11 Feb 2018 10:19:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Vd6s7oAb2kO1RfpQaJjXfrMQhtCjWIYBkvT3lUH2tlk=; b=WXY8T173wEBbk4fjDcIyKlp5oA oo+/6IHx7w+HyNOKhJR0cCyjxv4AFkgufJOQq0INW9ej3Nnidv1IjhbGggDEItWPuV7rwIpbWgbpy cMBuFuFUWkdbMjwk+M8WBGu0XVhrvFL5sFSMO6TwXrSitK2IzbGjTzF7O6YDIPfxjt3E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Vd6s7oAb2kO1RfpQaJjXfrMQhtCjWIYBkvT3lUH2tlk=; b=RN3q1QjfG8g4zvHbmn3/0RbLzU lGi79MduiXthtaSaEJudP/eLp8v7/5NU0YWbn/gQyTozy/eBFFkYRowEnIMs9YU0HRn0srswlT+CH u1Fiqr70lfh2S5ujjHWneumC2kodSVubsbgQ/mGupKw69FP47n4cgg4ZbwP9s9ypFUZo=; Received: from mail-wm0-f49.google.com ([74.125.82.49]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1ekojV-0004Ev-St for openvpn-devel@lists.sourceforge.net; Sun, 11 Feb 2018 10:19:44 +0000 Received: by mail-wm0-f49.google.com with SMTP id r78so4842891wme.0 for ; Sun, 11 Feb 2018 02:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karger-me.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Vd6s7oAb2kO1RfpQaJjXfrMQhtCjWIYBkvT3lUH2tlk=; b=j44VZEyRYNMiIqJUJi0XbQ/aGL+zQnmDzM3zbKWT4Byn/mrihnDm3yc3gQL2lMDmtX 1YS52YkCY5xYIqCR2Rb/HOrv1UsCCwherWKMlkqWHdINf27xXAUjEMjow6yQAdVMvhsu yxspz59eFXAWPaV+mIOovtrLLT5rulRjDFGaKyxnPqH8q5H8Hxj4+Cn/SoiHZBE5Huwm 34rL6mxXMobnu+UrNva87J2ZKda3wqduWN5tPN/dQ7q3LefL12vim1B4Qb1tbtI5PVyl WSLba4sXOyf3niW3Zvlu03O7TMN84aMCMTqvat3Ocm5fTCTBNfs9ktktKWAg5Fr+ROJp SxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Vd6s7oAb2kO1RfpQaJjXfrMQhtCjWIYBkvT3lUH2tlk=; b=g85L7ROn2mfWr8fvbAP7TesZisDf/P/AYT1laVyoHOQJezczjcpeSzNcwr/9HKzg14 S3abW8bzUphhlxz7QBbBGqAJTqhkN71EpPlc3NjBSMlXDv+IHZhkOTfrf/P24RmTnUXa W4ev+z0pB9sZnDJw6NQNZKAMNTww3vJJkks5jemPLTwwFgjKHuG8B609ktXWForKz2fI 9htx4GB2P7gOggv4GJWgVmBZ9nwji/mIaeVtPRCFrI+7TJm+ekTZEV6XCwdYXEOgkOg7 +X7+9WubxjVhz4q6GsA49DIGvUVFAY/dLMkeirj2IKlfxkwRtXAeyALlZeRIiXC1pXU4 y2aw== X-Gm-Message-State: APf1xPA/+bj3N8MbJc4PeXrJe1pRH8ZmoXn6elh1LzMINkTm4z2dzjk5 TFRC8cDB85qr4cQWN42qJ78WD/FLofc= X-Google-Smtp-Source: AH8x226iNbUcW1leRHNoVvqFet6SbsOkp8zRNNzAz/WNLX636u4To2AYHlMREuAfVrfQPloBB2D5Tw== X-Received: by 10.80.212.2 with SMTP id t2mr11422886edh.54.1518344375537; Sun, 11 Feb 2018 02:19:35 -0800 (PST) Received: from vesta.fritz.box ([2001:985:e54:1:cb8:907e:51eb:9b9b]) by smtp.gmail.com with ESMTPSA id p14sm3877053edj.46.2018.02.11.02.19.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2018 02:19:34 -0800 (PST) From: Steffan Karger To: openvpn-devel@lists.sourceforge.net Date: Sun, 11 Feb 2018 11:19:29 +0100 Message-Id: <20180211101929.4535-1-steffan@karger.me> X-Mailer: git-send-email 2.14.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1ekojV-0004Ev-St Subject: [Openvpn-devel] [PATCH] Log pre-handshake packet drops using D_MULTI_DROPPED X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox We have a debug level packets dropped by the TLS layer - use that for this packet drop too. This changes this message from 'verb 3' to 'verb 4' (which should result in less user reports about this almost always harmless warning). Signed-off-by: Steffan Karger Acked-by: Gert Doering --- src/openvpn/ssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 676d0b90..d758c31a 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -3361,7 +3361,7 @@ tls_pre_decrypt(struct tls_multi *multi, { if (!ks->crypto_options.key_ctx_bi.initialized) { - msg(D_TLS_DEBUG_LOW, + msg(D_MULTI_DROPPED, "Key %s [%d] not initialized (yet), dropping packet.", print_link_socket_actual(from, &gc), key_id); goto error_lite;