From patchwork Tue Aug 9 23:46:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 2646 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.27.255.53]) by backend30.mail.ord1d.rsapps.net with LMTP id WOiwGLl+82J0BgAAIUCqbw (envelope-from ) for ; Wed, 10 Aug 2022 05:47:37 -0400 Received: from proxy5.mail.iad3a.rsapps.net ([172.27.255.53]) by director9.mail.ord1d.rsapps.net with LMTP id qFtrGLl+82KEegAAalYnBA (envelope-from ) for ; Wed, 10 Aug 2022 05:47:37 -0400 Received: from smtp2.gate.iad3a ([172.27.255.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy5.mail.iad3a.rsapps.net with LMTPS id z2WKD7l+82K+WAAAhn5joQ (envelope-from ) for ; Wed, 10 Aug 2022 05:47:37 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp2.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=lichtenheld.com X-Suspicious-Flag: YES X-Classification-ID: 76cad6cc-1891-11ed-bbeb-525400de56ae-1-1 Received: from [216.105.38.7] ([216.105.38.7:51684] helo=lists.sourceforge.net) by smtp2.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2E/67-10547-8BE73F26; Wed, 10 Aug 2022 05:47:36 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1oLiIS-0004DE-Jq; Wed, 10 Aug 2022 09:46:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oLiIB-0004D1-Mp for openvpn-devel@lists.sourceforge.net; Wed, 10 Aug 2022 09:46:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hxy8BK8QlAjoF/46jHSm1ud+y8Sz+eoHdzbUajDsC+o=; b=XDwavkAlmYJrdnD4hUr23esAur 8g/Lv6Zioot3uE6tD3mKfvnOP3kik+vj8w2t23mbmJw4u+hk7WbeIN9YgJjSIBBVa7OllH3LiXQqW NsPjukOektXPMhYmbBu0H7Opf7/9SeCwt4fILRnK+fIE8uM8zi5J6XQImuJU4SVewRV4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Hxy8BK8QlAjoF/46jHSm1ud+y8Sz+eoHdzbUajDsC+o=; b=l WQvMAssy7nOSCViAGgcfcbJX/OYS37u/pWH0WC4/kzC8jclC4eBX6EWETprM9ofniJt5JZ0yiOT5A 8jPyUdcwGjBBtlpXRzndbSTlTfeIeDSBBdjvoCPrFSCN7tHQMxavr8o3gzpMSXDaUZ7CuG6hXbkPH 9t+czo1GRYKOsPj8=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1oLiI5-0001Ht-WC for openvpn-devel@lists.sourceforge.net; Wed, 10 Aug 2022 09:46:22 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4M2lSG3qWJz9sQj for ; Wed, 10 Aug 2022 11:46:06 +0200 (CEST) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Wed, 10 Aug 2022 11:46:05 +0200 Message-Id: <20220810094605.123072-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4M2lSG3qWJz9sQj X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Currently we issue a message when using --ifconfig but not specifying a default gateway. This seems to be misleading, the setup will still work fine since in P2P we now send all traffic to the peer an [...] Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] X-Headers-End: 1oLiI5-0001Ht-WC Subject: [Openvpn-devel] [PATCH] dco_p2p_add_new_peer: do not warn about missing default gw X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Currently we issue a message when using --ifconfig but not specifying a default gateway. This seems to be misleading, the setup will still work fine since in P2P we now send all traffic to the peer anyway. Or it might be irrelevant if all route specifications include a gateway anyway. Since it is probably better to have no message than a misleading one, remove it. Signed-off-by: Frank Lichtenheld Acked-by: Antonio Quartulli --- src/openvpn/dco.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 4f40255e..8aa7e896 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -438,10 +438,6 @@ dco_p2p_add_new_peer(struct context *c) } remote_addr4 = &remote_ip4; } - else if (c->options.ifconfig_local) - { - msg(M_INFO, "DCO peer init: Need a peer VPN addresss to setup IPv4 (set --route-gateway)"); - } struct sockaddr *remoteaddr = &ls->info.lsa->actual.dest.addr.sa;