From patchwork Fri Nov 11 11:16:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 2847 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id kFThFjcvbmP1YQAAIUCqbw (envelope-from ) for ; Fri, 11 Nov 2022 06:17:11 -0500 Received: from proxy17.mail.iad3b.rsapps.net ([172.31.255.6]) by director8.mail.ord1d.rsapps.net with LMTP id eATvFjcvbmO/agAAfY0hYg (envelope-from ) for ; Fri, 11 Nov 2022 06:17:11 -0500 Received: from smtp22.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy17.mail.iad3b.rsapps.net with LMTPS id ON6xDzcvbmOFSQAA5ccGVQ (envelope-from ) for ; Fri, 11 Nov 2022 06:17:11 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp22.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=lichtenheld.com X-Suspicious-Flag: YES X-Classification-ID: 6272187e-61b2-11ed-98e5-52540041dff8-1-1 Received: from [216.105.38.7] ([216.105.38.7:36448] helo=lists.sourceforge.net) by smtp22.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id DD/E2-27115-63F2E636; Fri, 11 Nov 2022 06:17:10 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1otS1b-0008N9-4v; Fri, 11 Nov 2022 11:16:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1otS1W-0008My-9f for openvpn-devel@lists.sourceforge.net; Fri, 11 Nov 2022 11:16:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3hKJPwW3z7EZ4SpZ4wOnluUP/u/IdnrhTF5A8STKxtQ=; b=MFPLv/BTxi1d0Ke8ZOJt6idSzH ua9fp5D7AwPaeIfqrjK8GnCKCBUpkW/uCdOz1u3arUrS4KPgZkfZGPJRicZpvjGl08ZDTRF5h+pAj YCqFfj3M6E2lHKxAEa7uQ8MycUWKcmOM6l+RfkdHJ3ClU8ZpzXZfy+GLDfOui2jQrBqY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=3hKJPwW3z7EZ4SpZ4wOnluUP/u/IdnrhTF5A8STKxtQ=; b=K Z3jT2GOjtptlev2+FM5E9mH2GQU831BBsUqs2p+jC5Xn5U8ywgN5Ly7ZYeG1WrxaVq7Yd+BfY0nCL dG8GS+mUU8Jr19c1SE2+Kiz16A2rJdXdEtVeaaA2q9Ldk8AmLeCoCffHbh9iuAz/upZ70fnHxd8zf VaG+Y6NZs2jzbbOw=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1otS1U-004IEl-28 for openvpn-devel@lists.sourceforge.net; Fri, 11 Nov 2022 11:16:38 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4N7x3S4by2z9sRT for ; Fri, 11 Nov 2022 12:16:20 +0100 (CET) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 11 Nov 2022 12:16:19 +0100 Message-Id: <20221111111619.21415-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: There is no easy way to detect whether this information is outdated. One possible optimisation would be in the Python code to actually only rewrite the file if it has changed. Although VC is already p [...] Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.151 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1otS1U-004IEl-28 Subject: [Openvpn-devel] [PATCH] msvc: always regenerate config-msvc.h X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox There is no easy way to detect whether this information is outdated. One possible optimisation would be in the Python code to actually only rewrite the file if it has changed. Although VC is already pretty good in detecting whether the code has actually changed so this might not be worth the additional complexity. While here, change some leading whitespace to tabs as expected in Makefile. Signed-off-by: Frank Lichtenheld --- build/msvc/msvc-generate/Makefile.mak | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Note: this patch applies to both master and release/2.5 cleanly and should be pushed to both. diff --git a/build/msvc/msvc-generate/Makefile.mak b/build/msvc/msvc-generate/Makefile.mak index ae8b0842..1c1c4bab 100644 --- a/build/msvc/msvc-generate/Makefile.mak +++ b/build/msvc/msvc-generate/Makefile.mak @@ -51,10 +51,13 @@ $(OUTPUT_PLUGIN): $(INPUT_PLUGIN) $(OUTPUT_PLUGIN_CONFIG) cscript //nologo msvc-generate.js --config="$(OUTPUT_PLUGIN_CONFIG)" --input="$(INPUT_PLUGIN)" --output="$(OUTPUT_PLUGIN)" $(OUTPUT_MAN): $(INPUT_MAN) - -FOR /F %i IN ('where rst2html.py') DO python %i "$(INPUT_MAN)" "$(OUTPUT_MAN)" + -FOR /F %i IN ('where rst2html.py') DO python %i "$(INPUT_MAN)" "$(OUTPUT_MAN)" -$(OUTPUT_MSVC_GIT_CONFIG): - python git-version.py $(SOLUTIONDIR) +# Force regeneration because we can't detect whether it is outdated +$(OUTPUT_MSVC_GIT_CONFIG): FORCE + python git-version.py $(SOLUTIONDIR) + +FORCE: clean: -del "$(OUTPUT_MSVC_VER)"