From patchwork Fri Feb 17 12:21:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 3087 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp1236952dyk; Fri, 17 Feb 2023 04:22:55 -0800 (PST) X-Google-Smtp-Source: AK7set+1d2H2h+vW+vJzK9ASq7oZzKGoG7RcQW+BlDFeo4p6Y/DGgqkP7xwoVJIHo+Z4edIDhTYv X-Received: by 2002:a05:6870:c0c6:b0:16d:f177:1a1a with SMTP id e6-20020a056870c0c600b0016df1771a1amr4911294oad.46.1676636575162; Fri, 17 Feb 2023 04:22:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676636575; cv=none; d=google.com; s=arc-20160816; b=YMAVrLvhUv9sD4VMQc0uk2+ykhm+HmCtsdbvdDIYcLzDfRMhXnfUCqMoVYYkXaf9yR bQbTJQ3ZPjNaKjjx8eDnOYb/+H6FtKxDPtsVOWGWOYf3cPaIeBGS8GgpP2e52cID6Eaf mX0iTZrIRdEztT4oBGVTrn27XlD5GuyOW6LCiqXurrUf2HU41Z33+8lMa/JlH/etDw2D U79X1XMw57JLKd2MkLUkyuMK55uMaO5zvd+r/ypudJ+ImeY2H0jB7WtZXl24GZz6nGXk CLJXaTkenqqEcCqmlQs/ZsrdymOp3iZGOoTrVTJ+PaIKuAfCdUSD7jjXxBp1FuABuoc2 misA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=21HkRjQDYfMx6VY2vkY6PQlMrup5N5O2vC3Vo5tMLOk=; b=nloqbTfUaMGpaXu1i5H1GYQ4BgAwMZFVp54mH3ptfsJbQXb0HeSV1NB/7GF7OmaPDc SRREwchQdaGoUNFJHyDd2roZlLWHLaeDptFW1lgA+teIhFKlvMjIZOdLtCNF5GWOM7Ud i68+ryXo7fRjYcH7knSOMq2CnVJuXEFnAfA9JP25ms2mr8jKShBxPtXs8kOhyEejvd0q CHSzzGOMw19UOEYU1NH1CVatLsVqTV3wJ6i8NGqwwWhrDffmtbVkzHRyVFOCwTOeEo4E 6wk4AI93AF75BfQtgDq4Q2BnFy3GccFxp8m9k72laxT26VugY/E6onlnwKP4f54UVwW8 hr7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mArTVZ2R; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Fsbxlacv; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=SKnHhxRC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id m16-20020a4ad510000000b0051fb8d7f653si5233731oos.58.2023.02.17.04.22.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2023 04:22:55 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mArTVZ2R; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Fsbxlacv; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=SKnHhxRC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pSzky-0002D0-El; Fri, 17 Feb 2023 12:22:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSzkw-0002Cu-0S for openvpn-devel@lists.sourceforge.net; Fri, 17 Feb 2023 12:22:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZMN5fhK8TLOvRPA9PbMkoyntq60HfML62RqTd59vmW4=; b=mArTVZ2Rz34Y0mMqVVr2kLICC1 OJMzI1sRT2O+bjo4slahb1Jtp3dDvKo+vokIt0FaWTLaCXywaGxzdQ1NJ/MGIDFl7y3FGsYixF3pt Ac5wHcnKosrJskOHchx1B8Tm2J1QsTa2+IK9oE/mMdsIuEnMSM2LE17LFOW/kzY3sqjk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ZMN5fhK8TLOvRPA9PbMkoyntq60HfML62RqTd59vmW4=; b=F sbxlacvfp7P49yhEWYkooOD9RsBP9DoUCLl7pbhXwwvCLmLWLzl2hDKKJ9c9nJe3uYgZugFA+/Q6G 36AHmz/QaPKBTKkxicJGIRqxqhriKeiLkTTdDPK9aWqjQitjyQ5es1V8730xq6qK3CjUs6QUKeL1p 1s4K8H+wTV1xeNsg=; Received: from mail-io1-f45.google.com ([209.85.166.45]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pSzko-0000ws-FZ for openvpn-devel@lists.sourceforge.net; Fri, 17 Feb 2023 12:22:21 +0000 Received: by mail-io1-f45.google.com with SMTP id f11so124987ioz.3 for ; Fri, 17 Feb 2023 04:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZMN5fhK8TLOvRPA9PbMkoyntq60HfML62RqTd59vmW4=; b=SKnHhxRCU4WkgdawCAQey2dOad1YsAcgswUP2445sma7DCi23GM69sZUM2stTrHmaE 9KBg9bXNN9LEDzmoMJLQsh9zzbWlqxTtUu8wSpX7aA1He+9BBRtTezlY+T6Jzt2EtMEK VrBBDCjJVO9s+VujvF1fVcFo/eAfMuFsDJ1jAFrGFkhuFyO0KAT6V9pkYxYy5JmPS7fS iElaFM0wfe07J6dbQ3dPU0Qp9OaW3yuLvtnjWgAr5AEqDijTgR/t48jD/H7NS65Za6i/ WMNU4DxlQJ9H+kBWum2JD9504xN8jRF5mh04RGmuXdBy8p4xJGyCsgmFLKJZ7TTCObwn vR6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZMN5fhK8TLOvRPA9PbMkoyntq60HfML62RqTd59vmW4=; b=lfUWdgUqTbXt94f13HFpUqYpnRi1zSPVH3gP4pJlJIcZVhsHeLCnmj1Es3MgjZ9L0L iDmDMhmXeQlxVNNq6f67CLeuF4bMPy2Dv1P2PfG2/kGv/UqX6Y7O+cmzEq8VvltPYa2W 4zuMCUKwssIviUbYucxbqbRUgitMWNfvaKdn2TwE81naCD/0IgcVCEsj9aADBnI8h5Vb xLpBJvo2n0wR/EdbluXbhpz5Z08ECSf9fDeu2Q8XBNSM5DTJvq2vt41gidI+qZIrEAsr fhLp0wjEApQ5N5PjIDJn0py2sl5GHkrhBAJTtUwEHHCJg+KUZnENDG+my5XixEfbxfpo RAmQ== X-Gm-Message-State: AO0yUKXdHN83PD401v+H80tUE5iUHClPwWMU5saBAM7G2/J/T0EZRE0s u+4wTrfbbeSi9hZBH3EAeoqAy8eIZBY= X-Received: by 2002:a6b:fb0b:0:b0:722:de:1afa with SMTP id h11-20020a6bfb0b000000b0072200de1afamr401450iog.3.1676636533401; Fri, 17 Feb 2023 04:22:13 -0800 (PST) Received: from localhost.localdomain ([2a00:1d50:3:0:7004:3f52:53c1:9196]) by smtp.gmail.com with ESMTPSA id z1-20020a02cea1000000b003c48ba8f772sm1354155jaq.151.2023.02.17.04.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 04:22:13 -0800 (PST) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Fri, 17 Feb 2023 14:21:55 +0200 Message-Id: <20230217122156.541-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.38.1.windows.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov This log message is printed within check_tls(), which is called by pre_select(), which is called on every iteration of event loop. When management is attached (and doesn't use own event loop), this message sets management state to "wait write", which arms event loop. When on the next iteration iowait returns with "management writ [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.45 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.45 listed in wl.mailspike.net] X-Headers-End: 1pSzko-0000ws-FZ Subject: [Openvpn-devel] [PATCH] Avoid management log loop with verb >= 6 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1758080873331740296?= X-GMAIL-MSGID: =?utf-8?q?1758080873331740296?= From: Lev Stipakov This log message is printed within check_tls(), which is called by pre_select(), which is called on every iteration of event loop. When management is attached (and doesn't use own event loop), this message sets management state to "wait write", which arms event loop. When on the next iteration iowait returns with "management write event is set", we call pre_select() and print that message again, causing the loop. Fix by simply removing this log message. Signed-off-by: Lev Stipakov Acked-by: Antonio Quartulli --- src/openvpn/dco.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 3087a0df..b53332a8 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -133,8 +133,6 @@ dco_get_secondary_key(struct tls_multi *multi, const struct key_state *primary) bool dco_update_keys(dco_context_t *dco, struct tls_multi *multi) { - msg(D_DCO_DEBUG, "%s: peer_id=%d", __func__, multi->dco_peer_id); - /* this function checks if keys have to be swapped or erased, therefore it * can't do much if we don't have any key installed */