From patchwork Thu Mar 30 09:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3176 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:5492:b0:b2:b40d:92f9 with SMTP id ab18csp1041810dyc; Thu, 30 Mar 2023 02:43:34 -0700 (PDT) X-Google-Smtp-Source: AK7set/C3FbCy3wfjJNclvjGIlqVlpjl5nv6sAsIdKH1mMohviV035Tbl7A2yhPaprPqVgX3eErs X-Received: by 2002:a05:6a20:4f1f:b0:d9:6079:acae with SMTP id gi31-20020a056a204f1f00b000d96079acaemr19049269pzb.46.1680169413871; Thu, 30 Mar 2023 02:43:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680169413; cv=none; d=google.com; s=arc-20160816; b=dtOlo8zeK8LuF5L00sIksz67+YmhqMLyURBWUwte1PLESb5pz0W7onNQobNNFVUSKR jJnBOcd7Fzobkmuu+cmzUKNJ3ESSUrVTbHetVRKNPvMS7iTtgdkQx4PZcKX7jgwasSqw gS4bPTdB4nicyqs8oxf/EWY09Ix5IZIoLEceX3TVy13JZc5KwYUiv+YUwLbRgdWy92kj 4nleh2wxS3PmQGESTteMSsRPsj9gjbk0Opjt9DorW537mFjpzqt43HOWy9Wbx8hMTfiL uzyGuMikKKFTBiqqQOM2t4E9RlAMyXV/csJCO+8/R9qKjWDL7sa6P1DHSfydHG0yxuJG GEWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=TNITheX4SncnGoinEyi/hW6H34plkNVUlfw+qE8VCpo=; b=yebF7PF+C8OFyleZwqPaZTWi1D0tvChwN1fCOfAOjAfA7SaJpN8A5sp4ATF1Jp2YlR l8tK24QLZS3f68B9wc17Ycld0jMmFUpT9sJaAVmj9V+sjsAmzBj/+3ZTTnxZmyo4Koh5 +A/8MnSP70/2P8X97hCJGzEX4yN/wkyXM6vok1KyIVehwXjqFJC7ZQxhbsrWEq1IPF0o x6WhZnvqdXNjp3qxEVNpg1zbm7+ZQpl5yvERdmF3Plfqi7yO16zaEo/NjQbIH7ryV3Hy 7dyoF0zTVyMYZEX7+UIsRs6H/sUrceijlwdafvGZh3aQKf4y5wOjhKyEcEqlRQEBD2l/ WGVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Opt4qF9G; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fNHBllGg; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=XTvG1aBS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id i16-20020a63e450000000b004fb887b4733si35185350pgk.874.2023.03.30.02.43.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2023 02:43:33 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Opt4qF9G; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fNHBllGg; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=XTvG1aBS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1phong-0003N6-Rj; Thu, 30 Mar 2023 09:42:32 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1phonf-0003Mz-PO for openvpn-devel@lists.sourceforge.net; Thu, 30 Mar 2023 09:42:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3jWfJ17U9kFplib/QKF5MElG8eORcCwxhFGSzIKaiPQ=; b=Opt4qF9Gc2RiLjZzFWjy8AQBzk NuRvDIOq9IjJmNUCIi6rR/IM3ahTiX+T2mTDROaW43angFU07Edn3f41ux/iP8tufjHuOjhwPjHvb 8GFEaGgcuQ/EzbpV3dyaT0rMen7GjunHEbup8Y6NJePHrQ7WUlbPUa6mDCobEjiQRPlA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=3jWfJ17U9kFplib/QKF5MElG8eORcCwxhFGSzIKaiPQ=; b=f NHBllGgwvo12Lkp5BLSal2CEq6jaIQqrnG+6wZVrhqME0toTo/P71K8zTcSBnL3Gz7TB/YfyBa6X7 igByun2lkT2qB96pWiZFL/6r0m0Myv2QVrK8rR9v1p56jBUENZmM+F+XM8jdXazGE9A45yrpsypTX +dVX+l1/i3crmzUQ=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1phonb-009PhK-IU for openvpn-devel@lists.sourceforge.net; Thu, 30 Mar 2023 09:42:30 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4PnJNm5v3cz9sSS for ; Thu, 30 Mar 2023 11:42:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1680169336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3jWfJ17U9kFplib/QKF5MElG8eORcCwxhFGSzIKaiPQ=; b=XTvG1aBSva55QJIS16qt6WoP4JZxFlJ5JXUuXSmT8/GCK6VDuvt+WCRvCBJwUdFcZxVKan PCiAvuEcOyyDrploxzhY39iIJ/OT8Rbajdl5x6pHzcWZXyYrnFFQd65YXyx/VabFNrBr21 QuV6x2nKy+72mhcpLrkooP91E4+CjG9aYy4MRhU7xPi54HCPbRjoiw9NZay3kJyQTqXYPE eGKAHbZQmnROsawi1RI5W/iC0/OVhElS2o20dKpBDRGFQJMmxg4ZEnjrcZdgt6XYyj8N6r cohk2lnMDLVHpbC6IPSLFaS0ymIBnFxwOk+PCBDJgrw44eyWY+fHa0FSj609Nw== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Thu, 30 Mar 2023 11:42:15 +0200 Message-Id: <20230330094215.487924-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This only defines three types and none of them is used anywhere in our source code. Signed-off-by: Frank Lichtenheld --- configure.ac | 5 +---- src/openvpn/syshead.h | 16 2 files changed, 1 insertion(+), 20 deletions(-) Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1phonb-009PhK-IU Subject: [Openvpn-devel] [PATCH] Do not include net/in_systm.h X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1761785323373446301?= X-GMAIL-MSGID: =?utf-8?q?1761785323373446301?= This only defines three types and none of them is used anywhere in our source code. Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- configure.ac | 5 +---- src/openvpn/syshead.h | 16 ---------------- 2 files changed, 1 insertion(+), 20 deletions(-) Suggested by Arne in his CMake patch. Confirmed and tested. diff --git a/configure.ac b/configure.ac index ca85e5ed..e1e79ebf 100644 --- a/configure.ac +++ b/configure.ac @@ -453,7 +453,7 @@ AC_CHECK_HEADERS([ \ fcntl.h io.h \ sys/types.h sys/socket.h \ unistd.h dlfcn.h \ - netinet/in.h netinet/in_systm.h \ + netinet/in.h \ netinet/tcp.h arpa/inet.h netdb.h \ versionhelpers.h \ ]) @@ -489,9 +489,6 @@ SOCKET_INCLUDES=" #ifdef _WIN32 #include #endif -#ifdef HAVE_NETINET_IN_SYSTM_H -#include -#endif #ifdef HAVE_NETINET_IP_H #include #endif diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index 53359225..7181b94d 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/syshead.h @@ -221,10 +221,6 @@ #include #endif -#ifdef HAVE_NETINET_IN_SYSTM_H -#include -#endif - #ifdef HAVE_NETINET_IP_H #include #endif @@ -241,10 +237,6 @@ #include #endif -#ifdef HAVE_NETINET_IN_SYSTM_H -#include -#endif - #ifdef HAVE_NETINET_IP_H #include #endif @@ -265,10 +257,6 @@ #include #endif -#ifdef HAVE_NETINET_IN_SYSTM_H -#include -#endif - #ifdef HAVE_NETINET_IP_H #include #endif @@ -301,10 +289,6 @@ #include #endif -#ifdef HAVE_NETINET_IN_SYSTM_H -#include -#endif - #ifdef HAVE_NETINET_IP_H #include #endif