From patchwork Mon Sep 4 14:22:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3332 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:390:b0:d7:3b0f:3938 with SMTP id 16csp1241533dyq; Mon, 4 Sep 2023 07:23:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2U4JIJwLLKp1uXCXIY3on/qOkP3bDV6B+fDVP6e9+4X8WVlaPQ+MddvzDoPNHUOj/WjUm X-Received: by 2002:a17:902:728e:b0:1c3:4073:bf80 with SMTP id d14-20020a170902728e00b001c34073bf80mr1778905pll.0.1693837399591; Mon, 04 Sep 2023 07:23:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693837399; cv=none; d=google.com; s=arc-20160816; b=iwvwMdUBK0VP8gX+w2Z9X8gz0jz2rry+x+ZffOJKRnW41406MGAWjw79HWThdbqDCS IRHLcrVwVEhmSDVnLzBJ7vB2Xc/yGi+F7KOZKTWSX8MtB3BdcwWtbzrBMq7PhHJWIM+a fonQD1LcbwqCbjrsb1RGqrMjyEy4tRvq7sy4YqTWJKVZr2TaC4lQIcy71dc/xGzRfNXN NcSWS6dIqfjRh16lNRTPIFBG5OymJevGfYwV2SrZpwyqOEZsg3MTZMBDdDF3GV7QFcn5 6zphxcIU4ISssT9Gv9BoMQi0WbXYKuDQ3FW6ijSjrtpNkgDOiIslIMxMTrgI6VcW443O EzUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=SbqiSpge9hgLrQjO+ceIXaZwMt1r8Jhaok/454eidMc=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=jzgivyttWr/0WvUhH9OG2n8yiKVRxaL/VHVe4xiEcbCUZLd0je8FbkLbt6GAyPDlK/ rWZGiExhTWYLHfjfKMmeCZ/yu/tliFbNYbZpAhZLwnA72tkoc0pZCpLvuh8+Pjcz0cbv VHrlzoV+sjMDaW1Y+0zAvWfEt4zbv0ogOtNnlfccf92XO7tCE7m8XjiZgA601h2TtWFs /dyiirtl5l/r+NCvnobZOIidr1I18Hn7zeI75Zu9vMcSUppaa5jnUl0ihN7ZMVbQBoNy hskFYU9sInqqJghl0Ag5tA1eaofHVTz4PouWI4MtCEOFs7jLqjX7IoNp6whOHHFgqXtS DyEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WqnTXfry; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TP6wT7WU; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AuEYmQug; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id b4-20020a170902d50400b001bb9c731a41si7765020plg.623.2023.09.04.07.23.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2023 07:23:19 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WqnTXfry; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TP6wT7WU; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AuEYmQug; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qdATC-0000ln-DI; Mon, 04 Sep 2023 14:22:25 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qdATB-0000lc-72 for openvpn-devel@lists.sourceforge.net; Mon, 04 Sep 2023 14:22:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1WHZmC2fFdjDrSwgA9NOYEuXUPIRgeirqd1ri6W+ERM=; b=WqnTXfry+kImY/LulcyhUJai4k 3JUAtlX2OiUJ26uxNtRcxA/abibhL0I4c5f/qd1X8tlJURKT8LGRAAKC1IJ4BmxpT0vq8JjQs3oay 0Rhuhejtch0vTF1jliV3bueBAWlhOQWxunQbW5j7HvN7ERdKKyNExGNpkv9XYQ2Rh+Ik=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=1WHZmC2fFdjDrSwgA9NOYEuXUPIRgeirqd1ri6W+ERM=; b=T P6wT7WUgc5Pbd7slLfodhMICcdoZNy33BFbRcQJ7v5hoSknTu8+JE3llqgs/3AKQOekIkd2B1LOob ZXuvvjuO+Ziqdmlk8DJzAeKYvXd8ZtZ0wagzWsdPrAjVZ3E3jj/cpHytBslCflUMundWrsHbZJjgn WcX4S4evF79nqYYk=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qdAT9-009Klc-7P for openvpn-devel@lists.sourceforge.net; Mon, 04 Sep 2023 14:22:24 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-401d67434daso16181985e9.2 for ; Mon, 04 Sep 2023 07:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1693837336; x=1694442136; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=1WHZmC2fFdjDrSwgA9NOYEuXUPIRgeirqd1ri6W+ERM=; b=AuEYmQugdXp4iCyBnbU390rhKxQqAsDKq+sow+B3eEzX6c5DvjI4OUQ2ld0zteJaQO 85QOL5LNOGYLGBe9W75wjvEHFOxbYh0uwUIe6IiGytLRNR5Ph9SOsYekeVc3zFkFWHj1 1RuUyN3Jg8tMNsD2pGWRWV3l/AwIFkmXgrhX++B74gTamp1sW31gcDS7ht8wEh3oGSAr nT948B9pAv1TQeTPJoXREB96EfayaeIYhqxrufTZeqgqyvrwZvO8b2A2hezsTt2SrkP/ CoKRFOzcpTwrfgDpI4xUsm7Hd2PhNcPYQ1dbqnG5ATzaXeF1xnWrrlzER1Kxgb8QXLrK dyZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693837336; x=1694442136; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1WHZmC2fFdjDrSwgA9NOYEuXUPIRgeirqd1ri6W+ERM=; b=WebdBfjrVrfB7gKxbDs0SSScQvHjddAoxvBuDFd2PzrV+4GsXKry0zu8000bOkdB3j 1PINGf0Lomoe4eRBhgabKqHdepHPybFIerCzgO8BK6mURmqrtFP/M3asmgM5UMUmNzvf bcp1RC7wXmSo4Cp1SmIqdWqFpnXXKF+lDkKIsHb9zcZEOpBE7Lx7Sx3ShgbILr0I4Pnz VMeEqjzOFa78RV5B22UwY8xxICt/GOLu1NtpjzBVKKVd9euM5rFXVYefUrfqyIUUyLy7 ZxlpXI4v+KYo4XhgNURlJmTtMczM5xACT8hteX49kRqSSWdgTZ0gPYWFUtjEO0gn9Mh3 cbCg== X-Gm-Message-State: AOJu0YxUD1FgHWKus3AB0xD62UWZLwq/wLWI2GKINj9+vLvcb1Um0THN hCZ7v6022H3EyftkDQXCl+YQhhsTGS+HCqv9RMs= X-Received: by 2002:a1c:771a:0:b0:3fe:e7b2:c97f with SMTP id t26-20020a1c771a000000b003fee7b2c97fmr7486106wmi.36.1693837336283; Mon, 04 Sep 2023 07:22:16 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id l3-20020a1ced03000000b003feae747ff2sm17500196wmh.35.2023.09.04.07.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Sep 2023 07:22:15 -0700 (PDT) From: "stipa (Code Review)" X-Google-Original-From: "stipa (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 4 Sep 2023 14:22:14 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e X-Gerrit-Change-Number: 327 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 1e9418d8abbb65a0b5dbb5c16abfba99d3d6f19b References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qdAT9-009Klc-7P Subject: [Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lstipakov@gmail.com, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1776117245484061996?= X-GMAIL-MSGID: =?utf-8?q?1776117245484061996?= Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email to review the following change. Change subject: Support for long INFO/INFO_PRE messages ...................................................................... Support for long INFO/INFO_PRE messages Current hardcoded limit is not defined anywhere and the server (CloudConnexa) sends the longer string in some cases. Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e Signed-off-by: Lev Stipakov --- M src/openvpn/push.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/27/327/1 diff --git a/src/openvpn/push.c b/src/openvpn/push.c index d468211..663cfbd 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -243,7 +243,7 @@ * We use >INFOMSG here instead of plain >INFO since INFO is used to * for management greeting and we don't want to confuse the client */ - struct buffer out = alloc_buf_gc(256, &gc); + struct buffer out = alloc_buf_gc(1 + 7 + 1 + BLEN(&buf) + 1, &gc); buf_printf(&out, ">%s:%s", "INFOMSG", m); management_notify_generic(management, BSTR(&out));