From patchwork Tue Sep 12 10:52:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "its_Giaan (Code Review)" X-Patchwork-Id: 3346 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:390:b0:d7:3b0f:3938 with SMTP id 16csp319792dyq; Tue, 12 Sep 2023 03:53:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOCkns19A2RBPZbhQEQUOYR51sq4rWdS3n8iwjuOcxkgSZutSzfr5chIZOxuHvlLQlR2a8 X-Received: by 2002:a17:90a:43c5:b0:26b:27f6:9027 with SMTP id r63-20020a17090a43c500b0026b27f69027mr11670907pjg.1.1694516000037; Tue, 12 Sep 2023 03:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694516000; cv=none; d=google.com; s=arc-20160816; b=ZTEAwyLB9BTsQfEKNl/x3gBmktT7YBUv3wnc3HuriQ/aKCxNiktPJBpYpTilevmfAj rGXa6H9lTzr4XNTJFz4cMjP+w6/AnQ7rUMZm02vtXj7sXVVYB6Lr3DAVQErr0HaPKCE3 FK+ZcQd3rBBQilplxI9xGDQkY0rTwgM9iUREkflLWgg4M9/Pr4fuTJEYmsyvk81DvTxv pxkCEID7STo5v5lLyX0J78ogVmaRi4jSleqlfO6kNqOuuk8v/D0/hM/e93MNnBRzETju Pp+Oa2tvuGsCb5PMVVZ+BUiRS2mo7BdkYYxSTAa46f54Ab2b9QRSjeMPDJTgJi7q1wL/ L8HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:date:from :dkim-signature:dkim-signature:dkim-signature; bh=wmyV+GqP7gOVXwH5kMT7V+jk+g0M21+RsTbaFnGC+kw=; fh=65XNDMZDtUAVPEs22K9ZMElrrCiP292uHQHDlBUdKcw=; b=AzUxYruNyhe6fS3GiF+PBWHSAz9/M5gvONEEEg1+lGMtY4F5caf+8gCzdLLydA3kRY Ue5TYht/TDLwPIGFvAG4ziFRzweN7lwRyus6iq88i4bEzKAMp7WN5gxPN8LqBwY+l3j8 R7wq/v704Xo55BV9yk7LOoUBl7hP/7E7pWWBKQS0H2rXOACXRl67TP8Pn5/L1+vk+ueu M+c12A/wMuBckp4kDZ4Uvu4xlr8UXtw5jUPVLGsZObcoRJlz13KnXhElDkKnGaYfbeeG 5j7PI7VUtcLNRvK0D8WsOWrYwBgI9AxjVZNcw706KGtC3q31W1n0WwjaZpcC3e5B7G70 +/pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LhVsA46A; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=KAksKyDn; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AZ2alQH7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ob7-20020a17090b390700b002465d98f18csi10154576pjb.170.2023.09.12.03.53.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Sep 2023 03:53:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LhVsA46A; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=KAksKyDn; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AZ2alQH7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qg10r-0005pW-FP; Tue, 12 Sep 2023 10:52:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qg10p-0005pM-Fu for openvpn-devel@lists.sourceforge.net; Tue, 12 Sep 2023 10:52:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:Date:From :Sender:To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7pKYdC6OPu/SdsfW2R1gyG+BN5dT6ZErCruP4a30LhM=; b=LhVsA46A8Gqx+Yi35OgcSeVYi1 0nL3BQ5SfLV8GfnX1zKMHkfgWJ8PAtYrMUanKO/Njrb3If/Ns52nXC+SCoWGBkdZaex9gh34Hp8wF FW+i3YDp5lm+/iHIJhjP+NqKoMam9+WN34v1/69JYiy8igoVqqG6VP0J7BgS5CA5Ykf8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:Date:From:Sender:To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=7pKYdC6OPu/SdsfW2R1gyG+BN5dT6ZErCruP4a30LhM=; b=K AksKyDnUqZHxKJDG4n2BvMI4CEUWt1KcJkaDYZ8fVYDunbByCtkAa8P260DkK/cE2QeCHEyOuukQE Ab1qHnbiaI828TJl0aogtKqLGqdZC7iEXe721bfXKWMX1HsFyjz5EYZafQY3hBBQX/2wCs51KoouB NbzdtZ19yyLxNIM8=; Received: from mail-wm1-f53.google.com ([209.85.128.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qg10k-0002Q7-SQ for openvpn-devel@lists.sourceforge.net; Tue, 12 Sep 2023 10:52:56 +0000 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-403061cdf2bso28839955e9.2 for ; Tue, 12 Sep 2023 03:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1694515964; x=1695120764; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:date:from:from:to:cc :subject:date:message-id:reply-to; bh=7pKYdC6OPu/SdsfW2R1gyG+BN5dT6ZErCruP4a30LhM=; b=AZ2alQH7bpDRWrgjP9U6niXzy7lFIr4JbhJH2XjYRe3tZ/da0Dm0JE/CgYA4REg3wk yS8coKoNKplNb7DzAXCcsIGFDUi+N1mjHuWhvEUfsvoJq4l1qb1x2SV3T5c1tcI526G1 JvDbyEqHUdA2EaDxyMFffbCDKf4+OjAxMhLle30ytvGc1CfjZAMb7hhI4fDV/c+y8uG8 lnuUnXWwqciWLGVJ7LZzDjWoBQl51QjJoJ7zTQapB6G3XiPmvOq8LL+8ptqj50a8lErY be5VUvDwtEJE4Gnxi1x2+30aSEGnV+7ATkclLsLCfwgE+p5spu/HN95kRLT3ely/+Jdi EEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694515964; x=1695120764; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pKYdC6OPu/SdsfW2R1gyG+BN5dT6ZErCruP4a30LhM=; b=ZCnaX/H55AeuvQ5cTus6kzApNH4HW1uBkDOYsHhyIcRR9rxXQ+KTlKQ4h5L98Bd7gG FGMQs6GGFfQMY80EMkCZRzFyPeLzIMN0P/E7fB9vEtWsZUjCSru6YfTyANFIEnU9p5I6 ETnKcQpRHdgYcKv/B5MIvWpYYzjwi9QGfI+eeoXhYVxUcB31q8cQ6QVQ1zkga/4nJPQF OWiwbFlTuF5RlOFcsPV1UQKppsG8KdvV2SfUUU9itBgESobJ39+6l4v+aFcJpEN5LSwQ pwRDrKKOWQRVNpKHPrb/gnPLX9ILPoiUd8pGbKqT9Z9sVDc1XL3WOfHyvf//Mmjng1Dq t7/A== X-Gm-Message-State: AOJu0YzT+JuIt1Fce+x/DtLuCGEDiDm5ErmjdgrhU/XDIN+9yfbqq2YM E5PXiXiVHX5AtiBFi/+n1SiilucDrfhJ3LPJCiI= X-Received: by 2002:a05:600c:3b06:b0:403:8fb9:8d69 with SMTP id m6-20020a05600c3b0600b004038fb98d69mr3889147wms.25.1694515964402; Tue, 12 Sep 2023 03:52:44 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id v4-20020adfedc4000000b003179d7ed4f3sm12541572wro.12.2023.09.12.03.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 03:52:43 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 3 Date: Tue, 12 Sep 2023 10:52:43 +0000 Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I3bd27a8d34d8cb4896a3b78508b7d16911571543 X-Gerrit-Change-Number: 34 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 022391ad5d09623ec031d351885e6030a5fa004a References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.0 X-Spam-Score: 1.0 (+) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/34?usp=email ) Change subject: Improve description of compat-mode Content analysis details: (1.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.53 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.53 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qg10k-0002Q7-SQ Subject: [Openvpn-devel] [S] Change in openvpn[master]: Improve description of compat-mode X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: plaisthos , openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1776828809231979310?= X-GMAIL-MSGID: =?utf-8?q?1776828809231979310?= Attention is currently required from: plaisthos. plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/34?usp=email ) Change subject: Improve description of compat-mode ...................................................................... Improve description of compat-mode Explicitly say that the version specified is the one of the peer and not the version we try to emulate. Change-Id: I3bd27a8d34d8cb4896a3b78508b7d16911571543 --- M doc/man-sections/generic-options.rst 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/34/3 diff --git a/doc/man-sections/generic-options.rst b/doc/man-sections/generic-options.rst index c827651..97e1b5a 100644 --- a/doc/man-sections/generic-options.rst +++ b/doc/man-sections/generic-options.rst @@ -53,10 +53,17 @@ need for /dev/urandom to be available. --compat-mode version - This option provides a way to alter the default of OpenVPN to be more - compatible with the version ``version`` specified. All of the changes - this option does can also be achieved using individual configuration - options. + This option provides a convenient way to alter the defaults of OpenVPN + to be more compatible with the version ``version`` specified. All of + the changes this option applies can also be achieved using individual + configuration options. + + The version specified with this option is the version of OpenVPN peer + OpenVPN should try to be compatible with. In general OpenVPN should be + compatible with the last two previous version without this option. E.g. + OpenVPN 2.6.0 should be compatible with 2.5.x and 2.4.x without this option. + However, there might be some edge cases that still require this option even + in these cases. Note: Using this option reverts defaults to no longer recommended values and should be avoided if possible. @@ -67,12 +74,15 @@ - 2.5.x or lower: ``--allow-compression asym`` is automatically added to the configuration if no other compression options are present. - 2.4.x or lower: The cipher in ``--cipher`` is appended to - ``--data-ciphers`` + ``--data-ciphers``. - 2.3.x or lower: ``--data-cipher-fallback`` is automatically added with - the same cipher as ``--cipher`` + the same cipher as ``--cipher``. - 2.3.6 or lower: ``--tls-version-min 1.0`` is added to the configuration when ``--tls-version-min`` is not explicitly set. + If not required, this is option should be avoided. Setting this option can + lower security or disable features like data-channel offloading. + --config file Load additional config options from ``file`` where each line corresponds to one command line option, but with the leading :code:`--` removed.