From patchwork Thu Sep 21 14:07:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3356 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:2697:b0:d7:3b0f:3938 with SMTP id ha23csp3062096dyb; Thu, 21 Sep 2023 07:08:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF76r/XTuGQ6v10KU+mw6EBxckV97rIRPm56Doe09pYHtLPXK3nhm2NjTFxdReF8B/sUbaT X-Received: by 2002:a05:6a00:4215:b0:68f:c8b3:3077 with SMTP id cd21-20020a056a00421500b0068fc8b33077mr5532839pfb.1.1695305319433; Thu, 21 Sep 2023 07:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695305319; cv=none; d=google.com; s=arc-20160816; b=q2yVxycCvbp7rQeQrcA/Ax2ZzmDWzLyfuIsb0orxbLBohAmVszzs/KQ4fNHz8F8sOW yRX9WSmNRQmj+YVOwlXrmje8Rxdn5qgPGDovpztsETmySZELuHUb54qt4s1egqKcCx7U 3lyRxZUoy7K/MZ/jr66h8vZ81vy1fhk0BVuH7xf+Ye5HJI+F6tVQj9JLRUUx7b/HR641 chTpy29p9DAcVMOc1tMpM2xSrnLb6BPXFCJb2QWH29rJ9gGDF1pFUWsZVmVfWl2W4BUC W9LGMhCdy33aXMPB53+/g5II0dRIC1CLKQao3EMX4c/Sb1kafdSlqcFGNZEbRik8JVMA cpUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=ziDCaUk69kaKq/m6Asg3nOyNGRXdFjGbutLmgXKvCW0=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=lagxiQsdZBpMSogZfne15yAl7VRcFR65TbPPAaL2+KJsC96pAex/xUf8YJVZc9+Chl X1Y4vsDsp9Bt/p8KDX/jnNTom7DdrhugvHIJ6gx6A2iAloav1bqda+wpGiLxv/bTPaaM njRpK+XcvaAL7ErUki+VoyZJHScMxiAjpJrNQ0sOWvk9BS/1IpNtx5ihWbC9ThQodL+j CN7DHyXD56AGzVhYlFfU87D3QuL7sUX2qwyYkZTaFiVzbZfDvrRx02zCbPhAQ4NUgs15 zcG4vGLF0WiMHaNw9kaCraA0YgEmtYlCNBDVjm5gBy91wiQ5N0UzwgW/PGuc7886zagh I/ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=exXvBg8J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=i71s3eDx; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=CfL4V0QI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id bd43-20020a056a0027ab00b00690cd91cee7si1487771pfb.287.2023.09.21.07.08.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2023 07:08:39 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=exXvBg8J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=i71s3eDx; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=CfL4V0QI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qjKLl-0008JN-W8; Thu, 21 Sep 2023 14:08:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qjKLa-0008Iq-Bd for openvpn-devel@lists.sourceforge.net; Thu, 21 Sep 2023 14:08:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QaPGM0VTq3bvGUvjXl98HY8i1Rr1dCX9q+Yl4H7qmHw=; b=exXvBg8J8f0OcD4qq/TzLNOFRT UH4wMv4VHgJoGWpj8SC2p9eOLNydHaSjajp2O63r5Rbl9V/RdODmdRnsFsMLDn634xV8GfIis08BN EUhk1at5SnxsxNrYXJQs4w3CAg1OQhvUeOOIKD8taxYuJ3K2LojhbcriglueZy+LyFJM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=QaPGM0VTq3bvGUvjXl98HY8i1Rr1dCX9q+Yl4H7qmHw=; b=i 71s3eDxgXrmF+mxEbyCrrIIKkFxhVIBpjC7rYmKrpGxO10CgRvEwtQIhUXgsook1hnzaNBr/LQYOs sXyMutI8/gOTecKYka2HdXhZq0JBNQIC9x3h7nc9otKaERR62Q6Zl/qcCAZo6we07d6kjgVp13C9f 3tHjJYXxXVGCxpfI=; Received: from mail-wm1-f50.google.com ([209.85.128.50]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qjKLR-000feP-Cd for openvpn-devel@lists.sourceforge.net; Thu, 21 Sep 2023 14:07:58 +0000 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40472c3faadso10990275e9.2 for ; Thu, 21 Sep 2023 07:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1695305266; x=1695910066; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=QaPGM0VTq3bvGUvjXl98HY8i1Rr1dCX9q+Yl4H7qmHw=; b=CfL4V0QIqvsdOO7qz9Zh/6sjrrSEBiuJgmngYfg/tgJBRb3fNihHs9TZXKpy2uAZIF 6Vcr0aNLfYnkbbMNpTlbyf2yLbDMXbGmsAGeGm0azFQsyQRmhe9xHMjsDek80FJ8Gju6 sisvGhrTHpZLQOEPvs6Fko3AZ2ZLbSseHMQJjiHELBNaTaBglSngwIecFRCOuVDsEehQ SA6SKboCIASGZcw8UmhbIX4w2atlkXcGjdQC2arVQULImR9jOFaJGwdeYgBJMc4iWW4X yTjguSrBhCLW6B9mBkYjJl0QBIuf+vD5Vt+1qYRbXvREk4uUms0thxvU8UkvmFMLZWM7 Z6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695305266; x=1695910066; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QaPGM0VTq3bvGUvjXl98HY8i1Rr1dCX9q+Yl4H7qmHw=; b=Uj4WO7eVOh/aZQn4WT0FLq9GlKNaSkG66V7YUvFfo/ZIazP5HM6P00m6+TgvZ/GqA8 b0/m2BKnDGmH+6UdfkxFKv+jy78scnCd4TGHASIpal9RziNlpV4jbgQS3Xt4W1Am6aoQ 8hnBir1L+mSjYZPFdnmXzLX9HOvMv2zY+wsHZyeP9tzDi5ZEc5JLhCGclzb21gQncWcd yv3dcyq+rJj+Cq9+6JE8ggyOl+3YfYli1VSHVBhHE4DTr+YJNbSkwSK9nRlqzr6fYKbq eBEMLiaKoAckN2JESuvSPNxyGJNo9Kj0HEesDBnPUPkQyXcCpDiggysFh7A8PdNpm+Fm ZtMQ== X-Gm-Message-State: AOJu0YyqP2EQ5ELziEg7XlZyxawkEcIFJ/fauyMQfkPcDOmtuC0qZYB9 rRhKz6ocGcgr5hZT1q2AKMnLy3vxAZdjpB8tOxI= X-Received: by 2002:adf:f48d:0:b0:31f:fa1d:898 with SMTP id l13-20020adff48d000000b0031ffa1d0898mr4684624wro.47.1695305266429; Thu, 21 Sep 2023 07:07:46 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id s17-20020a5d69d1000000b003141e629cb6sm1854693wrw.101.2023.09.21.07.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:07:46 -0700 (PDT) From: "stipa (Code Review)" X-Google-Original-From: "stipa (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 21 Sep 2023 14:07:45 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I30f4ea502a36eca155cbc79b89c0d18ee3419877 X-Gerrit-Change-Number: 362 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 09a588ef43c0e0a00082aa4a9e31d73890f26e2b References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.50 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.50 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qjKLR-000feP-Cd Subject: [Openvpn-devel] [XS] Change in openvpn[master]: CMake: fix HAVE_DAEMON detection on Linux X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lstipakov@gmail.com, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1777656470564209642?= X-GMAIL-MSGID: =?utf-8?q?1777656470564209642?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/362?usp=email to review the following change. Change subject: CMake: fix HAVE_DAEMON detection on Linux ...................................................................... CMake: fix HAVE_DAEMON detection on Linux On Linux, daemon() is defined in unistd.h, not in stdlib.h like in MacOS or FreeBSD. Change-Id: I30f4ea502a36eca155cbc79b89c0d18ee3419877 Signed-off-by: Lev Stipakov --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/62/362/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index 9de6aba..76351c1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -158,7 +158,7 @@ check_symbol_exists(gettimeofday sys/time.h HAVE_GETTIMEOFDAY) check_symbol_exists(basename libgen.h HAVE_BASENAME) check_symbol_exists(chsize io.h HAVE_CHSIZE) -check_symbol_exists(daemon stdlib.h HAVE_DAEMON) +check_symbol_exists(daemon "unistd.h;stdlib.h" HAVE_DAEMON) check_symbol_exists(dirname libgen.h HAVE_DIRNAME) check_symbol_exists(getrlimit sys/resource.h HAVE_GETRLIMIT) check_symbol_exists(mlockall sys/mman.h HAVE_MLOCKALL)