From patchwork Wed Oct 18 17:21:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "its_Giaan (Code Review)" X-Patchwork-Id: 3400 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:ea3:b0:f2:62eb:61c1 with SMTP id mk35csp5266132dyb; Wed, 18 Oct 2023 10:22:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIfF90qQlVpp4sCRcN6kBjogsTkulXABq2fSurYtSZfrUa+kQ7jtrXnqBUem1PeH5xxPvi X-Received: by 2002:a17:902:bd07:b0:1ca:28f3:569a with SMTP id p7-20020a170902bd0700b001ca28f3569amr5754974pls.5.1697649765525; Wed, 18 Oct 2023 10:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697649765; cv=none; d=google.com; s=arc-20160816; b=fRULzKFOLFjmw9fndyMg4TwaxXP+8GkP1PmuQqB/KIprQYWbqSW1Ekq5CrVY2UiNni ADBxx3AHu8Yq7unyVJBIb9b4yBIEYKr5vxcPnb2S3g+oTQeVuUtRA+CMVDmnLuAmBltX 5YkWt2aNQG7UmWrtMPMI1KBEFOT31vDzpOjBRQB/qFX3Y/id1vC9S3YClbplLZigLuY2 5NroVtmf5p/9YJk7XIqwSCA0z7lQCFinozUMhjID8Tg/r8l9LcPulMVNLReOARgcWBHy nD3QTviD3t4NSVHjz0A81sOUKWKlmNcNugFWXYCqc7acJn/QJHDJZa7qecIrOJ6PJ7od 8fEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=58yPT71p3gqn36bc7jiM/2W8v74iNBTPBTeRqCGi+Fk=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=fnH8xCywpNEOZi0Vz+8LO2lwAtgJO/EmVLa8Tx1STJhj3NX+vF3om+OdorOwoYA1eC 9G63gq/41Xjfl66YR6Z06TZjAwTv1nx0ytBLRKqruPwnqgtuG3BvonJJqr+yMqWOTFnI vIjg3kO0NpyTatN/hwIOIbqEn6PJK6u9rzP6BUqOHyq7z0RWoILOUXSHbtbVat38RnPE rKc8csTLz0qn3fHDdufbMJyOYNqr2lEe5CJOXYsSIYeucB3oMSQrf70DGqKE0Qncxh44 E23Wm5Q2tYZa0D+I8ImhYFElu6hbCqYxnGKClLc95Cd2LZ9xp/5MeEv3QfoZ7VyqIjGg clbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=creyal4m; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=WypVRqCm; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=GWlcyGuy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id w13-20020a1709027b8d00b001c61bd7cee0si291815pll.211.2023.10.18.10.22.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2023 10:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=creyal4m; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=WypVRqCm; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=GWlcyGuy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qtAF2-0003xp-Lh; Wed, 18 Oct 2023 17:21:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtAF1-0003xe-5l for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:21:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eWa16wJ2DNXwzI0ikqI1Vb3i5iY3AZWytDQrOQ8m0cQ=; b=creyal4mFn6TZ1rpReGhgTzhRy +/t4KB46EZ3pH6N8CNlemzWBsonUHjv3mBA8msasJ5YfcGM90xHHPCyhv6iAinU4/IQhr2Fz8sai1 d0QQxQo+/axGDE4X6pkSQK/CQxRieiGXAmTB0jr/0klZIZ5SCP81VfaWwaYzQCgve5Hw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=eWa16wJ2DNXwzI0ikqI1Vb3i5iY3AZWytDQrOQ8m0cQ=; b=W ypVRqCmpeENArabL2YQoXLNSDLbUMVRIPXq6s0AnJ9ToMp7B2guva99Gg/4m83NoY9472EPju8uuz 1gqLfCrRH5sUgK3d+4lM4FFH2Dz472TxWnESEGUrHqIFTxcICf/hoA9QxMtklZTDJz/L5OsZCZmXC bJG3ZcNkzyxOmGdY=; Received: from mail-wr1-f49.google.com ([209.85.221.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qtAEx-0003jH-JL for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:21:54 +0000 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-32d81864e3fso5520161f8f.2 for ; Wed, 18 Oct 2023 10:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1697649705; x=1698254505; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=eWa16wJ2DNXwzI0ikqI1Vb3i5iY3AZWytDQrOQ8m0cQ=; b=GWlcyGuyf87ylqUYGJTAB9lwLOtXTLkaM6wCyleIMph1azt474bRKgvtXIkL16Q8ui xsmz4gzVQZ4CdD9+raHFrwKhWdJn1glxDQWnnVOtqzhTR9AyUXPyJOAh2yT/ae6RBUJY O/cjbGpyAQbNIRCL4mQsTpSqSyoAjc8bYQHuf68V8Jh12NgavnRJ8o+kYQS/Wn32YX5x 4cFu1djB95tjz1N7ulWVZF6OVNS0AC4Ksst2UBmjxsHXccP4fbBV+Rnycs5n7dYMUbQk woHNdqdRYl1wfBpPGrSuko9P1P2nLo5m0dih144HAz3dFev4HmXUSp91M5mqF92siwCU Wapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697649705; x=1698254505; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eWa16wJ2DNXwzI0ikqI1Vb3i5iY3AZWytDQrOQ8m0cQ=; b=MAwvx21rnLax3bY4OUXxpSoonUEPXsqDsyOjPOLw4DXuya42L/G5QAdLUhjPXkkCXl Icoco3uzyJZ3zSIk3sw1cMEvW+lLlDQ2HNn3JOKVMLqs40uDOuufFpKQvxjkyKG/oAKx G5CmgfB55hQ1yJYEGzqcoQFXvm6aApwxOCr/M42LHHgwruh/6J/y4yhs5IPVIcMI2kdj 0FVn2tZa+NDzuRZ1zsSwhhlzT3IqTRtpS6mBFbTb2AV446GikJB4G+TxgejJFp93+FCU J6dGDAEqjoQJLot3PHf7htJoPBjDexSH9nSVHUAYQJ6K0nFRLGpueTC3P3DttGaBFhhf 1LPQ== X-Gm-Message-State: AOJu0YwYISokS5l7KcZGa4LzfY+TTKr8UZ/tmvT46fcc2Pm5+bC7NUDN WYXd1KNhJtwbKhBXfFnR8DWMzVhMXnVbNRMAIT0= X-Received: by 2002:adf:e908:0:b0:31f:f99c:6009 with SMTP id f8-20020adfe908000000b0031ff99c6009mr5102724wrm.22.1697649704782; Wed, 18 Oct 2023 10:21:44 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id q9-20020a05600000c900b0032d8eecf901sm2559048wrx.3.2023.10.18.10.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 10:21:44 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 18 Oct 2023 17:21:43 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17 X-Gerrit-Change-Number: 375 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 1dc095d0b8caf752b449bfee0a7dd7201b7eb9d8 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.49 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qtAEx-0003jH-JL Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add undefined and abort on error to clang sanaitize builds X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1780114800580279706?= X-GMAIL-MSGID: =?utf-8?q?1780114800580279706?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/375?usp=email to review the following change. Change subject: Add undefined and abort on error to clang sanaitize builds ...................................................................... Add undefined and abort on error to clang sanaitize builds The -fno-sanitize-recover=all flag ensures that for all errors we actually abort the tests in the automated testing and not just print some errors in red that nobody sess. Also add the undefined tests to catch more bugs. For libreSSL we do not add the udefined behaviour as we have (even with the latest LibreSSL version) an undefined behaviour in LibreSSL itself. Change-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17 --- M .github/workflows/build.yaml 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/375/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 58fbc29..2a25582 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -186,7 +186,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: CFLAGS="-fsanitize=address -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} + run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} - name: make all run: make -j3 - name: make check @@ -201,8 +201,8 @@ os: [macos-11, macos-12, macos-13] include: - build: asan - cflags: "-fsanitize=address -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" - ldflags: -fsanitize=address + cflags: "-fsanitize=address,undefined -fno-sanitize-recover=all -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" + ldflags: -fsanitize=address,undefined -fno-sanitize-recover=all # Our build system ignores LDFLAGS for plugins configureflags: --disable-plugin-auth-pam --disable-plugin-down-root - build: normal @@ -300,8 +300,8 @@ configureflags: ["--with-openssl-engine=no"] include: - build: asan - cflags: "-fsanitize=address -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" - ldflags: -fsanitize=address + cflags: "-fsanitize=address -fno-sanitize-recover=all -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" + ldflags: -fsanitize=address -fno-sanitize-recover=all cc: clang - build: normal cflags: "-O2 -g"