From patchwork Fri Nov 10 17:38:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ralf_lici (Code Review)" X-Patchwork-Id: 3425 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:50e4:b0:f2:62eb:61c1 with SMTP id r4csp1348877dyd; Fri, 10 Nov 2023 09:39:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLrE1Vu0bww6Rs2wxXRnSVHXdGZsyV08iZrkKUI29mWpHRdg6K0mAhBkOo6GVqXMfVvkLv X-Received: by 2002:a17:90a:6c96:b0:274:99ed:a80c with SMTP id y22-20020a17090a6c9600b0027499eda80cmr8297767pjj.3.1699637982508; Fri, 10 Nov 2023 09:39:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699637981; cv=none; d=google.com; s=arc-20160816; b=tR4jTfVzCeL8oHxj9TFoABl5u94Uk4U4mLh9LzKvH0CE27007WRsJAUCPmPVI1601R 1zpw5kohXtuWeMt3F9zyuZDYnYmCMa6uPW1PJNjRKyHAAkH6P/WWyqs/EVifaf+DlHMz gj4ocnlrbncGmEdxALIIR8WeAsBiFp4CFPYCXp3NdIIIh1i5iizp5WEDwpmvsMnc4OyB MptsXTbVTib5QBHIy8IWjHkns83UYmW4sDpgfsB2sBJAV2e3V1GegFt6RWw9q8x/+Mf2 ZeSxg02vO6D4HM0ewLmvPjaqUQNr9QQSVBewyLwq0tc9jgz3EMdsxUQQ9bOC/C4lAXWu Iwvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=j4djYE4Sz5/PJ1Y2JzELzy6KIjB5t4LU3vmfP2uo1fQ=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=tnsw/Yy5tfsv9fkc0PUIGaRIemnsCvkNKVYd8LYm39F9OJV/bLamBZA2QkpoOee66m n7pQThgfI6LC2CFr4M3LD6D+lnulTkoPGbEBbH7HIuaxKvT7FaHKTMEXlJIsT200ReAk wnhgiOQQ0yzgryE0g3oiKPKMabD75iqKeZSLqNz4I5N9pNF8rUKMwR138VrynTiPSu5R /vBy45SNN6JyiplbGDlTOo6tAO+F7F8zwbxOwjvWNuO8eGioM376mRcglLL4Zmu7yixl RkW4vwX7T/QYIkliQQTVSTWnc41wKo89pXWR7eU7nfDFsRDJEK5gBQoiXPANaW0la7e6 3sgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BO2Ag+er; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XTy71in7; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=aTfDSs7V; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id lr18-20020a17090b4b9200b002804fe98045si5096208pjb.33.2023.11.10.09.39.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Nov 2023 09:39:41 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BO2Ag+er; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XTy71in7; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=aTfDSs7V; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r1VT0-0001is-Qi; Fri, 10 Nov 2023 17:38:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r1VSy-0001il-Di for openvpn-devel@lists.sourceforge.net; Fri, 10 Nov 2023 17:38:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=58L0HuCx8uelqMCOjyURwE63fv3v06+XH8bgwBKrEzM=; b=BO2Ag+erkohFSUPuS/EzyH7zq+ CJggUFawcaBEFrOi4TPHfcgAU5pAqt/gjEdH1KBMAWA5/h0atYxAbyCjBYl0TxKwTGnoAZo6gwpdT pL7eiKjusiOwSdOVhIQY3xRKXKXMNDwTcjfM95oodxKuCJmldDOATC5Ov5jkDaaLzvnc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=58L0HuCx8uelqMCOjyURwE63fv3v06+XH8bgwBKrEzM=; b=X Ty71in7JjA+B+NHlYgwUUV7BaIyHJJDZJV5BbHZFyQeFqNg4CDtIIqhgT9anL9YPYH7JILqcWHoVQ ccL2Q3dcesGYfZ33gsGSb4SW8Rw5HGTbNBWX3AW+zmXUlX8w/P5lzzY5rOObVszH1zn2sHD8uD/sw i6o7KqiNor9pvFz8=; Received: from mail-wm1-f49.google.com ([209.85.128.49]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r1VSx-001pD8-Cq for openvpn-devel@lists.sourceforge.net; Fri, 10 Nov 2023 17:38:48 +0000 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40a46ea95f0so6170125e9.2 for ; Fri, 10 Nov 2023 09:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1699637921; x=1700242721; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=58L0HuCx8uelqMCOjyURwE63fv3v06+XH8bgwBKrEzM=; b=aTfDSs7VjWp1nyJ8qjsWZs/o9/qsRvpXa3zqq1bXvsIw72ABJgCdJChncB9hUTBU3I EmqpDT8rzu5KNcYqw7Oq0clhiuXv1kLe93qXNeY6RQaXeqMsVjfHBPM4DsUpMsS5feSe BJHmRdWvU4UwpiemmKJD7w0/2GHTXUUn17ZK+k/QmBkeQMQjTTxSaSS9a9OEpPb92KFH 1RZTjC/RuNRt0jLIqe+4OiEUBM+hJTihTn/RjqebdIJZJ6yXXOCmOFh0RfiWZw78qJy8 VYVSeOHT/e+JSn+15NzL1tuXRzknwgG4X/wOLb4Fv8KIoyTU9L5Xu7Gk+VBHBr8EroYb JfUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699637921; x=1700242721; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=58L0HuCx8uelqMCOjyURwE63fv3v06+XH8bgwBKrEzM=; b=v3hwDg1O8tvXvf7MhsP4B4ImWskYpipoJfm7OlNbV0+nvRViBd3BqA6L2O88WqbhvT +G2hXIC7xKEpebGpMnVe/1GepHUyuS6cuL6BtsntapdOii0CQtGkYI9MogmOLy0bbVsS /uxczbhmMdlvYriOaoZDdJ7G42OLUWsVrSraZ8GRT0ZWbeEFkkvz3Ou+eHvb0zWt4qAW UKB7VFmUc8lBrZ+CXhRn7DFYadWr01lrvJrHklzPTMqdc4SYw+LKE43Nbi4AZ6E/amqt Y+af3qO7Z9wHWB0aUkWSNFdK6BwjTp6ubyD7jGXffuCLEeDh9C9c83AwBkyMEivvKWXM I0uw== X-Gm-Message-State: AOJu0YwBJrBqkdocrsS7V1W7ZNWAcjjJhYzBuxWkAcB1T1vqO52J4TAN HB6ca/qTuvRmCazEYbpuzhSk94ZtnD2agwVsRlA= X-Received: by 2002:a05:600c:5126:b0:405:3a65:1b4c with SMTP id o38-20020a05600c512600b004053a651b4cmr43484wms.6.1699637920804; Fri, 10 Nov 2023 09:38:40 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id b22-20020a05600c06d600b0040841e79715sm5643335wmn.27.2023.11.10.09.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 09:38:40 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 10 Nov 2023 17:38:39 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I0c78ce452135fe2c80275da449215ba926471018 X-Gerrit-Change-Number: 425 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 938d6ed1fc254e55e03780f655d18fae51ed96a8 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.49 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1r1VSx-001pD8-Cq Subject: [Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1782199596490117483?= X-GMAIL-MSGID: =?utf-8?q?1782199596490117483?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/425?usp=email to review the following change. Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR ...................................................................... platform.c: Do not depend Windows build on HAVE_CHDIR This broke in the CMake build since previously we just always set HAVE_CHDIR to 1 in the MSVC build. But actually the code should just not check HAVE_CHDIR on Windows. Change-Id: I0c78ce452135fe2c80275da449215ba926471018 Signed-off-by: Frank Lichtenheld --- M src/openvpn/platform.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/25/425/1 diff --git a/src/openvpn/platform.c b/src/openvpn/platform.c index 32c4fe6..62acabe 100644 --- a/src/openvpn/platform.c +++ b/src/openvpn/platform.c @@ -392,7 +392,6 @@ int platform_chdir(const char *dir) { -#ifdef HAVE_CHDIR #ifdef _WIN32 int res; struct gc_arena gc = gc_new(); @@ -400,11 +399,12 @@ gc_free(&gc); return res; #else /* ifdef _WIN32 */ +#ifdef HAVE_CHDIR return chdir(dir); -#endif #else /* ifdef HAVE_CHDIR */ return -1; #endif +#endif } /*