From patchwork Mon Nov 20 10:23:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3451 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:50e4:b0:f2:62eb:61c1 with SMTP id r4csp2169404dyd; Mon, 20 Nov 2023 02:24:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIzaE2fWz8WJHPyEO6023n/YA3eye990KC4QHnMDYv8H5vE7fXpdiTMDJluq4vt2zfAcil X-Received: by 2002:aa7:93b0:0:b0:6cb:8347:c8b1 with SMTP id x16-20020aa793b0000000b006cb8347c8b1mr4007515pff.1.1700475884275; Mon, 20 Nov 2023 02:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700475884; cv=none; d=google.com; s=arc-20160816; b=Jwcn244V74wbhTYWwG/ga1YAORt1wTayFWv4Yw+W9aVgssV7rgfZZE3kEVMU2HmaJq SEuWLNYtbG68xl8aPPzf4vwZWAlVm9uoqoWElW4CFazdLC5dsHOcA18p+q1DNNmJSEi4 AXDWEEg0MZTJAO/47kLQ/0/beKFhkI4J93uAV97izSZG0kgMB8Ynf9I0U9qdhH/0q2sq v15KRroWo1nbLRYPHv3bzsvPd4/IKXgSy4FmMdwx48uVNyzF2zG3snsb2/doC2JmSuVU zti2aOH/V0EELgdULFXfinS36rMR7/LKkcUlp/l4BQfZhso/6Xx07SncjZXGhWr+FY0I F2mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=zWawJ5yc39Ox5+StiW30bDAUSlFSvKn/H4Mc3ckPnV4=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=lJyfo63/XibIelsAr5sinqNT6DMRVt2S7Pp/t6ltWjCQW1lcecc8ri9tifQb5cXhgm mWDSuLJyFGJE+lM9mkYE3xIc2z0Cq5j8bdLjoYk60A6HbqnPzy/LuMUrAXcK0tb+rXVu sidtr7r7wkTcL4MnDRLVHOxMAeXK6z4lA/OpCfzZaOw9uG6P4NOzt0dxojgbMube4jMX xBemRy8+74TiXFT90OKBGZBzQi4RO2KEv1yRlY1CbUihGPpDDFvJLnTU/1OdlKSeT0S0 OHeEfvJiaXcOKsWpbrz0elsHWLCRq2gtV6TE8xw7mjqAAZ1INK6UHClr+ReE4VW9QYQT J4xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CewChic3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AONf6nkH; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Qfv4WvWy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id by11-20020a056a02058b00b005b64e8336dfsi8243226pgb.604.2023.11.20.02.24.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2023 02:24:44 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CewChic3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AONf6nkH; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Qfv4WvWy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r51Ra-0004tn-Hx; Mon, 20 Nov 2023 10:23:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r51RZ-0004te-Ei for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 10:23:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=79tzKpfsqbDBKtA2Q6xWaE5JxKTzjBRZkOhc2U8WxzE=; b=CewChic3vtUsZg018hKe04uCG6 BxdUd8lrN1otueSXiMI0mhKYZjo4ETKvbE/mg8RSVjSn1d1DD83uz5v9ZBKshiuh8CrIR7SYIdlPn WU5C9HSrq9SsYilojPF9IanOlveNvPzvTsiMYHg94ROanKyh5C76YwB/uOM9XrZTRWzU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=79tzKpfsqbDBKtA2Q6xWaE5JxKTzjBRZkOhc2U8WxzE=; b=A ONf6nkHG6+Y6E1Ko2bCJbKaDHDfNqNhtjx68Z/HNRwThW+ZpyjT5S2UPS6yPwsR/LwjHN44NlPmfx 5CY8yUs5SOpMexCKHdkLhiYA7qZ8O7P6zBC+xj3KVhw4tMMjzXytZJYddJHKDu/LQHIyzeaaSqL91 z2Kgoh2EoMoWvPNY=; Received: from mail-lj1-f177.google.com ([209.85.208.177]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r51RW-0007Lh-3y for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 10:23:53 +0000 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c887d1fb8fso733541fa.0 for ; Mon, 20 Nov 2023 02:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1700475823; x=1701080623; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=79tzKpfsqbDBKtA2Q6xWaE5JxKTzjBRZkOhc2U8WxzE=; b=Qfv4WvWyAHQ/VFz+lpEytdWRuJzSHsPrkF2Oh/JJZ8+w/fjOqU8/MWWFMRCa+vEqE0 Y7sXvNfWQXe5UdqGfLuPdRFD3eC2Uxu4cu7DOHl/EvnXjV26zCVyuA6S/WB2gHHa9BA4 Krppa5yrhhtPUCSNsdCPo8pDkZ14g098qC8HEDOIcDeDKPSJsml6nvFSv+BpSiQY4xnT zXKWMQNj8MFIjbmCtT92U4of/44hsh2cZiPr+VV6iLdjd4hxuAe9JGshjDpRWXKMtmjY 81H57MsQDIVL+wq1r19cJemtIagYAqjTp3ctVNMeDqkcG/RuKmgoOd3BmNkoLyTuj/BA GR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700475823; x=1701080623; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=79tzKpfsqbDBKtA2Q6xWaE5JxKTzjBRZkOhc2U8WxzE=; b=upTJKc6wErRPWuPX4IUKxLXGZ++bhWi/GoNibOMLl+ipD4ccKo5vlhZuq3aMJd2Tti uByTmtWTshLwbFr14yLlpD2i+eAfqgIcz4GOdo4BEB+z9MVU/LXDccDnxo+XNpZmhZLa Kbp5blm1DCCeG0bCVjB4SEDXqKtRWHY6zeNTRIge0bLdUBB+rNy5V+AzC7t8UbNEG+N8 p5rTUoOq3WH5T/wHC5bk6yghavx6E8QxSRrMxPgZzUgtsicHSbN1pehMVez+ByPPaTui shBVGiDFjaLH9X5sd0+WsUZxdm+OCaQuXd5wdN6xFQ1dwb5dK52KFa/Hre0AGdQ086zT rJ9Q== X-Gm-Message-State: AOJu0YxkG5C/qTCGgaODtzIhyhi+GMmX8sCuGMNYXrtO7/6xcAn+tt5B hASSAz6HAjU41l+nlUBHlKprxByeXrrzGM3n/YE= X-Received: by 2002:a05:651c:218:b0:2c6:ed6a:780f with SMTP id y24-20020a05651c021800b002c6ed6a780fmr4487039ljn.11.1700475822980; Mon, 20 Nov 2023 02:23:42 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id n18-20020a05600c3b9200b00407efbc4361sm17733970wms.9.2023.11.20.02.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 02:23:42 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 20 Nov 2023 10:23:42 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ifd0376b36d4050dc22bc93b8fcf7ed29faef0021 X-Gerrit-Change-Number: 443 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 05ef270c98d630f0e4eb378c3977477f6e03f3af References: Message-ID: <610d62ff06b431ebf54762face240a907078fc10-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.177 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.177 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r51RW-0007Lh-3y Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove unused defined from configure and cmake config X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1783078200721279888?= X-GMAIL-MSGID: =?utf-8?q?1783078200721279888?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/443?usp=email to review the following change. Change subject: Remove unused defined from configure and cmake config ...................................................................... Remove unused defined from configure and cmake config Change-Id: Ifd0376b36d4050dc22bc93b8fcf7ed29faef0021 --- M config.h.cmake.in M configure.ac 2 files changed, 1 insertion(+), 34 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/443/1 diff --git a/config.h.cmake.in b/config.h.cmake.in index 19b79bc..25273ac 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -62,9 +62,6 @@ /* Enable --x509-username-field feature */ #cmakedefine ENABLE_X509ALTUSERNAME -/* Compiler supports anonymous unions */ -#define HAVE_ANONYMOUS_UNION_SUPPORT - /* Define to 1 if you have the header file. */ #cmakedefine HAVE_ARPA_INET_H 1 @@ -139,9 +136,6 @@ /* Define to 1 if you have the `getpwnam' function. */ #cmakedefine HAVE_GETPWNAM -/* Define to 1 if you have the `getrlimit' function. */ -#undef HAVE_GETRLIMIT - /* Define to 1 if you have the `getsockname' function. */ #cmakedefine HAVE_GETSOCKNAME @@ -235,8 +229,6 @@ /* Define to 1 if you have the header file. */ #cmakedefine HAVE_PWD_H -/* Define to 1 if you have the `readv' function. */ -#undef HAVE_READV /* Define to 1 if you have the `recvmsg' function. */ #cmakedefine HAVE_RECVMSG @@ -383,9 +375,6 @@ /* Define to 1 if you have the header file. */ #undef HAVE_VFORK_H -/* Define to 1 if you have the `vsnprintf' function. */ -#undef HAVE_VSNPRINTF - /* we always assume a recent mbed TLS version */ #define HAVE_MBEDTLS_PSA_CRYPTO_H 1 #define HAVE_MBEDTLS_SSL_TLS_PRF 1 diff --git a/configure.ac b/configure.ac index 84eaad6..055b2a7 100644 --- a/configure.ac +++ b/configure.ac @@ -561,28 +561,6 @@ , [[${SOCKET_INCLUDES}]] ) -AC_MSG_CHECKING([anonymous union support]) -AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM( - [[ - struct mystruct { - union { - int m1; - char m2; - }; - }; - ]], - [[ - struct mystruct s; - s.m1 = 1; s.m2 = 2; - ]] - )], - [ - AC_MSG_RESULT([yes]) - AC_DEFINE([HAVE_ANONYMOUS_UNION_SUPPORT], [], [Compiler supports anonymous unions]) - ], - [AC_MSG_RESULT([no])] -) saved_LDFLAGS="$LDFLAGS" LDFLAGS="$LDFLAGS -Wl,--wrap=exit" @@ -655,7 +633,7 @@ AC_CHECK_FUNCS([ \ daemon chroot getpwnam setuid nice system dup dup2 \ syslog openlog mlockall getrlimit getgrnam setgid \ - setgroups flock readv writev time gettimeofday \ + setgroups flock time gettimeofday \ setsid chdir \ chsize ftruncate execve getpeereid basename dirname access \ epoll_create strsep \