From patchwork Thu Nov 30 16:24:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3489 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:150c:b0:fb:b703:d903 with SMTP id ml12csp306015dyb; Thu, 30 Nov 2023 08:25:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiZxaQctqv8kZI1Rqq9bSHLi2bfji/tcEsA0l99xrqUNxXLzXGBB9+h6wkrwF4WFOcy4IH X-Received: by 2002:a05:6e02:168d:b0:35c:b3ba:8592 with SMTP id f13-20020a056e02168d00b0035cb3ba8592mr3142519ila.3.1701361550020; Thu, 30 Nov 2023 08:25:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701361549; cv=none; d=google.com; s=arc-20160816; b=D/ytnPYgS1LDvzSvfUPBWS8wBBngaOgHnbTwf+Ug2JUpzU4Dk10ejlDlIXYhIMZZNk yMMq1iB0ulw3Yk90HkqronNePNU8PRzVbU2LYwoxPsnG1xHPCXGf+qzAuDTZNCf44ZX5 /YZ7K0eI4vUPJcBWfifW/pzaEUhOxMKpALBXwNwt/CwTahktEho5IVZKlQ4N+ZhUusSS i/I7yluyrN3Gug5R07sOCET+3My7n0luE7Q/7ZgQ0/oK0kqYV36XkDVnvGdwMvuosCFL KoZET1n9RlaFW4jXupMzCZX+x+kWMJt44YDZpimulQ3iEn9rVkC67Nqtd8XMQ7aYQ3jO KQ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=BuXkGMYXC+kVYXyQULkV0Om1iCyZlhqsKtqQ6MEx7W4=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=JLzxlMFpA3cLVChfQNc4XAyLturb0D596Eb1dz+sn6lyVxAhfY1A3Aa+pWkhOxKb4t jYh09lQa3wWpJzqCKtkGl0+H7gwVHoIRQqIMksrQDG4m6ePc5gX9pCb4EcuWKc8sf+1f WI6ApEtjrrCWbiD92qFMKg4wGtFxNyHuflcIQ6OxolKqb6WJt4mP2JXq4gYbGcdFmu/v 8VTqXk76wpmrkO8cJdfW83iAptoG5uaNVAyyRvAmGGwBGN2zixrU2AseDezAVunKQEnm 3I8r06bvejLOts3to3gUhLbm1U4hPR9zSd426ap1Hg7ABkX4202vNdvRGxynbxYiP+CU IO4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Y43X5vz7; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=R46ENMqO; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="AEAO7/L6"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id n123-20020a632781000000b005b8f446408bsi1480489pgn.422.2023.11.30.08.25.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2023 08:25:49 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Y43X5vz7; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=R46ENMqO; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="AEAO7/L6"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r8jqn-0003K9-PL; Thu, 30 Nov 2023 16:25:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r8jqe-0003Jv-Dk for openvpn-devel@lists.sourceforge.net; Thu, 30 Nov 2023 16:25:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L1JzSlJCJItM4+n/1Hrof8CnSV5in1TGcFmvP8Fw70k=; b=Y43X5vz7N7E1j313DelpPVYSjE lunUV0rP7fQzaM3YNVl8M6OFUh18UPuKVP2BawRRnBXNJ5FdmS9QYnQ+HUUcLMzdd0UCpoVvy+QBE s5/SglnmMKUT+IQGepukEvXDrqQ1Vr/ZJh25y3m2GUsD3RxnBoG9IUN/tSnknfx3LNAQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=L1JzSlJCJItM4+n/1Hrof8CnSV5in1TGcFmvP8Fw70k=; b=R 46ENMqO3dtSRr+EBjRw0/hm81Ji3T2acR2Ui7XhYTrqu2dFfpsk3Y61dFjpb7DdyycFCqqDbBfe93 tgyBhL3dT/O79Cf4HnWd3YPXIMJ13Q0UhaobqfeJuIuZZRWVFei7BUCYT/gHBu8nOHEhP5JnkhMvv kg8YHS0sbtOP9W7k=; Received: from mail-wm1-f49.google.com ([209.85.128.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r8jqX-0006tj-PQ for openvpn-devel@lists.sourceforge.net; Thu, 30 Nov 2023 16:25:07 +0000 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40b2ad4953cso14307075e9.0 for ; Thu, 30 Nov 2023 08:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1701361478; x=1701966278; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=L1JzSlJCJItM4+n/1Hrof8CnSV5in1TGcFmvP8Fw70k=; b=AEAO7/L649dK5nvGqn79dPmbkNdZIJIBusittMt6O6IP7xLimgu+bDB95HUg7tq9uy k5Lp6E3YO9E3vyUFnC0giLXPkJARWa/KTA8wWJWSxAsNGhok79XiF2VugszgCbzWHt2T XI+1CGbwK0gXHCFCBiiLqw8QVnk/D/BHAk2duCDdWj+axl3WddeAarLeA54ULIpjcHhP Fgiu/bBX1wyJrftZDHUgv3PoROu0UjtRCm3roOElNJHw228WzKiT1wTBB1QHlJsiQbeY ACfzTtU/tPNNypVWa7kiIoBh5qwACg3dya1vnCTJ/NdLxMZosK+7O+V4K9f6TtEKjBig Ch7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701361478; x=1701966278; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L1JzSlJCJItM4+n/1Hrof8CnSV5in1TGcFmvP8Fw70k=; b=QdV5d+E70vZ/TJ6M3nJkvdTZYmrI+AlInNRHk3etl/eChRKPdTulX7YtG6bPPoSjW8 UdRQsP8vdcdCwweP0vAPEjAPGcSmmw8bEnngDuCRphkLowRZ9v08MQ7I6uiLMIHXUAGV 2YTmQEdE2aSfpEJA5lWwCiKvP1TT1MCNr5aRck6nycXOoQCvz+00xrMtxTQ9fQhSB6qZ VBtA7T/sEJ6FJgGKtDAvGbb5ajbUThoJRRklT24QgJtgkeJmYfBaMxXwX3VnPHehbWc4 ZxvXTELce1jY1MPzedVKCdzcaOhZO6RMxOXnWjWQMAMtnd958PyfbMWF1aO8UNrSIUew B//A== X-Gm-Message-State: AOJu0YwfQAvdOgMSVvvN5V4Zll+vJonAHXgZmwD8TvMkp/ACCaJvb/qb sx2a91FdNq0nEP5DSzKIlsjMfV3lit5jSzu5iYo= X-Received: by 2002:a05:600c:1c89:b0:3fe:d67d:5040 with SMTP id k9-20020a05600c1c8900b003fed67d5040mr23498943wms.5.1701361477994; Thu, 30 Nov 2023 08:24:37 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id fs20-20020a05600c3f9400b0040b5517ae31sm5390216wmb.6.2023.11.30.08.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 08:24:37 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 30 Nov 2023 16:24:36 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9 X-Gerrit-Change-Number: 462 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 02a4d9dd088b6cedf23ea5d2991ed173c4f9dfde References: Message-ID: <837d4b88d4ef5f44f6b4d385bc2a44501ed72318-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.49 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r8jqX-0006tj-PQ Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove dead remains of extract_x509_field_test X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784006888631409308?= X-GMAIL-MSGID: =?utf-8?q?1784006888631409308?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/462?usp=email to review the following change. Change subject: Remove dead remains of extract_x509_field_test ...................................................................... Remove dead remains of extract_x509_field_test This removes some leftover references to extract_x509_field_test that was removed 15 years in commit 564cbab5f. Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9 Signed-off-by: Arne Schwabe --- M src/openvpn/init.c M src/openvpn/ssl.h 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/62/462/1 diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 8c707a4..abba748 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -880,11 +880,6 @@ return false; #endif -#ifdef EXTRACT_X509_FIELD_TEST - extract_x509_field_test(); - return false; -#endif - #ifdef TIME_TEST time_test(); return false; diff --git a/src/openvpn/ssl.h b/src/openvpn/ssl.h index e842746..6ba6ff8 100644 --- a/src/openvpn/ssl.h +++ b/src/openvpn/ssl.h @@ -540,9 +540,6 @@ #endif -/*#define EXTRACT_X509_FIELD_TEST*/ -void extract_x509_field_test(void); - /** * Given a key_method, return true if opcode represents the one of the * hard_reset op codes for key-method 2