From patchwork Thu Nov 30 16:24:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3491 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:150c:b0:fb:b703:d903 with SMTP id ml12csp306267dyb; Thu, 30 Nov 2023 08:26:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2877pJTdlkGFCp2Wbwr+dxP3XHNmHGJ15wCppMR/DfMz4//Mecba0DtoqvvXZhnRO0BLD X-Received: by 2002:a17:903:181:b0:1cf:5806:5634 with SMTP id z1-20020a170903018100b001cf58065634mr25080666plg.1.1701361574904; Thu, 30 Nov 2023 08:26:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701361574; cv=none; d=google.com; s=arc-20160816; b=JOX7MT/DqPp5U2/qPl1UC6BRG7gr3BTwt29IalSS77tk/kB8+Gj9zFh1yUlS+FlGiJ 3cToeqqN7+ziBNTUpByu8BufN6xrxh/pFW8qddqEcgpfuN1IpdQ19G2UQRRnEWZxe24m nBv/lyQcIobcLPnGUC0jSwiEzw6VjtNw5Tabwn9QlL618VzpE48IZqen7KuxbxiSjLcH FEnDnDRc2kl5/6x5BzLfbieUpNg+dLr+y5iVOYVbKMijM0evT4eltRHU03n9mBXx6jEl G0+ln/YV1F6XsSbfYVpd2YNmK2G97LQqNSLeaEVAuOmDBz01Ifn2tPn3J0fllGuMOVJ4 GziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Tl2Zsj1z63FkEKCppNcMeeceG8B5kl8FpNQoaenwsQg=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=uxK+wg1CO37ZMUPxmoigemVIdH41edZkwOUwOP2YiAi0djE7HkC4Hq2gPCOHURY9PR koJRSmsOnHizA6C4BQajfyUZidBg4nXaARRDY2hVLmsK0tPuzo362KKK04HWFwOJzhvf DVREYeqilu4z4vWu4fbnNNoQ9S7kOczBPWXk9Q0gElUm9ukRJm9z9h6ZDRV+tLT+tySV 8Ipk25n/OrfaV1jJO0/ku66DlNbVyze4pB1tfRo0lbJeeXljB66uJ0s6aogKByQsGHV0 m2i1RyJpgj3+fldVzlQH9HETWu9LP/Yvs6Ks0Fz+nGJOliq9UaB4D57ozW2v7/TD/E1I oJ0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=i+6m6PJQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=VAcP1LIb; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=VFbwabSq; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id p5-20020a170902e74500b001bf88e777f9si1648916plf.33.2023.11.30.08.26.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2023 08:26:14 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=i+6m6PJQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=VAcP1LIb; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=VFbwabSq; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r8jqo-0003KH-Mn; Thu, 30 Nov 2023 16:25:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r8jqf-0003K1-5t for openvpn-devel@lists.sourceforge.net; Thu, 30 Nov 2023 16:25:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2olvCoj2T36qn4pfJAxdzMOQzaNOYb2HaBsNaTta1IM=; b=i+6m6PJQVGKnbWNJKAznnwtdow CgrQIQpxCidpG3EgBmzwGtVc9tOVJ7akswDYtGmM2vXSNbh/2DwtH7tQ12GoCRAp4d+RPfFapcLas xBFLqBSOSHh2eMOktRdcE8JvuYv+kIue4C20Br/HdfTcDaAz0irVVHNDB7pMWOA3gq4A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=2olvCoj2T36qn4pfJAxdzMOQzaNOYb2HaBsNaTta1IM=; b=V AcP1LIbW/W7W7qQHrSrvbPBYu4HR5SY7X0uEsMer658dv2gd3Jm3Pe92Rae1WCLOuvfpZrH+aY4LS H2AHHWQW1GTz5yjtXt81r9PEB3kn/1rFVm6RT54zX5JDQv27mDti6pjGGliJeU2g13puMSne23AMj VIayMAx5lGIAtWG0=; Received: from mail-lf1-f41.google.com ([209.85.167.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r8jqX-0006ts-SJ for openvpn-devel@lists.sourceforge.net; Thu, 30 Nov 2023 16:25:09 +0000 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50bc2e7f1e4so1699106e87.1 for ; Thu, 30 Nov 2023 08:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1701361479; x=1701966279; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=2olvCoj2T36qn4pfJAxdzMOQzaNOYb2HaBsNaTta1IM=; b=VFbwabSqOTU0sHS11TXbGv1EcbD8MlQJhjUqJMO3AO8GkuSHktBsdNHbOhi6Kr333W Np6rJjVMTf+4eYevP8ATuw/lwOB4vliNtVYCIxM7JgisWDOKjzkJu9NAn5h5LMWUYcOk ViGPqK0YAikovKyJROgwyOqbKspfHq/8Zb2oD5UeMWSUB6Epw7FrnIXf7hhO+Oofdis0 YPrPUlk/Yg9pHIDO3Q/FP5a+5UiRd7wX9QGKnct4pr7D/mC0bg+fOnTN8UbyrZ74T3pu cqT7AThuP2aj1ixnRv65E6DAFUgY4M2dHWGjHPmuhPWD7AkhymnN7XKmiqpXiBY7ae2Q rV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701361479; x=1701966279; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2olvCoj2T36qn4pfJAxdzMOQzaNOYb2HaBsNaTta1IM=; b=KmYEdB9OXAV3fk/sH5Dvs+zzQ7RJpyjfV45dW54Ox8vQ6Da3VjC+3byBkXTDEu1b5O NDEJu35bt1ahCbYyTmmFZmMkqR6N1SNa1Azwd+LdYyuJaEUhhJ72WwhkRRHdYyKjXBbF UU68wwrUPNrG5WP9mDzFMu5s/E+SWv3S7Ky1YLC8dpmfLykd8QCMozNYCWAT+77Nyzle +tANYass3icP8XU3iKGpdKvuzT2GU58zQmm6YcziRIKCq1ZXR331adE9D/tFfybyOmbk VrDq66Hp78wqn3e8AlFB5x0Hzd2Eu4ggAH2eQzT3yRygZ3UlRY/LRG/+sWCg3Ranww3w dXtg== X-Gm-Message-State: AOJu0YwnzZe081Twr5DXVJaYiSu2eEJ16fRXrpAncsmJ6O5YDbiPpUCV vK6JHf/lS+NisK8QsaAMTxVivW98KGgWrUH0WBU= X-Received: by 2002:a05:6512:1043:b0:50b:c720:8f88 with SMTP id c3-20020a056512104300b0050bc7208f88mr45532lfb.5.1701361479192; Thu, 30 Nov 2023 08:24:39 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id i15-20020a5d584f000000b003331c7b409asm1944788wrf.78.2023.11.30.08.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 08:24:38 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 30 Nov 2023 16:24:38 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c X-Gerrit-Change-Number: 463 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 37301e74d3de514dd9c626827f7b4b23b4cbf429 References: Message-ID: <0768d158f9982da5613e353a86618e05d8cf656c-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.41 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.41 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r8jqX-0006ts-SJ Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784006914407007115?= X-GMAIL-MSGID: =?utf-8?q?1784006914407007115?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/463?usp=email to review the following change. Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway ...................................................................... Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway This debug code is not very useful as it is outdated and the same functionality is provided by --show-gateway Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c Signed-off-by: Arne Schwabe --- M src/openvpn/init.c 1 file changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/63/463/1 diff --git a/src/openvpn/init.c b/src/openvpn/init.c index abba748..fdab26b 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -885,17 +885,6 @@ return false; #endif -#ifdef TEST_GET_DEFAULT_GATEWAY - { - struct route_gateway_info rgi; - struct route_ipv6_gateway_info rgi6; - get_default_gateway(&rgi); - get_default_gateway_ipv6(&rgi6, NULL); - print_default_gateway(M_INFO, &rgi, &rgi6); - return false; - } -#endif - #ifdef GEN_PATH_TEST { struct gc_arena gc = gc_new();