From patchwork Fri Dec 1 11:18:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3493 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:d588:b0:fb:b703:d903 with SMTP id ev8csp264360dyc; Fri, 1 Dec 2023 03:19:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDngQAQvSmupTpRxXyNLEMGLPwPlTzXoCSz4Y3B+iEB4FvdyvV7u9XkJmjZxmfhFkBgOpE X-Received: by 2002:a05:6358:63aa:b0:16b:9882:2b7 with SMTP id k42-20020a05635863aa00b0016b988202b7mr25670617rwh.3.1701429563551; Fri, 01 Dec 2023 03:19:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701429563; cv=none; d=google.com; s=arc-20160816; b=Bo4fGImrZ7EDT2XmoHOM1h8EYiO46KI0l0JL++DNePGuTEcIyoWfgNUdr4Ko1EsBv+ emFTZJXViccEFHc6OcR82NdvkWfod+3GQR3BLxY1bkuanpq3blAuZvr8P7GQ0hybFVfx nNF96rPOjoq1Z5WbYh9E2wBB7yfTlpwaOLG9kqGuTs1THWD4zLEtUZ+KneLu4CqKmWFU JEBdg3Up7dDvANwHftfAWcLuuz48rg/YCT/ej/XMWgBCltGL67jnywnTOyn33prILSwf rt0cWe2+pEnUzMuAA8Qqpi5w/vLm+miC0O9ajWydVRdBbOfZViWByOGuSuObSGo5ZHj0 bqKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Twzs+rGvhfh0LoAysRBpJ9qPMz89Tk/z9mfl9YggqCg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=TY5RDaRMqxg7z9lEHfEazIKyaB+DBX9ej+Y/R4CNoL0/z8GDh02cYa8PsKGwLM2zHK w2CpqUzrW1bJzo2BkiDeam30xEjQUashsF/tbkIEGIkVwcEsp+mvMWYStGwZ1VhLbY0U Ux/ULQr5MimJbF2pCdTr96/0ECVtT/0bAU9xRRM3+UOSc7UoeU7tw7jRJt3NNhXbdQSy ZniiQLCeT2Ep+V9kjJ6OGUo6IWbned8QyvS6WQkAU3MMwDbDJTgX9g6dPD0I5CEG9wfx pF4X0COR0DgGd3xgkrwFp3oJrev48beAiYS0fvRASL2n7Hahq274h7bD54V9UGD0XgDy YwDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JYEFLoWP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="OX/cWoQJ"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=1PA2wVMo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id r28-20020a635d1c000000b005bdbd1b52d4si3134137pgb.270.2023.12.01.03.19.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Dec 2023 03:19:23 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JYEFLoWP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="OX/cWoQJ"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=1PA2wVMo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r91Xx-0008TO-6B; Fri, 01 Dec 2023 11:19:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r91Xv-0008TH-GA for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 11:18:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KLRLKkIdomM4RdsftT9UV7XQg6kwnjZsEJrppMrRjtE=; b=JYEFLoWPFZo/ZcAm4Lz5Mz6QmC cZqgr0P6mRn37QAIAn9USdNfYH7NWI2B766vHFbzCKjf+gdAUeHNV1CXXSUsGXyzU9oqEm6lKd5WS jZmFFgGEAZje3XQgHt07lhIY6uyxlEs+cZw2zf4FWmeBPFNrKoS+KK54QuLxuLfHfBW4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KLRLKkIdomM4RdsftT9UV7XQg6kwnjZsEJrppMrRjtE=; b=OX/cWoQJfI3MZ/8k/4sZOsQBQW WC1hnL6SMZ6RtipuXKSQklWVyPfQuviBfmo9ePHkF7JkGMrb5nj89tWQv5LoqGjkvpAvXwCfLSHy6 dOEnk8Gsq7E1aqlzklnQ6avNqSK6xqKt4U+elaeJ3RKdk8JLYYMqrKqGgXn14EcoHywg=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1r91Xr-000879-VN for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 11:18:59 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4ShVtb3wthz9sc3; Fri, 1 Dec 2023 12:18:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1701429527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KLRLKkIdomM4RdsftT9UV7XQg6kwnjZsEJrppMrRjtE=; b=1PA2wVMoeF35BIgaKcWF5t1dWB8If7OfPwf7JR3biSPnroGbX70S3/4h9tD+OngoiLQrSj dZOfRqs23wLz4S+fShNiCyZV82FxU5rrTbMizm+eqHXR7QmxbjwFnzbcRGK+xNqQ0pnp7I IPIlCAPACDOmZkjFBoXw01jLF0zVp7Wl1jX6+/Nv/+hBli6tVGunYg9KUNsWxTyzOoJX96 Y3fjCrlB3+U75ovxLH548dkxrZF8jOySldxTEa6sf/1W/fqW7qPKTmsoySNwN3wKkNlkxx 16SUPoatDHtD6hgpg0IThkIQzeQ1IvFWfY1SnC6pV7PqErQj/Xd2Un3uBCwMwg== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 1 Dec 2023 12:18:46 +0100 Message-Id: <20231201111846.15097-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4ShVtb3wthz9sc3 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This removes some leftover references to extract_x509_field_test that was removed 15 years ago in commit 564cbab5f. Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [80.241.56.172 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Headers-End: 1r91Xr-000879-VN Subject: [Openvpn-devel] [PATCH v1] Remove dead remains of extract_x509_field_test X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784078206022430754?= X-GMAIL-MSGID: =?utf-8?q?1784078206022430754?= From: Arne Schwabe This removes some leftover references to extract_x509_field_test that was removed 15 years ago in commit 564cbab5f. Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/462 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld Small fix in commit message added manually. diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 8c707a4..abba748 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -880,11 +880,6 @@ return false; #endif -#ifdef EXTRACT_X509_FIELD_TEST - extract_x509_field_test(); - return false; -#endif - #ifdef TIME_TEST time_test(); return false; diff --git a/src/openvpn/ssl.h b/src/openvpn/ssl.h index e842746..6ba6ff8 100644 --- a/src/openvpn/ssl.h +++ b/src/openvpn/ssl.h @@ -540,9 +540,6 @@ #endif -/*#define EXTRACT_X509_FIELD_TEST*/ -void extract_x509_field_test(void); - /** * Given a key_method, return true if opcode represents the one of the * hard_reset op codes for key-method 2