From patchwork Wed Dec 6 15:24:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3503 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp2276387dys; Wed, 6 Dec 2023 07:26:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbgcilJcYWAImroY4ZITEuDtGv0EMVEwAed3do0JcFKRAQA+aJOS1iKRskIVHivVuDM30l X-Received: by 2002:a05:6a20:e11f:b0:187:9486:901e with SMTP id kr31-20020a056a20e11f00b001879486901emr2112246pzb.0.1701876363852; Wed, 06 Dec 2023 07:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701876363; cv=none; d=google.com; s=arc-20160816; b=pMbpLpsRUnOJUa00oe2qiZpkHKOmtScgcvtRIcz3bc7AuPnpgm+b7HhMMWOtg0zBDx m0wHqFHonrzyzEANoGH2fI+MFhG1G+OwTrOjcvyJN4btjZNYEA1xNvvEF1Diws8QULh7 cj1JIYk6QXCW3vPz9iVu7nEf+RA0T+CsFkmKkXv08Ku9ejC8XGM0RQIJ6tZLfIm+exGJ JJ0f2ZXFgvlz/uG34/3XjhH9aiTRenq7+2C6L6Eplkg2lwXWdNFpkF8yiJHyC0mETqpd sW7cKGaHTJ7ILVkEpYU6VYAzQqajjnuCtDIQh5R4Yb9MOcHtXJsRsiLZSp2olTXhaAFJ 0R9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=T8X9GNA2VpqNuThuZy/bdg/qg3guEWaFn/PDgKhFnrk=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=K3fPJCC7SiNyJ9L97FzTQGN8zcQNfqpFOpYOET7/QlTmZMwYi1Ut5ZkD7Z5YQ6l0zO 6xixsPJZiBgMN29GQHfvwoDw0SMP0ZW0a8az2vTEk149ZN+oIhqwFimV9fRs2hFQrMpD MebxVDV0tkTHJjoIXq+qKK5JG1M7UQdSp3Ms7Gm6ZJY9bWFF+U4MqhrNcckjAtyctrvB /fB4GUooSkxF4gsj6WAPtJdbuG2ETu1ATcinnDrr16hiGCF9wsneBy2rj1lesjTBseLa Ori+Kt0fa7ZESPS9k0ojoOL/p5oWYIuaAbMyJxaHGNzIK27M8VemJGKKk2E8Y/v9npgi KqCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CJFwKO10; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=friEVezv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=bkx7GJkU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id m128-20020a632686000000b005bd3ca6c394si72364pgm.43.2023.12.06.07.26.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2023 07:26:03 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CJFwKO10; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=friEVezv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=bkx7GJkU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rAtlu-0001kw-QZ; Wed, 06 Dec 2023 15:25:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rAtlt-0001kq-JW for openvpn-devel@lists.sourceforge.net; Wed, 06 Dec 2023 15:25:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tps91uAgz0jtWMURZxH64g5+SgNaCSLZZmv/JRqsHP0=; b=CJFwKO10GuNUMxWehV+yzqJteI OSiUznyQDL+EpC4xByoDnhmPJyBO13WLATmsraeJiM7WJcb/0ihnLKzoQUxh+YlspPf7UarDDvJHr 8Km46XSOhGLfZl6gDncAJ5fXq4vBHr9Xq3KW8NXwPP7ff8sdpRmxKarj8/Zi6rrcbTIU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=tps91uAgz0jtWMURZxH64g5+SgNaCSLZZmv/JRqsHP0=; b=f riEVezvhuMe/8HzwJ2kK4Sh+44VW39IRXgPzpZT/CuW/Lx6CFoH+MWx62H2MPwCtD+Xnz/3x7NMCE 3dG9EKTKBEVNH+W/88nqjxcvs+CGohlbhSS8RIiGTfbjb/5i0zmy37/aXL0uFpXpFyptQztc0lnCm LtogedP1rxxlqWhY=; Received: from mail-wm1-f48.google.com ([209.85.128.48]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rAtlk-0005oX-Vk for openvpn-devel@lists.sourceforge.net; Wed, 06 Dec 2023 15:25:09 +0000 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40a4848c6e1so76996655e9.1 for ; Wed, 06 Dec 2023 07:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1701876294; x=1702481094; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=tps91uAgz0jtWMURZxH64g5+SgNaCSLZZmv/JRqsHP0=; b=bkx7GJkU4BNigFo7gMUjUQCsQFTakmjLkKei/BPu1C2WLUkh5TNjdRc1jEGkgZtyHL fWqgef6t5IUnO2XTlDycpT6QtVJ1fRXDdPfxBiP+j43sM6Y8HFiO+ggHVsua8cBvjo3H orK/2R9AEfO6c5LHyaLXQuZcnZgisqbYHoeBO+XM9rIVqhfldHwAaiL405XIZ0OWUOLd a+RSskuDQNrt3xwkMfW2dUQLkaTI8rfSf73YDr2Iod3c8/zRI3aII3AG0mxZFQuA1aY3 CKSDC0+aLfppot5Gdt56ypFuftx6frIMAjjgJzdcLbOpJvXDtJnZdWRKLis+rLqf06y6 gFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701876294; x=1702481094; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tps91uAgz0jtWMURZxH64g5+SgNaCSLZZmv/JRqsHP0=; b=qh643iiFCxLBLD6qSs+F8N0kQgCxppb2FYE/mF4C5G5C5Y5fUz3Yae7dDGgDUZ/tw4 MwfgHtT0xldHxW0EmKIwTwAyJPR1aBSZyG196l5f2y3cKA7w2kEiF/4HDs7/M3oenbW6 Jtd7t/6dbzcFDgW8ot2xkF4jDEDfvIwP76NsZoODHMhBsx3hoSfZgQKJUV27Od5myKUy EOmGqwYQLR6byE+/M9jQUMIRX4mRBOqVfa0+1y+0uadMAtjxs0+YN1ymBzr14eYuyLkm NY7JQLW435X4NgBDEK8SWReyygcKxQvsDOgB/Ib/mJRRU5pQ5bM0XgrZMLac5o2vp89n z06Q== X-Gm-Message-State: AOJu0YytN75qHhLRzYiMp+MnP9sUZukwmCsaQ2HlvivJv4RVYG/QQt9M Dd81s7WtBsQTxZJaBFuEIDhMTnsrYFmMuY6prss= X-Received: by 2002:a05:600c:4d98:b0:40b:5e21:bde6 with SMTP id v24-20020a05600c4d9800b0040b5e21bde6mr661454wmp.117.1701876294383; Wed, 06 Dec 2023 07:24:54 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id u29-20020adfa19d000000b003332db7d91dsm15786786wru.39.2023.12.06.07.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 07:24:53 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 6 Dec 2023 15:24:53 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I5e394bb73702d87562ed354100eaff9b41f5389e X-Gerrit-Change-Number: 467 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: c4a31d7a8c9e9ab91bef190497977d4025092233 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.48 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rAtlk-0005oX-Vk Subject: [Openvpn-devel] [XS] Change in openvpn[master]: unit_tests: remove includes for mock_msg.h X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784546710075180418?= X-GMAIL-MSGID: =?utf-8?q?1784546710075180418?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/467?usp=email to review the following change. Change subject: unit_tests: remove includes for mock_msg.h ...................................................................... unit_tests: remove includes for mock_msg.h Not actually used. Change-Id: I5e394bb73702d87562ed354100eaff9b41f5389e Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_auth_token.c M tests/unit_tests/openvpn/test_crypto.c M tests/unit_tests/openvpn/test_packet_id.c M tests/unit_tests/openvpn/test_pkt.c M tests/unit_tests/openvpn/test_tls_crypt.c 5 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/67/467/1 diff --git a/tests/unit_tests/openvpn/test_auth_token.c b/tests/unit_tests/openvpn/test_auth_token.c index d96984f..a027330 100644 --- a/tests/unit_tests/openvpn/test_auth_token.c +++ b/tests/unit_tests/openvpn/test_auth_token.c @@ -36,8 +36,6 @@ #include "auth_token.c" -#include "mock_msg.h" - struct test_context { struct tls_multi multi; struct key_type kt; diff --git a/tests/unit_tests/openvpn/test_crypto.c b/tests/unit_tests/openvpn/test_crypto.c index 5564524..9e5469a 100644 --- a/tests/unit_tests/openvpn/test_crypto.c +++ b/tests/unit_tests/openvpn/test_crypto.c @@ -38,7 +38,6 @@ #include "options.h" #include "ssl_backend.h" -#include "mock_msg.h" #include "mss.h" static const char testtext[] = "Dummy text to test PEM encoding"; diff --git a/tests/unit_tests/openvpn/test_packet_id.c b/tests/unit_tests/openvpn/test_packet_id.c index 90c67ac..2a2a973 100644 --- a/tests/unit_tests/openvpn/test_packet_id.c +++ b/tests/unit_tests/openvpn/test_packet_id.c @@ -36,8 +36,6 @@ #include "packet_id.h" #include "reliable.h" -#include "mock_msg.h" - struct test_packet_id_write_data { struct { uint32_t buf_id; diff --git a/tests/unit_tests/openvpn/test_pkt.c b/tests/unit_tests/openvpn/test_pkt.c index 9f49ee7..7f05184 100644 --- a/tests/unit_tests/openvpn/test_pkt.c +++ b/tests/unit_tests/openvpn/test_pkt.c @@ -40,7 +40,6 @@ #include "ssl_pkt.h" #include "tls_crypt.h" -#include "mock_msg.h" #include "mss.h" #include "reliable.h" diff --git a/tests/unit_tests/openvpn/test_tls_crypt.c b/tests/unit_tests/openvpn/test_tls_crypt.c index ed7c794..465543a 100644 --- a/tests/unit_tests/openvpn/test_tls_crypt.c +++ b/tests/unit_tests/openvpn/test_tls_crypt.c @@ -36,8 +36,6 @@ #include "tls_crypt.c" -#include "mock_msg.h" - /* Define this function here as dummy since including the ssl_*.c files * leads to having to include even more unrelated code */ bool