From patchwork Tue Jan 9 11:09:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3558 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:a213:b0:100:d2e5:60d with SMTP id bs19csp30865dyb; Tue, 9 Jan 2024 03:09:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWQnkdOtBAzanafaJwU4a0HWu+4GIkN5t/01WBBFhJcaa2IybMj5UbQHy2jLySE9Oc7dPY X-Received: by 2002:a17:902:6848:b0:1d3:7788:1c40 with SMTP id f8-20020a170902684800b001d377881c40mr10648083pln.0.1704798588746; Tue, 09 Jan 2024 03:09:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704798588; cv=none; d=google.com; s=arc-20160816; b=nXvDx+rbpffikUzDdAM4ZnDQV8LrJf2wBWdfxFYVlUqFrcpuL8PXSzjh4W+qPNsN57 buJ+nCsykTLNIg1BlB6YKY7u6py4EnA9262ncU8Srx4jNu5GV5XD3APb8NVDUlmjopQ+ btBxBMEAN1+KKIpnQFj7kl8ebVsHz5M+xcrW8YrshjkXphX0IC3svn929UF1ODvwejrT wGgFAGULFza80Pci4TgYmocI6OkHhSZ9nvJ5cFphVHe9l0ZPpwO5gDXpAncLqLWlYRCt sDTqpWMzVpdBPQRECouAMYh39LIDjYgMfCUWcY8Ogv7ES3Exr0nXMr83GR+tL+aiQqqp Lizg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=SbYcr+ml9t14AQHjJDQKdu+is8R4Lfd5dqatU7BPK04=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=kWrzUWIxGkbt9RbLiZxtHzMrZOyHAjBNeKjBThKv7mVkAYvX1H5vej6sae4fSkaYpR Tb8owwndkeOikLaSXXSFtmbpNscLE1IcD/lx9y2H7oGPNFUWeAaCL0UCtgEscKjKZA0a n7UF/XY3bPbyfKEioHm08IdG6qoPBWYcRMNjbHPHOsabVd/sl8Wm3JtB/+vT3OTBCCr0 rtRG1SqyEdWuLq2bYbxQ+AvSHgk6x4s4OvvjdnEvhkDNnJB68rWFk/tTOUNbcnBV4jB+ ND28BlWwFxbB0Z5hqijVdBkBqS52h5JjNws88dChT/WRR8YY8JBMcUKTF4x4vClHtePh Z1gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VyA4pg8U; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jLKWSaoO; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DVmDgOka; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id x2-20020a170902b40200b001d55aa9ffecsi652716plr.253.2024.01.09.03.09.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jan 2024 03:09:48 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VyA4pg8U; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jLKWSaoO; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DVmDgOka; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rN9z1-0004QB-8H; Tue, 09 Jan 2024 11:09:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rN9yu-0004Ph-5W for openvpn-devel@lists.sourceforge.net; Tue, 09 Jan 2024 11:09:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x65PYWKOTnOD9rQIbkDW0sPWDmZJ7kr5R6kNII7bps4=; b=VyA4pg8Uss86Z1hK8sQRJG6RQA VPr7PoSUrIl+wk9/NI48kPCqvNY1Xe4kLYdUR2TF+y4RIDqga5YIXWPq/Ah1mVAapt1CPnc2LVmWa 1vCgxtEKbHO+Aqdbi16L/rPkAMH2pvRBLYlOF8yuYY0+T3xKjgyvyIeznuRk4KbG5lkw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=x65PYWKOTnOD9rQIbkDW0sPWDmZJ7kr5R6kNII7bps4=; b=j LKWSaoOhGL4uQAzQPLakGZrgVDKV1YMcc4rw8gTAv3TfYvy942TYd9wmN8ZGKbxGavzurd6isyRJg r3STVUvW+0M69trc8xLCMO+lN6c9v57/S/sp8Jqx4ZjLW1RNoCvfpmnt3+iSa2cHcvolyLtY79mG0 inxAdVN1oOL0MDRk=; Received: from mail-wm1-f49.google.com ([209.85.128.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rN9yt-0002iR-4l for openvpn-devel@lists.sourceforge.net; Tue, 09 Jan 2024 11:09:16 +0000 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40e4f71288bso4932585e9.1 for ; Tue, 09 Jan 2024 03:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1704798543; x=1705403343; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=x65PYWKOTnOD9rQIbkDW0sPWDmZJ7kr5R6kNII7bps4=; b=DVmDgOkaEXi8R5RXoIDD8L8a8p7tPYpMcuFkFTZSG4YH2GHj3U234TNlXZfWBwymQQ uNTLN9vVUOvX+tM31evWmpr1S/Hc/4oXXqpU7VKXfPFiXjGtEIYSERTl21K2oGrU06M3 dBbNhZOSC4Fb+GnatiGNCDlIkZMNhfyMQByhOKisX7qJkmvN5c2oAscg4vAdY8KPRJkU 041CLyPbTAQ5Y0rS4QLckG3nc6fDTWPgrnmCj1+O6+9hPA5WiXOTRDJEVl6chy/Pwk2A NYVaoa74PmhExaXbb53Kg3OU/2vvUaEpbzibIrPTLpTYyirh8U+PG76lHPwhDhSQe8h1 oLGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704798543; x=1705403343; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x65PYWKOTnOD9rQIbkDW0sPWDmZJ7kr5R6kNII7bps4=; b=vLMQ2eSbVLV8Q4QKcRjqCc9yrwIAcRIgRNayCW8s8nYUCv1cmwo7VEAzYIE84dzqMa uIwt++SwMmAuZ+6FqWbOdo4sdkO2v9yrQONqfHGQpIwsbDPsZKgPWJ373nXD/+17i9Jn JrIB4nrIMJd9pu/llwByWIW00fJHsDUYWALBrYVncw2ARd4Bm1t8rNhbY9zRMALy0/gY Ie6Oxwm8EQqQ7GTowb5JYyOC7mhD/Tg5ynxhcvCqoPspmgwSjopRqUch3AjJKwrwaXWF hQ4DxbG/zh7aNMO472I7g/OFRaVrXyq9SDEUOL1IMQ6J3rL+FANQ0V4fVFq4wY4KMBAC N7Yg== X-Gm-Message-State: AOJu0Yz8g5S4lTt9j7WIgaQzIVhsAleV4Fg3VHci6GqHIB+xc9DOWH2m 130qFaG1YQi8S8B2+jvPbrRtptlyKJOtUg== X-Received: by 2002:a7b:cd8b:0:b0:40e:4866:efd5 with SMTP id y11-20020a7bcd8b000000b0040e4866efd5mr820729wmj.279.1704798543725; Tue, 09 Jan 2024 03:09:03 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c358f00b0040d90407f7esm14426154wmq.8.2024.01.09.03.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 03:09:03 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 9 Jan 2024 11:09:02 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 X-Gerrit-Change-Number: 491 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 0dffb9edac25f59c5f49b71d3e8902707e80e337 References: Message-ID: <77b603bc7e5a745a4e88f37c194cb081860c9c61-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.49 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.49 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rN9yt-0002iR-4l Subject: [Openvpn-devel] [XS] Change in openvpn[master]: buf_string_match_head_str: Fix Coverity issue "Unsigned compared agai... X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1787610884840011271?= X-GMAIL-MSGID: =?utf-8?q?1787610884840011271?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/491?usp=email to review the following change. Change subject: buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0" ...................................................................... buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0" As Coverity says: An unsigned value can never be negative, so this test will always evaluate the same way. Was changed from int to size_t in commit 7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning, but the check did not make sense before, either. Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 Signed-off-by: Frank Lichtenheld --- M src/openvpn/buffer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/491/1 diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index 0b94a52..2ad3461 100644 --- a/src/openvpn/buffer.c +++ b/src/openvpn/buffer.c @@ -822,7 +822,7 @@ buf_string_match_head_str(const struct buffer *src, const char *match) { const size_t size = strlen(match); - if (size < 0 || size > src->len) + if (size > src->len) { return false; }