From patchwork Thu Jan 18 13:25:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d12fk (Code Review)" X-Patchwork-Id: 3578 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:2802:b0:101:b91e:57cc with SMTP id hj2csp333219dyb; Thu, 18 Jan 2024 05:26:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGaTo5g9Q6eo1jinzCmd7PTh0p/kwVO0wFS/fgSyoJ2DPFse4gmFglnlOQMZpNYSFXWcZQ X-Received: by 2002:a17:902:c3c5:b0:1d3:c3d4:86a2 with SMTP id j5-20020a170902c3c500b001d3c3d486a2mr1578907plj.2.1705584381651; Thu, 18 Jan 2024 05:26:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705584381; cv=none; d=google.com; s=arc-20160816; b=OFvr6NrbG8z7N6x8qXwT12CWDR0F0Ub5WTeBKQi/9sR8NzP7UQzOFxJUTeWcDFmNib ytvM8jpG+Pob7/EtwQwavk3KarGRR2nOLmQKrAPJEb8veFO7N3exY4yNnvwNTJ4p3X93 LML/7VqKM0yqxR32M8JfOOrczmhETpM0d2p78hBmceYVV6MeGccnjoUnBiaTVPuLnGEX MwYJISKvbIdDet3rBwqkiKecjaLJZkKqbE5436asUVf3aqWipRTsvZOJfnMZWUb3i4U6 w7SqjDk/I3/Ch75m04j+NpoY9F2FqhNZEluIjCVFJnY1RicM930sWdo3Dxjwq7G5Dc3D Mr0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=zL/gP7NEu7OxNOuORzIRUhw+je7K5Gi846x6bMDoTmU=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=UZGOxVJFV1JYM95pVnAVT0ERWtaZkElNjrRrTvD7gqPIoVvWwaL5XMA+snxWQAqBiQ LP5LDCAnnnu2EOY76QPfwJZ2kNZZ+bpepUKMJLIRspH9jT/QkhEwPOGRZjf6yeufR5a+ QtjBLw0Uu68SvQq3ew2AR5iAO7nI1og5JpVeBZzi4o8ld4ZoHi5oBN2+EkVusWm35UKl 6kDv+lLv845NNMePDoemSx/snHu+lu+QueQZydJN8mRuuzNlTKAVgNJxFrNOQMLNLVg2 ctP+kQmd7hFCi6laai6LxH3jxWyACH1ApOaoPh7cbSPvj68NPqv/te/9nOj1vrmzf81X Xh8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gPj2RYzO; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hnBimB4n; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L4EG048K; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id j10-20020a170902690a00b001d453cffb92si1382034plk.620.2024.01.18.05.26.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2024 05:26:21 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gPj2RYzO; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hnBimB4n; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L4EG048K; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rQSP8-0008WI-R3; Thu, 18 Jan 2024 13:25:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rQSP7-0008WC-Rl for openvpn-devel@lists.sourceforge.net; Thu, 18 Jan 2024 13:25:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=96bkBG12vBJ7QfdEDBAhjr4rAlElByi3oORIhRqO60s=; b=gPj2RYzOe/sqs76243AdDoAai5 C8MO3eEtlG9aGFcNXL6XLqJK2zepDhY78+cUsjvm8Fg3Y6uYsWAA5Lub7jFh/Lmi90AT+x1Oa3QZf NnP/TbLrMf4u0tmsnDqJpY6Eqn10cBCIjSXPJzh+86FRMERgHVrYTYR/tWaRbFkDdRmU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=96bkBG12vBJ7QfdEDBAhjr4rAlElByi3oORIhRqO60s=; b=h nBimB4neLimMYcLbuZ9F/snfqOmWoIC6Bz1aqUP4Rcv6Jv5E5uDu8Dk6QRNukh4TCK2pqzk5fLo5G xjcTetxnXmrUU0+2YXY/3WN8Yz94VnsO4I3ZQ/ZRei2jTZMCjFcVvpC/F/6iFNHMR79KhRKzawydV 4iSGO5ciPmnF1+SM=; Received: from mail-wm1-f44.google.com ([209.85.128.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rQSP6-0008Ly-GP for openvpn-devel@lists.sourceforge.net; Thu, 18 Jan 2024 13:25:58 +0000 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40e8801221cso17468515e9.1 for ; Thu, 18 Jan 2024 05:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1705584343; x=1706189143; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=96bkBG12vBJ7QfdEDBAhjr4rAlElByi3oORIhRqO60s=; b=L4EG048KtrbCjcIiJ8Nb/89H7mrlOe+t5v3EgTlUpd/cRS7e/HS+p7aHMZ3Tk2sZ59 dgHQQSbhRjpna1nTwBolamLv9y4BSrJk9NluXv0xMs7jzYj4rfPUbGVqAHR6O2sXesOw d6uqdzlRxotxx5YAb6YE23UNPOFGTIalZEBw/vWgW6+ogEF52IHhXj5HRa9aFjI3l4vj +wG3oJ/TP8AtzuPp1/S2isetN7CCiLydBTEm0CrfTbBPXvfdAHi9diPCSAykMWVqlQst 7qm7WLxUYTJE4qiOiqRR8jiz3xd8ZWGW5AJC37ku0oiWy4Tn1q2nZTbVG6Ki33uvr3vA cFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705584343; x=1706189143; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=96bkBG12vBJ7QfdEDBAhjr4rAlElByi3oORIhRqO60s=; b=a2k+n4+mo5jSAhEHbdVBjih1WfzO1TYbtoxPwtYqeqjN2zx9Tngk7dlno8vCoOGU3s fOypHLIM0H8pAVLfoBwepEOyrRXO0sCXXn/H2+Sv7x2K6HuJJ3t4NAjNKI7VkbN7paRx 0u1gy8htfR8BXxCYj4x1rc0329Xwl5k8r7OASIimq0klXwJOL733hTEcBQliDULQcZGe n0Jmdrpp3oYLv7t7oL5xA1w7sI41A4YgYlwUq19+nZ9KjLOeh4KvgLxqpux4Y0b0dyAO Ol5NwvNkRi0QOZZYL88BdikZbSB9H+ZyVH1Nm7UWYs1SueMMRjmL90wEwPu32VyrOSjf LiTA== X-Gm-Message-State: AOJu0YxjQ89GN6A//nCp6QMF8rGjB7c/Vg9zH2ihKfmya6eDfwVXcS6J whq3EhchLaLjRYeDpQnlT1MYt7rh+Gvtt9jrloaLtGBieCy90dICj/e7VDLTxlgUq2MMFBjXP+M e X-Received: by 2002:a7b:c396:0:b0:40e:57f2:5972 with SMTP id s22-20020a7bc396000000b0040e57f25972mr559945wmj.104.1705584343054; Thu, 18 Jan 2024 05:25:43 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c1c1100b0040c46719966sm29663287wms.25.2024.01.18.05.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 05:25:42 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 18 Jan 2024 13:25:42 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ia9c5453dc08679ffb73a275ddd4f28095ff1c1f8 X-Gerrit-Change-Number: 502 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: fa03cfaa96a9e180aaa9aa3177b954d720e87491 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.44 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rQSP6-0008Ly-GP Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove conditional text for Apache2 linking exception X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1788434848608582865?= X-GMAIL-MSGID: =?utf-8?q?1788434848608582865?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/502?usp=email to review the following change. Change subject: Remove conditional text for Apache2 linking exception ...................................................................... Remove conditional text for Apache2 linking exception With the reimplementation of the tls-export feature and removal/approval or being trivial of the rest of the code, now all the code falls under new license. Remove the conditional text of the license to be only valid for parts of OpenVPN. Change-Id: Ia9c5453dc08679ffb73a275ddd4f28095ff1c1f8 --- M COPYING 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/502/1 diff --git a/COPYING b/COPYING index ab59cef..28525d7 100644 --- a/COPYING +++ b/COPYING @@ -33,11 +33,6 @@ Apache2 linking exception: --------------------------- -OpenVPN is currently undergoing a license change to add an exception for -Apache 2 linking. The following exception is only valid for new contributions -after 2023-05-03 and past contribution where the authors have already agreed -to the exception. - In addition, as a special exception, OpenVPN Inc and the contributors give permission to link the code of this program to libraries (the "Libraries") licensed under the Apache License