From patchwork Mon Jan 22 12:45:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3584 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:2802:b0:101:b91e:57cc with SMTP id hj2csp2549425dyb; Mon, 22 Jan 2024 04:45:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IER3nrNWDHnuUrq4iP17KH+XVa9TLFl5R8zfg5qa+ixqtYOCmD4eJjhnbzPhZv59NsaejUh X-Received: by 2002:a05:6e02:1a84:b0:361:9667:937f with SMTP id k4-20020a056e021a8400b003619667937fmr6449669ilv.1.1705927558465; Mon, 22 Jan 2024 04:45:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705927558; cv=none; d=google.com; s=arc-20160816; b=cQl1gI+3g41kv4ohCqw1Nf7sIHPtzM4+fZN/nymRG085wqHiJDn65kVuLjfmB3w6fU m31pvjsIhP3hsTKN0Yyn1O1Bgi0RPqUj9zY2rgQbtsVVr5IYvDvTi6a6YxedAMWchr+O KL4zZ6YNivAIKmJtw4OR0hZO6nrwX7AGVashHiTRsbMEO81WmUqH2IN3EXeaKm2ocUqr 1tdU6i9v2bJY1n9Q8ax7OcfEY+9+WO1roBMYW1UEEHfBw1Q5mw38XQG6p8sGU4xrcux7 zcLRnuav6aWYikb37tyRtKsbT48icVlddJmfgApYRK/yVpjNCPO8joAtkjt/x4LjIRYa jCTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=DyxK3GwYJZFbj6IrUo0mgAv73BM73XPrPwoxpg8uOHM=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=L0BKbV7wc4Gz5xxpEbj0LDBLXwDKjxjaAj8Rkm86IlvZ7mxUouI3CKuywWjChmdTu4 Qv1WCkGbWiKvgDn0rKqn38qx0rZhmqLrMeBNFdabRaFW9UsWBRXN3/lacaXx7tcG4OfT v1z6m98Q2r4MJeNQPWmBKzRLah18Sj3cqu80/YOnBCXScnxsKICRLBjZ0nkjTH6EK7uM mxihMrCw1o9WtfqOA+aCBmazhYlXXwy/Yw9qZ2OVF722VAPQjvA/imdAK1smCax+tLWP VO5R/QyHo8VRDB29StH3d0AyyGIxbAr/++OG/b1Cc50IR9Pv51TymBLm9Cm40cuCVaoj md6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="IK/hXMtP"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="ekY6/WnF"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=fmuB66Be; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id b25-20020a631b59000000b005c6673e2c72si8007710pgm.213.2024.01.22.04.45.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 04:45:58 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="IK/hXMtP"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="ekY6/WnF"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=fmuB66Be; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rRtg5-0006QK-6Z; Mon, 22 Jan 2024 12:45:25 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rRtg3-0006Q4-2J for openvpn-devel@lists.sourceforge.net; Mon, 22 Jan 2024 12:45:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zXv+zeyVCkRjBjmNWEecusk6KiEFsHqAVwFyYImna6s=; b=IK/hXMtPu1rxgf8WyV37P+kCg7 8TmGhYAPuxT9MA9BWIBMs5trOyfSi/IkQFDiYrICjIipaw0y/QCeJYcyKQ6cIl5Y7x/6Hy5Y7OcIV QMdzQnOtA+rHdlGkJhyUSuYpGtQXPTr2aVkiwe5DWWDyPlLgAhVqP9m0fGiN2nUO8PSE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=zXv+zeyVCkRjBjmNWEecusk6KiEFsHqAVwFyYImna6s=; b=e kY6/WnF6PsTNRZ811ZOOPqZ8wG+ymvd5+VPAx4N7OIsQBWCkOwffzxiiiKZl8GiCWs2K3vHA2+oap 43rxGDR9+STklM5XEzmC81GgZp3BJBIhwrYWfJ3Dp9YAOdgoNw6Jr4eZgNF3u6GdbZfZ/ycvkuRvQ 0tXa13EKO5ZENfPE=; Received: from mail-wr1-f44.google.com ([209.85.221.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rRtfz-0001IX-Uo for openvpn-devel@lists.sourceforge.net; Mon, 22 Jan 2024 12:45:22 +0000 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-33931b38b65so1138812f8f.3 for ; Mon, 22 Jan 2024 04:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1705927514; x=1706532314; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=zXv+zeyVCkRjBjmNWEecusk6KiEFsHqAVwFyYImna6s=; b=fmuB66BeKx9FKG/OmoSsEC70u/9AaW+b+lpuvSGUkaNcf2/B0/TtfWjKJvy0rTcfvO jhJmUVtWpR62RFJJnzAjk5Koi96ydbbPChBSFphhbHK/dzN7c9a2tVxy+XI/xoUJjA/Q 5Un3Vt4sVKGuHu97LEfRjcld3EknpcqoBc75d7bKV59dLSk20EVCxXyuc3JTBo9DrnSy YuKIJoyYZCBtfaMM6URUr2bUPIodhXZm5WkJgFPkLnUmCLxSB5cZssyZdrxg6l0zRY/0 E8KVPZWQsytPX64aBfUxLSCh8LIRxpRWx7lmo48Ytk7SeGK3jYp7fWejWdg4dV4Ie8oL EsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705927514; x=1706532314; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zXv+zeyVCkRjBjmNWEecusk6KiEFsHqAVwFyYImna6s=; b=M1Wp8E7FprbekGw/wviMOwP4kzqy20BjGOiEy8AH+l9prZK+JOzQbTK4A0bJwrKax9 mOodY7cI3v7HfWT4TYLsV2K+UDJznRFEnNknh7PIh6lrNxEOIuN4U1VhEQ9506vE5k+m Uvu73Di8MAzOcF+3YAh6Xl1vbwQhKhQrfW8uRKcVP2gyd1N6El+KcH62wNz5ZwN2vqfO uC3OdGwTrSk4lTYqq6S5Dr9SOjWrNLaEUKyheKi8xkfZ9tkBddCAbgDHOeWYm/ONHLml /wCWwe06T+1njV7Gh8TMTpH+loqkcBv+68rbF2UIby9Vzj3La4YT1pjwasJZrWAyDRoX iBEw== X-Gm-Message-State: AOJu0Ywa5ZXZaQlLxkg8joGPs5aLd4GZhX/qiKgtPj4IeT9s/u0Vkzs6 chE85/O8XGUBwW6W52WzDtdqfrhzT4xIOgAn5mJcq/aw6QDnJUdLxiQNvcWUUA6a7WeQanI29Hu 3 X-Received: by 2002:a5d:494f:0:b0:337:c267:7643 with SMTP id r15-20020a5d494f000000b00337c2677643mr1205123wrs.243.1705927513825; Mon, 22 Jan 2024 04:45:13 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id h2-20020a5d5042000000b00337d941604bsm9563286wrt.98.2024.01.22.04.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 04:45:13 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 22 Jan 2024 12:45:12 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I378081f391ad755d0a6fd5613de5c2a8bacc389a X-Gerrit-Change-Number: 503 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 841932620435b89f4cb8955264525dc467600e28 References: Message-ID: <7ff1e5f7717b7ef3102ae50d125f9728c1424ce0-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.44 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rRtfz-0001IX-Uo Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix ssl unit tests on OpenSSL 1.0.2 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1788794695241640528?= X-GMAIL-MSGID: =?utf-8?q?1788794695241640528?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/503?usp=email to review the following change. Change subject: Fix ssl unit tests on OpenSSL 1.0.2 ...................................................................... Fix ssl unit tests on OpenSSL 1.0.2 OpenSSL 1.1.1 will initialise itself using clever linker magic. For OpenSSL 1.0.2 we need to manually initialise the library. For other unit tests just doing the OpenSSL_add_all_algorithms is enough but this unit test needs a more complete initialisation. Change-Id: I378081f391ad755d0a6fd5613de5c2a8bacc389a --- M tests/unit_tests/openvpn/test_ssl.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/03/503/1 diff --git a/tests/unit_tests/openvpn/test_ssl.c b/tests/unit_tests/openvpn/test_ssl.c index fd2049f..d0c3df7 100644 --- a/tests/unit_tests/openvpn/test_ssl.c +++ b/tests/unit_tests/openvpn/test_ssl.c @@ -127,13 +127,13 @@ }; #if defined(ENABLE_CRYPTO_OPENSSL) - OpenSSL_add_all_algorithms(); + tls_init_lib(); #endif int ret = cmocka_run_group_tests_name("crypto tests", tests, NULL, NULL); #if defined(ENABLE_CRYPTO_OPENSSL) - EVP_cleanup(); + tls_free_lib(); #endif return ret;