From patchwork Fri Feb 16 10:09:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3620 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a042:b0:554:adf7:68e6 with SMTP id bi2csp937732mab; Fri, 16 Feb 2024 02:10:09 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUgfr1KdPRB9gKc69Sia7/GS8bH7ewoLmxTw+ygnskyX3gfqzLr1oObk6/AEiuDJTpn+Hvw8awd2MM0SEh5p1HfaiPgCSs= X-Google-Smtp-Source: AGHT+IHHiMvN31BXSuVPBnaEKqwhPsf33Fk+ntWZxWex+kjPPixroUXUQSEsCwmS9PLB3lKVxIh2 X-Received: by 2002:a05:6a00:9383:b0:6e0:e2f8:cf39 with SMTP id ka3-20020a056a00938300b006e0e2f8cf39mr5000545pfb.1.1708078209692; Fri, 16 Feb 2024 02:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708078209; cv=none; d=google.com; s=arc-20160816; b=vQ1ELqGJyZ5AnJHfqR2yns53CgVV0JveBUVF6r3mXtnheRnfp1wTkX3Cc94HPD2ujM /ATvHTjcdrW7QimewxAyMQRCmHVUMLmbY6yKRbhf4bdrQMw6FG7BOgJvQZnniLlI4BNN 6yhX3rl19FbAbVQnE7gdHOsrXx16cPykyEs8hBcoOylzVK+Jjj8GKcVvQMgpvXlKZ+Mw GcWSMaha/JXAbPSSUzjabQ+IyUX9bx0rgVfOwDtaegNhYYCRRkPA07gb+jkQ8XkDJrH0 74iXqwCGuYWzdsqIb2b2yUYCEhQkoF/tPnc2QfveNB+f5pkPrxhgaChECf5j/3/BRNlV DF7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=yU4psd2NwbHdHTlQhJvMsYBxF5e4GhJqXMtBojkSNJU=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=kw0A63D1jpm+/Hn1HulI27V2OLgB0NbTHY+ye3NbRTskffEQGMUN1cq4T1PEdUVBMi hAQJQ+VWqkKtZmHuqw8QKJ8/R+t38bTXI+aBNDKwKVNDtduzETpl+F012BLp3iE+CMnG kMrhokVmepdFMCeUk4+6JjyApnSDayfx0iAJAMdGFHQeS5TELp6XCBWUTpHSnlF3pQhh 9b9ZgvLNTviQ3rOoAS5RC3TA3VkyAXmSa643SSz2GRj6SayI90taV/d6DF5mnsO1UuPI zUwHSVPQEjmigw5BKywaptWF8wAfeSOiu/JF+m4jQa/+vhOUfIslmSv3Ds5Tcp4QX+JP tqHg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dGMtqw5K; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dAHxCi2O; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=cxnpiGJP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e22-20020a656796000000b005dc833ef4e6si2735660pgr.75.2024.02.16.02.10.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2024 02:10:09 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dGMtqw5K; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dAHxCi2O; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=cxnpiGJP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rav9t-0004AO-PZ; Fri, 16 Feb 2024 10:09:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rav9s-0004AI-O6 for openvpn-devel@lists.sourceforge.net; Fri, 16 Feb 2024 10:09:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mjqhz5iGKAfMdEqVojr1vln6+Jjs6eX1ysuoQu/6DIk=; b=dGMtqw5KCnDrsfvkyMKvHTu5/c wwozSlMZK0rRtrsbeNbWooee5UVMBC5qOuxcPHoSqnbGznuNokSSq6cHHpXSkhAUsr0SQ+8br4kWQ ns1eYtI99d4vCAE6ipz5eiqpqB7tM0KDaEhnNRL2hDASLwEbbbVH3tfWI77ohsUDOolY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Mjqhz5iGKAfMdEqVojr1vln6+Jjs6eX1ysuoQu/6DIk=; b=d AHxCi2OEmQG76NSlUw4a6dsKrdwco/EfJWZzFj3XL4VmviyQVktCW3ynjoaxT2FSxs3t/7PxKpIRT 6B/d7dqE0pnrxstV8wgO5opfsxFx31UCRLq6Qa70SC+l8xX0ag3V1qPTu2yHysbkwRxet+mUNklK2 3nacA/Jl93lQ1DIg=; Received: from mail-wm1-f44.google.com ([209.85.128.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rav9o-0001Nv-G0 for openvpn-devel@lists.sourceforge.net; Fri, 16 Feb 2024 10:09:29 +0000 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-411f165ef9bso15193655e9.0 for ; Fri, 16 Feb 2024 02:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1708078159; x=1708682959; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Mjqhz5iGKAfMdEqVojr1vln6+Jjs6eX1ysuoQu/6DIk=; b=cxnpiGJP3SVFWYi0i91JIUbFPihEtBLodcAUE1nC2zyhXhJyXM5KFcEJ2aX7zr/7i6 DbBDKESCW7vpjm1ln/HJjMuzbRz3DG3F6rekeUpDPBGV2WPVYGF74rMpyTCbiguoD0Ad 9Dj9ub3ZOIjVIPhiBLkNFddOTmS+iI2q5JUSnNTD8B7dNHEQMy1k6+tnmu9iugJ1B0B9 ZCHEKtwJdLGX6zxnjWCTnh7gFmpcI3cFYTFq2AbBXK7xL/qYXWE4H0JKZ54ugxoyypFg FIMf06lTGyiGbtRsrvdZ5EK7xcrQ7YkJZ//qE5wgCt+9noTHspq2GT2FXy2hWufJNjRn zG6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708078159; x=1708682959; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mjqhz5iGKAfMdEqVojr1vln6+Jjs6eX1ysuoQu/6DIk=; b=Mcv4C2XDd0eUumZnTQZTSnxjmemyUKtReRMmQhs5oGRwi9kqZ2rgoXU7IAwXLxxB10 60vJHHMB3jZAGqKum+pZdqRK0+OOH9hXLbEQ/dv5mMsDMQK+AYAT8uxpkRx8eh1GRbWU yHL6Xj/MlQIwX/U5trKCruIl46Q48ADwYCnSb7OvqmVTHblYHY1x6/dkefdY4ro3KGhb cfs4IIjBKItmjYO8Ctib3S8YgOhftpv2u4B0lRXQUHgQ5fH7nUdeFgLVkoBhlDV5CivR 1PC6rQknC4UgOfn0m21TaI6mJfTrWYhpkeVGIv2DQDoCVtKgxZ3dKhVtSKHW7QC5/+sZ /DYA== X-Gm-Message-State: AOJu0YybOdO0i2tVNOjuHmDDH16XKOWkxdwxkXtd93kFmHMLnlXPNRF0 ZHnfCU5Ef/1xQjl0Zl/pjdj6JSJErNeX+vdHDp8+lhgaV21L9NMQmcF1DwYsT77KBYD3EG6Pc6W w X-Received: by 2002:a05:600c:444c:b0:411:d6e3:79e8 with SMTP id v12-20020a05600c444c00b00411d6e379e8mr3226646wmn.30.1708078159374; Fri, 16 Feb 2024 02:09:19 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id o8-20020a05600c4fc800b00410e638357asm1875115wmq.10.2024.02.16.02.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 02:09:18 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 16 Feb 2024 10:09:18 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Id6b038c1c0095b2f22033e9dc7090e2507a373ab X-Gerrit-Change-Number: 526 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: c29b3fd4576df0e7af47122ecf1f2a64eebecabb References: Message-ID: <745034d45020b812fa63dcda984dd56b1e7a36c4-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rav9o-0001Nv-G0 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: check_compression_settings_valid: Do not test for LZ4 in LZO check X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1791049816679950787?= X-GMAIL-MSGID: =?utf-8?q?1791049816679950787?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/526?usp=email to review the following change. Change subject: check_compression_settings_valid: Do not test for LZ4 in LZO check ...................................................................... check_compression_settings_valid: Do not test for LZ4 in LZO check Probably introduced by copy & paste since there is no COMP_ALGV2_LZO. Github: #500 Change-Id: Id6b038c1c0095b2f22033e9dc7090e2507a373ab Signed-off-by: Frank Lichtenheld --- M src/openvpn/comp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/526/1 diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c index 6e30369..311f3e9 100644 --- a/src/openvpn/comp.c +++ b/src/openvpn/comp.c @@ -195,7 +195,7 @@ } #endif #ifndef ENABLE_LZO - if (info->alg == COMP_ALG_LZO || info->alg == COMP_ALG_LZ4) + if (info->alg == COMP_ALG_LZO) { msg(msglevel, "OpenVPN is compiled without LZO support. Requested " "compression cannot be enabled.");