From patchwork Fri Feb 16 12:30:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3622 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a042:b0:554:adf7:68e6 with SMTP id bi2csp999303mab; Fri, 16 Feb 2024 04:31:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWf7TOS8t6TvV+nnZ+TGBKQNqJjCs/mRxxS7yvHV6gSDiEs3F7np4K3xHN86upeFO1sDKlL60it30mBNnwVWjA40N82ROI= X-Google-Smtp-Source: AGHT+IHbLLmvYIb8xxgrZHV4hdDlR5QDwcR2ns5OPtuOqNKEp7M1kSxkcfgV7LWJsYyNuw93wK68 X-Received: by 2002:a92:cd87:0:b0:35f:bc09:c56b with SMTP id r7-20020a92cd87000000b0035fbc09c56bmr1938309ilb.2.1708086684619; Fri, 16 Feb 2024 04:31:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708086684; cv=none; d=google.com; s=arc-20160816; b=nvTfD3Vg77gEnwKkQ0EnDVLI7tGIhMtMxwkY70ZiUoT6THlFwzDwHKkYY1tp0RfUR/ ZGgopF2/+k5L4QMtp9OC4qkNex10US7FUG/Otgwtq02HDuLOGS+oQYWQB2UkvC8AQyv6 NmH4uo2ianFXEMBcbHHX+qAR8Sz9qhEkalryCtuo6VJcdm0t3Okv7o0/BSdwYk8w/ajz XN6P4TC1rJvKsZsrL1ABdbR+i71MlVqv9E5Y6RYyftG9nyP1HskTHHpJ6TWkDMARjZP0 6/qDciCa5jZqt5ytqRFsLD3YYSUdh/saVWTWKLJUdp63XKXHrMo5Z4TQVDD+p0/hyFkH uSWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=WS23JGyXai7+4jo74IIQqIAJVmWugFzYxxo3mmsgNyY=; fh=CfxSpwd5kfiMJoL3kcov7PTxVKT7pGe/79idnx9XlBs=; b=zc49+LZZvE0miaw2/vyPokJbyGu4Cmhavenf32fbu0qEU6Dc6/KLGCrs4mdOeqTqvR Z1Bgqv0JpI05OgQWwTVgwezCR2Q7M5kjRLdDr4QNZ2aXzX2mvZ5gRwoxtXHlw3OYjTus ccyyo6zuMn5uNvku3eQDMV1nuPPBPGHiGPurGu1Lm8rVi+vLkivSTv9aBlresmv+rnL2 UtCSt1EzUQXJBbXd+gaNh1SZfrZ8QVRKB9UQT9gRcFh0kl7VWVw7kDP8hix99QinIqLO ELG24uDzCU0G4bKW+q7YKs1XIo4qgtMLMaJbSOwRk2ZirDlc8mja4j5z2xkJvxPqBM2R WAPw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="KH/mShCI"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fO09qY3w; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=maAm4g3W; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e23-20020a637457000000b005dbec1a87b2si2917661pgn.247.2024.02.16.04.31.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2024 04:31:24 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="KH/mShCI"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fO09qY3w; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=maAm4g3W; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1raxMs-0002hI-6O; Fri, 16 Feb 2024 12:31:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1raxMp-0002h2-Nh for openvpn-devel@lists.sourceforge.net; Fri, 16 Feb 2024 12:30:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aALywJkRyrRVe1HS88q4zVdsx25sAoNPYB7BzfcLZik=; b=KH/mShCIxPgNQpQHsw1YQtaM8s VqSIsam87v2zNprOs3CQFvzkMn4j6+KRP82dGcV3vINlkwQb9/j850IjJPkICf0iEskch/KvwrH2z 1AHUN7Jv1bJliQDch2X4D1FNH83WEPUatTVG7YnsxfifNwnZlrezbn6ksKAfMKBnlDvQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aALywJkRyrRVe1HS88q4zVdsx25sAoNPYB7BzfcLZik=; b=fO09qY3wmOoT7GJ+8G3beXKOoN XnSj/oFG9M37HNjV/53SS5gIYMff+jWF/H9hyeLJ+oYvOaQOYRrpHDMpZa2HMLXHHqvhxueZMybF/ JmGP/DLDsCnDB/KbhQYuxnOcsgmoIhMJxrf4fJiS2b26DHjGfANrotwVR35aJDv4RTJ8=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1raxMj-0003gl-TU for openvpn-devel@lists.sourceforge.net; Fri, 16 Feb 2024 12:30:59 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Tbrr020cTz9skj; Fri, 16 Feb 2024 13:30:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1708086640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aALywJkRyrRVe1HS88q4zVdsx25sAoNPYB7BzfcLZik=; b=maAm4g3WDey3Wv9pKDYV9FV/qOcA5nlXirHjQYlO5IyvZxDOYnLTEuRFjg1oZmFOvdN6nh iTx3SnniXpuMnwVc/amZzf7PaeeCGL1eGSJ2W/ipW6RNM1Lt9+veJX/7PUg+3aA6lZjtBt siaW2RVLC2ypGveb5vBmJQKFfEEhbqr3m+IoU3c6hM2HrSi+9o2dhk9tc7BFE3+1jlYlde bJUFAgF6Uw9xoDaFuPOuAU2U4wWbGBQRK+9/vPjlJNZ1E2oVLvSfgDjFuxEY5AGIMjcTf/ uv71WYf5zVPtEhoAQw4RrRfhzwCmN+b9qylJ5sTv+1Nm3gdGYBp/SYVK+6pX2A== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 16 Feb 2024 13:30:37 +0100 Message-Id: <20240216123037.3670448-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Probably introduced by copy & paste since there is no COMP_ALGV2_LZO. Github: #500 Change-Id: Id6b038c1c0095b2f22033e9dc7090e2507a373ab Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1raxMj-0003gl-TU Subject: [Openvpn-devel] [PATCH v1] check_compression_settings_valid: Do not test for LZ4 in LZO check X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arne Schwabe Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1791058703345310703?= X-GMAIL-MSGID: =?utf-8?q?1791058703345310703?= Probably introduced by copy & paste since there is no COMP_ALGV2_LZO. Github: #500 Change-Id: Id6b038c1c0095b2f22033e9dc7090e2507a373ab Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master and release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/526 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c index 6e30369..311f3e9 100644 --- a/src/openvpn/comp.c +++ b/src/openvpn/comp.c @@ -195,7 +195,7 @@ } #endif #ifndef ENABLE_LZO - if (info->alg == COMP_ALG_LZO || info->alg == COMP_ALG_LZ4) + if (info->alg == COMP_ALG_LZO) { msg(msglevel, "OpenVPN is compiled without LZO support. Requested " "compression cannot be enabled.");