From patchwork Fri Mar 8 14:03:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3643 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5897:b0:559:d8ef:cc57 with SMTP id h23csp2196754max; Fri, 8 Mar 2024 06:05:05 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUel6VbDds5krxnLSA2xCSemEymHSxx23VQuR7Fb+ZzTjY3QUVPDaHvd3Gd8IUCmsRJu6GFM1rw6oeXhe1w6Tu8QqI43Nw= X-Google-Smtp-Source: AGHT+IH7ML0wTPgJ9Ndizt9L6hIIb9jg84CH9DquRa4xMCZiACGMdXB8lFuyoksyTakQ1HiA8ypx X-Received: by 2002:a17:90b:1893:b0:29b:bb08:6997 with SMTP id mn19-20020a17090b189300b0029bbb086997mr829536pjb.3.1709906705262; Fri, 08 Mar 2024 06:05:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709906705; cv=none; d=google.com; s=arc-20160816; b=AVLVXb60XFErgPSYom4FFneIRTx45FwZ3iSy9f7rOBm3qXPgI51EWsyuephE1wu3R4 81ms15Z5mAhZkA0pN5jRvllR5Sh2DvPL9lH/BnyM4fyveVAm/GoptXE9eZoEeXaZ13SQ tCT6dmjqHcoqhpQ6aeCeKnoLr/PcGCJn+gGMvZSjIKBbHPgpUwSRb1CRClfR5ZBU3nUV Wge0LnbU/2b4HlYSMu5diV2OUWzjVpVKMcQCObTVJCR9uZqlhhfzPkpQO9SjqDXeRXKv 1G1NJ2sRVKXc5fhBuuU4k/7HUzLx9IbtsTZDpd0ZN+Tg3KoaGCQJqSEyk/w/3yhWPrLX T80Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=FxHDyiyR7Xc9FGJ/hmKFSaxV64+3WYGQ9W5Xod6k11A=; fh=gLnzMrc/EVguQscKsJGyv5mVcpIe3IoHZOkzI4Uh69M=; b=ncmDZVEcE82FqJ/8y32BBMzX1rSdNukxepA4sKgr8COK0wcOaFHnXqUeZJpbvttxmf d24K5VfZO38CHIbAUbWDWFO2UWc34SqfXoo3UGSMVJ3nXOA+sFHcpajwX2aDABOB8MN5 5v0W8NMEo8Fo4jYWT5Aeky2avXHb8dOkuWQn5Ld13WL/25DjgqvNqyCXZ8LRmoNMqqSJ Ey6UTXS0dCmqq6dn9O6vCPxRyrxKAnsktucesVoGam9y45soI4xUxonIUbgflxjnC0Tv KyKEaz9DPD0C5LKFRP3cEiJNv96NyWpCTZXr8tQjESvuckgowiibQxMkWB5MSvxQBKgB Xxbw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Bb+BUK7l; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="Bsm/Sqix"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=lJ8+LQ93; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id gf7-20020a17090ac7c700b0029b5d3f3120si3762673pjb.161.2024.03.08.06.05.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2024 06:05:05 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Bb+BUK7l; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="Bsm/Sqix"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=lJ8+LQ93; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1riapT-0003EJ-Vc; Fri, 08 Mar 2024 14:04:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1riapT-0003EC-1O for openvpn-devel@lists.sourceforge.net; Fri, 08 Mar 2024 14:04:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ILqd7NNrUx3JvUFJVbMZxR4UlG8+HZhyfgNwLD1t1N0=; b=Bb+BUK7lLypOlT/xNuKobbho0r aNiD/15LSEiFMb1ex/7TEnpQchIoAbR3JFYTmdeA7CERT4+AYSxJG/bjzvctWrcH+AWg2nWFytsEd yGBYJtXAJrFLwzlbQ3cztaCaCbB8EPxkhOVMenn+DbgOMuPyLSL7tog27gKtUrMy6dfY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ILqd7NNrUx3JvUFJVbMZxR4UlG8+HZhyfgNwLD1t1N0=; b=B sm/SqixC/aFvVJED4sYaTCCikqWV6mN/TiJTHOgpSrcWQ3E0EI3X8ZqUjjwPA4T1gTfgroIrKfrF7 aaj8/hmk8h33DtNN+D5Lp8Qq4zhSLySKoEcPU4lrMMwo+C+NpB52+GErjsQtEwdX/ZJRDGQgwFYda w6BZxrRFN+RCrcZM=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1riapG-0003IH-UG for openvpn-devel@lists.sourceforge.net; Fri, 08 Mar 2024 14:04:07 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Trnvl4bG7z9sT3; Fri, 8 Mar 2024 15:03:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1709906627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ILqd7NNrUx3JvUFJVbMZxR4UlG8+HZhyfgNwLD1t1N0=; b=lJ8+LQ93cdY9v+4a431gchB4P3pjnuvrnBSTfgKFeu8VyLXB7jRB515rP8gvhnw7xZ9pfT 19l0ADAvcvHoWzkMqysBY+sJZf9qmG8OGEcwWvOp46ci2Ft46pX/3wYe7R/3nGYWdjfq2x hun132zqipGgEZdB00Q5nBnrQl1BhFqOeR4bPW5GcMbyo6oM8yOWrdXpPXUz83+7q4coL7 I9OMZJRHpIgPDdX0lyaaPlfNKCCLjTdLQQ/He7aPrIFEBpr3YYEK5Th/vDqEpQUluKMXKV jETR6FxBX5BUC+UzNpeTUu414iCZAXTEPp/Ia9YtQjs1y1dbxiKx4xaUnyxgug== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 8 Mar 2024 15:03:46 +0100 Message-Id: <20240308140346.4058419-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Christoph Schug The systemd unit files for both client and server were referencing outdated documentation as they were hard-coded to the OpenVPN 2.4.x release branch. Change-Id: Iee289aa5df9ee0e9a03c0dc562e45dd39836e794 Signed-off-by: Christoph Schug Acked-by: Frank Lichtenheld --- distro/systemd/Makefile.am | 5 ++++- [...] Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1riapG-0003IH-UG Subject: [Openvpn-devel] [PATCH] Update documentation references in systemd unit files X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Schug Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1792967133456728685?= X-GMAIL-MSGID: =?utf-8?q?1792967133456728685?= From: Christoph Schug The systemd unit files for both client and server were referencing outdated documentation as they were hard-coded to the OpenVPN 2.4.x release branch. Change-Id: Iee289aa5df9ee0e9a03c0dc562e45dd39836e794 Signed-off-by: Christoph Schug Acked-by: Frank Lichtenheld --- distro/systemd/Makefile.am | 5 ++++- distro/systemd/openvpn-client@.service.in | 2 +- distro/systemd/openvpn-server@.service.in | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/distro/systemd/Makefile.am b/distro/systemd/Makefile.am index 7e8f4753..d1c903f2 100644 --- a/distro/systemd/Makefile.am +++ b/distro/systemd/Makefile.am @@ -9,7 +9,10 @@ # %.service: %.service.in Makefile - $(AM_V_GEN)sed -e 's|\@sbindir\@|$(sbindir)|' \ + $(AM_V_GEN)sed \ + -e 's|\@OPENVPN_VERSION_MAJOR\@|$(OPENVPN_VERSION_MAJOR)|g' \ + -e 's|\@OPENVPN_VERSION_MINOR\@|$(OPENVPN_VERSION_MINOR)|g' \ + -e 's|\@sbindir\@|$(sbindir)|g' \ $< > $@.tmp && mv $@.tmp $@ EXTRA_DIST = \ diff --git a/distro/systemd/openvpn-client@.service.in b/distro/systemd/openvpn-client@.service.in index 159fb4dc..15c82fad 100644 --- a/distro/systemd/openvpn-client@.service.in +++ b/distro/systemd/openvpn-client@.service.in @@ -3,7 +3,7 @@ Description=OpenVPN tunnel for %I After=syslog.target network-online.target Wants=network-online.target Documentation=man:openvpn(8) -Documentation=https://community.openvpn.net/openvpn/wiki/Openvpn24ManPage +Documentation=https://openvpn.net/community-resources/reference-manual-for-openvpn-@OPENVPN_VERSION_MAJOR@-@OPENVPN_VERSION_MINOR@/ Documentation=https://community.openvpn.net/openvpn/wiki/HOWTO [Service] diff --git a/distro/systemd/openvpn-server@.service.in b/distro/systemd/openvpn-server@.service.in index 6e8e7d94..b26d976b 100644 --- a/distro/systemd/openvpn-server@.service.in +++ b/distro/systemd/openvpn-server@.service.in @@ -3,7 +3,7 @@ Description=OpenVPN service for %I After=syslog.target network-online.target Wants=network-online.target Documentation=man:openvpn(8) -Documentation=https://community.openvpn.net/openvpn/wiki/Openvpn24ManPage +Documentation=https://openvpn.net/community-resources/reference-manual-for-openvpn-@OPENVPN_VERSION_MAJOR@-@OPENVPN_VERSION_MINOR@/ Documentation=https://community.openvpn.net/openvpn/wiki/HOWTO [Service]