From patchwork Wed Mar 13 19:07:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3646 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5465:b0:55c:c090:46f0 with SMTP id d5csp2440373mas; Wed, 13 Mar 2024 12:09:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX8Qi3Ilkvd1q6Cj5DSqc1qMpNtJ/NyTONF368LNSm4iy01UrHnWSy6/dHyISm/DEer2IKRIwI+5PsaBNxP11a5UFDy7yM= X-Google-Smtp-Source: AGHT+IGbHICHln9Ww6Xh0WmR75cvx7cK6Yhtn4mvyUQFD/wHWbG8bsHXUgEcYX832MQIEmLeyrEt X-Received: by 2002:a05:6a20:d495:b0:1a1:1a07:b0b3 with SMTP id im21-20020a056a20d49500b001a11a07b0b3mr13821783pzb.5.1710356946498; Wed, 13 Mar 2024 12:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710356946; cv=none; d=google.com; s=arc-20160816; b=Eu+OFZuYqoTlDbjZK84XDu7lxeDPS9K9bGAibRHeDKQL7eV83etQeMH9Hib/cTDquE 29IExrq1wNho0wNU6oRcYh2PaNrXaCkDI1davvByTx8LYiDkJGdnUCo6SptagQa06aQB fQkOfn7FpTqg0FQ+zuTAOVVl0PSIHG/XDgko4rzOOO/zUABowgdTolPt7E+f3yC7b/CT om0EkLrQe+0X16zaPMJA0ak4uPFipedD6vyFxtGXdT++fShGlQWMt7o/QwoNVlckGMKg 6tZpxZPiBDTMxf2nlLW9ETL+aJCfau1ahgl0uG4GpwQ5sbC5caIU9/0pH2YnI94tHv/W ZHxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Ck7vfUqYu1FWONBq/oLr5loMPfpMLXHb42SNSJtRwDw=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=A6IJ6es9y1UvPeFfHDXHnrejUiTW6atXUFsdE6S0+fsx9NIKNNe8+mSOUy9jBgTUFJ 0pNINuazzWzbW2eM3uWWdPeKDiEr+a5z5SHJfqIFOOXkfDKOaLTYE/pFcq6H2mIbPIxU AEVMMtI5D+2rpOxiEDY7LKDGd5QUho2dO8GSdqKjP+YRfLaFEwslW4TDT0Ug99Xqrwzl Heb6zahAmfDO0nglVnRCKDwYQH4qdIJGWs3yC7h2SAk2U+EXq5442jBajilWM0barsXI 3YEzNV9xbM4NbVxTqwI33u+e0ZVrUUB0If1x4xG7Xy20rJB5XaoEE3jF2y5IOuTA+78J i0wA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Cf7KCL34; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=YyR2Uqcv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="NEm7bEZ/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id l8-20020a633e08000000b005dc427c3fc8si9725067pga.527.2024.03.13.12.09.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2024 12:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Cf7KCL34; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=YyR2Uqcv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="NEm7bEZ/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rkTxQ-0008QZ-An; Wed, 13 Mar 2024 19:08:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rkTxN-0008QT-Pe for openvpn-devel@lists.sourceforge.net; Wed, 13 Mar 2024 19:08:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=g5j70gfqB0q7559WluNqSO+iMopRGdIYwhrKYy4TROc=; b=Cf7KCL34mjfr62f9o62QKofOXE sQau7mHT99dqo9ACIEvWEJI3asPE1ae/pxouRemYOHFUtDeL2m6yAqjBImeFRB9V14fXn3gnIUGf9 wNTp7liggQQtb0dQvIYe3FcSwbw5i4WUs00Ge8dk1D8/Odvs9h3RNQQbllfAGeY/qJZM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=g5j70gfqB0q7559WluNqSO+iMopRGdIYwhrKYy4TROc=; b=Y yR2Uqcv7L6cO3etDzwuHbacLsjGromgV7xawb0tk9k/fF1ZgmSXdyFqLLtLsFRhwBmCPgU6dtFGfa R/M3hjkNZX+Y+9c0FiDk/5B4INHCBmvSfmnzmNn5WaMfyAxBgDsD5H3Zxi6qtE5rOSnZ8I+qP+z9X zTa7qv2qruzLRJ60=; Received: from mail-wm1-f46.google.com ([209.85.128.46]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rkTxD-0000uu-AA for openvpn-devel@lists.sourceforge.net; Wed, 13 Mar 2024 19:08:06 +0000 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-413f034d886so321715e9.1 for ; Wed, 13 Mar 2024 12:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1710356875; x=1710961675; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=g5j70gfqB0q7559WluNqSO+iMopRGdIYwhrKYy4TROc=; b=NEm7bEZ/C4c+6s9Rv/cuL4sqimigAfpd0BPRQSjaDuH/zTg+V5EhzV5VxbIaeahFE5 452Yhx2P5pbfe3uwK9zmyzwBsku/txAlWmd7XBhJtHYnruX+wYgxtOxeoBcNejYMLoyn R5yYRd+yB5hlGIMXck6tUw5/85LZwX/v5Bj2be0jT6YWCUf/voimKPWMgEEj6JQnZQS9 i4plJYw+a0qo6vux5Sxn6vvFsQdEIVxc/NebxlxWF7/ahZs79cs9+thBDYShP8chCfBD E+Wa2LsnHbbarabslWnAPDLDme6uZrRqJNssfhOfe6HWTQ2VeAs76SAEGfnVQgyHl7GF HQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710356875; x=1710961675; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g5j70gfqB0q7559WluNqSO+iMopRGdIYwhrKYy4TROc=; b=T56ZI5RSHmCF9KRLwz3AgcN+9F2ED6rSz+Llbq/+bz4FBJ+puuI3Z8XbqqTi7QRaTo +dfwRSSVYAKUBqpwLdLZRCuIjsklPc84w+lftTUCuyQas7AkcpdMj2E9f4eo0LwqUyLW nRWlgIszVwY47qW+m5kMW6GK6mGwaqmPyKdfDwsPkfGsadQO5w6p7sg09IlPnyAlK9Nm CKG0Gd5j5E5wtdC3B5jDQ54vpGzeeLsQ/GvRmnZJZBHLLqnDh5xJW9kKe5PgUTk4BG6G 1TqNRaH9+zdAABGnaMof3fAXVBloOE/j1NWt86BG7EbmVFv9wfLme0qSMNHlyEwnRLRE jRmQ== X-Gm-Message-State: AOJu0YwyJtD2J92rHm66TQxBrl9NBY092ZPCR1eqelLARzOrjOjkuK6N 42GecPCetbLsXhJMqMx0bKpJECjZGM4PYX0vFPLo7dNy37PrNrKsUf+A7x52UbP5pxKOExVZQ7R K X-Received: by 2002:a05:600c:198a:b0:413:2ea4:164b with SMTP id t10-20020a05600c198a00b004132ea4164bmr678902wmq.14.1710356874726; Wed, 13 Mar 2024 12:07:54 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id j15-20020a05600c190f00b0041312855081sm3137677wmq.5.2024.03.13.12.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 12:07:54 -0700 (PDT) From: "MaxF (Code Review)" X-Google-Original-From: "MaxF (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 13 Mar 2024 19:07:53 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1879c893ed19b165fd086728fb97951eac251681 X-Gerrit-Change-Number: 561 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 43c5abb0f7eccd8318e2d4a6cac3b8a7f2929196 References: Message-ID: <291a0d76c19c02e469d405b198c3b43ef2d6a873-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.46 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.46 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rkTxD-0000uu-AA Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove license warning from README.mbedtls X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: max@max-fillinger.net, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1793439245901835879?= X-GMAIL-MSGID: =?utf-8?q?1793439245901835879?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/561?usp=email to review the following change. Change subject: Remove license warning from README.mbedtls ...................................................................... Remove license warning from README.mbedtls The licenses are compatible now, so we can remove the warning. Change-Id: I1879c893ed19b165fd086728fb97951eac251681 Signed-off-by: Max Fillinger --- M README.mbedtls 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/561/1 diff --git a/README.mbedtls b/README.mbedtls index 124eaa2..c4f3924 100644 --- a/README.mbedtls +++ b/README.mbedtls @@ -11,22 +11,6 @@ ************************************************************************* -Warning: - -As of mbed TLS 2.17, it can be licensed *only* under the Apache v2.0 license. -That license is incompatible with OpenVPN's GPLv2. - -We are currently in the process of resolving this problem, but for now, if you -wish to distribute OpenVPN linked with mbed TLS, there are two options: - - * Ensure that your case falls under the system library exception in GPLv2, or - - * Use an earlier version of mbed TLS. Version 2.16.12 is the last release - that may be licensed under GPLv2. Unfortunately, this version is - unsupported and won't receive any more updates. - -************************************************************************* - Due to limitations in the mbed TLS library, the following features are missing in the mbed TLS version of OpenVPN: