From patchwork Wed Mar 13 19:10:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3647 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5465:b0:55c:c090:46f0 with SMTP id d5csp2441919mas; Wed, 13 Mar 2024 12:11:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVUk6P+4xnqGOfArMDekS9P05JlhL53G2j1hwG/TJYjQE2pQT7Jt7pB0Ep+eoDuwl0re1IWi4qUdheoUZ+meWCQPgM8Mdk= X-Google-Smtp-Source: AGHT+IFbhVtT8YgaBJ7ELdFSV4UZ5DCQlrqGv5ofaotppkSPVveiJMnU+sm+s4XyQGb8SM0LTFtR X-Received: by 2002:a05:6e02:218f:b0:366:3766:6c48 with SMTP id j15-20020a056e02218f00b0036637666c48mr2809942ila.1.1710357091607; Wed, 13 Mar 2024 12:11:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710357091; cv=none; d=google.com; s=arc-20160816; b=ZL/5MlbgGhd/qtDgJB5OJUjvy5emweNmwPgnVEQB4cKcaJMUFC/83vzfOU61cvrciT paiWMveprHrViIfR/uoIods39i0K72EYGmgRYl06qslWAhTVTE+3LbAkhcShFR1oHMPc CWb8FpJ9vlYZoRdn7BLRsgFCK5Lu2zOrRqndNOmp96miP9I6eEh4O2aSbEZO6z4NA3EN lH491eAX79dTXD7CRdQxfXbV/mM8Z8JrvfP0WNA5uZfDdZWgVqoG0H1UfXTwBQsSMY6p Pp5hIXDaCD8mE4BIbK/yG02LDyRvoKB5IcAD9ApRkQtXvnpKitr/VA/flgNu+L8AAkDN Rpiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=R60ukp+ZO5Qh3Ur/Dq3TbstPZNpDllEaK0oUGJWjcGA=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=sS5gsxrvYhKWxyk2yBLPR3QqjXHrbc/xijDCcGe8PIcoHZqQFLgG/772KdwsZcOUBz 7RXCHG9hzYkbzSqK9EOKaoAAYB6D/3u10fptzmfC9IyfPaCSgh3mkQXr4LM0Y6QH+GZF ekX7CDEsT6ohL1eSPVL9o5f8Gw6TiyGYU5SZlW74Zww9qQVDiIuU0LeSZvPo000xc8HU BRtR/U/uhh4B5sB9LMlpqMqDsLsWrG79Xm5nFz/XD7v2zryf6bwhI/TdR0LhlULdnsr4 f7HFfaZs6KV2MvbkOjLG1nqKTXq3UVlpQWM5kYhH7aSwNZljVFigDdhM+kPvr08RjW1r hPuA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c6bZL9D3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=YGkzNS0X; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="a3wI/e/P"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id u1-20020a63f641000000b005dc9617013bsi9312881pgj.33.2024.03.13.12.11.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2024 12:11:31 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c6bZL9D3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=YGkzNS0X; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="a3wI/e/P"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rkU07-0000ir-Kf; Wed, 13 Mar 2024 19:10:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rkU06-0000il-BO for openvpn-devel@lists.sourceforge.net; Wed, 13 Mar 2024 19:10:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1g5dc2MlolOcQXDYF9PI3ktNf0fFhY8PRZS4CbLnwJc=; b=c6bZL9D3Df8s0Ytd+B2QBo8sMz B/CpZPzxm/vd2p2O4VgqrqptlHYO70MzTQ+u5iBxlNlFM6SsCBO0y4JAegisl6DUgBjOtZ+A/HOf8 oW+gRvGDYnV+gf65I65IWTwfdLmO8+c5et8qhe9NVlsL0EqCwvV4ZPFPfxm+BJTTajMc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=1g5dc2MlolOcQXDYF9PI3ktNf0fFhY8PRZS4CbLnwJc=; b=Y GkzNS0Xag+2Gm7REG+Lt3CNquJ+8C0vhdSZL+3AZfA4l3HR/1O8PSfvU9Spg2swbN7VbFDamu78zo tx4iirAqgVDgfxefSzC2WUU/IwdjcaLQ/ak4CuSz1KAhMYX1jnsqu6mmsaW93tMxUabBWo88lFKbO dAWa3zQrjvJ1yur8=; Received: from mail-wr1-f53.google.com ([209.85.221.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rkTzv-00013d-PT for openvpn-devel@lists.sourceforge.net; Wed, 13 Mar 2024 19:10:54 +0000 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-33e899ce9e3so100191f8f.1 for ; Wed, 13 Mar 2024 12:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1710357043; x=1710961843; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=1g5dc2MlolOcQXDYF9PI3ktNf0fFhY8PRZS4CbLnwJc=; b=a3wI/e/P3bmmaq1KIBj0JCsv8nciP0KTEdiwOqPOZ0NR5r/v8HY2Qtw86+XOBlLA8E btu5b85WocsefYBtDe/dpCQfk7AITnP8LJ7jXa4BiMM20ewZQ+NBIe5WxQRCJy+bU4Eo UYqvQt0OiEHS7agQhP1CmtfAGj/npzQnMS2cmRbcs9xW9vwPr7a4ia7np1mWVWLDW9iF 5PCP7H7lvp7k1Hoq8p544mm1h/ctt6xVRwz5FwuJO1M2hKE2Ym03Ncg1YUOCKTgfMKl6 AdlyGIsLW1b0D3Bg5cECksWDhu1th5Zmvt7k3AJTU+83/HGYEWgMgsns51RNwCUn+U75 s9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710357043; x=1710961843; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1g5dc2MlolOcQXDYF9PI3ktNf0fFhY8PRZS4CbLnwJc=; b=MuXQduDB5or+x7kVsAam3nsvjuiHs2KcLptCx20Ev5QqipDaw5Gl+ovvF3T2bHexhg mN02ZH20X8pUA/r1wLIB0KEpsZMkcB90vE/0vCCNw26sPWTHcLA9e66t1zmaJuBJqxab bBZ7tGZ7iUNpjqJkYSepZxdhXjmUhtUYWI5/3+nkj9jGdaVV9yBMhKL6I9+nEIkrDLzv S7lyt4WrzUbG8bduquYaiUqrFXSD6CcOBo7DKA56ayC+st83yuamlHo7litRQjMuN4xa 3YIZ/SKpCnWCeOyyPjoftfRbHgFUAZozPI3lp7gwIO8B7rtKl6Gq4q33JsKJv0z6C7ts wTzw== X-Gm-Message-State: AOJu0Yy2CgSS5Mam73PngHvjtYOae6/dMGf+DNVcBc4dbylQMYJDh1i6 LG15Bd0vv/aE9yVPwie4lZQh1P924wnOWYBQ9bSViQG51q4sMT9n29s0w9NibgcxoQCw1TcbJ9C p X-Received: by 2002:a5d:574d:0:b0:33d:fe8f:8c44 with SMTP id q13-20020a5d574d000000b0033dfe8f8c44mr2580851wrw.46.1710357043192; Wed, 13 Mar 2024 12:10:43 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id bs9-20020a056000070900b0033e9fca1e49sm6076412wrb.60.2024.03.13.12.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 12:10:42 -0700 (PDT) From: "MaxF (Code Review)" X-Google-Original-From: "MaxF (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 13 Mar 2024 19:10:42 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1879c893ed19b165fd086728fb97951eac251681 X-Gerrit-Change-Number: 562 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: db50cf997bc990b948f878139d2ef7e9c006c9a8 References: Message-ID: <754e5379eca734c410c95a6cefb4acc2496e0eec-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rkTzv-00013d-PT Subject: [Openvpn-devel] [S] Change in openvpn[release/2.6]: Remove license warning from README.mbedtls X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: max@max-fillinger.net, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1793439397726549588?= X-GMAIL-MSGID: =?utf-8?q?1793439397726549588?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/562?usp=email to review the following change. Change subject: Remove license warning from README.mbedtls ...................................................................... Remove license warning from README.mbedtls The licenses are compatible now, so we can remove the warning. Change-Id: I1879c893ed19b165fd086728fb97951eac251681 Signed-off-by: Max Fillinger --- M README.mbedtls 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/62/562/1 diff --git a/README.mbedtls b/README.mbedtls index 124eaa2..c4f3924 100644 --- a/README.mbedtls +++ b/README.mbedtls @@ -11,22 +11,6 @@ ************************************************************************* -Warning: - -As of mbed TLS 2.17, it can be licensed *only* under the Apache v2.0 license. -That license is incompatible with OpenVPN's GPLv2. - -We are currently in the process of resolving this problem, but for now, if you -wish to distribute OpenVPN linked with mbed TLS, there are two options: - - * Ensure that your case falls under the system library exception in GPLv2, or - - * Use an earlier version of mbed TLS. Version 2.16.12 is the last release - that may be licensed under GPLv2. Unfortunately, this version is - unsupported and won't receive any more updates. - -************************************************************************* - Due to limitations in the mbed TLS library, the following features are missing in the mbed TLS version of OpenVPN: