From patchwork Fri Mar 15 17:05:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3652 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:8444:b0:55c:c090:46f0 with SMTP id m4csp1206240mat; Fri, 15 Mar 2024 10:07:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXKt5U/KZR3OkFb8B9VCetWkmWh7gz2jG3PGazKOXpVHFLS+kUScCogkMt8A11L/h2IIwss2k1pV4wQ8tX7ltlJPOEQuZI= X-Google-Smtp-Source: AGHT+IEH/+eXvzTpYDZhQnctxz/tBywitgP0tvuTcuYqCcr65sr59BnKPycYpCFoIlmOrijr55HX X-Received: by 2002:a17:90b:3751:b0:29e:b16:dc77 with SMTP id ne17-20020a17090b375100b0029e0b16dc77mr686190pjb.0.1710522455679; Fri, 15 Mar 2024 10:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710522455; cv=none; d=google.com; s=arc-20160816; b=LVfiehYNZdBJXwUWBVd9ig2hjwsgREmHEKQktQOp0Uv8YRtC2KmIT6LP7Bv/QYwVZk 1nh7lXyU5xSr+1c6aC0bhr11Sn0F+mqpikt9TgFrh8j6Af9DzPaHydrfSpD94rViegRP 5mHvqDrPzZFwlFqbfheb+jE+jkKlAltBGYKnvAPDDo9DGx7rjzsJpKIoxZli5Khb2Z+R lnuHtKC2psZsEbeTJ2SAdJBZ/l2VZx6wn9215GvsVxB9h9jh0dWPNp9VrOURzfMWpWo6 DsZLly/SRg28AICodfbcGcljkTN8LXclJF9osE89/Oqtuy9Oxucrl+xStS2y6e/siftH 5puw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=47eZuGzjEf2P2nk+cGjNGm2fBR8E5edGtADsYSlmd+8=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=S6sp8bKDVKqP6QyN9wbd0fR9XWzFaaHA0sfkoeVikZS3MQ5Ihml1OfRzCTOR6FlZML C1AsV24g0pdC2LA1X5X8GdfvBQW9YL8/Mf5BqCHD7FwAy5fRyT4oQmrINad9c4J9bkC/ d2qynl2XoA0Eyilp74EvVdLPqgQy5jb2WcV7nr/S0+bb+kBUrPhNEUlWoG6bjDB2Syjt I5OW7s1PlwZY+Ihcyj4jHMAAxLPhLn4NDEV2EGSyvwvnmdX4nJm4OW0uYmKn3yDH2e62 Gtz1oiSX5mYyRTmREI+OMi7reswe8v8DWhd0ouuaqgcT1cXRmnmt7cnW7Lzw065F8QkE JmJg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZNYaglFg; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jORDd1mV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="NHRygq/E"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id t2-20020a17090abc4200b00296416a8f10si3063383pjv.112.2024.03.15.10.07.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2024 10:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZNYaglFg; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jORDd1mV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="NHRygq/E"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rlB0I-0004O7-QT; Fri, 15 Mar 2024 17:05:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rlB0H-0004Nw-ED for openvpn-devel@lists.sourceforge.net; Fri, 15 Mar 2024 17:05:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z+mA4OsLVDSQEyYcPbQqDtv/ZBcg6TMw/dOc1p8U9c0=; b=ZNYaglFgS951cMgk7jFrpP/oIi zPeymmvEAqlvsbUEGUJw7KmwSlnjVgAATb7jwHOWV3ZLFWvODHJbwIf8jUuLKoptTCh3nVU34V76A V+lH1rxzj8CZBb75ULmX1oNWucUV/KsBZcT45BP/mU876uzxvMltzUFHi+srNvLxcGEs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=z+mA4OsLVDSQEyYcPbQqDtv/ZBcg6TMw/dOc1p8U9c0=; b=j ORDd1mVvBclf6+W+ILnkRC1anwgR4mw7GMI2v8zmEpBA3mPxDHZRZoGdKjmuvMYwZbA3wJE4KIteX luEM/JRJpW2zBloUYqaq48lMGaZHkjOhj7wDbvkcoTn3TD3XZZUnUlShLLahbuCRz9235wzMlFxhU GvFP420InB07Bies=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rlB01-0006bh-GZ for openvpn-devel@lists.sourceforge.net; Fri, 15 Mar 2024 17:05:57 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-414037f37cfso4747345e9.0 for ; Fri, 15 Mar 2024 10:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1710522337; x=1711127137; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=z+mA4OsLVDSQEyYcPbQqDtv/ZBcg6TMw/dOc1p8U9c0=; b=NHRygq/ElmHVnJvRXXzO6ZLsh27WKB6ED7u1eSmhoERUm7Bv9k6QrBLIjigpVzrmJG fu85t5b/Wj19pnv74vW2Pn9HyUGHuEpE1jWscjm6wfy11o+cfoO6AHrc7ecZkR1g+cMW 49zppU9bQP86WDmDUJq/1DoP3ArA2d8/F0AYTcCm0BGqvCjFeNokE4+7RhsacX5oElCA XY1vsL4cCnI8DuWoQWVfci7VPHw/cnUsczvGumNhVRAI4ITst6cOWIjGHvsEf3TfRf5C R3FK4voBS57jLPqzv5MoaR2XHHl70W9luqNad8WtobqgaqORULAzZZcVPBZix3Qtcbee 3FlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710522337; x=1711127137; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z+mA4OsLVDSQEyYcPbQqDtv/ZBcg6TMw/dOc1p8U9c0=; b=WkL6SdoFf2YeZJSyBN6Ds1DkvNxaBiZc6VL08CfjBzHx5IMYk+jGLGVV/EPwa9gOO9 D0xg0JspkhRd8H6pd35zTDdfXez8CK48S8NcMtadROE6EIZunnibp2Z+v1Kq//QSe4Bv LzX1dr/78acOpMJbbLhNo0cBZMFCZlK3eJGx1WZhD0V+FFjaRmtcZdKwRDqBmucGC2F8 d5fMAKiGvFtYMHJa6/TJwKFhIn9wQCPH/7mQURRKB7Uw8bZ84gyIIDphr+JRzevazNx/ oA87vxDO6cI4kwZK9Bmp2HTxD4dIC5zYywTamS9avlpU7HUHKxiBIuQyt+2ltqAWeKRM wpbg== X-Gm-Message-State: AOJu0YydfRGs12ZAOQVPROmcrA9rFmBZt7AId4WukE6nZ2IwAPiSVaBd xwSloClTbaXAX+qiv6cSWhijIRCOF/sAOf78VxpKK3kiWcYgJjjE6DARbaJjZBqnNDHbAv9pbL3 Y X-Received: by 2002:a05:600c:3d14:b0:413:2f70:10d with SMTP id bh20-20020a05600c3d1400b004132f70010dmr4160698wmb.6.1710522337082; Fri, 15 Mar 2024 10:05:37 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b00412f016a151sm6372255wmq.9.2024.03.15.10.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 10:05:36 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 15 Mar 2024 17:05:35 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1ad6a0b1323ce0872f4a3299c5a9f18a982e0126 X-Gerrit-Change-Number: 544 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 06e0c5eb6962ef2eacf51a232f5020e4c2e6da28 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rlB01-0006bh-GZ Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: general update March 2024 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1793612794552937970?= X-GMAIL-MSGID: =?utf-8?q?1793612794552937970?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/544?usp=email to review the following change. Change subject: GHA: general update March 2024 ...................................................................... GHA: general update March 2024 - Update to Node 20 versions of actions to avoid warnings - Update to current vcpkg - Update mbedTLS and LibreSSL to latest releases Change-Id: I1ad6a0b1323ce0872f4a3299c5a9f18a982e0126 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml M .github/workflows/coverity-scan.yml 2 files changed, 23 insertions(+), 23 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/544/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index bc937e5..f771f5a 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -13,7 +13,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y uncrustify - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: openvpn - name: Show uncrustify version @@ -27,7 +27,7 @@ - name: Show changes on standard output run: git diff working-directory: openvpn - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: uncrustify-changes.patch path: 'openvpn/uncrustify-changes.patch' @@ -49,12 +49,12 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y mingw-w64 unzip cmake ninja-build build-essential wget python3-docutils man2html-base - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Restore from cache and install vcpkg uses: lukka/run-vcpkg@v11 with: - vcpkgGitCommitId: '1ba9a2591f15af5900f2ce2b3e2bf31771e3ac48' + vcpkgGitCommitId: 8d3649ba34aab36914ddd897958599aa0a91b08e vcpkgJsonGlob: '**/mingw/vcpkg.json' - name: Run CMake with vcpkg.json manifest @@ -64,7 +64,7 @@ buildPreset: mingw-${{ matrix.arch }} buildPresetAdditionalArgs: "['--config Debug']" - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: openvpn-mingw-${{ matrix.arch }} path: | @@ -72,7 +72,7 @@ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/Debug/*.dll !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/Debug/test_*.exe - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: openvpn-mingw-${{ matrix.arch }}-tests path: | @@ -91,9 +91,9 @@ name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL" steps: - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Retrieve mingw unittest - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: openvpn-mingw-${{ matrix.arch }}-tests path: unittests @@ -159,7 +159,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev libnl-genl-3-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${PKCS11PKG} - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: autoconf run: autoreconf -fvi - name: configure @@ -186,7 +186,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev libnl-genl-3-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: autoconf run: autoreconf -fvi - name: configure @@ -235,7 +235,7 @@ - name: Install dependencies run: brew install openssl@1.1 openssl@3 lzo lz4 man2html cmocka libtool automake autoconf libressl - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: autoconf run: autoreconf -fvi - name: configure @@ -257,7 +257,7 @@ runs-on: windows-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: lukka/get-cmake@latest - name: Install rst2html @@ -266,7 +266,7 @@ - name: Restore artifacts, or setup vcpkg (do not install any package) uses: lukka/run-vcpkg@v11 with: - vcpkgGitCommitId: '1ba9a2591f15af5900f2ce2b3e2bf31771e3ac48' + vcpkgGitCommitId: 8d3649ba34aab36914ddd897958599aa0a91b08e vcpkgJsonGlob: '**/windows/vcpkg.json' - name: Run CMake with vcpkg.json manifest (NO TESTS) @@ -285,7 +285,7 @@ testPreset: win-${{ matrix.arch }}-release testPresetAdditionalArgs: "['--output-on-failure']" - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: openvpn-msvc-${{ matrix.arch }} path: | @@ -325,11 +325,11 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - name: "libressl: checkout" - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: libressl repository: libressl/portable - ref: v3.8.2 + ref: v3.8.3 - name: "libressl: autogen.sh" run: ./autogen.sh working-directory: libressl @@ -345,7 +345,7 @@ - name: "ldconfig" run: sudo ldconfig - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: autoconf run: autoreconf -fvi - name: configure @@ -384,11 +384,11 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - name: "mbedtls: checkout" - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: mbedtls repository: Mbed-TLS/mbedtls - ref: v3.5.0 + ref: v3.5.2 - name: "mbedtls: make no_test" run: make -j3 no_test SHARED=1 working-directory: mbedtls @@ -396,7 +396,7 @@ run: sudo make install DESTDIR=/usr working-directory: mbedtls - name: Checkout OpenVPN - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: autoconf run: autoreconf -fvi - name: configure diff --git a/.github/workflows/coverity-scan.yml b/.github/workflows/coverity-scan.yml index c107933..e289746 100644 --- a/.github/workflows/coverity-scan.yml +++ b/.github/workflows/coverity-scan.yml @@ -10,7 +10,7 @@ steps: - name: Check submission cache id: check_submit - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | cov-int @@ -22,7 +22,7 @@ - name: Checkout OpenVPN if: steps.check_submit.outputs.cache-hit != 'true' - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Download Coverity Build Tool if: steps.check_submit.outputs.cache-hit != 'true' @@ -62,7 +62,7 @@ - name: Cache submission if: steps.check_submit.outputs.cache-hit != 'true' - uses: actions/cache/save@v3 + uses: actions/cache/save@v4 with: path: | cov-int