From patchwork Tue Apr 30 14:11:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ralf_lici (Code Review)" X-Patchwork-Id: 3693 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a58b:b0:577:9287:30c5 with SMTP id hj11csp822494mab; Tue, 30 Apr 2024 07:12:02 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXAmZyFqMMEW820FepQD3zvoFzJKmMBrryE0jiFfZfJXVSjxheaOqympKwXdp0L9YNy6cF5X6qoRI9QJ4f5JuTc1u3U0SQ= X-Google-Smtp-Source: AGHT+IHvtrVDknv7ZektTBbEUvuO2nWQ8aHyl9tl9NQbVmIuUmYEHw8EJ3pIQi+c+OVYMFg7sd6H X-Received: by 2002:a05:6a00:8e07:b0:6ed:6944:b170 with SMTP id io7-20020a056a008e0700b006ed6944b170mr14794917pfb.1.1714486321834; Tue, 30 Apr 2024 07:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714486321; cv=none; d=google.com; s=arc-20160816; b=lCnPse1JA9AZNsN5VBAvUupG+Yt0dB9l947np9i4ibtBQBGGmYhnhETkp9p7K2HA1p FKOse4ag+uQjTtXhrKEluXkyekTb+iMXA69y7DqQSUXTDk/0aN8sUXwzS/HnTzsLiR8z 48DEoM3v0ruJThb0FelZbONp+ilcPsQxD/COGVv22DAIXNgpUtC3pAGl6/VaHy5Jdbx7 jHrUjC8Wq9UbhtJ8qJCArT21k1wulLotZ+HnAYFNgzY+aGprCIjfnU57ueRtkqvLU21i 4vL49V7Rl7uVDl+TPkhJEOojtcI9iJ2HLLvqrogo9Nu69p7bASjEY8X4x8sBGb7QRSwY CqSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=YkY4HzTx1fwEPARlOT7XXtjKNXm3lA7u1KqSDVYqO0A=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=Mgt8bt29Beqe5e85DQW7PjsVkQ9TJOxe6D7lyucnDqFtOhhXIILoWZ1RRIiHR1El7F U+cxJixOmTOaWLNWIVOWDaMMGNb2BWKNglQjDo9P8eJV4x6grimXNaVtnR0P2u80l+/2 NRpR50zKCVQxtdCIaB+w8RYGBx75NWrlPwcr7cL11rECYQA/HC2EiSLGwdUiAHenTWEk nghI8pgwlHu3kONnmSwyjTOBVsGRhzUwX658HkPfkt6XqGPRYE3kt6+NiYp+bTEFjS7Q XEGKvffjbwp5CtZ9RKQ8Q/SRbDulFybxb6W4dO9rGazcPtE3qbmnVUo035boAbqAm1Hj YiqA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c67ZxTNk; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y7sgLtCi; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=UTikeyEM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id c6-20020aa78e06000000b006ecf8c67605si21328090pfr.72.2024.04.30.07.12.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2024 07:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c67ZxTNk; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y7sgLtCi; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=UTikeyEM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s1oCd-0005aO-C2; Tue, 30 Apr 2024 14:11:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s1oCc-0005aG-Po for openvpn-devel@lists.sourceforge.net; Tue, 30 Apr 2024 14:11:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t5oyO5WVXwxM3CjXqV2cyUlZd0aginxQWFWADhge8M4=; b=c67ZxTNk00rhs7zjCl/xat9MnL QPL6cHuWzyh896VGBcQvfVv+TSdVFKnswqcin38tnrfpu1gMhuYzRFXMvHJKges9qMFZQjVi+K/9Y 1UyfsX6ALeSvZQpzdum9tlSMGh5FtM2EcYFqmIkgLeXW+Y3/w1IJ2cKU12/7W+eeNT4I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=t5oyO5WVXwxM3CjXqV2cyUlZd0aginxQWFWADhge8M4=; b=Y 7sgLtCi7S1zVasOyMVGSYiur+l49GVxXAF9Z5LFihHufHeKfW+WDTARRFD0Q5gshpY7i9DND+MMU+ W3QcLX+8sxS2MRJc1vWGKrvuJadoxz1qj4q+tk9JwPLAGCARahWFgt1SXutn/rJt9cHNqZ1RfJ+iD YgCwHRR0GtQaTf9o=; Received: from mail-wr1-f54.google.com ([209.85.221.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1s1oCc-0000OH-7r for openvpn-devel@lists.sourceforge.net; Tue, 30 Apr 2024 14:11:27 +0000 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-34c0f5f5cd0so4540077f8f.2 for ; Tue, 30 Apr 2024 07:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1714486275; x=1715091075; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=t5oyO5WVXwxM3CjXqV2cyUlZd0aginxQWFWADhge8M4=; b=UTikeyEMckG+lrGaN27Jhtf4gC1SVTm/um6TP8SkaRe/I1FZG4bj4/+AoiZ9bnBju2 UbOI27XAxd4MUi9RK9PUO/EJqz6NPUiHx9UGFwP0Adt8cR6ar3XN4HQESBrHoUUEdTYv IP7fPU4fi5eRBPUKPldadJlfJIXcNO7LR8fkd7jKwomnE5q57cJJAeFrCn8qf+RgeExD 8Vh9v8trkHoQMWfCbiCw9gZ2grFmfrjyZYCOC6W6mogWt1Cx2X9puXMMf3+afS2fPTiS BttQ7HYKavt3oo0d9fPhFZFtqjhivw6rDQK8sfoa953th2q4ZMnzaM0Jr/8w9Ell+O88 Pa2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714486275; x=1715091075; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t5oyO5WVXwxM3CjXqV2cyUlZd0aginxQWFWADhge8M4=; b=SwSZg1Sv+pPvzOM/RS3+spsVLyJQDtP+W8UxkTsg3hkAa9jL7sQ9G89mMB2TdnAU21 q4kGF2YDF89aSixB4jFOTJaeEB1g8+/roAmpdKz5sxztWI1LvPFT9HSO59Zp3KHPx1Fr JsiDm0q8saeVogzxYCPZe37qfSgD0qlzpK5UVXI2RBASuh5lDjrNg0p30c7q5Zke+er+ JwtNV347PB9tSvaY7xyxLT/Cg8FnEtokV6gGTgW7fQqAY+29BZFGiPIsDmLGYwkr+u/Z jK1ECcwO8zCfVp2F2mou41XZ9xNq0cJmqALZ3AAEwOuBzPrJHGM+ZaICV8XHzvlUXVqr sOKA== X-Gm-Message-State: AOJu0YzNGt3TVW1XIGfnh901bG6xPphuWk8MaRhOmpy5IxP0uSkQsPUG nJqMmpc64xrjizyzRhUuYXNgelwHx/Qz2dCByC0+qyf9aJjPAlrnj8Af80bg+L2lQXMJw8K0rVQ A X-Received: by 2002:a05:6000:b82:b0:34a:4d1:b914 with SMTP id dl2-20020a0560000b8200b0034a04d1b914mr9451296wrb.48.1714486274493; Tue, 30 Apr 2024 07:11:14 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id p3-20020a5d6383000000b00341b451a31asm32066125wru.36.2024.04.30.07.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 07:11:14 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 30 Apr 2024 14:11:13 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I5d70198f6adbee8add619ee8a0bd6b5b1f61e506 X-Gerrit-Change-Number: 581 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: f14c902959010588e6c6e074232861ef75ae24a2 References: Message-ID: <5fd5f770af789f38b9b4a47a8b762789d0fa30fe-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.54 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.54 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1s1oCc-0000OH-7r Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1797769209749164941?= X-GMAIL-MSGID: =?utf-8?q?1797769209749164941?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/581?usp=email to review the following change. Change subject: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF ...................................................................... Add missing EVP_KDF_CTX_free in ssl_tls1_PRF This is just missing in the function. Found by clang+ASAN. Change-Id: I5d70198f6adbee8add619ee8a0bd6b5b1f61e506 Signed-off-by: Arne Schwabe --- M src/openvpn/crypto_openssl.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/81/581/1 diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index b2c4eb6..61c6518 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -1372,6 +1372,7 @@ err: ret = false; out: + EVP_KDF_CTX_free(kctx); EVP_KDF_free(kdf); return ret;