From patchwork Wed May 1 08:30:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d12fk (Code Review)" X-Patchwork-Id: 3694 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:f212:b0:577:9287:30c5 with SMTP id sk18csp278603mab; Wed, 1 May 2024 01:30:43 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXl/poSSworvBDwPCBW+/If7RHS/97West7XLiOnduyCHF/acFjPSvCVMaBW4spU9J2XnzFkZESH4LhsZuMxTWzuZaP88k= X-Google-Smtp-Source: AGHT+IHfwAtbAr2bX6z1SMCG8jwpdCGil1q2tA5qwdS47tV/4EQO5imV8DCiYdBNptuo0nFGtub0 X-Received: by 2002:a05:6602:168f:b0:7de:dc52:18b6 with SMTP id s15-20020a056602168f00b007dedc5218b6mr2671054iow.2.1714552243184; Wed, 01 May 2024 01:30:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714552243; cv=none; d=google.com; s=arc-20160816; b=f/UaGArWfpMwMpFGnGhL5CRHOwtiWKmk1mmRwYcpq/313biheLCB7EojIF4LuvPV9i VdR9fbFS1m2WnrD3cLyxUPxRPcZuE73qYqydee89p0xwDmZcVkwq+48osa6xsRhrMk1C JsLyWytooqg96pCWmsjdtWl5zMfan82eH1ikjASDb3hDmdGkcQZZOhIXbWMpBto6d+Xe asX1/NxhmE1wsNNeVbHEGcqYfRSbOAOR/RoEWvcWxtwJKhB5597CRzNue1RvS+WADblI U4ZKtHWqP522TDE5vYNxZpa1ZhgBGDqkO3lWSNTR6ihYXW1Kn87z+XSfah7eiGqfn+rS Pm1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=EeHeuWy8T19YjV7zlnwkTOPE1RsYRDB3CwKzavjXwBE=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=fh/Nc8ejnK8zAeywkaaeuWDHwy1ED1a6FH7UUqwLiwaqgpzXKPxgEUOpkg3K1Bx8Fl lp0yHhFE33TTdmDTS5Op0oDnUMFxoKReeX439dPRPzJQxfHGytXhEpV+bwc1pWHeenbA EE7REtqbI1oyQrxs1amjwEhaWV3rcN5z9bhjdHN/YgfWsIm0frqC3sLOfKbjHKNEpLIv AL3QD6f4kaiOMNThznNS0uUcmy57wfPLeWAF3etb5QKIM7sQHrovFYXPuYRbrYZ1EbTj v8ActsWU/qla+C5SptTBvPPp5KX+KGEcRrMUXWbGHvhe9hlKLkFy14yA9stF9Ct9TawC tM0A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ke1rIIrR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ficPhsJG; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AVbHQea9; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id h62-20020a625341000000b006f3ee233975si7885897pfb.219.2024.05.01.01.30.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2024 01:30:43 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ke1rIIrR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ficPhsJG; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=AVbHQea9; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s25M3-0004j8-EB; Wed, 01 May 2024 08:30:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s25M1-0004ix-DU for openvpn-devel@lists.sourceforge.net; Wed, 01 May 2024 08:30:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uvtsafMW8L1iNls21CZP/JOx0NoMkrjbFcIULJJ3ed0=; b=ke1rIIrR8KwcSPbYeHvlRjVSh8 akHJE+dPSxgZ3UiAh01LNFY+I0AGUo3ay8tbSTIeWjCECw/8Ma6Y3Zdc55H7C8DZ4P8KVd9VvMiRG cM/nuHYz/lhxCGoTRAoCN/T4kZnq+Ye7Yf0wlf5rup75LcdfFx0d0svHiBERzo2t2K4M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=uvtsafMW8L1iNls21CZP/JOx0NoMkrjbFcIULJJ3ed0=; b=f icPhsJGCi/w+UOwPogEpYr26xKiKqwrYrLgvDYw8pCtZx4aKgeiOxuO0XYDgJh57CrFV36RwbmhEB rnZWCRiJviLMhoAsIXBpOYBMmciTCt0PXpiOWLOpS+h73W6HDoazJwHeJCnv6brUu+Eyv1lQ+h+7A 4aRi6jc5bx03JZY0=; Received: from mail-wr1-f48.google.com ([209.85.221.48]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1s25M0-0007Bu-AN for openvpn-devel@lists.sourceforge.net; Wed, 01 May 2024 08:30:17 +0000 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-34d99ec52e1so859946f8f.3 for ; Wed, 01 May 2024 01:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1714552210; x=1715157010; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=uvtsafMW8L1iNls21CZP/JOx0NoMkrjbFcIULJJ3ed0=; b=AVbHQea98oOrARwX+THjMPRhTCaHZIw9u5cQ85zs00GlRytlnbTWc2dDynDUW4/zfu VoDmTYAqKLUpNQep4/tnCpZunrcnUU3Wd7fLomniJ9VsWOzeoy6urIvZzCfMOFCpOIPK OibHBj0ech/dWaIuLQvVuwZpKFVKCFy9BtudZIXSyS14qjzGPcuowiDYsAGSZukZgRmZ /u+2v2r9Twkykc7dA6Ga09OOhLytqLVJyqXcuJbuWoobGQCNx1HRKfSf4kOlyrurMgLc 7Yvu+1IMwhCbhfIdNzHni3iuNwB1ZmHIlc8V+xwT/b7K/jG1Sygp5LGMcBfe7WDdbvlH jQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714552210; x=1715157010; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uvtsafMW8L1iNls21CZP/JOx0NoMkrjbFcIULJJ3ed0=; b=OtY+Ob2og4/A2az+aFG4QHC9E/RJRGZf8efjzxBxLzLCKU6L7cP//z4j1ZOAOqZv60 sswfPzISYylcM0prF03LGjwoF3SUsu622v0mrZC5XmWGQQbDQ69Cnm+ODmkpcJ3Uqdij r+5Gk31Y7ppGvs8AVodJuGD+K0/Cd4UmpQ7pPunupZ6XFW/8FsxoiV8P87X2bsV4U3Pv Ingv6vty/41yDF/BrHMyDMPqgVmaW5YBdRkKycsF5WaFIObgKTaxgkxV8CF9UFQoHxwH f62vtBRtzQA2owlVMU8BAHfd0+ciY5VT4hDywwg9ygAXFwDH47h93DaipOvGDiFUe9sg RLaQ== X-Gm-Message-State: AOJu0YxhiEJlrDDIUaMzy0Q8xyu5fPlDdts5BTujkMVviBHEVGSRcPP3 SvBSOn4ddPs9JScn+SGzENIpXRc4neUVvVVkEKKEL2d7iIqZSRJuPEgpbFmoUq477eS/+cDVLKc y X-Received: by 2002:a05:6000:1283:b0:34d:ae55:8fb9 with SMTP id f3-20020a056000128300b0034dae558fb9mr1143687wrx.66.1714552209538; Wed, 01 May 2024 01:30:09 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id df15-20020a5d5b8f000000b0034cee43238fsm7957633wrb.27.2024.05.01.01.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 01:30:09 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 1 May 2024 08:30:08 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ia70f230b2e9a78939d1875395205c8f48c4944b7 X-Gerrit-Change-Number: 582 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: aca8c09ce479f03eeed9120dd5e92f9f54744d63 References: Message-ID: <8d04702e1c8c0cbf6bfd880ae38373b692a72915-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.48 listed in wl.mailspike.net] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.48 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1s25M0-0007Bu-AN Subject: [Openvpn-devel] [S] Change in openvpn[master]: Replace macos11 with macos14 in github runners X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1797838332543597971?= X-GMAIL-MSGID: =?utf-8?q?1797838332543597971?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/582?usp=email to review the following change. Change subject: Replace macos11 with macos14 in github runners ...................................................................... Replace macos11 with macos14 in github runners Github's documentation states: macos-11 label has been deprecated and will no longer be available after 6/28/2024. Add macos14 which is nowadays supported instead. The github macos-14 runner is using the M1 platform with ARM, so this requires a bit more adjustment of paths. Change-Id: Ia70f230b2e9a78939d1875395205c8f48c4944b7 Signed-off-by: Arne Schwabe --- M .github/workflows/build.yaml 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/82/582/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index f771f5a..d7c3ecd 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -202,8 +202,16 @@ matrix: ssllib: [ openssl11, openssl3, libressl] build: [ normal, asan ] - os: [macos-11, macos-12, macos-13] + os: [macos-12, macos-13, macos-14] include: + # macos14 and newer runners use ARM CPUs and homebrew uses /opt/homebrew/ + # on ARM instead of /usr/local/ + - os: macos-12 + homebrew: /usr/local/opt + - os: macos-13 + homebrew: /usr/local/opt + - os: macos-14 + homebrew: /opt/homebrew/opt - build: asan cflags: "-fsanitize=address,undefined -fno-sanitize-recover=all -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" ldflags: -fsanitize=address,undefined -fno-sanitize-recover=all @@ -228,8 +236,10 @@ env: CFLAGS: ${{ matrix.cflags }} LDFLAGS: ${{ matrix.ldflags }} - OPENSSL_CFLAGS: "-I/usr/local/opt/${{matrix.libdir}}/include" - OPENSSL_LIBS: "-L/usr/local/opt/${{matrix.libdir}}/lib -lcrypto -lssl" + OPENSSL_CFLAGS: "-I${{matrix.homebrew}}/${{matrix.libdir}}/include" + OPENSSL_LIBS: "-L${{matrix.homebrew}}/${{matrix.libdir}}/lib -lcrypto -lssl" + LZO_CFLAGS: "-I${{matrix.homebrew}}/lzo/include" + LZO_LIBS: "-L${{matrix.homebrew}}/lzo/lib -llzo2" UBSAN_OPTIONS: print_stacktrace=1 steps: - name: Install dependencies