From patchwork Wed May 1 12:18:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 3695 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:f212:b0:577:9287:30c5 with SMTP id sk18csp372545mab; Wed, 1 May 2024 05:18:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXK/8JG+wWHH1v95seWHQiQgI5uKcqd64dg0srUYkMS9P48Gq7F+tYtOJowovSLoycJx+3yoov/G1kh3Pv1P9owgqt8wJg= X-Google-Smtp-Source: AGHT+IGx2TD53Is809Kvw+bQ6hDNijDRombGP0RP7pG8B2W5wkfmCJNgGLmaSOqKKT6S6JgypUIM X-Received: by 2002:a05:6a20:dd9f:b0:1ad:8a2b:8744 with SMTP id kw31-20020a056a20dd9f00b001ad8a2b8744mr2712067pzb.4.1714565935136; Wed, 01 May 2024 05:18:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714565935; cv=none; d=google.com; s=arc-20160816; b=ifKQS4peMdntvUJFWFBns9/KmFjeBXFMujht5k/JYyvEbZAkR/DlqEkvD6YTpDgYc5 Tz5V9GYAvC7O+GaQzgNmp9dnGT9UDc5SBDiuOBCNTRPmBGG7jPhfmWJT+0bxYFmHCXJn 2+YXk7ls5lGcIfrzcS92rPrAmIz0qVMp9xuhchQAHywSS4q1EY5DRSMlyo2QyMiJf3Sh Rt+58Azjcn6o70Yj3/q6X+zHvvwhvKAK8v56bHmdD+l3ZHgALwgh/6P/lELPOojLfjfR hLklfCPKKbo9xEtjyIpLWTN2J20RYicsv0N0sErZ6U3D0hpgWxSJKMhG9dcjKRch+j8O dEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=52F3+WRJXUFewEuPOZwqTrFLXP8thaa8T1noQz89jgg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=hnHfQXojbt+DgBBqREkzDtTKca1r/9elnGQkQfduSa3vi0oLgcyg8HAF4x0fzFXD5r Mg6/xTX1JgSRNKm/7en2AYRr8HrW/diPEA9ApYt/MICUqB8bN6IlN33kKosiBUN1YHJl 29k8+2Yy4wrbRx+z+JHyUMoQqoQSxFzcGulKev9J/5zIfKxaO33C12BRxlunBidy1j6o EGv0o7KtKIMUWA2/ADwG1AckKabyjZiJsTrooaFZdBF7R1FBmKypBVhum5CNsEaHNBzB W4tWsAtJ4volmZQF57uXBODbDwNdpwG3EasnE1B6xy6lKkmsUU3c/8eBc+Ri0hpd9rcd egZg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BFowVE4V; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TqcD9JNh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id w13-20020a63b74d000000b005dc5070656csi24319267pgt.785.2024.05.01.05.18.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2024 05:18:55 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BFowVE4V; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TqcD9JNh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s28us-0003d6-Fo; Wed, 01 May 2024 12:18:31 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s28uq-0003cn-CQ for openvpn-devel@lists.sourceforge.net; Wed, 01 May 2024 12:18:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rfxcF/P64gYxAMIkSspiSFP/RzP8QOco4+DNg6kuvNs=; b=BFowVE4VRpsJXZK5gwiN3uDTXI zWN7R8MhIJ6K836zHWGJGU6RtactLOTZ8pDcuSkQpCzeAXuAWH/WTD8SJ+XPEseFkwtEfl8cyYFFK YG2CBDPT4bOw1MNxfdu8W2lJYJFc2djOL/61LG6xI1K1gZon7RCvdXE+O6hZOS4Jijz0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rfxcF/P64gYxAMIkSspiSFP/RzP8QOco4+DNg6kuvNs=; b=TqcD9JNhEHMn5bbG4bAU2ia3aJ riNfTQYCIL7Ssd8tkNaPBqzPiXL9YqSUvJVV98mdQEF8T/yS9ye8IxaAH083plZep4wl5EE2XNrFt HvhJ5VihygzxJYe9II8EUNsNmN5V5/F+ZJuB78DKz8TXzaRf4i2oAhDXAwlIh7KZhx4A=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1s28uo-0006MU-Oz for openvpn-devel@lists.sourceforge.net; Wed, 01 May 2024 12:18:29 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 441CIKn1012815 for ; Wed, 1 May 2024 14:18:20 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 441CIK82012814 for openvpn-devel@lists.sourceforge.net; Wed, 1 May 2024 14:18:20 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 1 May 2024 14:18:19 +0200 Message-ID: <20240501121819.12805-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This is just missing in the function. Found by clang+ASAN. Change-Id: I5d70198f6adbee8add619ee8a0bd6b5b1f61e506 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Headers-End: 1s28uo-0006MU-Oz Subject: [Openvpn-devel] [PATCH v1] Add missing EVP_KDF_CTX_free in ssl_tls1_PRF X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1797852690029441889?= X-GMAIL-MSGID: =?utf-8?q?1797852690029441889?= From: Arne Schwabe This is just missing in the function. Found by clang+ASAN. Change-Id: I5d70198f6adbee8add619ee8a0bd6b5b1f61e506 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/581 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index b2c4eb6..61c6518 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -1372,6 +1372,7 @@ err: ret = false; out: + EVP_KDF_CTX_free(kctx); EVP_KDF_free(kdf); return ret;