From patchwork Mon May 6 13:50:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ralf_lici (Code Review)" X-Patchwork-Id: 3701 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:83a3:b0:577:9287:30c5 with SMTP id e3csp1324675mat; Mon, 6 May 2024 06:51:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV7NFmcdbC3lv9pD6FLNiDyf9sBLUAu7JZTEcZYzF7oqrAc51bEPaQaJEMy0tfuSQvEsAO7mjO5jdxSyZZLlgsLsXBhJi0= X-Google-Smtp-Source: AGHT+IF35bcy7tKf/g0SapFGXixxYmGw7QLngi2ZGKVFv2VIMtLEzgSR7k3gbaTqpGPNYC479Voi X-Received: by 2002:a05:6a21:3382:b0:1af:93b0:efff with SMTP id yy2-20020a056a21338200b001af93b0efffmr8052134pzb.2.1715003469748; Mon, 06 May 2024 06:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1715003469; cv=none; d=google.com; s=arc-20160816; b=m6SLqMR3AYNZ/qkjhnrqj1MZXdWLFc1oc9Gcyks1bCbX7xVitSTj+XL9tN9UosCaXe Rdn/xkzAPGkfySuY9vA5gTzve7bBkGaaGmMcDrJso5tJHJiWMuwUNMXutqBYUUTURkh9 d+GyOrlolxmBUFPz0sYM4L8K8g4H+uVUgnloA5Me+S41adgTSsLlmnNhDuNytzHQTCMG OdRULRP6fGCl3tm5rlkdcDR5B6vzqYapPnxntoeKjy4HJvBB9Zy8xXYAbEJo73xkCW1U pV02j0pPYlRGx7sppMgOhpRVvlOehIhOqunaDDm/+oCj/E/sHoSEEoc5NBkT0OjOkPye Ny1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=AhirKjx5p047UPdhLgbsPF12au+lYAIULlG59asFTDo=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=esyccsZwv7zDIvDXWzeqkObtj7kDAujOzZczUCwdfggMMwLF3cfYKnFAXKVraC2/pA N6A2yUaCrP1kSXgKPT7etR6WyXmzXSVvhDSWzFmzF+fSFQLR1un2M4cMFlzM3pR/rTgv iDq9ExkIZHcFu5sKgrJkA2tg867e1yZM/0dMxRDX2ZKKfW301Uf1q37M1rLQF8tznet3 m6DVJDlZVjTfc9UPpd+HQJB8lLBj5HuN0RwPpdG9AeF+RLoQq8Me6v0N4p9lupuPSZcs f1H9dPOmYaXjeukpB18wqW7P2dGn9n0kQmxmYwechdufKEEpnDYNPS6jOfpZxS0dULJn kPmw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=lU1pyxWV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="ca/jgDf0"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IMpOY5R0; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id v2-20020a63b642000000b006229867b8bfsi3823974pgt.509.2024.05.06.06.51.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2024 06:51:09 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=lU1pyxWV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="ca/jgDf0"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IMpOY5R0; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s3yjx-0007Mb-SN; Mon, 06 May 2024 13:50:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s3yjw-0007MQ-4q for openvpn-devel@lists.sourceforge.net; Mon, 06 May 2024 13:50:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sfR5PLynnFlzyRwWVy+ryNgmgpCpiDyvMphj4HP6cbY=; b=lU1pyxWVMQM43L79VF1EDByNqq 3VgCnqy+KVO+PPoVwZ/fOn5lpmqvr4gE1KEHa1HR0kTEK1OeY49uSC2FuktoWK5X2Q3kV69rKxDDm 2QH+6YCugRq6pfoml0uFSmt6y+x7y5Gb1TOargCVRGG7eVu0ugZD4JLxtUsLnN7zmYZ8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=sfR5PLynnFlzyRwWVy+ryNgmgpCpiDyvMphj4HP6cbY=; b=c a/jgDf0fWdN/MfOrIvY9KmtDtVJ2v6d9WaKIVV/guC7lQocLYg6VlJQQMb7VUwVtujxgZdk6OWvRG fTmezk7FwZ48EFYReJ6RJLVjyPyqgo/1n8sp0NjMftiVOZA38VbtFBkV0zR2gIk6n9d6/cyqLFNER OhNwTrqeyyPVskcU=; Received: from mail-wr1-f45.google.com ([209.85.221.45]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1s3yjs-0002dU-6a for openvpn-devel@lists.sourceforge.net; Mon, 06 May 2024 13:50:44 +0000 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-34dc9065606so1061992f8f.1 for ; Mon, 06 May 2024 06:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1715003432; x=1715608232; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=sfR5PLynnFlzyRwWVy+ryNgmgpCpiDyvMphj4HP6cbY=; b=IMpOY5R0wu22D9M3sCrRAfE/HWiGSCfhNsVEYv/ABoyiYi7oUxFTx9SAqSRiaOoVz5 HyO30rJC6BBSMbYk+moV/Ip/9uuXSX4TrDrfR1wVIG9yT2F9BzjWgpReQS6SsFU2Vqwn Y5sUO37HqqOwGRF7//eivKXlr0gEEGnzkHGqgEqO5ibDCgRCbV5sAQ8H3eaHDZpFTaUw GDdtYy1KAeZa1VtmnNmBbAJiQuZ1RfG8WTWdvcljQ14cZfK/loOD2Dn3FMRUbMIUzQlD Ci3PS0uHWLCGdZy2sPHOYsiJLSE7b9QS8AaRUeDk/8gW+XKHdjLe87QjEvzuOqlMypz9 fFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715003432; x=1715608232; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sfR5PLynnFlzyRwWVy+ryNgmgpCpiDyvMphj4HP6cbY=; b=MY3O+lzhBboWfeS1JM4MMzpIYG8HumnWO+dh/KYDlt3aIonwBF147uGkTsGWeU29Td aD2K7h8M5He+SLuNWLWtjAocw4fj1pxnhHBjSi+/mCVonoi2MF3bQAONXxMZBXWD1RO0 NJ19JJOTB+b5bwMr+sQiKYxIsIfvH6/ImlF33LDlNWvQvcZd8lYQj7KmS8ouV63Jsk5I QMHCg08JSQSe73LER5b3c28jjFmlZL31XHDAdg2pVeCyXiqERvwXjGTWCao09LXaMgwj Nouqak6kcFzto6Q/Bjzj59z+HUYgN5KCkp+VYqWs7PkFkN0qJvNCDpVVNh35JXapoSzc IgQw== X-Gm-Message-State: AOJu0Yy0ZiIfzpDHWjZJvCeIcUjD7qWuhBIqZIoBcLoDtenp9nLkZdr2 yuPASQ/AtspYx1kFYg9jt5a34wwNCOPl1URi6ksjZAjbdyMAm9PqqWiE46l/qlT3aHs5ndeMDrW 7 X-Received: by 2002:a5d:64c5:0:b0:34e:81ab:463f with SMTP id f5-20020a5d64c5000000b0034e81ab463fmr9942902wri.20.1715003432319; Mon, 06 May 2024 06:50:32 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id c10-20020adfef4a000000b0034a3a0a753asm10686040wrp.100.2024.05.06.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 06:50:32 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 6 May 2024 13:50:31 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ie2b62bc95371daf7e1eb58e0323835f169399910 X-Gerrit-Change-Number: 584 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 23aee59d07db7011f032e69bfb379b0f074f8a00 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.45 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1s3yjs-0002dU-6a Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Repeat the unknown command in errors from management interface X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1798311478162093324?= X-GMAIL-MSGID: =?utf-8?q?1798311478162093324?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/584?usp=email to review the following change. Change subject: Repeat the unknown command in errors from management interface ...................................................................... Repeat the unknown command in errors from management interface This help pinpointing errors in logs from my app Change-Id: Ie2b62bc95371daf7e1eb58e0323835f169399910 Signed-off-by: Arne Schwabe --- M src/openvpn/manage.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/584/1 diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 43c5507..415ee7a 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -1663,7 +1663,7 @@ #endif else { - msg(M_CLIENT, "ERROR: unknown command, enter 'help' for more options"); + msg(M_CLIENT, "ERROR: unknown command [%s], enter 'help' for more options", p[0]); } done: