From patchwork Wed May 8 18:09:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ssbssa (Code Review)" X-Patchwork-Id: 3705 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a40b:b0:577:9287:30c5 with SMTP id vo11csp646399mab; Wed, 8 May 2024 11:10:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUO3uTRxNowN8KGacRYEhz23uKmkmCP9IZrCotssdyoiXjULINz5bdPH1v6ApRL9p5wST240RNT9CDw3Rk5SaRfRFcTyzk= X-Google-Smtp-Source: AGHT+IF/20nNtAwFssItPnulzPbWlWF2/oIydJKrG3L1hn4qHdaLAhM5ezXddws6dUcdcD6O32wg X-Received: by 2002:a05:6a21:6d86:b0:1af:cefe:dba3 with SMTP id adf61e73a8af0-1afcefedc4amr1851620637.0.1715191821690; Wed, 08 May 2024 11:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1715191821; cv=none; d=google.com; s=arc-20160816; b=sVq4e6q2G1WumI5CnjRb18ueyyQdQNx3p9zWojH2u/lDjErR79mZ8/9QUoxfRsbSbE TT8xaTADX4gU9jC9gPfp2WsE5phmdGNCBRowKNSm+QpycCCk3f79wEUO2cAnU7w5s86R 8/7qPiPqp2hcGDwfJ5kJiQoiErrjswDx4x1xecGTa9nlgioHHlvd9pp96tayerJ5JEdG g0NAobAArOzIRLUYPTfGouUbTdJCgD5GDmAD0vtGC8etaYVhmDmw6IZmDqmooVE2OyJg DsQhblHP6B7SKyhY9zdfltyNmcF1N/UDc0XFNnvCTi8e7K1RL1X8R5sCFfEGqJa0jJy9 ELNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=lN0+68rcJQCkyVWEsvuiLuQ1f0ww73SOR6N55+VscsU=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=wHa8lZgP1C5hRXX0dqXkMZ/A+oyRhQWeApb2B4j2lcCVbn05LsJ2+Nws0MoBkHZVqt oi2sL5tR3xgfMaA/2cps4301lfNGBqenV6l7kCFq3afRmETr8cWiLBi5Z0ZfhcGnP+II xgMYaCRVIahg5nyaNeCKCXZKSnkc/KIJUYbEXF4WuFaU8T8fnZw/VAbvFJcpYc0Ot3J6 vLr33gq1n9L/t3nld+7jyMjPlwdH+X4RzK52E2WyNnCUjOkEGbBbLYYV2zhi0dReq2LS Cv6Zu7e3syFobtFqMWPw+PiqqrxBfyCJIP9+iSirMx36xxTxe4fiY0h9DKJ0xFycjtMg 8sJA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Nje50OoD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Qa4WbMKd; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=RkTlWuSu; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id l24-20020a635b58000000b005d29ed61d61si12077273pgm.78.2024.05.08.11.10.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2024 11:10:21 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Nje50OoD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Qa4WbMKd; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=RkTlWuSu; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s4ljq-0007vz-4z; Wed, 08 May 2024 18:09:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s4ljo-0007vq-Ss for openvpn-devel@lists.sourceforge.net; Wed, 08 May 2024 18:09:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hTyzS/H+k8Q3dsvVi7Bu9ev7GW7Wr1LGkA41u/V+7m8=; b=Nje50OoDBi3VSDOIjjzGLM44f4 S3oB2bpil4c521lO+9C79eFmAPO3FlTbnXYViQeW7hwDv7gf/oq6vR0altF7C9dxSoYHil6bZCdSn Y3rFOA6Or6vpvR6ojJMVybKGj24FhHN7G0voAOPf3thWxHRfXHZk9JZ2Pm6qHJSieLr0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=hTyzS/H+k8Q3dsvVi7Bu9ev7GW7Wr1LGkA41u/V+7m8=; b=Q a4WbMKdj+YzURd3n6eJJWg3iSjGc2M+YjTWQylm1w4zxnf4lTsuMZeRbydSJ8i7k7AO9149fl7nis n9RwfMG2/ZpLvd1xDRYpe3CEIbus7iAGjzZMpDSdGKumjKQtspdASykxxmPA0mrVe0hy2gyStlkN1 Zgx1FLWay6ayb+/g=; Received: from mail-wr1-f51.google.com ([209.85.221.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1s4ljo-00036H-Rl for openvpn-devel@lists.sourceforge.net; Wed, 08 May 2024 18:09:57 +0000 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-34db6a299b2so4078234f8f.3 for ; Wed, 08 May 2024 11:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1715191789; x=1715796589; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=hTyzS/H+k8Q3dsvVi7Bu9ev7GW7Wr1LGkA41u/V+7m8=; b=RkTlWuSuy/jea+RYSTCVeKiz+iXqkOOgPmAT2m1Hc1VY0iq1zdLFcl627qgJlH7fnr dSImieeWh5pWw6z0DqZ6xH1QKcD9c28nK+4S3KUpuhBW58IUTAwasGCkFTCHDQZTCdY1 Q2xctsCb8qDJxbdhE5E9x8Wu5LUpduxrYEjfSakQ/X/Y8Y21XqQfPo55DTCN7gvYXq8m KyCzuORFJiJQ9SHSnFGlJYFuLdkbIvYrQ6c02NSe3azkwL4uu2SgpBNa30sndTapT1O8 7BahiNkrixnhqSncbvCn0MKAPO50rtJtJt6dzdWX2g0lTIUN+dNZcmq0MaNkmPi8PAOX ldAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715191789; x=1715796589; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hTyzS/H+k8Q3dsvVi7Bu9ev7GW7Wr1LGkA41u/V+7m8=; b=glugDC+uJqtZodhyvKMaY4x9NgphL3k6xwSDyk3y4U44fDwzS5bgratDlI+Gp5uOFq 2FNwkQKdHLyJMjMwaajVqZ58DSR3phTaevnGkyOmitnPlkYRhbR2fdp5PcADGitJ+IoZ 1KQCXrC/5muRPgSbV6+F8YnMtJfXbY6xkV8I8Y4GqZtXRa6S8nsIIB1ycYGbqyXyqfQ6 U7I+owtKPSNYAzzdQFgIUbfV3LNEDgEQp0itZVaufhgIUf3YB8HpL86tztIPOQBdhUkP mIDxrUlWH1294b6DLyGi0p65PRWaArodoBhr5Tvi6cXY6msc7hN4ZTfQlbv+rAOpPAgr cFRg== X-Gm-Message-State: AOJu0Yxii7V3TBt9AXa/mTp/fH7Bibw4HjFeS8LDNBzHhmDkEVfVtlID ObAyshagryWRy8/gsvorAmvPqCjhESP4V88qoyTEc74vbNO1kyGdNWw+zxAPUAy9nUKMiyWr2oN 5 X-Received: by 2002:a5d:6086:0:b0:34d:12c3:ffb0 with SMTP id ffacd0b85a97d-34fcaddf8b6mr2425841f8f.9.1715191789065; Wed, 08 May 2024 11:09:49 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id da11-20020a056000196b00b00349ff2e0345sm16068006wrb.70.2024.05.08.11.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 11:09:48 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 8 May 2024 18:09:48 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I85d4d27333773e8df109e42b1fa56ccf57994e57 X-Gerrit-Change-Number: 585 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: badedc780925f8337a9589f9f23194b37a2ff73d References: Message-ID: <71594b6f52f7888e7e421e020cf43d8c714ea13b-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.51 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.221.51 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1s4ljo-00036H-Rl Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Support OpenBSD with cmake X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1798508979653361336?= X-GMAIL-MSGID: =?utf-8?q?1798508979653361336?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/585?usp=email to review the following change. Change subject: Support OpenBSD with cmake ...................................................................... Support OpenBSD with cmake Change-Id: I85d4d27333773e8df109e42b1fa56ccf57994e57 Signed-off-by: Arne Schwabe --- M CMakeLists.txt 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/585/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index 3127611..f8b37a9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -136,6 +136,8 @@ set(TARGET_FREEBSD YES) set(ENABLE_DCO YES) link_libraries(-lnv) +elseif (${CMAKE_SYSTEM_NAME} STREQUAL "OpenBSD") + set(TARGET_OPENBSD YES) elseif (${CMAKE_SYSTEM_NAME} STREQUAL "SunOS") set(TARGET_SOLARIS YES) set(HAVE_SYS_SOCKIO_H 1) @@ -169,7 +171,7 @@ check_symbol_exists(setgid unistd.h HAVE_SETGID) check_symbol_exists(setuid unistd.h HAVE_SETUID) check_symbol_exists(setsid unistd.h HAVE_SETSID) -check_symbol_exists(getpeereid unistd.h HAVE_GETPEEREID) +check_symbol_exists(getpeereid "unistd.h;sys/socket.h" HAVE_GETPEEREID) check_symbol_exists(epoll_create sys/epoll.h HAVE_EPOLL_CREATE)