From patchwork Thu Jun 6 10:51:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3724 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4507:b0:57d:b2cb:6cf with SMTP id d7csp260020mae; Thu, 6 Jun 2024 03:52:02 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXd5WKHcoWhy1Uz4z6PGxSSZT4Gt+RWPVq4ZV0Ltk2rqVW6n6Y+eTMbT3SZzxdhqYsEItrAzV3BbTg01PyzhE1SROHE0gU= X-Google-Smtp-Source: AGHT+IE1CZEfvv53YHcN0Jf+LQWGaCCvFZKE1wJTTHWQNgVvNWzt5a8S7ZisicUGflITeCgxErq1 X-Received: by 2002:a17:90a:a501:b0:2bf:bcde:d2b0 with SMTP id 98e67ed59e1d1-2c27de6cb58mr5007967a91.4.1717671121990; Thu, 06 Jun 2024 03:52:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717671121; cv=none; d=google.com; s=arc-20160816; b=MYDHWX5MbtomWCCOZ/HLmmLVdJPpYTHv6DsNGqMNbOoEox4+IpeKHtT5TdVI4SjRoi HgiNKfTdUnNl3XxT14hHCvndn1ywSVCYCsXH9WgXRJayyn/q6fA85I7fXJ11TaU1etYK Un2cSPdayI81LkMyqXiOS5v1q22lRxZJ9mTuKxxejGb2jw51JhHhSpcCecN8Pn57gm6p dE8a0CuNbmMtKM9y6HpwUzigmOltJp3h2veMmcs9eLPArutijuyN4SvJo7TQAum+u+Es 4XabCy8/gVsqFQ8kyEOSgBIC3/5gl8uuAFN/0ifBfhMnnOknsC6/iod/7Dgd/DlrMlJI 3ReQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=RPxJf3AuLCRGxEet0JTBzYUap/X8C3+MSVmYZlq/tjs=; fh=TnONIKyJu/AQEtSB2FN7LEosIRKcXOHukEhvPtee/48=; b=vKlKfzRgs5455YS6PasHxmg9naxHT81SgzAaOv4E9gk8VKBYR2RN29nKIb6WWS4SNd xA9/rdkzV7Phk2abWdqqyODwyYcsGnTwGgB0FUtj78MXoFs4aVoqnaEjwCYgOZ3ARzNa 2XOTf4+CScVLOeCBmqaW6xGFc+yRjvZP1RtCZflyy0SvSJMye8H2lD44dd0n8e4fhQMC DFSwa0uREi8u83ZrrASdPA1fPpuoG9sy9BkCcoaR/NZ2e9/kGDOLcULw8E+ALf/LQYGT blufbClCd387hXfFLzL0LOgDaYXDhptKlcHqQI3peA1gWYmqvkGaOsyorok2brR3z1pf 746Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=j4lIMOxU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Q4G3UR3N; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=KsZzLkW7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c29c204109si1029743a91.36.2024.06.06.03.52.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2024 03:52:01 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=j4lIMOxU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Q4G3UR3N; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=KsZzLkW7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sFAiZ-00029o-8Y; Thu, 06 Jun 2024 10:51:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sFAiX-00029d-PJ for openvpn-devel@lists.sourceforge.net; Thu, 06 Jun 2024 10:51:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DraiUqTIyYw3HntBUcdT09j4M20iM7crNVI8xdLLRPg=; b=j4lIMOxUMFM5OarfeaxsVZgBxv tkEMClztmty0Cz6H2MY5MTSaAGiuwOQcySEL/0BV9pQLB7vfWK2SQq+/Ymy+ApwbrrE43fHUCvMrS KTNWem6Q47JdCbRdJNy4XKYiK7+mbWbfu2dpYgl1e0ho6EGjZOZ0QtWeSqA7L021dmcA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=DraiUqTIyYw3HntBUcdT09j4M20iM7crNVI8xdLLRPg=; b=Q 4G3UR3N/k1Ik46j72pv8tTCG6hSm9XywC/tVvGMlPeoORroukalgBUq/QClZqt7PlkEerZUNkBLS9 /DbSLNkMjDLnRNmYwVFaoKLqnaK4DDimCbqqc40wBqcE6g5D9m6cRotn65vY63CsRXcKjnPcdN7vq 7m1qC9gvsU52hrio=; Received: from mail-wm1-f43.google.com ([209.85.128.43]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sFAiY-0000iN-5j for openvpn-devel@lists.sourceforge.net; Thu, 06 Jun 2024 10:51:38 +0000 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42163b9027bso210175e9.2 for ; Thu, 06 Jun 2024 03:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1717671091; x=1718275891; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=DraiUqTIyYw3HntBUcdT09j4M20iM7crNVI8xdLLRPg=; b=KsZzLkW7Dd+vStnXvvs5nCjLHAk/5pynXv6JRREIkuFL+vYLzzkgSVPxycwF+5WVcw Z+VW8mtJgbkwBooboCowtEP+uUas6MJlj4rXYMdQHNsIXCysssx4ZmIYd6rGDvPlp/hG 7ac70uBDSJd7cfCAuAlYUwG0VnOe5vX410QpFtRLqcWGA+XoUYkltyhJX6tqFOST0CUX bscXVq5gKCBVBoqTzjjAMQ/LQXb45r7Zb67pEXpM0UvMZE9aJjj1ey7KJ8+/xOsIOQ/h 96pEmMp7Wnsp0Gp6DkJ1Kxr3zJkbgCOan775dS6FcpHfzSHMqPd1V9DcvLC9Yz9RcUt+ 69pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717671091; x=1718275891; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DraiUqTIyYw3HntBUcdT09j4M20iM7crNVI8xdLLRPg=; b=i5FizUyOdMfeLscxO3ggO4Nd6ECQ7FeKLJmn3UooIaZO/Z5tf73eBKXnB/EaCi3/r0 FDb+ucSm8OOoS32qLqFw60/XHozTCOst2zyYRlP0B6qBbzhW1cEsVgoIrRMUVVI89jhi rBqh+ks+YuO9NQz7m6BJ4mmNYx4vRfu0SEWsBxfpEY6o+5ue+v8lgfMjP5fXGWBwNL3a 7Wk0aZQ+jKpNv9/4NvBU6HYgfC08SH60VSSsoLLBMG+wSubNUSiYjWSezp3Temme7P2s 3jZn7crMmmMaQu8ccZ0gBqsLI15/md7umFYWarAaZ/qZb2+MFaOngUFY25efW68SfFIx +WPw== X-Gm-Message-State: AOJu0Yy5khsNQ3U3cnUrMyRKqU8MJpUJDpml9Ltx8EDjAIy94S+hvqTs 4Oryed7lnraGNT+ssQ7XzN4Jplrd0ErEpZbFmYqxeIZQVilwNsEPHjnEzSYv+vQ= X-Received: by 2002:a7b:c393:0:b0:41f:f32c:e097 with SMTP id 5b1f17b1804b1-421562ee774mr45250945e9.23.1717671090647; Thu, 06 Jun 2024 03:51:30 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c19e572sm17678905e9.10.2024.06.06.03.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 03:51:30 -0700 (PDT) From: "uddr (Code Review)" X-Google-Original-From: "uddr (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 6 Jun 2024 10:51:29 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I9612e4dc3d93437f59ee7846781589b36f57d895 X-Gerrit-Change-Number: 661 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 59fb525eee9e1dd011999d79a24f020cd9fba7b8 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.43 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.43 listed in sa-accredit.habeas.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.43 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1sFAiY-0000iN-5j Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Test: please ignore X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yura.uddr@gmail.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com, yura.darnobyt@openvpn.net Cc: uddr , openvpn-devel , buildbot Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1801108714830254022?= X-GMAIL-MSGID: =?utf-8?q?1801108714830254022?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/661?usp=email to review the following change. Change subject: Test: please ignore ...................................................................... Test: please ignore Change-Id: I9612e4dc3d93437f59ee7846781589b36f57d895 --- M CONTRIBUTING.rst 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/661/1 diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index a848f89..8b93cdf 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -1,5 +1,9 @@ CONTRIBUTING TO THE OPENVPN PROJECT =================================== +=================================== +=================================== +=================================== +=================================== Patches should be written against the Git "master" branch. Some patches may get backported to a release branch.