From patchwork Mon Jul 8 21:08:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3757 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081925max; Mon, 8 Jul 2024 14:10:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUu59E4dFIPNZ7kL6ie+uu9XcYAo/2byzKTlq7PlIfMVhaVVKudkTGtK6PX1Zj8eGOxVBHsWXi3XL1+cW8eHrBt6QxzAZU= X-Google-Smtp-Source: AGHT+IHoRhFSr4Bz/Abry6p4e7UPf8gMmNK92Tc4QMEs/AGJ0zHr06f6Ipe0qOZtNKrXeISjmvW7 X-Received: by 2002:a05:6e02:1353:b0:378:cf86:357b with SMTP id e9e14a558f8ab-38a5910a911mr6582515ab.3.1720473019315; Mon, 08 Jul 2024 14:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473019; cv=none; d=google.com; s=arc-20160816; b=d8LxcgGcb+3MdJhUtNCTFGz7pqe+zVY2AdZ7hvtbUKJNNLuC3QNTNZFfpJJy7q3v7E zs+nf7TZIzAh6cB2EUXAGKEG2IaOTfmy9DpUOdEauyd23WLdqkmWDm8UrDKKzPz8xhKz OOqP/RzKM2AY4Z+JezAdtXr+g1ezL5LuTszC0XHITxCySSgOWxQ/ucjIPZKPyUaie60f jUDT8XpxZlgDhamjioLNM/hqULoa2Bkim4dZ658mi35Pwxvv5BzdSN0TX4hwOWAu7Kd3 s3FQULGIZiSPbURRLydRe16kh7q7ufH/YRmKNPUGpbHQuh0l0/2azw1vG7CCjIgZlw6W DFBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=azSYVrAliUxK+AhXakUbOIV1ZcywZPahrY0Jtwzh/OQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=0fTBSbNc6ZwJQ1pbDpjeDvHRx3XhGjcuE30SdWTp3f8t/Loo5dX6+7a6hVEohW8rOO cbmveFWwTiiHA6J5A9uIndmhBht+JAhOWo4qZn0kPKQTct2+JgKjiFIyDy4qQLPE8TVv Qf5rC2ZDFV1AncML2auIOtHHH+yDF4/VYaOEkbLgnfPYKIbPcpUOr7dQCBamYN5P5ZCd DEh/IgPW0anE8cBCf6Q076m+tentdh2IIdHtAjI8oYgRty/p109zzYAVAdrpymZUzQBG gHml+Z/K74PwZkAMofESamUMrJI+9aJilRvidJ/2uGLL/MiSrsQysbohEW5X8x4cf5FO o4ng==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NKTtOjFH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=eYKAHbEn; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=JWfVWDbS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-77d565b47casi549055a12.108.2024.07.08.14.10.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NKTtOjFH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=eYKAHbEn; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=JWfVWDbS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcB-0002s3-Ft; Mon, 08 Jul 2024 21:09:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcA-0002rn-8U for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=NKTtOjFHsHcLKmEzi/N8qgT0tF DogPrpQO0W+Bqyr0oq+kSMkG7g1yfZO6n0dj2dFHAty7ndetmV18e8dhlrvkzAqKxe07B3TSXBQz0 3+1T3pKDePMeJ3DcgOrt5do/t2m6BjELwTnQxmeB81EYHZhcPmgpv4ArU1unw07Y2/i8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=eYKAHbEnn0+IdOr8bRDTlnZ8ks QwHHlf0W4jATWOzPa5MdciERARie7GQe2LekgCobC1IPtL1IIUxTcWSDcVT2wKpDISShQ8NIWY3av iIu/ZHzxVcAWarxrBN6lgtK6zFxVuykllx1suXmQ+Oba94ah0vaSn7l/OGwTncZqaGYQ=; Received: from mail-wr1-f41.google.com ([209.85.221.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcA-0000RQ-Lb for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:38 +0000 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-367a23462e6so2763720f8f.3 for ; Mon, 08 Jul 2024 14:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472971; x=1721077771; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=JWfVWDbSBPT28+2k91kUl7ubJwkfPDJVqEeZ5zEcYq//LCwBxH2OtyRaXmo3X5oar1 n52mNoyxL8edhnqNrJ5hiBLl/I2hd940uzn+8tKfaOIjJebSLpqDURLGTOH9Dzfwl6QO yBx4WDILzJfwWXaYoeXxEg2g93JB++DkKJPPrltkle5Hm7K8AL0uATOF9UV/Gd9rz8pi vRlQFFt3xS5FMzkQjyQoIesRE5kAS51lLdgA71WOpoYNd568l/6N9eEjSogaNmyqfyOK Th1z9F8iMmf++PI98RHd9fajEGLrcisQJqjQRq/0TDe0Asgqi1WhZ9B1uhGI2hWG1wuG 8RcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472971; x=1721077771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=ARsGEfXEdjcFhzXUtqMWv6G+tRYzt3p8et6cWMzrMfZgm5yobipaTCVVmgp35H3sZr WyC2q+ykff92gaJ7E1iFM0cowdUZ1hnfJfXz+luFHMrhNEtgYVVgelUKQ7QQIZVptGpX QBnVV05Wxs+Y7zuUdO8LFT5W913HdgeRKRkl6hgSzsd5C2XcVFrrMWjAX9MyRLwd+hhk n26yi0L5awfdEycvXnrETu3Qfv3dM5B2fpRcDg/YaKYkHW9OJrufAV7Mj3YxGI7EIeIG s3x6Wk2WSgux96DUtTdV3cJP6HWR4D4LP2INISb4zQmjmkygqJhC7rvEjZT2Rqk3zSKK GGmw== X-Gm-Message-State: AOJu0Yx7JRSCTlBDTs+xMnJCKyEIkOO2LtZqz8IsmKEwvqBbGrKJD0Yi Ug1UxPpcLGYsYRr4BCwN3hT+YflHlUiZG+Fp8tbyaYh7JnSY4eCTtYxY9Q== X-Received: by 2002:a05:6000:1844:b0:366:e9b8:784f with SMTP id ffacd0b85a97d-367cea96425mr628586f8f.32.1720472970714; Mon, 08 Jul 2024 14:09:30 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:30 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:18 +0200 Message-ID: <20240708210912.566-2-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- src/openvpn/init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.41 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.41 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.41 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.41 listed in wl.mailspike.net] X-Headers-End: 1sQvcA-0000RQ-Lb Subject: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046716722012085?= X-GMAIL-MSGID: =?utf-8?q?1804046716722012085?= Signed-off-by: Ilia Shipitsin Acked-by: Gert Doering --- src/openvpn/init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const char *chroot_dir) if (!chroot_dir) { saved_pid_file_name = strdup(filename); + if (!saved_pid_file_name) + { + msg( M_FATAL, "Failed allocate memory saved_pid_file_name"); + } } } } From patchwork Mon Jul 8 21:08:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3758 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081935max; Mon, 8 Jul 2024 14:10:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQb4W9FvQmMxu4St7UndBl1kqAO0kbX46WImkNzqkeayHxFenvolw0WzPWhC+T73peleVHNWEEWyk5nKdM2UrRJyzHy54= X-Google-Smtp-Source: AGHT+IHO6E9aqwKTlrVDZUy0yIElqh6h0DsJs5lXhHC0C2iiMDI3fqXio07dSgSP5kBn6Z2Y4mFd X-Received: by 2002:a05:6e02:1066:b0:382:774e:a820 with SMTP id e9e14a558f8ab-38a54366279mr7689505ab.0.1720473021034; Mon, 08 Jul 2024 14:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473021; cv=none; d=google.com; s=arc-20160816; b=J5gd5/h+JrsDkjSH1xD6rtygCfH2pI1cLYt3RDxu14rXsfjql9R2jZ8/l3WaiiPijo 32GzuxQeeZclKtZCSNK7K3YZC4K10PIYjnz2sfvS1K7/f1C7DoX4erPb/lBFpcW6WOUG jsN6/Xp/8ebTwLbsoqi/1JFPzMiO7EernzEq2aC33xXa7PQGKgxLc20JKeB/lwCMfhXl QmhKxFi9Jsknu/571BPaMmVLuU9fpIipwyoWHGjEDBRYr2pzcHF/VB6dwAlaIsFtJ6oB bS1tfCtLh7xddMv6WqgKxfraFHrTqRFq4aj4ufzKV9U1awrOO5/YzaNHpF0VTnE4EX3I JEwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=WwKg+cnWVLcNxrp7gH2W62E/VBN3AKVkslqepxP6E7I=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=l7IBHtRTCF7N1Pmk4Y+CBjW+A1Kj6b7UzRHp1l9hxmVvtq4S5rsA7roAGrSFh0NV9n vts46WsCQhwSYdJm1jyHaLqSAZe/p7lpMK3XKuxe5yRCaGypJjb9ac+ifX0rCg1VjKVY IfQPU5gIw1prVbmDjQe8w6BBslZrmL725cH8U3k1KOryns6/xW7JIY1mstSvrXhZD/Xk UZBOwrEU+U2CJgGkOk97D9dPO3GcibDURiFt0q/MSPVm9Lfziccn7IphY718+gwoJjKH MB9TvX+PT0mVURlv4QNlJc7AgWfvzDu3tIQJ77ytGr7WLFxgKGLZUe7eT5j3AaTR9Mtm JLxA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Z+EyFJcm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT5cMnzQ; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=YC4L9eQa; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-77d61738960si543234a12.701.2024.07.08.14.10.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Z+EyFJcm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT5cMnzQ; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=YC4L9eQa; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcQ-0005q4-Ex; Mon, 08 Jul 2024 21:09:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcP-0005pv-EM for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=Z+EyFJcmE3cVen9F9wYEnzI/KJ XxTPkib7f3kocqnByY0LYEAx1x2mK+sxk0tBSdvY14uA6CS1BFExVxobu7ZUcJI3TDKp9yHO+RGah 28V2jH/dRH62zXImtEs7bDdFaHc0djig95/D/vuwdqTP2KoIzdftVH1sG7ggVhFOADsQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=XT5cMnzQ46yZa4IIqlClWnj+QK QpAcB70+m8OaYTxJWVcOHxifBTvzBd4huN4znnS0MMPFDL+DcLkRvqiMUWyKW+sjak7QPBPbTmn+A BR3vU6sm0/eMwqkdWwB5aVLtkbgDqXlx1OvVnitxKhZ2WHgtuunaN8xsW/i3I0y2N4no=; Received: from mail-wr1-f51.google.com ([209.85.221.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcO-0000SH-Vx for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:52 +0000 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-35f06861ae6so2871566f8f.2 for ; Mon, 08 Jul 2024 14:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472972; x=1721077772; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=YC4L9eQaFdfO4zYUknH3iJALGrLct8KRwfZcH4/FLNQ7oBr2iNOzvOY54OfXK4VkAN 4gwplvz6UlikN8hnZqj9T8LU6jAPOVOwubMPGiW6KijcAfMVe0uFbPmFqmsZKlrV930k 93AfIGUsFoIm75GuqyS20NEIF/5Wh4BqohpI2Jqh0/0RGGMxGIEFe8+FPlBOtJn35aEl 2i/J8cq2DK/bebkNh/5xe/x/hJVvrNdfXGAXT0L4/QneXmfy9awnYA5/O1IuXay+QoEx HwKSlLhHtfANBkcpCOxBG4lWNMDUbixJ6Q4vEh/H7F8jyFwJ/ghQEF7gjRspOItBBL2g RUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472972; x=1721077772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=WkuoW/N5COfP1yQlcaRNCQLfYuaiLU8wm6Wpx+p7UlhTrvYt5XqiMasraX/9dyU/sA YTA2FB/8alSx2vG1/qpdAj3FZsqKa8fwAS6qsrPKwrvjDeBRahl9JSJADC69RpMGUG4s XeJGteOs4cQM1sIY4nKNST8047oRH6rh/Vg0l3IevGnmruj6fCMF/IBddN9H1ou0+9fS B8mz6uxOUbI+KXctJPP4LCLOIH17gM3yy4t2D/dvzlTb10+ou1NxJKuMN7eZnKMwc+aM Sc6SbsTp9gLbcuZXJyoo8ed9BuU5a21Trhd1tlBEkIDa8TmD7GXhxXvGcDtanYfUdYnu A46g== X-Gm-Message-State: AOJu0YxinjK52gmPpyk+LXvLIsW5Ct7aKqyqRe2c+pd38gQUoNy7iO7i dS6KUxDvUcHK8GL1ov6cLJfpi9aNbsSXJWhqYcNarI5m4vsuTC1E2yHAJA== X-Received: by 2002:a5d:4491:0:b0:367:9754:810c with SMTP id ffacd0b85a97d-367cea965b9mr501377f8f.38.1720472972099; Mon, 08 Jul 2024 14:09:32 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:31 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:19 +0200 Message-ID: <20240708210912.566-3-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- sample/sample-plugins/defer/multi-auth.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sample/sample-plugins/defer/multi-auth.c b/sample/sample-plugins/defer/multi-auth.c index 2c482799..109fa40c 100644 --- a/sample/sample-plugins/defer/multi-auth.c +++ b/sample/sample-plug [...] Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.221.51 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.51 listed in wl.mailspike.net] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1sQvcO-0000SH-Vx Subject: [Openvpn-devel] [PATCH 2/5] sample/sample-plugins/defer/multi-auth.c: handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046718438547059?= X-GMAIL-MSGID: =?utf-8?q?1804046718438547059?= Signed-off-by: Ilia Shipitsin Acked-by: Frank Lichtenheld --- sample/sample-plugins/defer/multi-auth.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sample/sample-plugins/defer/multi-auth.c b/sample/sample-plugins/defer/multi-auth.c index 2c482799..109fa40c 100644 --- a/sample/sample-plugins/defer/multi-auth.c +++ b/sample/sample-plugins/defer/multi-auth.c @@ -206,9 +206,24 @@ openvpn_plugin_open_v3(const int v3structver, if ((args->argv[4]) && !args->argv[5]) { context->authid = strdup(args->argv[1]); + if (!context->authid) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } context->test_deferred_auth = atoi_null0(args->argv[2]); context->test_valid_user = strdup(args->argv[3]); + if (!context->test_valid_user) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } context->test_valid_pass = strdup(args->argv[4]); + if (!context->test_valid_pass) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } } else { From patchwork Mon Jul 8 21:08:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3756 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081907max; Mon, 8 Jul 2024 14:10:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUKDrSPL4V3LJtQl2ku7bCXmmazMroSbYxOdhsTcZTbT5BQx2rL4KJQt41DsuGskF1XpBxg5kwKjwleZ1Sgt2xVj4cO+Z4= X-Google-Smtp-Source: AGHT+IG1QDxFb44xPjHzyIkKTts+racWFnpZx6T2Nml8sks6/LLH46ODaNwUd75gunCttxaY49Dn X-Received: by 2002:a17:902:dacb:b0:1fb:19fc:1b44 with SMTP id d9443c01a7336-1fbb6ec4ef6mr6882185ad.3.1720473016976; Mon, 08 Jul 2024 14:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473016; cv=none; d=google.com; s=arc-20160816; b=bL1AtnPy5rlAmNegBvyjgsWUDRpa1UJseCVvDZnsaW4aIegxjlUoSQGs3Hnx4YS/Lc MZXN6vvegodTEUHnr1ZywkGbZNgIZoa3fCNB1QPPo52ewsAr/EPTkx3Je5/cJoCnMwh+ Bf8MK0X01Wp9+vhrmDMxoynmDMzMO+AccM5FgqFxJEk1benM30fVHjxIdgAFljGBwUC/ 5as5qheC1YHQpfaO9gt6qyKf8yqHy8z9160aNpsAt20e9oyhGZRrXX4GMdVp5tMG0Ezz KVElQ+txVBDm9Q7Oq2zVYFLV/zAqnImWLrI5R8qMQDDXSGLaLJGxbFGjIJ9Hgxh5zRIB blmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=9GU+S36f89OeSF0CO+hpcRdsYQyujqbDVpmra/l7goA=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=yhVH9FTcMuX97+CvFRPxC9EDcg957aVq4dZaFMF0j2GFWkKm92beCHvXEDaWfDNeyF Pn2uwh7EC6mMuaLX6B/K/P166LtRAsvbYUnTEKWGrY42IavQPnMHOybq4d7iOh6vRMjn pZDt6iiaGLpKGjcnTiLf4B1jzdAz0N4uxWwOZRxb/DLqe9LonoKg8tmRBJoDgY2DMYxy 4r6igwJcyccSkWSlG75xEkv6GO/VqIcbT/aQIuv9p+NJXWGIxHAdePaLXDVdTKEWa0yh CwR25y8WMWrwAVxyVim/J/vzML9xIdHQarSK7kDxSiFVp9LrIvYCupybG5SiHq+yFpzT uMHw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=DAfLM+LE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JFu667KV; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=WHKFPGDs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d9443c01a7336-1fbb6ad00e0si5026825ad.565.2024.07.08.14.10.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=DAfLM+LE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JFu667KV; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=WHKFPGDs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcH-0005Zo-7h; Mon, 08 Jul 2024 21:09:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcF-0005Zc-Pa for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iu652Sjz7Kk9Lmkg96SKh5v7WAbeork+s2ixnBBHtPg=; b=DAfLM+LEG31PNhBrr2KOHnlZHi hHO3wp35jvaWDOSo1w2Vc3K5enuXgRnY0XQDFD+5U+rY+bcG4r7M1vzLR2HSm7Z/DCi52+tkbpsm0 aiFK93qDr47svDXyST+mzKpQWqNwrD/+WyVmUkKhqE0Uk3x4JTHaGPUzW6RmOj7JS/ws=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Iu652Sjz7Kk9Lmkg96SKh5v7WAbeork+s2ixnBBHtPg=; b=JFu667KVV6Sdow7FKl+C4oApWV yasm7AF0hA08eHPZkJMdCclyqEtTJS9vNgSH8UWV2jxOiuI48h0wiAvzsm7zMEATq3IDI8EkcandY rS1GBLvxaAFLCROAM+FtDPpxgrfcEXmQjIM6JcTQJLOsGe7urXi/2amjwBbp2ILePlOk=; Received: from mail-wr1-f49.google.com ([209.85.221.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcF-0000Ra-CR for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:44 +0000 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-367963ea053so3734802f8f.2 for ; Mon, 08 Jul 2024 14:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472973; x=1721077773; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iu652Sjz7Kk9Lmkg96SKh5v7WAbeork+s2ixnBBHtPg=; b=WHKFPGDsItK3oyWekOg66je5jQ8GmF5YaJ6IqwHKKMuBjGLdH6eFmvqGUPLSI5WCv+ JXYXXR/aRFsZ0t9kVhOp8M6foU3OhXEunCPx927dWPaO5Io6IyJrxWZyNGKOnRXE6tu5 64QNw4lohLu8po50NGKgj+GQc6zm7dIzBJlP2OD+rDMvsqIqkqYb2GwvgyctmTCqglap 1ycjXN4Oru8VoRbfMEfQoPxw4j3EYxt1RF2vuUe8C0w4nqCz7a81dvvcIvWAh89tsKMs zrmd8SLJ2TE5JlxjYVhlA5E+HN4N0b6WzxCSDtYCOqVZWagNMZ0JDaqxXr1GvwtKhBa+ cqWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472973; x=1721077773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iu652Sjz7Kk9Lmkg96SKh5v7WAbeork+s2ixnBBHtPg=; b=QO3X49WtfufnIcM6np+Ei8hySX0HwlHGyMTpdU6wO7AJ8gV+ie6HG4G8iLA8BiblB0 /+1xHpficVwtn3Q0JjXnHputEYoAC1LZTldF9VIFNJ0v2spL4dEXDmQNmWn1vEX0SkuT 3uQhy8CKRxkw+JN0+FbGYi3pYCpg/LJ+TC9c3C3BozJnn8IIFJ9DU6POMpppXeo0/DRR VlOYwuOvdLYBUDYbh/UXsCegzL3ej3hCDYK8KDgkB0GLrEp/2g0ETPOBcaaffwYHBUuc cc21424FYvk60k6DjWsIcJ12QG60EALgELwY7g0xA8oq2mcARUSoyR1Sf5fl9DgH6RHr F7wA== X-Gm-Message-State: AOJu0Yzawfrlmxn/VXJZUH1+L1/Nin3hjsUyuZ2MW1PUd3/lodJPXDO1 usHhBldqhR2NldVQRCbd8vNzl71TeNuAZ60h5p7mveJhBsom8C26JuDagg== X-Received: by 2002:a5d:5258:0:b0:366:ec30:adcd with SMTP id ffacd0b85a97d-367cea45ce7mr593144f8f.7.1720472973454; Mon, 08 Jul 2024 14:09:33 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:32 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:20 +0200 Message-ID: <20240708210912.566-4-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- src/openvpn/auth_token.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c index 6787ea7d..2278afe6 100644 --- a/src/openvpn/auth_token.c +++ b/src/openvpn/auth_token.c @@ -260,6 +260,10 @@ generate_auth_token( [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.49 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.49 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.49 listed in sa-trusted.bondedsender.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.49 listed in wl.mailspike.net] X-Headers-End: 1sQvcF-0000Ra-CR Subject: [Openvpn-devel] [PATCH 3/5] src/openvpn/auth_token.c: handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046714495206782?= X-GMAIL-MSGID: =?utf-8?q?1804046714495206782?= Signed-off-by: Ilia Shipitsin --- src/openvpn/auth_token.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c index 6787ea7d..2278afe6 100644 --- a/src/openvpn/auth_token.c +++ b/src/openvpn/auth_token.c @@ -260,6 +260,10 @@ generate_auth_token(const struct user_pass *up, struct tls_multi *multi) /* free the auth-token if defined, we will replace it with a new one */ free(multi->auth_token); multi->auth_token = strdup((char *)BPTR(&session_token)); + if (!multi->auth_token) + { + msg( M_FATAL, "Failed allocate memory for multi->auth_token"); + } dmsg(D_SHOW_KEYS, "Generated token for client: %s (%s)", multi->auth_token, up->username); @@ -271,6 +275,10 @@ generate_auth_token(const struct user_pass *up, struct tls_multi *multi) * and timestamp in updates */ multi->auth_token_initial = strdup(multi->auth_token); + if (!multi->auth_token_initial) + { + msg( M_FATAL, "Failed allocate memory for multi->auth_token_initial"); + } } gc_free(&gc); From patchwork Mon Jul 8 21:08:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3755 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081831max; Mon, 8 Jul 2024 14:10:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXdGpNOG0uwZIuA7Jm+iAo8IVz6Jyo7CZP9K3LP8pnAr3GAGWPJkvfl3eyzrwtlBRYniZcTTdLbv7xRViDjD1p2r4DoTF0= X-Google-Smtp-Source: AGHT+IF90sxmV3tfWEYa29O5dFBgZpiWSD6yF2SymCCuiub2DHL0tDuxsWrSB2BMPFZMBZZtIf0w X-Received: by 2002:a05:6a00:4589:b0:706:a85d:bd60 with SMTP id d2e1a72fcca58-70b4368a78fmr874524b3a.3.1720473006416; Mon, 08 Jul 2024 14:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473006; cv=none; d=google.com; s=arc-20160816; b=eWSQxNwfG2Lu/oa7MnVYUJn5wt5RF1xMu4/xE0Fc2W0kkOifP0xPvuC/vmG50Ud6lG oLVqdmRcPY9I9y9GeMGF0q8orxDA3f3FAdKKSFEXyBb+MftfUV5GB+Ax+B0AuFJT6+JO USUyYiy/nR3Zk+l92vIAbXakocnTbtJe0nLPVj6/ZOLT32AL4JKyMg1a1/sSMygmGtH/ pHqXQP+tcbZ5Api/b1XF/IiComlGj7fLrWT5sg8xNPeCy1T8Nm61L1sudxRdI7dIRV0H zJgY1rqPXtx7GYwRpLXuSLlPbr2sC+Dd2o+4w0u/q/MLCI2T0deuHQ4+JfTytWLx4e02 rT7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=JAHTa/J6YmCFu66vDA4wMeUKf4jrpPDIps3udKKsD2s=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=RiQt+cPGNVyscuQWZqVZXBCrar48u0mW9+j56Sz10T3kvgsCzJc2q+JRw8+gpv+q8l 9J1uJKLGCzscdhgwR194av+H9D5XsrUE2YDCkhb8lZs8JiYjvwdQNsMuWwaBjDhybsrK /dTgjQmkS9+VoMlzbjelrBnfLztxO9LlLfnS4gEMm+VQhIWKUMuxqOzxtfJRvgGVv3VE /Q1YeZG1L8ZT9rWHIXPdwKkKghHU9uG6JbqWVkHRrtxMbEcr85q2gUp4YIopOl43sjUl 3DQMMzx5PMTnQBOjQ6jVMIDWC2vN/+W5Spy/hBo26G0v6Zo5pcjpmKlMB8Gno4kzaoPw M1Sg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=havh1+rw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Ue1vProH; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=e723PWBz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-77d565b405asi565596a12.60.2024.07.08.14.10.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=havh1+rw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Ue1vProH; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=e723PWBz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcH-0005pV-3O; Mon, 08 Jul 2024 21:09:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcE-0005pM-P6 for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jsCnMl4D6DnhA/6RKu5uYDr0SZhan8sZ4RwLhoXMn5g=; b=havh1+rw2OQE9+7j38s1KPjfkG 5Aii85PjjSNOiMq1WEn6GhLwxpa1tyf5Cr5dccUorGUq7OxSr7D4z1goWI74t7FhZJ6aQoqyraP1G eY4qRImsZHt3zWaHvYV/OVS6riTdHZYWD0ZVvg2HISGQF+b2t2M0MOexmx3rJbj5K6/U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jsCnMl4D6DnhA/6RKu5uYDr0SZhan8sZ4RwLhoXMn5g=; b=Ue1vProHh337REV4O6BGCB4Rzz iMuVyl34wnBY/43e6p1TQpVnNXwqQbOuwlPLieLlt0Cgk0eYVZPqiNMEdSFKWRcjUanXcUHs/W41T sHa+hgA2Sr7H/IIDrc/ehAJnXiCF2hE5aiMkUNoEpNuyPcr2OiSDTXLvJ+DfEWpTyt0k=; Received: from mail-wm1-f49.google.com ([209.85.128.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcE-0000Rl-8G for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:42 +0000 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4266ea6a412so5527885e9.1 for ; Mon, 08 Jul 2024 14:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472974; x=1721077774; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jsCnMl4D6DnhA/6RKu5uYDr0SZhan8sZ4RwLhoXMn5g=; b=e723PWBzXvNXYPsfAFgZ6ivebo4jZWHPOpc21F0zP8wjXhXwVy9SFiUHBvSyuP61wS E6fGydbuJXqcfJJAhfefnfOWsYxu/sZ1zgmW6xOQyNAxS6kZD+BMe+Sb6QqfR1YzGV55 Oc744dXzktuieEQ0AW4nEkDGTm43vjSV8hchjURS0cDAI6SM9xsNTefcINb36nkeuc/5 TZHvXK7Wka2rE59ZV2rFMx7oCQZaPo9R0lFnwaS1tIwn2N8iatcVPLGLCX76en+AuGNm zHLd2vj6OcdQdXEq0ztShySTUrkglSh5/Pxxdtt/qBcTWlCYNNXhWvQZOiZz63aQdubk jgeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472974; x=1721077774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jsCnMl4D6DnhA/6RKu5uYDr0SZhan8sZ4RwLhoXMn5g=; b=AotTCgzN6q4tJ5l9UUef8eNee2fu+VtJSbmSutokwagj2pAxl81rmtJbXlcf1r8Bo3 4UjyDXpvlgYMVZbQlx4I5XCmKs5BBdCpo9i1602vjxcUyfNudraC46A8cqZP1OG9NPpk 1/JAH1WAAed1yG1MJcZ0Mp4QVCysbUoKGXxSV77WUnLS1z//zTUm834Sv/oDwjjYkodR z7xtJLcJVjEMcq4VRv0XS9SP8DZNEd/HpyfQnL1xtwyJWF4Ikdnk8Z1+mrWp2tZJOWuO 2hvwQPhTuRrwxOMUe5sCBPCsnJTFJUmM0ILXuCLMJcPOiSMfGZglvJR0a37tZ2hyVcco dmKw== X-Gm-Message-State: AOJu0YxAHO8dbVfGg2FHKMLoY49wd36mDqCAc9P/mt7cyunSK9lukIae OnyhsO4DS0eSsI079RxHUJsg6oe5aWU4VruxJbO36mkfSd+E954WukNGMw== X-Received: by 2002:a5d:6da9:0:b0:367:95e8:3af0 with SMTP id ffacd0b85a97d-367cea46c41mr641911f8f.9.1720472974502; Mon, 08 Jul 2024 14:09:34 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:33 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:21 +0200 Message-ID: <20240708210912.566-5-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- src/openvpn/ssl_verify.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 934ff8d8..c4b95553 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -1629,6 +1629,10 @@ verify_user_pass(s [...] Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.49 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.49 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.49 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.128.49 listed in list.dnswl.org] X-Headers-End: 1sQvcE-0000Rl-8G Subject: [Openvpn-devel] [PATCH 4/5] src/openvpn/ssl_verify.c: handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046703110882668?= X-GMAIL-MSGID: =?utf-8?q?1804046703110882668?= Signed-off-by: Ilia Shipitsin --- src/openvpn/ssl_verify.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 934ff8d8..c4b95553 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -1629,6 +1629,10 @@ verify_user_pass(struct user_pass *up, struct tls_multi *multi, if (!multi->auth_token_initial) { multi->auth_token_initial = strdup(up->password); + if (!multi->auth_token_initial) + { + msg( M_FATAL, "Failed allocate memory for multi->auth_token_initial"); + } } if (session->opt->auth_token_call_auth) @@ -1749,6 +1753,10 @@ verify_user_pass(struct user_pass *up, struct tls_multi *multi, && !(ks->auth_token_state_flags & AUTH_TOKEN_EXPIRED)) { multi->auth_token = strdup(up->password); + if (!multi->auth_token) + { + msg( M_FATAL, "Failed allocate memory for multi->auth_token"); + } } /* From patchwork Mon Jul 8 21:08:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3754 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081830max; Mon, 8 Jul 2024 14:10:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUbf5wBw8Yz+BHHDAWs4noHZ3K8+XIDQ+Y+oCZsBVwW1jVihn/5QkBzSJ2rRvGbnpTp2s5mz0QMa28M7fBzXPUlKlSOito= X-Google-Smtp-Source: AGHT+IF8XccK3K40tpOV4607vrHKcyQJpru9A8+oVm0szosIT73DxRy5rI8bzOZ4QXL6rdRTAxpE X-Received: by 2002:a05:6a20:9719:b0:1c2:9009:f6f with SMTP id adf61e73a8af0-1c2984ec5c5mr426526637.4.1720473006290; Mon, 08 Jul 2024 14:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473006; cv=none; d=google.com; s=arc-20160816; b=kSdb3JW92/0d5nPoBMv5NoPsp+T17ILVJw/J6EAlhjOt23nZ2OenE7c0xhR9+FmfeK bFXI0d1DnBSy3EC5xtr0wjyNhafMWuG8GEzOfuM9cfKTS4YF/fdTzvUBpH4CDx3pU1Xo 0ujZvhKxthTUAppDY49C+eNc8X8cpxqQChF38SBOw3pKO4R1alpQfEGqDwSzKBk4Gwe0 yvL3JH0Ua1S80bisqLwQNsy6jTjBYBs62C2zfSrPuUmTA9vKy+xnUMEpoFZ6vDZhumw2 +bPnc5LahrMrHYDCnz8h0/DU1UaTCQvnU2ggt4/frbH/R2YcNDSV4r/vyxMkQNpHcdzJ Ry/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=gCAmle+ZMFvPwVSaWiXOBAlNvDRdzPjgyW+rdMlZwP0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=qzq9PeoQcHIeItfWjJzs2Gw3Yb4gHaHdjK3R6E5eFsyp11K8V3AIOoe3jz4TYBKg7I lbi4gEMoIg6Qz0Be7Kt2f2utb7yREeqXHxyTE7nV+iOrTrB2aI2pevK4zWY9qX+a7Pdt Z0i/T1tb3ESDwFxovrluK/kyDUt3tqMRj7+A7xU2xXLQW9oI3xLi5c4kf7OkXSh/5dOo H7gbEO01QQnEDgM7NHcWvXxPkjtAn5cWRVSBFWGdgxsb6pYkxlOHP26XGs3l+eU2E2bt l/gnXpAjXHdVBMGzWVwXKbup5ZDhffwdbD0YYnCfpvYHXRcwZggCdpTfrSdLdT0jMIeh PFbw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=DGoHYTtQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=OoGwc8xu; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=ir6xpkxA; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d2e1a72fcca58-70b438b38a2si488648b3a.198.2024.07.08.14.10.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=DGoHYTtQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=OoGwc8xu; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=ir6xpkxA; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcL-0002tY-RJ; Mon, 08 Jul 2024 21:09:50 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcK-0002tF-75 for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yvcX1GYafiOOKSWJZqV5qlIWIN6tR48YC1zUJFn9CyE=; b=DGoHYTtQQkgfP/H9tj29E6RK+b 3rd6pQSwWx42+sth6QMAiKpDF3bki6vuStZP6JDkOKC4gYyB+AZM6M9bWB/nL0UtjhL1R7bX5comj bDjHFPBW9C7QmPXRCeOavpcaj68zLRqYW8BVDIEjEW4NswA5u+bjJR7TSjLtDiPAYOiU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yvcX1GYafiOOKSWJZqV5qlIWIN6tR48YC1zUJFn9CyE=; b=OoGwc8xu1Cp+QQ9KdPQn3HbBPE y6N2spRjDJfzJYszG//VdIBa2SOVEfA06nGGLmt5hldc6hGABnuUYrzUazS0NgmAX1OdBvDoEgGc1 0uNvZAFg30DZAO+jYaGdhGzS7VHBiArstkd4qyqpCCQwdGmytX8agt7UnF0jYyRyL8Sw=; Received: from mail-wr1-f45.google.com ([209.85.221.45]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcK-0000SK-MR for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:48 +0000 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-367a183df54so2704905f8f.2 for ; Mon, 08 Jul 2024 14:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472976; x=1721077776; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yvcX1GYafiOOKSWJZqV5qlIWIN6tR48YC1zUJFn9CyE=; b=ir6xpkxAzOHj+7rTX5uQqQKCf6881+hcf7iI9a8oABW09+XeRJsz6ahzIVaFOlpzx/ F7YaCwsxqe5ZDzb4+TBDtQaHKLAMQEhmHgNGOO/wQbsOTJNu2ibNDGxa3vQ/xkz7jaQ4 ZlKAKUom0KJ4hQkWiFWyGkhicQyOBVLNDAYTrP18+zyjttFpOrJ4n8iCEGa0tObsFCDV 4cysIq1CP34uHb+DH6k02ACdLSi80SRQpYM/l2TohKXRX5ETHO5e5Njke6npJexXxcFv L3XsvM5bYeiCI7ZuVcjP8u+A66hQCg4Rmdeq0uFGnhF/Qrd9xz6Th/VpfmcaGxYTckb+ 2TyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472976; x=1721077776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yvcX1GYafiOOKSWJZqV5qlIWIN6tR48YC1zUJFn9CyE=; b=cTzOnOX6DD6qtyUOSRh6PWsheeQgGdtBemEcrfkZX3XVuGqIXOp/k0BrWmsaG1VcYV zxQUVGY4opjXv9wwpamnR0kPDDd648Qdk8PaidAkdHDRGcxzVh4iLU5CI2VxIfeDzMEq MoaI7ugvNJFyVjuwL30AWJFv8wokK1QTfeDRDKwFNY0SpQB2BSicKf6Dfs7IFg5VkUrZ BDMTT6BBBExTkQq+WogXeuqO2pcdYEtWQSY9Pa9xe6H9hd4m2IDNiADy1GvEf/04ESDe +Lf3f7j4LmeuPQv00Lj7c8udOfESWemU4E19XmcU/W2gljQY+ilKX6T9RAdghBU3Biok c13w== X-Gm-Message-State: AOJu0Yzk+oZTsqZtt5Kp9C8UIDZJU4wtLQvegDR1uOR9QXOqCrwtULs8 AQgYdKQnw9QCSKWmwkR7Zm01FEOtQ7QKejBdqt+gMXhHHvKykcfag9KT1g== X-Received: by 2002:adf:dd8d:0:b0:367:a49e:746d with SMTP id ffacd0b85a97d-367cea961c6mr404024f8f.39.1720472976007; Mon, 08 Jul 2024 14:09:36 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:35 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:22 +0200 Message-ID: <20240708210912.566-6-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- tests/unit_tests/openvpn/test_auth_token.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit_tests/openvpn/test_auth_token.c b/tests/unit_tests/openvpn/test_auth_token.c index 3a3cb69b..8a0c16af 100644 --- a/tests/unit_tests/openvpn/test_auth_token.c +++ b/tests/unit_t [...] Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.221.45 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.45 listed in sa-accredit.habeas.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.45 listed in bl.score.senderscore.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] X-Headers-End: 1sQvcK-0000SK-MR Subject: [Openvpn-devel] [PATCH 5/5] tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046703269960735?= X-GMAIL-MSGID: =?utf-8?q?1804046703269960735?= Signed-off-by: Ilia Shipitsin Acked-by: Frank Lichtenheld --- tests/unit_tests/openvpn/test_auth_token.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit_tests/openvpn/test_auth_token.c b/tests/unit_tests/openvpn/test_auth_token.c index 3a3cb69b..8a0c16af 100644 --- a/tests/unit_tests/openvpn/test_auth_token.c +++ b/tests/unit_tests/openvpn/test_auth_token.c @@ -245,6 +245,7 @@ auth_token_test_known_keys(void **state) now = 0; /* Preload the session id so the same session id is used here */ ctx->multi.auth_token_initial = strdup(now0key0); + assert_non_null(ctx->multi.auth_token_initial); /* Zero the hmac part to ensure we have a newly generated token */ zerohmac(ctx->multi.auth_token_initial); @@ -374,6 +375,7 @@ auth_token_test_random_keys(void **state) now = 0x5c331e9c; /* Preload the session id so the same session id is used here */ ctx->multi.auth_token_initial = strdup(random_token); + assert_non_null(ctx->multi.auth_token_initial); free_key_ctx(&ctx->multi.opt.auth_token_key); auth_token_init_secret(&ctx->multi.opt.auth_token_key, random_key, true);