From patchwork Wed Jul 10 13:57:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3761 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:518c:b0:59e:d24b:d55c with SMTP id g12csp361092mae; Wed, 10 Jul 2024 06:57:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXaSVrxky1POBuOJ7vPKuw4/EF9N9OSeSITONa9Wwj6uT+F/CtdrdJpN6X2k0yxX3YZ0GPHuUa1TC+au/9FR5u0iDpPQv0= X-Google-Smtp-Source: AGHT+IFVBhIW+FkkyuzqZVowBt5hiqoz6NO6RvUOU/H7LKkff9WRJs4MOOXtXHIFsG/le8OWiT6l X-Received: by 2002:a05:6a20:7495:b0:1be:c3fc:1ccf with SMTP id adf61e73a8af0-1c29822d17fmr6016786637.2.1720619865548; Wed, 10 Jul 2024 06:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720619865; cv=none; d=google.com; s=arc-20160816; b=tpuwmGHwehknlgE8dxhqiI/KWArUnNNEkhPkQ08QrZijJuN6Vzrz4HSOsyR/6+tawg uLAIktP+vonbz0s/Pg/u91AXjKOCGH4qf83be8JOMqQJdcdwtNPgUmRUgghI/FzK+0BH KMMi9k2a8AU8xB1s4ky2KNzTVlj8utdnKUTLPo1lvzbAxJTHAFFNFQLP6gkkxm3/uqEz mwBs+sREpwIj/0+hDBDwXlvI8wN41CELWU7tAdhCEgQUhp7V5J9uSBGIlY2sUCyKU3c+ OltgfjhtMIsPSqt2o5s2OE18ajHIKsqUYs20JsXnLGH0HsJaQ3nY6RIPJdt7lOOz9Cdc 0XcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=a88RnHifFmdIa8IvrZcJA79coYaMO9jWgbbAJxQOS3A=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=eSaHLZ/qix3TLHxVMGz6fImgRvW32FG5Rqq9V7UhzU3PfmRXZSVv0XKCsZ8wTibRdI C45/QzFUlfOxJOVjZaOsSPxpJ9O0EBKxO8JeMlaSkXJb+2Y3HobxSXL1a53Iyse/tb3Z /iLREW50ln+JcPJr/Z7WhYM+ULcV7FrWRc2W1d1b6JZMmZzMxs3Ypixm/3cvp16Le6mj xfQuhGca1turfiFxQzxMjCz7K+fPNOP+bouyzwhdv8GVOJbIFGFGjiMVtgJmbzcTmezt xuSeeNMz59PwBf1+5Yp55jfJTBGxzF3KembIFoXFi/U1rNJIIxeUGyZUEcnd0aFnBMY8 CrCg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=d2n1Q719; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=X1UFiofM; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=OeCgiblU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d2e1a72fcca58-70b43910cdfsi4082936b3a.290.2024.07.10.06.57.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2024 06:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=d2n1Q719; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=X1UFiofM; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=OeCgiblU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sRXoy-0004R8-Sz; Wed, 10 Jul 2024 13:57:25 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sRXow-0004R2-Cu for openvpn-devel@lists.sourceforge.net; Wed, 10 Jul 2024 13:57:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d5EpEHXMj1cNXYoMpwsCpU8hWJ42gqaB+0RapMxvjK0=; b=d2n1Q7190X1UPbZuh5Ff9ZvArL wn9Q6dizObdBydMbLE88nKFdYvIR8T0Vbds7lM/SD1oSM4tqV9rL0Cdir3A3d8DxPpZYGw3sWrt1D vZgUG9vIvfCouYsroO6muaiqTgswuuAo52VT2wC7y2Lfg77L/ILLGtqNKRtGV2LAn4ao=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=d5EpEHXMj1cNXYoMpwsCpU8hWJ42gqaB+0RapMxvjK0=; b=X 1UFiofMAmWPnBpKxxKVdy98DXPncMd2x1Fa4ouLwkU57S1B74knqwrimZPBt4wsh+IBgQai7HfI89 0p1s7m3PssJiSShLZnhdjRHRYSt2e5w9iLWfJ0sJZFMSf+n+VM/5fMsgCZygfrEU23wD28hFrOUsG n+2frT97uoxn4wr4=; Received: from mail-wm1-f54.google.com ([209.85.128.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sRXow-0002Eb-Jv for openvpn-devel@lists.sourceforge.net; Wed, 10 Jul 2024 13:57:22 +0000 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4265b7514fcso5245185e9.1 for ; Wed, 10 Jul 2024 06:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1720619830; x=1721224630; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=d5EpEHXMj1cNXYoMpwsCpU8hWJ42gqaB+0RapMxvjK0=; b=OeCgiblUsyyfE2TSbImrbGVUxgLBz25o/wqdSqaCF4yAZaFoaIh79QYFWljhfP11rJ Y6H/A62FO9J7nkBr2WtVh8QWq+K9NHwoR9Otp7eh4HCLzZIUMqxSJTQec/ncM4XtFRx1 TVlsdGeIn7+icYuO494YJsAwBcIWxjIjS1m05R6TridnOjJXWaX/85VUSsrcYdvRusO9 ReiWQJ5V56bo1JDzXqMjGn/nr8y2SKwp7M0Xvb6gmd2ShIhdQAb8tjVfqUub9/9nmS5V 3tloJ48LdsXRMz2i52sGZcsBMHacw1zK6YmZIVH/UATvAfuF/mm+A58Kix1WjjOaN5f2 /Glw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720619830; x=1721224630; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d5EpEHXMj1cNXYoMpwsCpU8hWJ42gqaB+0RapMxvjK0=; b=IK5k5x0qM1GonRou0R7gmlsplhf7B+yq0W4pk5Lx5yfE9QTIGwWP8uWIN7y3IKliVX WPfCBCkwAU/wh/GH98z57fM97JI5OFwQsNzQOEcfs2vze1ZUXoTdy4esU+ylWDnbnoaM +b366bsjY2kfqC0yZ75U0820GanSp6MJ1wvjNC5g2nfrafj7QWtCHKieqAXbLvLZIBAf Sbmt4dCXQTSW5uNvTlwre7oY6z/40qQCjYxwMpMmbS1rph6aHbWKcMijTiiFfDoQfRPP 4Zs5UiGV7oAgRRKar+0b5DTMAS+iQ1sGxbdWyaIq/oVA/oHjYuFcN6JzZKLiluNDkEEz 3t2w== X-Gm-Message-State: AOJu0YxSaNqLMkOZ5dIFaHS6bMX3ihjFEJa2HiwCWxOe+iw+HJ4/8Wzd Y1V2Lk/B/9+lsBYqDyZvpVRN4XFDVDcmlNs3J15bwkx8k0+s3NKoWAjTPBeEriTy4MwdTV+yQOv m X-Received: by 2002:a05:600c:378d:b0:426:6981:1bd with SMTP id 5b1f17b1804b1-426722d4b4emr44827975e9.5.1720619830319; Wed, 10 Jul 2024 06:57:10 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4266f6e0a07sm82936575e9.10.2024.07.10.06.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 06:57:10 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 10 Jul 2024 13:57:09 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I7927a572611b7c1dc0b522fd6cdf05fd222a852d X-Gerrit-Change-Number: 674 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: a5658d7ac42930c03083f46a22b76f79e209225f References: Message-ID: <93a0b05c76fa2aa87d9e032b33efa953055208af-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: configure.ac] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.128.54 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.54 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.54 listed in sa-trusted.bondedsender.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.54 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sRXow-0002Eb-Jv Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Review use of standard AC macros X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804200695916879911?= X-GMAIL-MSGID: =?utf-8?q?1804200695916879911?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/674?usp=email to review the following change. Change subject: configure: Review use of standard AC macros ...................................................................... configure: Review use of standard AC macros - Increase required version to 2.60 since that is documented minimum version for AC_USE_SYSTEM_EXTENSIONS - Remove obsolete macros AC_C_CONST and AC_C_VOLATILE. They are noops on every compiler we support. - Add explicit call to AC_PROG_CC. We get this implictly as dependency of other macros, but it is nicer to have it explicitely as well. - A few typo and whitespace fixes. Change-Id: I7927a572611b7c1dc0b522fd6cdf05fd222a852d Signed-off-by: Frank Lichtenheld --- M configure.ac 1 file changed, 6 insertions(+), 8 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/674/1 diff --git a/configure.ac b/configure.ac index dcc46e2..3e7c0be 100644 --- a/configure.ac +++ b/configure.ac @@ -23,7 +23,7 @@ dnl Process this file with autoconf to produce a configure script. -AC_PREREQ(2.59) +AC_PREREQ(2.60) m4_include(version.m4) AC_INIT([PRODUCT_NAME], [PRODUCT_VERSION], [PRODUCT_BUGREPORT], [PRODUCT_TARNAME]) @@ -387,6 +387,7 @@ pkg_config_found="(${PKG_CONFIG})" fi +AC_PROG_CC AC_PROG_CPP AC_PROG_INSTALL AC_PROG_LN_S @@ -443,9 +444,7 @@ ] ) -AC_C_CONST AC_C_INLINE -AC_C_VOLATILE AC_TYPE_OFF_T AC_TYPE_PID_T AC_TYPE_SIZE_T @@ -959,7 +958,7 @@ [AC_MSG_ERROR([OpenSSL check for AES-256-GCM support failed])] ) - # All supported OpenSSL version (>= 1.1.0) + # All supported OpenSSL versions (>= 1.1.0) # have this feature have_export_keying_material="yes" @@ -1059,9 +1058,8 @@ elif test "${with_crypto_library}" = "wolfssl"; then AC_ARG_VAR([WOLFSSL_CFLAGS], [C compiler flags for wolfssl. The include directory should - contain the regular wolfSSL header files but also the - wolfSSL OpenSSL header files. Ex: -I/usr/local/include - -I/usr/local/include/wolfssl]) + contain the regular wolfSSL header files but also the wolfSSL OpenSSL header files. + Ex: -I/usr/local/include -I/usr/local/include/wolfssl]) AC_ARG_VAR([WOLFSSL_LIBS], [linker flags for wolfssl]) saved_CFLAGS="${CFLAGS}" @@ -1252,7 +1250,7 @@ [PKG_CHECK_MODULES([libsystemd], [libsystemd-daemon])] ) - PKG_CHECK_EXISTS( [libsystemd > 216], + PKG_CHECK_EXISTS([libsystemd > 216], [AC_DEFINE([SYSTEMD_NEWER_THAN_216], [1], [systemd is newer than v216])] )