From patchwork Tue Aug 20 12:25:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3793 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:21c2:b0:5b1:8b5e:23cb with SMTP id t2csp376129mae; Tue, 20 Aug 2024 05:26:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXrdq9q/tTTkQbjBKw1Iz40gHr3n5oR/XGx3YrIfTIG2Be2vuYnlNVoGmjoGD/HKp4ZCaULq58YfRM=@openvpn.net X-Google-Smtp-Source: AGHT+IF7cks16+G1FmRGF9eKTEVofsijiEbAfRbiXWpFR66hy25W223rPz2tqdJtmwUrIUDjuHGU X-Received: by 2002:a05:6870:b6a3:b0:26f:e09f:6090 with SMTP id 586e51a60fabf-2701c519f9amr14590376fac.37.1724156767561; Tue, 20 Aug 2024 05:26:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724156767; cv=none; d=google.com; s=arc-20160816; b=nlnrjSWvCw8FE5Vv9WhZ2byUoYQi3f8I9PYbY2mTkEtMk51skgMcm2aaZ0glrv9d3i e4x0p9ZTVAJFnjndg6TWw2YVUsmN0F79ULUE3kbhtf3He21xrjv1gXsaKdHEjNvZz1XS ff3Ql5cVnCaNzwkXApx9GJw+qQVO/57Uc2N7OD9GsYWPY7RQXpNqM01KbMLJ0c8D/X1L 9vtTEVepBvtDj7KCI7RujzADVUY2EmzCt41nW/vvy3QJ46bRqZaTM9FoRGzOBn+vYrRl 5EqEcviXTi/eQ/VeVvylSBtjUnkojc/TNaIgg4SfUokHal3sQHkbgs45dwNeUBqk1eF6 K4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=gYTk0Z2A2AE8qtrOBjMZtGMHHeuI4TI9ogDCIfbjal0=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=T6l6MEiXskPlpGDCn0UWGDDUQKyhRQVTlKCF4eLgO3exvGxEFHF6+E4IcbLpQ0IpfJ 8hpunr/JmNTb2UMjqNwafaY5X9XlhJ2ug+sCgYmuSlewgPE9uOD5s38zst/oO0gEfRWV RmqjgTHKvGhOsRqc+5AXGgn32sp5MRNVibc47WDaxmgabV5Y1pvBr+t5uJBTkn4bAWov a+sMtuuZlfCjrHohx/K51UP5/HXYP1bX3wbAteHomgMJfJKOeHCYMnPKHqLqfpjkYcTO NIxMk5NBs6RQziKieBQa97m5JJ6aLShfBj+D48WodRpe33TBLth7bzD+gcyipw4rWZ7b avQQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VZiRJdXP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=iUdbQGzq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=GwGBYpc2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d2e1a72fcca58-7127af48a6fsi11509428b3a.366.2024.08.20.05.26.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Aug 2024 05:26:07 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VZiRJdXP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=iUdbQGzq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=GwGBYpc2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sgNvi-0006RN-So; Tue, 20 Aug 2024 12:25:42 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sgNvh-0006RD-P2 for openvpn-devel@lists.sourceforge.net; Tue, 20 Aug 2024 12:25:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rd3Ll3ytRsA41AG5OxqcGnzSstu9VxCEzeETs+y2C3Y=; b=VZiRJdXPuuyDrWMh3norWGCyuo cPt5F3p67AZXPFk0h0cht7THv7bWVipYrieJUXS09OuBd0wvPRV/WkhmmwRjxps/kVvGW92Yw964E TNRQkt942hceYr5ZEwJR77fM7g9z9hspw/Trtbs3of4tE+lmalE3e+RyIZvPgchyhBYY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=rd3Ll3ytRsA41AG5OxqcGnzSstu9VxCEzeETs+y2C3Y=; b=i UdbQGzqYpzE4fCsXATsb19daGFrijPt+4eCvWjkJDM6wvIluQQYq3jFiLlliHuR+t3OuQzS0Iysah m9dr53AzMxR76jttRPeuiOm5tTAko8rcjvWRRgaOKoe2U73Ac6vo90EVJtrNfUQX/fL4I/CXDCvGl yhgZes6EPN3ia9Y4=; Received: from mail-wr1-f53.google.com ([209.85.221.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sgNvg-0003RT-Sn for openvpn-devel@lists.sourceforge.net; Tue, 20 Aug 2024 12:25:41 +0000 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-37189d8e637so3261491f8f.3 for ; Tue, 20 Aug 2024 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1724156734; x=1724761534; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=rd3Ll3ytRsA41AG5OxqcGnzSstu9VxCEzeETs+y2C3Y=; b=GwGBYpc29QHn2Q2CINuv+aPcYWZINMJzvTYo5FZMZ7nV0xDutY4971p2rnIGuYLyYH vMyIZsf6ju6GJOtLSznLRXtQVUnyfM9WJx5eolLF5RK6li8UQyx82cHrVoD2gHxURhQ/ gJthxZ3IJYZYosbAntkFYIm8hT8z1QS8TVwc3eIbLx7Qn7jg7RcIv+A79itaQrzB0qFT +fnNPKtENe5TCkG/khdyqvfru/gED4utTDo3VT6/mxMGiwEpk/AisXQNsillCNW+YUG8 z+994akk2nr9QIElpx6YOJ3GkQzCoctJcUqKHYHiElrMgxk0oCKk46vbEkIgb1b+a9A4 t0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724156734; x=1724761534; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rd3Ll3ytRsA41AG5OxqcGnzSstu9VxCEzeETs+y2C3Y=; b=I1kC1opGfBIa2No4gQkIiqmqFVG9yuuMCSF73IqhtPumabDk4j3tptA9HnDaG15d6u Txh7FuYsX/NFSJxAyw3Js4ps+sTzTvI22FvkLbX8cI8IoM370ygNe7UxGzBA8AayqXQ2 EHcOuHHA7LtXppAPxqsYIZREyc5xXBc8AeEU50ao7EgPSUkLuTmthMVOxx/B51XRp5SS s09H0oE7HmiTXzpzy8GcBvaCuu+w9JxD984H4H4QFH2sQsu+/ps7YDCgrP2tU58lQnlU CGbmpXiVXCiyU2cbCGVZw+SOW5H1kXFo7KPdMKIw3RGW4OdBRN0GRmsk4+Si+ZWj3efE gqYA== X-Gm-Message-State: AOJu0YyTtKteYvTfVkR+PfghIWNsm0ToKv5d2DNmMItau4G3WptewmnW ErL8Yan25YUcdzeM3CVhXbHEbbq8pPfmt+aLzu55NcbMLkxuHFKRIV6Aw1bbTRM= X-Received: by 2002:a5d:5110:0:b0:34d:ae98:4e7 with SMTP id ffacd0b85a97d-3719469531fmr8724096f8f.41.1724156733752; Tue, 20 Aug 2024 05:25:33 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189897926sm13039446f8f.87.2024.08.20.05.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 05:25:33 -0700 (PDT) From: "mrbff (Code Review)" X-Google-Original-From: "mrbff (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 20 Aug 2024 12:25:33 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I2f018ffc3e067b7967289a87e06f730de0d7e8a8 X-Gerrit-Change-Number: 732 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 33a1395f232f076891290c3016366fb71c2702e1 References: Message-ID: <9f39214e2d65c2f1a2b15374587f576664c1c939-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.221.53 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.53 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.53 listed in bl.score.senderscore.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sgNvg-0003RT-Sn Subject: [Openvpn-devel] [XS] Change in openvpn[master]: GitHub: preventing errors on GitHub Mac runner images X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: marco@mandelbit.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1807909406871526515?= X-GMAIL-MSGID: =?utf-8?q?1807909406871526515?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/732?usp=email to review the following change. Change subject: GitHub: preventing errors on GitHub Mac runner images ...................................................................... GitHub: preventing errors on GitHub Mac runner images Change-Id: I2f018ffc3e067b7967289a87e06f730de0d7e8a8 Signed-off-by: Marco Baffo --- M .github/workflows/build.yaml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/732/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 6e361d5..616b322 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -249,7 +249,11 @@ UBSAN_OPTIONS: print_stacktrace=1 steps: - name: Install dependencies - run: brew install openssl@1.1 openssl@3 lzo lz4 man2html cmocka libtool automake autoconf libressl + run: | + # Unlink and re-link to prevent errors when github mac runner images + # https://github.com/actions/setup-python/issues/577 + brew list -1 | grep python | while read formula; do brew unlink $formula; brew link --overwrite $formula; done + brew install openssl@1.1 openssl@3 lzo lz4 man2html cmocka libtool automake autoconf libressl - name: Checkout OpenVPN uses: actions/checkout@v4 - name: autoconf