From patchwork Wed Sep 11 14:33:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3824 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:24eb:b0:5b9:581e:f939 with SMTP id o11csp259668man; Wed, 11 Sep 2024 07:33:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUpSSBOfg4Ji/ktt23xOg2LvM7Nj20mxIncSC7s+IYI75uk1Po6rtUdwKVXdfi6c9t6yEX+ELEzzr4=@openvpn.net X-Google-Smtp-Source: AGHT+IHAMUhgS8s+ZCrkESz/ThiZS4qD62PVRLT7JjLJZxv682CIAUeWtUGZpCEyUExuhdhZqlDa X-Received: by 2002:a05:6871:299:b0:277:bff8:cf5 with SMTP id 586e51a60fabf-27b9d8b0e2cmr8939541fac.25.1726065238000; Wed, 11 Sep 2024 07:33:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726065237; cv=none; d=google.com; s=arc-20240605; b=NH1elBUKr2H5ssI6mnaiit12+yaDdHQoGI14AjeOFGpaY7FKbsNtbfL9bVi6PGL6OL YRIsenAsSs6rbh7QnHzrQEe0D3CIjvE/b8l+IVNgjC9N052lHJLuiaUDmaj60Vw+Fa3g dtxpANguwQJe68LhtZnAfJgrSaTmrjFJgVEdWKU9sOf51fP7eUcVQpEcx6bZlKM8rCXZ fgBoOKUTx72d9tkk/hFdJCtWDBCcJfUjUN5ubbE9aynbuUsy7dcQEimCWn3gLU9Eswpp l3V6E+UpJ2aDJWtaVgKG3+G1h1UhYAD79GnN15DC4s2qfoCHbklNbtFKdlBSp5U7mD1j rW/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Agzk+q2yveAc3Toj+48T29ddA23GSTHTwPhBnyK48Xk=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=lOJCiYGODxEAzniG9Wv6gncObWZnoM+93nQGRRhyKh3aE13P3lFfuNCsNw1+tXvE7S E055gk/AUFz1Yl7+7p+t9vXdNKe0ocrtvyuonn1OVTM4oh1qU4W+b7H7qoRi7qhK+89K F4O20P7F6p+D3i/9ElIXOM+JYCuidF6/U0XyP7SxzUHjwjbvDVnWKjc0e2LvtwaSNWDk MZFZi8XYkz82uSo1zbELcBM1wPZvz3Oq24jC00ytpuhPAw++5pCY85E2al/fkkj2K8dP ffFbgpN+DzbKOO/wSUT3XKnAav8XPeO8NIs8abaP5J4Ws9IXQv+8e2YYnLi16heT9Hj/ 5YSA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gixNTdjf; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ejHTQS64; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="HsB/UIIU"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-27ba419bfcdsi4708421fac.311.2024.09.11.07.33.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2024 07:33:57 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gixNTdjf; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ejHTQS64; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="HsB/UIIU"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1soOPo-0003TJ-Gk; Wed, 11 Sep 2024 14:33:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1soOPm-0003TB-Ng for openvpn-devel@lists.sourceforge.net; Wed, 11 Sep 2024 14:33:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l3lLAei//fnU2c3uRb7dgOAsukn9e8OlwsJZqPDDHkU=; b=gixNTdjfPS3Obkac6cBfi93TaM ThDys9HbwCWGrFgs/j1+MMzWGk/3p8AYc0NTCcQp7IDcdK87CXjapFjKED+1YXZgbYo+Yc5RNo+O3 QTMS8Glq/Q8+Uj5nlUxt+wiiZqS1uPKLbsy0oS0KNQGfwYxn5ibrhNfDywLg4gL3T0Ds=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=l3lLAei//fnU2c3uRb7dgOAsukn9e8OlwsJZqPDDHkU=; b=e jHTQS64dvbvpGbMLrCI1Ik4wqj1L3Q6xTNQEfo3yesBCRT6rE5ykL8Xmf1W0b0BeEswItNCTdg7U6 isEElbGZdR+3X2/h/sPZkqVXjBlg6v/ogr7zcT1bmKgq5KWJLxcwgdkamGzHa2q2v5r/WYxqBzs6A 4m85Pt8+CDtRvxrk=; Received: from mail-wm1-f41.google.com ([209.85.128.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1soOPm-00081G-7l for openvpn-devel@lists.sourceforge.net; Wed, 11 Sep 2024 14:33:51 +0000 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42cb6f3a5bcso3261665e9.2 for ; Wed, 11 Sep 2024 07:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1726065224; x=1726670024; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=l3lLAei//fnU2c3uRb7dgOAsukn9e8OlwsJZqPDDHkU=; b=HsB/UIIUE6Y7Ehz2rKRAg97fb7MWX7bs1M8R0QcKnGNsrojfFURSEw/H0sGDkfdE0E gYBq/J2Ecn8uO25uuWN0t325qj51X9OYQfaRpoDmjmMsH2dtKjV42Cqvl57nVg7VVjb4 T5rDGFbzneoWqmiOxGZOrFsDNJQXUQUmNgFabs7wO7F3mmPM42imeul83rt0m+cDXcuv FHy4CIViU8VPKEOMzuFOk3UKOa4nKY1QdJfGWx9eKRRSTbgsDALvj+LsYHNVXNAKw6UV z1smgjD9R+8TI7I49/Z2K/dNaBc22UjOabGMOIddfE74+VWpBGjgiUvZ8+qdK90McYXF dPrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726065224; x=1726670024; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l3lLAei//fnU2c3uRb7dgOAsukn9e8OlwsJZqPDDHkU=; b=XHriJb4WMM0+KzF8cdliTkMYoKyLR9xP5wKS/A073BfB8M0Vv/j5pxJBfa8VYaMNEO HBSniEom1Gu28FJkO7SWM4cVMBLWUKg1WC4qmP1rSnTWVfbKH7IBuqv92CQsDg/L6Yp8 CC1JyUZR1FnnyLsefQTuVE5U2mvPo6R8v8GCZhwpMohq9kQ6p69l+ju9oNohHARYkTFp MKo+yE6JDS5TEMsMLBAnMbT3UQLf2490ZqDtHOvMK89IeeKg4RWpMsE0mR2WgnXva/HL WWAxWstjmAbv3AbiYH+KVHkq+BsQzli4SkjAVYN/5ircp2CMYoq2PaychrfjVyPE0j1w 9wVg== X-Gm-Message-State: AOJu0Yzgrj2iVA5dGHZ2pY1WJkdQWytqU6f2vOy9ll1MyowyVFgleeB2 JCUCqUdWxPwqBHSJFtOlgiAHISOaorQ/YB/fqdO9PRZ7s5hlzMxYmy4Kztn831ZZeD2/iYEyrMD C X-Received: by 2002:a05:600c:a48:b0:42a:a6b8:f09f with SMTP id 5b1f17b1804b1-42c9f9e0f8bmr157824795e9.23.1726065223070; Wed, 11 Sep 2024 07:33:43 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb43d73sm150163805e9.24.2024.09.11.07.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 07:33:42 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 11 Sep 2024 14:33:42 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I86203b8f9a6d3cfc5e56d3ce9452af694fd11011 X-Gerrit-Change-Number: 743 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 41ac9ca5d0b3b3a957b9c7fcaa3757749ff72199 References: Message-ID: <73512253abd82a644d72f5c297ac252926f6e0d4-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.41 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.41 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1soOPm-00081G-7l Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: Enable t_server_null tests X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1809910582603720394?= X-GMAIL-MSGID: =?utf-8?q?1809910582603720394?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/743?usp=email to review the following change. Change subject: GHA: Enable t_server_null tests ...................................................................... GHA: Enable t_server_null tests Change-Id: I86203b8f9a6d3cfc5e56d3ce9452af694fd11011 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/743/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 8f0a7b5..361d457 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -172,8 +172,11 @@ run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}} --enable-werror - name: make all run: make -j3 + - name: configure checks + if: ${{ matrix.extraconf != '--disable-management' }} + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check - run: make check VERBOSE=1 + run: make -j3 check VERBOSE=1 ubuntu-clang-asan: strategy: @@ -199,8 +202,10 @@ run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} --enable-werror - name: make all run: make -j3 + - name: configure checks + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check - run: make check VERBOSE=1 + run: make -j3 check VERBOSE=1 macos: strategy: @@ -258,8 +263,10 @@ run: ./configure --enable-werror ${{matrix.configureflags}} ${{matrix.configuressllib}} - name: make all run: make -j4 + - name: configure checks + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check - run: make check VERBOSE=1 + run: make -j4 check VERBOSE=1 msvc: strategy: @@ -369,8 +376,10 @@ run: ./configure --with-crypto-library=openssl ${{matrix.configureflags}} --enable-werror - name: make all run: make -j3 + - name: configure checks + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check - run: make check VERBOSE=1 + run: make -j3 check VERBOSE=1 mbedtls3: strategy: @@ -422,5 +431,7 @@ run: ./configure --with-crypto-library=mbedtls - name: make all run: make -j3 + - name: configure checks + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check - run: make check VERBOSE=1 + run: make -j3 check VERBOSE=1