From patchwork Mon Sep 16 13:04:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3833 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c41d:b0:5b9:581e:f939 with SMTP id jt29csp1191574mab; Mon, 16 Sep 2024 06:04:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXmaatWCVqGNgBziqZh119Ym4Rrk/CTSzHoI/sMS6Z1ukfWPZGvJn+QmbETpckQ3XlDcqc4TPXOaCc=@openvpn.net X-Google-Smtp-Source: AGHT+IGuPfHk4fomIUHHmCeyKf4LMYtENMyq+MJRDy/bqSw4Tjz3CAXIQA1KPKdwHJRitLIuqEw+ X-Received: by 2002:a05:6602:15cb:b0:82c:d744:2936 with SMTP id ca18e2360f4ac-82d1f80b5demr1649171239f.0.1726491870157; Mon, 16 Sep 2024 06:04:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726491870; cv=none; d=google.com; s=arc-20240605; b=IS/eyDm6w4o3KYnEnwKm/JAz5hiyyzLhcWhgKhe02zfezSo1+53N3p3wbA1Dyuc87n uQKMll2Bc9ZmumbxkxDBFpZjbsGOVn/6rzk9e0GBi5Cb+8MmkeDiwc+jufUriDhrqFFm oZYp56FspZDr7rJ1lGGftrsxSZKDppTrnqiDclrgVZPkuFJsxU5tm4n+v1ZY+AeiONdk ya7kzNFOAB1z8IDINT6p8OPcq+ldgfYbVsYtesOktFdqcz6Iw/ZuY8lWdcomG+vIcpn5 8dyzZEZi6ysuEVbBA3UgHnNddt6UrOfxald3VQWHIP6aTTOpLklrRWhBGOvVJunnH1eE 3jGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=5DCH1VQx9VEm0tQhgNE755jr3SDoVUD1WBrhSNiUQwg=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=FL6kvhsyN9CzMBVjgts6FdiFDBJjpJix17LEpOSEbhjIC1dNcjRVUzOCSVLBNag6NF mAVg/uNd99mK+ywetfSGqQpu39w1sXM5p41VHTYRMYGMIo7050HkCr52EbJvkoBB0zgV eIExYDyqrovPItobembh5iyO8Fy8UTOCUk8BWipFJ29h0G325jxR8pjiaXSxJ8FRTl15 ej0Mycc3OCueUrSC66LR0Hy7tNd34gfHc7ClrA3SoWYl6/x9jumu/BNXirDsZ0X+RtiP 2WsmQIKt7ui5nQyfq1gAeUAYGx1LQjIb2KCx/LSj6IX8hOujV+k0jOjCdPFhEwoYspYn F6Tw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EUu4NuBF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="MBl/J0p1"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Fk/YhHRC"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 8926c6da1cb9f-4d37ec054aasi2624387173.40.2024.09.16.06.04.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Sep 2024 06:04:30 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EUu4NuBF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="MBl/J0p1"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Fk/YhHRC"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sqBOo-0006cF-Ag; Mon, 16 Sep 2024 13:04:14 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sqBOm-0006bz-R7 for openvpn-devel@lists.sourceforge.net; Mon, 16 Sep 2024 13:04:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eCcydmDMeeFqKbQgZKDR6Db7VnlCS67+AkkupPJCvHc=; b=EUu4NuBFn3z3vqr1Br/NV2F+se XChiNTvIuRCpujgjhu97dHI+PzVKM4NKHpH1aFrOqaaG61NtHeFyqERtvUMbmN0h+NONKhRetAw1A KUbf3vA1AH/tz2phWNE0DE9A0CPwRTAgUWMmh1CVd50Xz1iQDr2w9Fq/cryYYOldNKJw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=eCcydmDMeeFqKbQgZKDR6Db7VnlCS67+AkkupPJCvHc=; b=M Bl/J0p1H9F7MZK+GC0zcGmBeWXWXIymXY+8tsAsyXKuOscp4Wk1bqbwT9lQ6J/duJENfhhrOvHZjs IDN6jKf4gdGDDFPZRyKDRSnHOM/xTgVNhO2M3a0DH7HFj/9EaMyzMyyUt0IAeoS3ZX7HJ0n/fafYb JvbL0BFXfc+823TI=; Received: from mail-lf1-f52.google.com ([209.85.167.52]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sqBOl-0000wt-E2 for openvpn-devel@lists.sourceforge.net; Mon, 16 Sep 2024 13:04:12 +0000 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53653682246so4993751e87.1 for ; Mon, 16 Sep 2024 06:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1726491844; x=1727096644; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=eCcydmDMeeFqKbQgZKDR6Db7VnlCS67+AkkupPJCvHc=; b=Fk/YhHRCKV4e0sIcM1UVX9WehrcYxGmIOeiyGqT/G0e1NWnkIhW42qVfc2FUzzUHqW N19lKg1VBBY4VL9STxu3ikmLrpS2T54Ww8z/Isxi+VyqkiIHOcXuDCF8pnPoZostVgVW i4kIYq60TJtpE4QPoFKeZ8HIotTobT6HKTeIbfGJXUihMdW+PN+Xav436Bj6so9cD9CP xjrCl3kq93MXt+fL66pdDQVOUUFvc9bqzrUZ7OJnFmRzNa6QmAQm6NtrRcsZ1PizTkmu 3Y/5fRwpctI3RdWVo0KWP6LIZHmU/oWRh8au4jNClJs+tAFqplP7g8G4/EmEakGizwUd k1vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726491844; x=1727096644; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eCcydmDMeeFqKbQgZKDR6Db7VnlCS67+AkkupPJCvHc=; b=GeNaCYIwXIe5K/rzOaQ8919CJAA1oMhm40O9aYcj1DgbLleJd4kNqv8zok5uhAtxr1 LkOTvuP5HUHkER8ArBx3+LDP/00CtQY/jReopnOL7EA1ecV2fND3dHSy2Rn5Z7CNlSEz NSddpRbazIlE0yyYvQnWcx4ThRTNRO7GOPLUuSQ+NrWV3SQOkYkcXI8JQIng4hrKhCur 2M+WmRDrjDbLhtmxMmGJHur5GYcr/m5rVkWodVzfzurkqHQDl0jAYXKsqYQVFoehSE2I xmJlTI3rU6SrdpzI0jWzRa0LMrb54lIgHu3th4nkcgrvEMCk5W1xxluXVKlSTI8kEEEV C88Q== X-Gm-Message-State: AOJu0YwIgc9KAmJKQZntmLZQou/aEgpmwAjo58wNl7Q+h9T5esDT0cyv m3arJ8cfGCA+TwR3f7G5iEyabZmZe4baQINWCpP8gyuG3+KBLvoqglTjtYj3omMYNIrTvs0yo0V I X-Received: by 2002:a05:6512:e8c:b0:530:e228:7799 with SMTP id 2adb3069b0e04-53678ff3267mr8837045e87.58.1726491843263; Mon, 16 Sep 2024 06:04:03 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42d9b1947e2sm114212255e9.44.2024.09.16.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 06:04:02 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 16 Sep 2024 13:04:02 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I028634dba74a273c725b0beb16b674897b3c23fa X-Gerrit-Change-Number: 745 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: f893a0fb4b48eed6f06a9d3dc527a23272c83f14 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-1.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.52 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.52 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sqBOl-0000wt-E2 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Make read/write_tun_header static X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1810357939098857774?= X-GMAIL-MSGID: =?utf-8?q?1810357939098857774?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/745?usp=email to review the following change. Change subject: Make read/write_tun_header static ...................................................................... Make read/write_tun_header static These functions are not used outside tun.c Change-Id: I028634dba74a273c725b0beb16b674897b3c23fa Signed-off-by: Arne Schwabe --- M src/openvpn/tun.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/745/1 diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 1f0eadd..0832375 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1822,7 +1822,7 @@ } } -int +static int write_tun_header(struct tuntap *tt, uint8_t *buf, int len) { if (tt->type == DEV_TYPE_TUN) @@ -1855,7 +1855,7 @@ } } -int +static int read_tun_header(struct tuntap *tt, uint8_t *buf, int len) { if (tt->type == DEV_TYPE_TUN)