From patchwork Fri Oct 4 06:03:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "flichtenheld (Code Review)" X-Patchwork-Id: 3885 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:731c:b0:5b9:581e:f939 with SMTP id b28csp260240mag; Thu, 3 Oct 2024 23:03:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCURbhUETCP2Ra72bQNZsEHbh6LtUk8QrPawT3px2JbuAbXDVRYoIoKQwmfZ2HjksfNSBsi5IgOd1I8=@openvpn.net X-Google-Smtp-Source: AGHT+IHfHNWWv8pYJRY2I+LZ2Gjd0tknC7X6yhANPPUTSb5Y3jQk2CIkAjB/UejHz4ccx6n7heXF X-Received: by 2002:a05:6808:3c8b:b0:3e3:9a29:c6f4 with SMTP id 5614622812f47-3e3c219bdb5mr766124b6e.14.1728021822659; Thu, 03 Oct 2024 23:03:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728021822; cv=none; d=google.com; s=arc-20240605; b=SXPnCr7m7YPexnyKLHIwVOsFg6GKxKT4F2kIOA2DRipFOTIo+z2anQCH7IJuhPzCYV HtjWULjBJx7j1dS+6+JoUaM3QMmMOSscTFswHdCtH99ngNNsfG++3W+bPvqK1n+gDdT8 sO+3j8CNQtr6d14Smv2Phvh7um+o+tluUtMK7XXBKNiSOza3LmVFbQ4bzxtL2LX/rIEB zO3to1lq1dd0B2slz2rMyIzivV3Ccc9xD+cx+AqKBeX5jorKToNguxcHoFJMKonwJ9ia 63OErP9JaEmEPfCf4dBv0NjGcNTzPnPTaEiOs0FKi15LOTTQWRXGM6fxi8fWQw5U5f4M ZkNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Z0qlUQSW8ag+7F6+GxeW/Bc1jHq+qC2wU/GrFSYt59E=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=CWyUDcDYRGZPrjGnc1g2rFQTnwRpjdmt6PsraEBIj65sr45ubMy8/WxUuYAi8x49YS G8hQsE68YOJdTo3RsmrxilEy2scMmSFA3zNLHGwY6GJkXRs1uBr7kELVTQsswGzh5V3J ltrApbrEXBBiSjy/nrWLkQqKp4lsDZhv7dk7lDzzGcN5rUEk+TpvO0OTjQ4cWApTb4qy u5fGBmEHmnamhht72bz/tOJDCNw2pmjTbOrMnE+/hsFUklRKvnEwY7Y+BUqXYSqiVOnA jcau1fWFkuL/EyvOUWpEyK8G/ABVmIGMyLSIm5cNdjeRevdKsRAI8rxxTiQctnOCDjp0 aUJg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HHWtqeOw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D3JnWeC9; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=CT8wPCTp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-3e3bc361248si1306826b6e.48.2024.10.03.23.03.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Oct 2024 23:03:42 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HHWtqeOw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D3JnWeC9; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=CT8wPCTp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1swbPZ-0007of-R8; Fri, 04 Oct 2024 06:03:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1swbPI-0007oM-85 for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 06:03:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9uT0gyq9/27a0mVA0jNvIMvzrZ18n29ZzLq7ol7CTAw=; b=HHWtqeOwjgztdHmNtFxpjmlGcf ufsCs6Qt26AUfgu0TbnB9GvMBUZsS2oAuFYiHGCFzIqISvdmCNt+VkVb/fZHHYfmWGFcSQZZgaD7K cVbwwYFP2Wi1BY8fYIdWTjnNvQEE/dtPN26YyZfK0eNXLDmYsnZiWQf+HyJPUMR31Rgs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=9uT0gyq9/27a0mVA0jNvIMvzrZ18n29ZzLq7ol7CTAw=; b=D 3JnWeC9H9zWMBQP1sc45bswqBMe/hxXcqIzphH1rFY1h7glwoT8SCKstiDQhyWZDz4m339DrM9uOL qmoBBd0gedxUJ6at8Rg7y5Kp3GSrwLXqg+EDO+7Vp6YJpBVwA2mpBRGUlQxhZm3akSR4YHdZW0f5W BExyxro7rGHV8FhY=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1swbPG-00020m-JA for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 06:03:15 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42e748f78d6so15747455e9.0 for ; Thu, 03 Oct 2024 23:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1728021783; x=1728626583; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=9uT0gyq9/27a0mVA0jNvIMvzrZ18n29ZzLq7ol7CTAw=; b=CT8wPCTphPOry+kP7B/4G7ZFgNl5MST7a7LYt40CattWI5FnvxdcTPt0pHVWWGWH8h LX+R0myQDL5dRrckzGr/PkUv0mfYh3X0DtIV1YCpg7imjCcAPdVt3Gam1I0a/S1ejAdD td4bpNElVqR2gqvRYbHZz0NrSDHpW2+ft29TuHMioLecnGAMqJZlKKEwFSV3wwy+3pwz NfXPAlGOsJh1Rn/IP19R4oordH7NTi64cScumuC4CvvVwEudPfRCCf95gsWl1+quyVDx 4p0K9pQmpxs1yhRd6Y0t3tCRpIMhywoGKHYpdDm9r4yI/fOzlTD2YV8c9nneQTh0c+IQ 586A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728021783; x=1728626583; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9uT0gyq9/27a0mVA0jNvIMvzrZ18n29ZzLq7ol7CTAw=; b=UavBU4OyFB0PAv/img9jKtav/LIb01Xh6tsDcutgA3vl9ieewce7qN3FioMmITg8ir nNJGaPCQyT6WM+CWo5hDoyTfGXAZt9XdJDdS+Jy//2tbuMIAQkzZ3m51bz8+NU0e/p0X X896RMlV42zioshghHw5EZ5FzvgHyz5kB/tGg+wNf0S2v8cv4POnI7FD7KepxP4ezBdt w/W1kl5zOTQqJpCNE1rTm1D/m7lX6FHNp4H7WLX57EeBLlWhKQtb5XWjTptX2IYXNcGD znKEqXoJ/N7cuPWptqf6MpoRCfuI5hA7kvMrjcuHImoCmz5gQUp2Q+beNrHs8yH2Qeo2 MQew== X-Gm-Message-State: AOJu0YxeND1uL675N4WTMdzdtRSM3pLG7Z+FXIqiQTyakDXRm/G6WEQ3 oszOLAieJgznrrAT+ybItYWhr2L5h2apZbo70/6pNpCY/7lk2pHbtaKCpphidcR94iJ7lrg1ajS 1 X-Received: by 2002:a05:600c:548a:b0:425:7bbf:fd07 with SMTP id 5b1f17b1804b1-42f85aa3c1dmr10210995e9.5.1728021782903; Thu, 03 Oct 2024 23:03:02 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d081f7482sm2584752f8f.8.2024.10.03.23.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 23:03:01 -0700 (PDT) From: "mattock (Code Review)" X-Google-Original-From: "mattock (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 4 Oct 2024 06:03:01 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I49f1e7d25edb62bf202ffceb45dedc213f2eafdd X-Gerrit-Change-Number: 776 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 781328842035c72a1f8db6663d1c6f4ff6478e4c References: Message-ID: <07bc3590c0b3cdf5100f0f5df13bb8b925adfa94-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1swbPG-00020m-JA Subject: [Openvpn-devel] [S] Change in openvpn[master]: t_server_null: persist test log files X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: samuli@openvpn.net, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1811962210558676717?= X-GMAIL-MSGID: =?utf-8?q?1811962210558676717?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/776?usp=email to review the following change. Change subject: t_server_null: persist test log files ...................................................................... t_server_null: persist test log files The goal is to help debug issues with t_server_null. The immediate goal is to be able to debug server startup issues encountered on some of the *BSD platforms. Change-Id: I49f1e7d25edb62bf202ffceb45dedc213f2eafdd Signed-off-by: Samuli Seppänen --- M tests/t_server_null.sh M tests/t_server_null_client.sh M tests/t_server_null_server.sh 3 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/776/1 diff --git a/tests/t_server_null.sh b/tests/t_server_null.sh index 7627edf..61a9cdc 100755 --- a/tests/t_server_null.sh +++ b/tests/t_server_null.sh @@ -56,11 +56,16 @@ fi srcdir="${srcdir:-.}" +export t_server_null_logdir=t_server_null-`hostname`-`date +%Y%m%d-%H%M%S` + +# Create directory for server and client logs +mkdir $t_server_null_logdir "${srcdir}/t_server_null_server.sh" & "${srcdir}/t_server_null_client.sh" retval=$? + # When running make jobs in parallel ("make -j check") we need to ensure # that this script does not exit before all --dev null servers are dead and # their network interfaces are gone. Otherwise t_client.sh will fail because diff --git a/tests/t_server_null_client.sh b/tests/t_server_null_client.sh index c1a25df..846f790 100755 --- a/tests/t_server_null_client.sh +++ b/tests/t_server_null_client.sh @@ -14,7 +14,7 @@ $client_conf \ --writepid "${pid}" \ --setenv pid $pid \ - --log "${log}" & + --log "${t_server_null_logdir}/${log}" & } wait_for_results() { @@ -44,7 +44,7 @@ should_pass=$2 log="${test_name}.log" - grep "Initialization Sequence Completed" "${log}" > /dev/null + grep "Initialization Sequence Completed" "${t_server_null_logdir}/${log}" > /dev/null exit_code=$? if [ $exit_code -eq 0 ] && [ "${should_pass}" = "yes" ]; then diff --git a/tests/t_server_null_server.sh b/tests/t_server_null_server.sh index 10bb44b..9393b9c 100755 --- a/tests/t_server_null_server.sh +++ b/tests/t_server_null_server.sh @@ -13,7 +13,7 @@ "${server_exec}" \ $server_conf \ --status "${status}" 1 \ - --log "${log}" \ + --log "${t_server_null_logdir}/${log}" \ --writepid "${pid}" \ --explicit-exit-notify 3 else @@ -21,7 +21,7 @@ $RUN_SUDO "${server_exec}" \ $server_conf \ --status "${status}" 1 \ - --log "${log}" \ + --log "${t_server_null_logdir}/${log}" \ --writepid "${pid}" \ --explicit-exit-notify 3 fi