From patchwork Thu Oct 31 13:29:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3920 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c09d:b0:5b9:581e:f939 with SMTP id jr29csp1630076mab; Thu, 31 Oct 2024 06:29:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVn8RDsEJa2vEuZHE+g2yv0fhzT346N4c18H/w4CjkHAfZ6HRSib7Utnu/5aG992igEvYtLJpgoLN0=@openvpn.net X-Google-Smtp-Source: AGHT+IHykW0bWk+fhdh3wnUGglMNCuEqTe3OsWYrjSZn810dAFLONF0aQohHeekWklJVHKbD9GAJ X-Received: by 2002:a05:6602:160f:b0:83a:b52b:5cb5 with SMTP id ca18e2360f4ac-83b64f92b7bmr302573539f.5.1730381397571; Thu, 31 Oct 2024 06:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1730381397; cv=none; d=google.com; s=arc-20240605; b=edgba5ID3Q/Q3Q1y5Bi6Ge232ujf0JfttFG2u2VKLVKq6QTOxesrrPPAHPf4BqTcA9 q4l4XfqFu4Wvc3cVT+FGAPJ4/wpqlJnM1zUZTi8qawZLAjLFD7Ie87upFrhePP6Qbev5 L7Mqxbw4fR+SvXDxSBNFvFRQxndhZmMw0AplDRBsJQPS04PLWQyh4gNrXzKXL7JuA6Ep gAUIiy37gxdxGYt4qAZWTcZaTAKbdrFX5oo44966FL32vNIzxp0ps1o2fUiUYfHAsiL1 l/RXV2c17/FJBi/sDFEb1xu7JczptqmurJwnCTwkSTYmt8h9quvATjkNUx6sAIMNh23x 9V+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=/UIaxr+jH7Vid2HjzttPjUXSYHD9AFyeYm9QYArAoM8=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=RBJqYKGXsosVb4hVrfiCbUXFZSTdghQlgu95ofFZm8P0ktbhc3H1gQdhpvh5WWD2/w P3uf3MUGc2LlPCeW5hPDUBd6vr0gHEiAfRxiHy1y3ww9l/14QanrlCBdnLvTNqOnphcc RLY0tNmI4tpvFHs4TRfWuVN8UKDWW/XeiA7tSVf3suKCUJLO3aXm4ynVs99CUAugoU9n 5/7ALdFhsnSbUsvBVh8CcZMjeQwN3tBA760cGC/sCEvbUeX5bLjnYHVwKV9R2Fr51WWY wXsLN8Tb3MbAN9fbrbu2tzSAClDw4Od4FpeRWz3TUaR7nOvZhh7w7BK+gK5qB4TgT9K/ Ss8g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UDE12IdV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=doEQtrZb; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=PCfOoGlr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-83b67b379e6si62892339f.68.2024.10.31.06.29.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2024 06:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UDE12IdV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=doEQtrZb; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=PCfOoGlr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t6VFA-00014O-8K; Thu, 31 Oct 2024 13:29:43 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t6VF2-00014A-Gr for openvpn-devel@lists.sourceforge.net; Thu, 31 Oct 2024 13:29:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uyAYKF8v8gnTTjk9X38GDBYO5POXdywvqCEfu7DLKSs=; b=UDE12IdV/tjXMZC7R4gzepVftM p5YHsuZAnTo1UzWVcjWuNVpCcKmC/ELxJtc8KZfK9qWfIh7hJ/kunH66Afcbqf4lXb518Ye+9nb/c EDGSWX2QA+mObqIa0W8JZ3NteYBS5zE7/YWRsBpgebcIoe+MzTYt0ksX6S22Njs4XK4U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=uyAYKF8v8gnTTjk9X38GDBYO5POXdywvqCEfu7DLKSs=; b=d oEQtrZb+L1Owv8xGRRCG29Uw8SiQ0rZ5VrXTJr7N5X8T0Fo+ddfHLLLP5zSXm0lnZgEz0RdfzbaiU +WV0XPvlbqPM/8bvnYVBjWUc2HUPBYkJ4GFAsFs1wXQZMA+p3AaOJ3xGZ4rRTVppf1tn4YrWG4+8k wxi/JZdgaCt59YZA=; Received: from mail-wm1-f50.google.com ([209.85.128.50]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1t6VEv-0004oj-GM for openvpn-devel@lists.sourceforge.net; Thu, 31 Oct 2024 13:29:31 +0000 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-431695fa98bso7227855e9.3 for ; Thu, 31 Oct 2024 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1730381358; x=1730986158; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=uyAYKF8v8gnTTjk9X38GDBYO5POXdywvqCEfu7DLKSs=; b=PCfOoGlrmuzifaGL8bYcQMtmsNjWYqS5yfJNiIQXvtALswno97yWkHBktD87jKlUer gNO9lQYQjHusxqyr7mneYEmFoFZqugNS6J9tnng9uaZ7vIXZco6EJUcGTeyI1VasEOve aXyzqHtF5Ps9APR2S6R3Z1ZVRpZxn1XsNiD+zCTvOvrWe4vyZND0wsTn7sILIH+UTaUJ +SVN8BYDan8OpWiV0rbDs0X2/JQ+0KguZkp8KkRt/8YnCe3RT9TPba81xCu1WdICxSdy ErLAKCDD81cijmbra2u5YAFIKYYzTwtpkGn3PpFZPrhM3e/YAFAByNAD+eqf8cATgkAg Ee8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730381358; x=1730986158; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uyAYKF8v8gnTTjk9X38GDBYO5POXdywvqCEfu7DLKSs=; b=fKswYGzEzxFCUJEfzFDOuiBXDiXaIrbIF4Y8tiGqpEuIiBDrzNjlXQ+ATup7FqZkLF k0E7tJNhg9Cnw8xqlWEXGiBXf9oPj2/XTxMUvYdoWmPxKBZ5/PTkSvmtIz6vtWpu+3Mi cKl+AYwDG/mCUd5Ffja/ZIovQXJAkQ39hYLChrZgBgimhxf8xgJmSQL1YF+TSRY9uPCo RHvlXNBnw6j+5pet9LIhaOgUy7im7G02M0ju0DrKMIdpF5nyLAfyUe/JNcbKu5RfOXgQ FqM9kM866Bs41stItZYbqDOYU+62fbqUK9Yl+xhF73YtZR7F6SVk9+72iaKzq5wZyqH2 LCXw== X-Gm-Message-State: AOJu0YwI6HJ3CPn/0kn9E8A58MGhcrK1u0QXBUsSSjWa1n20inaHoQSI Dp2TwjbXsdZMCcYa2UrC24KDgE/JdbNr//swIF9VHf2sOAxlTSA453690HKWxdDFjNTxbmGLPdY 9 X-Received: by 2002:a05:600c:5249:b0:431:6052:48c3 with SMTP id 5b1f17b1804b1-4319acacd6amr197000585e9.16.1730381357503; Thu, 31 Oct 2024 06:29:17 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4327d5bf429sm25456365e9.12.2024.10.31.06.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 06:29:17 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2024 13:29:16 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I91f68317450c3c0d69be2c489276739211ccb422 X-Gerrit-Change-Number: 789 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 67d3210acc390f4bb438be0a098ae1d6f496f788 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.50 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.50 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1t6VEv-0004oj-GM Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: General update November 2024 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1814436404463116300?= X-GMAIL-MSGID: =?utf-8?q?1814436404463116300?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/789?usp=email to review the following change. Change subject: GHA: General update November 2024 ...................................................................... GHA: General update November 2024 Contains the following renovate updates: - Update dependency libressl/portable to v4 - Update dependency Mbed-TLS/mbedtls to v3.6.2 - Update mingw ubuntu runner to v24 - Do NOT update the uncrustify runner since newer uncrustify is not usable with the current config - Update vcpkg digest to b505fa7 Additionally change the action reference pinning to consistently refer to the tags instead of the branches. Change-Id: I91f68317450c3c0d69be2c489276739211ccb422 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml M .github/workflows/coverity-scan.yml 2 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/89/789/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3958ef0..bb13ab3 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -13,7 +13,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y uncrustify - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 with: path: openvpn - name: Show uncrustify version @@ -27,7 +27,7 @@ - name: Show changes on standard output run: git diff working-directory: openvpn - - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4 + - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 with: name: uncrustify-changes.patch path: 'openvpn/uncrustify-changes.patch' @@ -42,19 +42,19 @@ arch: [x86, x64] name: "gcc-mingw - ${{ matrix.arch }} - OSSL" - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 env: VCPKG_ROOT: ${{ github.workspace }}/vcpkg steps: - name: Install dependencies run: sudo apt update && sudo apt install -y mingw-w64 unzip cmake ninja-build build-essential wget python3-docutils man2html-base - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: Restore from cache and install vcpkg uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5 with: - vcpkgGitCommitId: 8d3649ba34aab36914ddd897958599aa0a91b08e + vcpkgGitCommitId: b505fa789fd96eb5496a2e42c651c169e8460d27 vcpkgJsonGlob: '**/mingw/vcpkg.json' - name: Run CMake with vcpkg.json manifest @@ -64,7 +64,7 @@ buildPreset: mingw-${{ matrix.arch }} buildPresetAdditionalArgs: "['--config Debug']" - - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4 + - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 with: name: openvpn-mingw-${{ matrix.arch }} path: | @@ -72,7 +72,7 @@ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/Debug/*.dll !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/Debug/test_*.exe - - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4 + - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 with: name: openvpn-mingw-${{ matrix.arch }}-tests path: | @@ -91,9 +91,9 @@ name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL" steps: - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: Retrieve mingw unittest - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4 + uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 with: name: openvpn-mingw-${{ matrix.arch }}-tests path: unittests @@ -165,7 +165,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev libnl-genl-3-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${PKCS11PKG} - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: autoconf run: autoreconf -fvi - name: configure @@ -195,7 +195,7 @@ - name: Install dependencies run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev libnl-genl-3-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: autoconf run: autoreconf -fvi - name: configure @@ -235,7 +235,7 @@ - name: Install dependencies run: brew install ${{matrix.ssllib}} lzo lz4 man2html cmocka libtool automake autoconf - name: Checkout OpenVPN - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: Set environment run: | cat >>$GITHUB_ENV <