From patchwork Thu Nov 28 12:04:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d12fk (Code Review)" X-Patchwork-Id: 3968 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:57cb:b0:5db:cfa9:4424 with SMTP id v11csp1176206mau; Thu, 28 Nov 2024 04:05:18 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXIGNYW7KRsosH2IHbT14Vk7sTC+rpGi+QG/AT8KEqdwwmB/nMRYZZlSD7Lh9773SM7mvrpmf9BDig=@openvpn.net X-Google-Smtp-Source: AGHT+IGYQTT3vLhRBJZElZkKcDmz7htDIxnOa2fWQoXQsbnXaE1LkTX/9dH8d97IcKOfT+Y7rHwY X-Received: by 2002:a05:6870:c07:b0:297:245b:1e38 with SMTP id 586e51a60fabf-29dc4304e64mr5729450fac.33.1732795518131; Thu, 28 Nov 2024 04:05:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1732795518; cv=none; d=google.com; s=arc-20240605; b=PRZsX9gfrnBevrvejZw6+I/9fiIgpfDhyl+HTCPFG3HjLWg6/SXTF92cEAHL4f8ujl UqyV9Jv2ljhGW9JJyjeuSXxCW/KQw3jpSFsP0l248XdzBBsgW6SYvqwYYe60RHUul+kR 7AR/07fmQ/G6DKxchHv2jeCgW+tR0o63gbKU3nAGzQfQvb8MUfH7hLa+Ia45UVDXr/fR VcxJX6gAqP65KVgULJ6tLP8zs8t9HR0QkQF/E04ZstJjZRuOYsVfRxc5zlg/kFLXgIWI BPufRD894GAv+f9y3c3CHNHdBG6C9qpK9psAfza/GdjJIeKpIYWl9EbUKtKm8ZdVyBjd PsFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=PCUCZtIckI406mhLX8hZiWxco49i9X1JnkpMIucaGz8=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=SKljnjSah7+LOcboFMJDiCY5bjkGaBYjaax8tqAJVdVSGTA4ogUmvTgDOuEyszqwnR UAeXogUJEZFX6GH8TzNqOcumlUarXvXW4GvcpVQjSexNYwd1ToW3yGK04eDf0bjJ/KLe q82/kGc9kC+uCKo8fY08zqV6Oe7NecLUx6idQZpWEXrplHVKEU2w2pzi/ymFmBJdNctR TIhDK0cfiZCSo23SKrJtdiTx6/46HLSYhKZwZmObdWkWQB5TSG0WrJDpjP5biUPVzQwH Wm0um771kaEjGVmcwm0tHjLS79Yn7/Xhk3ewzEvjErNp1H4LU/bS0RiRho4++jXcdc10 bPJA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mUhEEK2C; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JXK4IGm4; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=XZMLbPFN; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-71d725f3dedsi527426a34.242.2024.11.28.04.05.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Nov 2024 04:05:18 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mUhEEK2C; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JXK4IGm4; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=XZMLbPFN; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tGdGc-0002o9-O2; Thu, 28 Nov 2024 12:05:06 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tGdGa-0002o3-RJ for openvpn-devel@lists.sourceforge.net; Thu, 28 Nov 2024 12:05:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bSpQfzW9v9KWSqo7YKaKFugQhLVYltiee2ilVpWQsEs=; b=mUhEEK2C2lSwDUDArb3OINitBm /QlrC1ue7hO9XE69qCAcEiLLmpZYM7M4mVUmRtnoQrfRKpWHs0IhtZF8MxNOUC5ZrrMlXvH/E8Pze /IcJpuQNPU3EhmItK1Vb8STryW2MxLjEHVzn8Fq/lOEzzBFmV9OuNeyidS0q9j2FbZm0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=bSpQfzW9v9KWSqo7YKaKFugQhLVYltiee2ilVpWQsEs=; b=J XK4IGm4EYnVYoVGXgR9/ehubyF7qmZmwhCF3njI8bEZcI5vSwnXItVTitIcHF0H0T30l1SBF6KyW5 Hf50WqH/07RRxjC4SKPyM0yHyn6bga8t3I8oOwxVXLfL58mzFoRYcuTWCeTzmSzknIM4bqky/laBu nhGoNdiZ6unC71PA=; Received: from mail-wr1-f47.google.com ([209.85.221.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tGdGZ-00078X-MS for openvpn-devel@lists.sourceforge.net; Thu, 28 Nov 2024 12:05:04 +0000 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-38242abf421so464450f8f.2 for ; Thu, 28 Nov 2024 04:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1732795492; x=1733400292; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=bSpQfzW9v9KWSqo7YKaKFugQhLVYltiee2ilVpWQsEs=; b=XZMLbPFNxLlK4PYGsGvSQPZEWM7q8qNR9gujaefM64yJu3YzAYH93dwEplid3z27D/ Fc+Xn/KDAU2ueAhze86Tdph50dyiJWeZIux97ntxFzMBhtmGEx7euXWpxsEryOQP017I qEWvRcqoYLZyo0/k6Z5zkAaPtRX4V5y4DZ0yhAJfvQsfGMseIzrS0wFC9MZK9IaGtsds crzRRvelUYlzEDmFnHYA0ht6JqomhuTf5S9J9xGd8XusnQXzc0HqEJfgMtIDIQxzHUqH vvnaQn7IQacGdgzfJI0O3OqkOV9sjhBXkF4CsNgcgvMQC4+pVefgRaSr4MVhPLxvQtwr WFnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732795492; x=1733400292; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bSpQfzW9v9KWSqo7YKaKFugQhLVYltiee2ilVpWQsEs=; b=M57/79+Ml8U58XGPmC05FJo3eqg0msSrICz4Qu8l8cGG87qMomP1XTOkdRtH6FBTA4 w/WeNDbi/5rx62+E9p2X7n0U9w7+SZO/Q1qsQ2/9nuANkQOlaOy4q4gye5OrKxz9E/Ol LEHX0KIfqNbM6jl+pFAVZpsPE5gWBTksAUDGaYRTfAc+OxV6nZrxl3NmtK5H4UIq2O2g MqFb1g6K6L/0tFh6w7uXqzHKwfwQxPrjadqIv5kLwgSVlU/ZXSF9uKTA1zvzoNCZRn3I 5SkNYYjRGootl3qzKfruJBlE7ei7W6ORJ2IJ4ekLPxRqFCmBSmKW1htJq0E7rRSVR38w KO9w== X-Gm-Message-State: AOJu0YzVEU/kSVITlwe55+E6EyPXv/DIy7AEwa/HaoFxpA/sZ3MTzXLh 0TZLv1OymeJuoRZKqNN3dx/5HiWxgKzs8ftyrW2SUwyYjNZrxigFqhjzgFjkmoBuQjQZ6Lrq/1i f X-Gm-Gg: ASbGncsR+X2lxRl+YjAnnspCBIWp5RQsrsIVFYWC6/8IilRO7GlUMRdj1GEkc9oSjN2 yXtpGZwM75TXFaBgD7fTxmDcwclpb7zPX1rLPjh8XZWRF2yVMAJyKsKdN2OYULCzC4nPUjwT3HO Gn55Qv9U5OOIp1PpNBoDdk8a5+WgM1n8kTLsLesxgA5L7IYCCI6JZahqaXN3GW0An4UU53OFQv4 x2ZjxV6nom0ze/iDLlg/P18TnnCB7vUKQUkVOIph2jAMysh8sA+W2OkgGVOdy/K32q7PUyZDt3h 5eS2i5dS0m+ehf0QTc+mKE0DS6FP9h4P2nB/Tt8m7A== X-Received: by 2002:a05:6000:144c:b0:382:397f:3df4 with SMTP id ffacd0b85a97d-385c6edd9b4mr5421412f8f.42.1732795492079; Thu, 28 Nov 2024 04:04:52 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd2db4esm1480402f8f.20.2024.11.28.04.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 04:04:51 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 28 Nov 2024 12:04:51 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ifad21a2841e97e910775f3618ddac1c483d74b65 X-Gerrit-Change-Number: 822 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 7abbea95608a13074f0ae8638b24fa43f27dd61d References: Message-ID: <63c25cfb2c0bc003dd399a12e01d3c1a6f564e80-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -1.1 (-) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-1.1 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.47 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.47 listed in bl.score.senderscore.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.47 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.9 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.47 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tGdGZ-00078X-MS Subject: [Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1816967793293754913?= X-GMAIL-MSGID: =?utf-8?q?1816967793293754913?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/822?usp=email to review the following change. Change subject: Various typo fixes ...................................................................... Various typo fixes This collects some minor typo fixes that are not worth each their own commit. Fixes: OpenVPN/openvpn#644 Fixes: OpenVPN/openvpn#442 Change-Id: Ifad21a2841e97e910775f3618ddac1c483d74b65 Signed-off-by: Frank Lichtenheld --- M doc/man-sections/connection-profiles.rst M sample/sample-config-files/server.conf M src/openvpn/options.c 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/22/822/1 diff --git a/doc/man-sections/connection-profiles.rst b/doc/man-sections/connection-profiles.rst index 520bbef..767ff3a 100644 --- a/doc/man-sections/connection-profiles.rst +++ b/doc/man-sections/connection-profiles.rst @@ -6,7 +6,7 @@ options which are related to specific ``--remote`` options. For these use cases, connection profiles are the solution. -By enacpulating the ``--remote`` option and related options within +By encapsulating the ``--remote`` option and related options within ```` and ````, these options are handled as a group. diff --git a/sample/sample-config-files/server.conf b/sample/sample-config-files/server.conf index 48716a0..f6d9e65 100644 --- a/sample/sample-config-files/server.conf +++ b/sample/sample-config-files/server.conf @@ -199,7 +199,7 @@ # all clients to redirect their default # network gateway through the VPN, causing # all IP traffic such as web browsing and -# and DNS lookups to go through the VPN +# DNS lookups to go through the VPN # (The OpenVPN server machine may need to NAT # or bridge the TUN/TAP interface to the internet # in order for this to work properly). diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 043b240..d8dd518 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -879,7 +879,7 @@ o->pkcs11_pin_cache_period = -1; #endif /* ENABLE_PKCS11 */ -/* P2MP server context features */ + /* P2MP server context features */ o->auth_token_generate = false; /* Set default --tmp-dir */ @@ -2966,7 +2966,7 @@ if (options->pkcs12_file) { #ifdef ENABLE_CRYPTO_MBEDTLS - msg(M_USAGE, "Parameter --pkcs12 cannot be used with the mbed TLS version version of OpenVPN."); + msg(M_USAGE, "Parameter --pkcs12 cannot be used with the mbed TLS version of OpenVPN."); #else if (options->ca_path) { @@ -2995,7 +2995,7 @@ #ifdef ENABLE_CRYPTO_MBEDTLS if (options->ca_path) { - msg(M_USAGE, "Parameter --capath cannot be used with the mbed TLS version version of OpenVPN."); + msg(M_USAGE, "Parameter --capath cannot be used with the mbed TLS version of OpenVPN."); } #endif /* ifdef ENABLE_CRYPTO_MBEDTLS */ if (pull)