From patchwork Mon Dec 9 17:54:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ralf_lici (Code Review)" X-Patchwork-Id: 3979 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1d8b:b0:5dc:2311:f747 with SMTP id hp11csp2784916mab; Mon, 9 Dec 2024 09:54:49 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUvHnjElmMhyZt9dq8JORzRlqdcA+PiQkfNxCTSN3XiiO0I+aZIptiCMdmK0jaCJ0/mv8CC/IebYwU=@openvpn.net X-Google-Smtp-Source: AGHT+IE6KSIqixZ8e3JsYFRKyJaSuKFozBHEaHV2rJD7Ucq0PlxlwWD7ogeDOBwrzN78k2BUz29c X-Received: by 2002:a05:6e02:1487:b0:3a7:7ded:521b with SMTP id e9e14a558f8ab-3a811e00f3emr123006025ab.17.1733766889707; Mon, 09 Dec 2024 09:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733766889; cv=none; d=google.com; s=arc-20240605; b=L3kElAbGQIEFIW7Yf+vuxFZIH9abLn5XsEsz17PUl4tR7ImXG5JRH6osGu8PqZTD0K 7USIZ6/LXfQJPVO7H6zOMRnkbGdjpT6LrBcuF96zG0xkOMhb6wV24CPdWCJ1a0ybGdIq KzoyWtUewoIJoqu+9wIHQCQlJSlebCxwuaXF9KY6EiWxEOpu9id/502LTkr2xRWULT3F MAdtx7Vs5n7+gijDSvo//qaqdEWsid4k8Sb8+jOD3fZRjjH2uDpKNFfH4MYGHKY2XpRE nvfE28a+UlxDZNOceRPq3MiB+EGBTyNvGwbyVeIl6/2daAq9R55OrVV82nh/uwvC4+U6 uN8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=wIYLoolbwsnDuPLItYofhrqzf3nSCpt2dhyi0BKrE9U=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=BmTR2i9BXnXTNOzSnCEz0qtVtq5Ul0eJUuKrBIbXQwdb9GNsX9pSM8KqWcuHw1P2FA bCdxvgQqUQLwnKlzNGmMlIGVKjwZVAVRb+ivsOkrEWsO2frZdUJXJJUNDz+95cfsu6e+ sLqldLAoC3MMbMtt6FIpwM3Jae7Ekn1RFkZfBOcjKgZqVaEPzzlDAp9wKCwNNlEeF3zM eoMk3U3PmeUnfRSt8vNBKrpgiZHBYVxYLXr79WW57qF5rbAAO6kUK6Y+0Nkyrp7aCDIt zgVTVrQmYd8rf79uzBmWsiNkGDpEdHynwCrpo4ixS4MmvcTToFkPr1VrvwcC92gvAeIn 1VWg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OfHTn609; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UBiwxihk; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Qk2GZD/0"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 8926c6da1cb9f-4e28624d881si4242342173.108.2024.12.09.09.54.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2024 09:54:49 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OfHTn609; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UBiwxihk; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Qk2GZD/0"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tKhxy-0003Wc-2E; Mon, 09 Dec 2024 17:54:42 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tKhxw-0003WQ-Vz for openvpn-devel@lists.sourceforge.net; Mon, 09 Dec 2024 17:54:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c5m+tM4VW/vpq0pVCSqTq97DS5cCxzHjs7hzoX2LGOk=; b=OfHTn609dlqKLlUyO/HNcIB1PA IOgBwdfjAEs2guxZiC0PQqh1ZHkgGUCpKP59GptLrsMEM/55myc/bJJePpy2aTU6SUfkMKQ825pwj 8PIr980rcZHusZVQ/XnyN7FSz9FXevf9xYwDQ0Uhf/oDCaofl2G2VBKdBWWIWPqHd+4M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=c5m+tM4VW/vpq0pVCSqTq97DS5cCxzHjs7hzoX2LGOk=; b=U BiwxihkNQDgaVFcAdXxp3lPuA7VY+cUeLHfpm7butlzebgrs2WJHP2rJBQ1pN3auHfyNWjhVLrA6m SKNBMpe9iPaaGV5GilkbdTCqyCb0VX5n0heePF4HPh9DxukOq7EAQor5S5BCu8VvjD7Muuo8pDHR4 IoU14u8WfFkk6kY8=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tKhxw-0006xg-34 for openvpn-devel@lists.sourceforge.net; Mon, 09 Dec 2024 17:54:40 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-434e69857d9so13806215e9.0 for ; Mon, 09 Dec 2024 09:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1733766868; x=1734371668; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=c5m+tM4VW/vpq0pVCSqTq97DS5cCxzHjs7hzoX2LGOk=; b=Qk2GZD/0EOZvZ09p2ETGcweChkgl/L4A5OJK7h7wurkgiFbufX7f8ouYrZ9gHxiGF/ PHbK8KL2FT8NbTAK7DPvWZ4NtAf3/J44YRnLX8pLtMyptP7kKNXQ5yYqX2pL9GzjVpuz ZP92V6mhESC/tC6czyq9ol4VpCnsO6xA6uU0AVErul+Vn5pIUZpx3xnzIXAOFI9UG3C4 JCSau9bjzyHVcN6v/hNTd/B/p+IF6fE0HXhN7v+/s8ORrkUc1fgWJea/RPk7KzqPqlK/ 4N40muwKQ2bnXHhwkRGhiS/0mVPo1c22SWO5EmNwN8vGg92Ki+B0epE3nyojKm+4sBOw uqEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733766868; x=1734371668; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5m+tM4VW/vpq0pVCSqTq97DS5cCxzHjs7hzoX2LGOk=; b=fE+iZ11jtD/dlWmvCU8RmtkmDPUD2MIsFrZn/dmkahlSapIJvqwndiWMYhUqjuSq72 UgRIKPOrDbNuE0pgCDBQztr4AV4RMVmqiEc2ZnAHtzW8Apn1B4Juo5A5lAj7DbIUUJGv 9zb4zRYpsdGrjxIWJ79F2lusfuvIeRQtbnOh/ZQgaw+aAI4u2REUinFh6cfGKPzDwcCq /yqaUxmZS0qp6ru/MP6sVrL7gxJY8/00Ob9HumYcp1z4Ulv+rAmIySh4vXwo3JpQfL0+ kEQcRvnQNYnFRkwR+uwMayrXqtBBgqLCUUKxrJf7mfYiXmvpLNJgNz88JEj7pm42yPOA 3pzQ== X-Gm-Message-State: AOJu0YxHHI5HkLCnz/CaJoTfr+rNxWtBVgPfWkmLAwldJYUq8dE/6w5c 3lCcTTWaV/N/VBvaA8drBbmkoPKVQQHPy6WBRWGFt4mbQUMOaDd2Hhu38GDzDyKCXKr9J49FK9q 3 X-Gm-Gg: ASbGncui7fMdiNNtx2JKr1PDfeD/O1KgbzjFJvRtwx+zb/HpN0//9wFI2I+yBOtm4xd u0R86OnX2zHc2iItcMzAEVUpFxXpuOZleNy51NjkQ1OMfH8+nKMrW0SLA2PVfvSLHcSGfxrLTgV SmeX/VFqKfwUjT+bvSzCZmxzCrH14nXBaSHpkryj+7JygZ1AQ+dov46oIq5/UrHdsAMlV6CRHZw fbb8ZJQPMO/zyJZiE5qbDW639I+Ko5QT5EvubMo5ulO4mPYkGFoRsfT7l+9D5qkw3Wr8dNsDjzl 0saRF/21lWRFDIMHS5Yv6aGWxjnPHwrsHDpX7UOZOg== X-Received: by 2002:a05:600c:1d01:b0:434:f2af:6e74 with SMTP id 5b1f17b1804b1-435021bc588mr2472075e9.15.1733766868417; Mon, 09 Dec 2024 09:54:28 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434fc530a2dsm26910005e9.11.2024.12.09.09.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 09:54:28 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 9 Dec 2024 17:54:27 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: If472398d4ff8323de485f084a07160b365dfc501 X-Gerrit-Change-Number: 826 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 5f4c6a6b477b3c6a4795683f4562225a48dd05d1 References: Message-ID: <5254714c1a270a4f4c43ab6a1aa66f11fbf86e28-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in bl.score.senderscore.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tKhxw-0006xg-34 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix memory leak in ntlm_support X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1817986350071526026?= X-GMAIL-MSGID: =?utf-8?q?1817986350071526026?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/826?usp=email to review the following change. Change subject: Fix memory leak in ntlm_support ...................................................................... Fix memory leak in ntlm_support Not really important but prevents running the NTLM t_client tests with ASAN enabled. Change-Id: If472398d4ff8323de485f084a07160b365dfc501 Signed-off-by: Frank Lichtenheld --- M tests/ntlm_support.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/826/1 diff --git a/tests/ntlm_support.c b/tests/ntlm_support.c index ccf8962..18d555a 100644 --- a/tests/ntlm_support.c +++ b/tests/ntlm_support.c @@ -33,11 +33,11 @@ int main(void) { -#if defined(ENABLE_CRYPTO_OPENSSL) - crypto_load_provider("legacy"); - crypto_load_provider("default"); -#endif #ifdef NTLM +#if defined(ENABLE_CRYPTO_OPENSSL) + provider_t *legacy = crypto_load_provider("legacy"); + provider_t *def = crypto_load_provider("default"); +#endif if (!md_valid("MD4")) { msg(M_FATAL, "MD4 not supported"); @@ -46,6 +46,10 @@ { msg(M_FATAL, "MD5 not supported"); } +#if defined(ENABLE_CRYPTO_OPENSSL) + crypto_unload_provider("legacy", legacy); + crypto_unload_provider("default", def); +#endif #else /* ifdef NTLM */ msg(M_FATAL, "NTLM support not compiled in"); #endif