From patchwork Fri Dec 13 10:51:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ralf_lici (Code Review)" X-Patchwork-Id: 3995 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1f13:b0:5e7:b9eb:58e8 with SMTP id hs19csp287261mab; Fri, 13 Dec 2024 02:51:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWLYuhuBhhqobkI9+BpekpJW7h3eeIWiiVWL/HNp1/Kz8WtXeW5+1CSfXw7Q53BggwFCu62JIoaNaQ=@openvpn.net X-Google-Smtp-Source: AGHT+IEArwf1ORWr5A/ShK9s/0Sb1AEXmfVCHdcVvjC4w+9+N82dT8ByVsQCxsJgkHtQqRLJRILe X-Received: by 2002:a05:6871:e495:b0:29e:5f1f:152d with SMTP id 586e51a60fabf-2a3ac49634dmr1203382fac.8.1734087108418; Fri, 13 Dec 2024 02:51:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734087108; cv=none; d=google.com; s=arc-20240605; b=aHsweIuc1pyimx2CDQAj3pCApW9VXMyZcbbjuWXptzASjM+U/n7G6KbuQhfQeZcVUa 2c6hGlUfNzDMsAXZh47mQvidf8hUYuENcs15ruDIoiqbyWlwsXywkqIpnd66oMKJ1mFc 3SXvgaOAmBo0bOIpkiAMk+JCq4mJvJSM3x61xloFI7uCcnPPhHw2LPEPdK+J9a1E6OJP xXJT8fo9WBDmm6aaMobONDJPJBEnEGIHGk4puSgPcTqH+H+8XcTxzTDVQwTD75F2mRDv 863Mt+th7MStPLgr0Jl/gjeF1OnWVrtqRZfiP5XO8deUjFaMS1IxFxjp+ld28LA1f1bg mmbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=iHVBGerrzPb/sAH4WzyVRyjGZJMz4A/aQDspCHfQ0fU=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=a+iTr3RiY5nqtoMgf+gpQoiKlvWG3iQBqI6pXfRNA0Xo0GWZaHQtg2qC2l/5DpJDRX xH7RrnutTYV669q5kBaYxj34VOeqfAqyyCehJNNRL8vsrtBzN5l07BVw8j7fRR6WMi2T p9FKlYNUsSblLO+K97tPJsT8agm1A3sN0wGTIrs/sedFFeGWDtkTyv/7XkhFkoeqoGg+ BNHWb7VQLHu/aT9eoyiazDlet+xcsH9Plib1T1hZgxcjUJGVhvqaE1anNPzJ1no1Orf1 b5RQRpGNmm3/qUlq1NPpAH+g9sNhxnMOmHnxg99sHeKT+mdtkDJg81LFoyGciygkfJDO lM+g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=bQKlhmkL; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JMGuhimv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=VIw0QTVr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2a00e070261si4140267fac.84.2024.12.13.02.51.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2024 02:51:48 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=bQKlhmkL; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JMGuhimv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=VIw0QTVr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tM3Gl-00036B-OJ; Fri, 13 Dec 2024 10:51:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tM3Gk-000363-F6 for openvpn-devel@lists.sourceforge.net; Fri, 13 Dec 2024 10:51:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LKtaV6xlz3fu9WHt4g1qbCV8fQSY96cNe5Q8NGcdmQI=; b=bQKlhmkL4zWNcATQ/ljr6FW/9m HigtiqqYOv0JFnketrs0NVvTNiXhjzcx/OvB/w8qFy+jRQ6L8uk5K60m9Qt78mG74T2jP/pl7vqPW zWCOkm6ZywL3tJmffn5yYiOMHNhiDOyjPmyQysldDvO42NVg3iDw73M3PR9olvlQy0XU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=LKtaV6xlz3fu9WHt4g1qbCV8fQSY96cNe5Q8NGcdmQI=; b=J MGuhimvKY3uZAQywKjQUoPZ8v6USRiL8tJ9yaaDRDXcg0/NdT23r1yiHsnwEnSPwb3kvR1C6gHZ6G 1pr3Hao4XxsP4CeuWuZqjxcngBEt/dLI3L6aAkvZ9tG6dYj/Tx+z1yqwR+icdkw67EHPbbWXIEYfR +RkHp9ujIqIp5NT0=; Received: from mail-wm1-f50.google.com ([209.85.128.50]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tM3Gj-0006md-Fe for openvpn-devel@lists.sourceforge.net; Fri, 13 Dec 2024 10:51:38 +0000 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-434e69857d9so9945085e9.0 for ; Fri, 13 Dec 2024 02:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1734087086; x=1734691886; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=LKtaV6xlz3fu9WHt4g1qbCV8fQSY96cNe5Q8NGcdmQI=; b=VIw0QTVrDefkzUlgfQDNS3eZCXpcJ9H8tEWJSRptIXD2IDHykM6qQBWSNaRqPFvWop vNqO6D+WQ4eO6ycAov/NYZIXaJ5H0aqiIYCiw6VTbGFRw7C2dPzks8ApfcaflZ06S/fd G3vT9fkCNntEePcvM+HN1mfBq5umxp8UKTS9KeSf60ybpP7CHab41lsoAz4UcArF7Diy SS6Vd+VaModZ2jEuatzXCK+7WlsaCXwR1LZ3m1VMJuBvjo+rpA2OWj3hCrFAiD7lrjHw 3GcUqhwsZpxIXO7Zd/Ptsnh74934yt6gKdB78QTMGVOUfCT2SosdtYB0rScKYsQlpKJP KkNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734087086; x=1734691886; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LKtaV6xlz3fu9WHt4g1qbCV8fQSY96cNe5Q8NGcdmQI=; b=OXNC/lQtvhbGou0KNjj8qIGwoN60SrxMehos+YHw1UPm8PgJ0Fc9b8ZWCqAkwaBz0Y 0FM/RLzUNoRwoXibfMQCvYXCD+JiV+/uf/+UOZsSh8lw60f70aed5KiNDrnd67D7SKYP lTxIycPgCMHY4P4djac+LE3r3g5khJNgWo6ckLATpAojJq3qxmfLXu3il2WtTTXRaQzn Gw65HFDOUpm25j6QfdM8CIOAbz78nuIoTDynnRCVCSC9JrMUfBRy0BdarQ+5y2vumwF+ kRbNQNg3Ra/GoKvcctPKMefCp4h2ZY6uH3HsR8ZKssxhdRTHTUvI+xXAJi4z9iMiqZ6K kd4w== X-Gm-Message-State: AOJu0YzbTG0GaqPoetNBeHT3kW9g5CsUxTYbWHVD2Bn/7L4WyGMUVfGY UXrQ0pfUYq2Wxbf0l/WyKXG1sKlYc1LVYnzGvw5tsMgGxwnyx1rbcw/UMigfBSrdH6Ar9hTAayE z X-Gm-Gg: ASbGncvpo6QEUwDfw1ZhwdgHbiSbTuG3aFMluiYV+hYLBF1bpXeKRoYYj1DY7ZfDuAT h5WXWzK6dIxtnJP38y4IP6xB5lnCB0mXrrprCQHi7lKtajWhvqGXGCJPrlWWXnkxHl9YYzi0RAp fXeli1Kt525SVR/l75w0Zp2+v09q2euGVSggqoCp28+B4DxkTcCPwb4EMD+PsAXCWb0XXsK3qkE HrY7FMhy7nphi04yzZ8FcjQ1zPPHdtBzpgof09nYU0hADWdLFLC+yoTFNbBLSiQ8HKuALpsJHXM iX8yOpZ9deVpup6xBp3aNnckmNs3V/xDrdvLRY3CDAFH+Eav X-Received: by 2002:a05:600c:4ec9:b0:434:fe3c:c662 with SMTP id 5b1f17b1804b1-4362b14bc1amr13915185e9.12.1734087085865; Fri, 13 Dec 2024 02:51:25 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436255830b0sm45224805e9.18.2024.12.13.02.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 02:51:25 -0800 (PST) From: "ordex (Code Review)" X-Google-Original-From: "ordex (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 13 Dec 2024 10:51:24 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I9e27ff335d892429334137d028f8503da4e4ca5b X-Gerrit-Change-Number: 841 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 91c912ed33c5892048c41f7b96c36e8069ebc51a References: Message-ID: <2e91e04f0d7c5b3289abf729faff133a762dd353-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.50 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.50 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.50 listed in sa-trusted.bondedsender.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.50 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tM3Gj-0006md-Fe Subject: [Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: a@unstable.cc, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1818322123853584082?= X-GMAIL-MSGID: =?utf-8?q?1818322123853584082?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to review the following change. Change subject: dco_linux: extend netlink error cb with extra info ...................................................................... dco_linux: extend netlink error cb with extra info A netlink error may contain more specific attributes: i.e. missing attributes or missing neted objects. Parse and print this information too. Change-Id: I9e27ff335d892429334137d028f8503da4e4ca5b Signed-off-by: Antonio Quartulli --- M src/openvpn/dco_linux.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/841/1 diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index b038382..3f0715e 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -339,6 +339,18 @@ (char *)nla_data(tb_msg[NLMSGERR_ATTR_MSG])); } + if (tb_msg[NLMSGERR_ATTR_MISS_NEST]) + { + msg(M_WARN, "kernel error: missing required nesting type %u\n", + nla_get_u32(tb_msg[NLMSGERR_ATTR_MISS_NEST])); + } + + if (tb_msg[NLMSGERR_ATTR_MISS_TYPE]) + { + msg(M_WARN, "kernel error: missing required attribute type %u\n", + nla_get_u32(tb_msg[NLMSGERR_ATTR_MISS_TYPE])); + } + return NL_STOP; }