From patchwork Tue Dec 31 20:46:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Boeckel X-Patchwork-Id: 4034 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:998b:b0:5e7:b9eb:58e8 with SMTP id d11csp8546283mav; Tue, 31 Dec 2024 12:55:03 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWndwII2CGPiP/xmd/uEDs5PaeDmHtPInkn9ssMvNRPMPlNuCqlEMztRKvfSLOMAY2rnSNzKKqh6ds=@openvpn.net X-Google-Smtp-Source: AGHT+IGLge1g2nRF+aR6YGrB9Jk4kfYFQYZ312Xc6H5RZfyC6hnITMiatNq4+cUteWUg81vqMJbm X-Received: by 2002:a05:6808:1694:b0:3eb:4b4c:80d8 with SMTP id 5614622812f47-3ed8033b2afmr20383552b6e.0.1735678502941; Tue, 31 Dec 2024 12:55:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735678502; cv=none; d=google.com; s=arc-20240605; b=XMeR4nN6TRS9y1lFFoHG0PNgKKT2evlbf/L/N9mlJcemvSz5CnSTWU2IN+vClC1rQR T7Wzw1Eg0Zgs6L+AcWhF5auFvZYd15p4rx08/05PqZQ6xXPEqJ8m84MMlblQJx2bBu4B LDrv7QARejSXkFILwU2K7ox0nnfjEhyORkAFm5CugQK4+AMqzg8XL8REenzrSKklj8U+ vEPX/J1sK1pmyzQ+FP1QBbo+mexPYO4CRJmyZVrNpNlkbHBBqmGvDg9YA2txZMedz5um rqvOEMekGPa/4wL1qN3WapQsFRg05ZSY/Dw9Cpw+KV0oYrnwWNxsuthv/SYfHoUyC0eZ km/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:reply-to:from:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:dkim-signature:dkim-signature:dkim-signature; bh=vtnrizGmIoStfnhrVv9BTcLz5+ILC3qx5QhQy0ZH0u4=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ddzHUrOypR67ZDDGWsW2+474/gEIo0/bFvDhFmTJJh/NE9aU5DP7mSX7bT8DfIQg6z TRgbjTVRPiJtna1W5JlHkt8AOBCdXfhZY1Ok7gB448jIqf0EMovWRnZPA7G++u0zClsq +Jgf0mOcI34fT1NqSGsfAvhjbGiUII6GH/pxBwWgpzMPgmrnXrXDQwgboLgali8UiZb6 JOJgvZjy3TBOmKcBM2DrHZdwBYUcNbS6U5rYlbt4grDCm8TB8YZGY5aagGnPzZFMUNNV N2Pn5ImPJ7fmbZeJjzm56jXW2XCCt2L6KLocGZ0smk80aaP90Dug74qMqKg5zJxtvKHP 0dig==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EqMnZ2RF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZD0hEqnd; dkim=neutral (body hash did not verify) header.i=@kitware.com header.s=google header.b=LjT41MUL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-3ece244d485si15316000b6e.18.2024.12.31.12.55.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2024 12:55:02 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EqMnZ2RF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZD0hEqnd; dkim=neutral (body hash did not verify) header.i=@kitware.com header.s=google header.b=LjT41MUL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tSjGQ-0006Uq-Pw; Tue, 31 Dec 2024 20:54:55 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tSjGK-0006Uc-NN for openvpn-devel@lists.sourceforge.net; Tue, 31 Dec 2024 20:54:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rcuytI6dwxt/l5LxV8+8hd3dY6o7SqDitkmum67dRW4=; b=EqMnZ2RF3BTFaCehMbA+VH0p8F ikgFJxV9l7a46xfmMWKvDqf9audzTM2rSgDd10Mqta5MryxO+n+IUJIkxIsKT6qiKWpZ9SZBEY8ys aPbgWaVjxfAQ43jAcK4Kosmn341WJPA98aZUUoYcRXwFXCJ8esieEU7Slr0878sa6eJI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rcuytI6dwxt/l5LxV8+8hd3dY6o7SqDitkmum67dRW4=; b=ZD0hEqnd/9zVk1LJiTgjNzNBPH XhS8cc5ZBmXg5FO4SynTauRzD8KJ9eBLfqwyRGv7AxSzk3kR2zK+wF7EIdSCCuaOAyiGb0TOMiNjI D8IcxY1mLKdtEh2me9mtIOvji58xv7ILIFXaxfdymFoDcNkTISPKKHlsK39pC8dac2eE=; Received: from mail-ed1-f44.google.com ([209.85.208.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tSjGH-0001sT-K7 for openvpn-devel@lists.sourceforge.net; Tue, 31 Dec 2024 20:54:46 +0000 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so19890710a12.1 for ; Tue, 31 Dec 2024 12:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1735678479; x=1736283279; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rcuytI6dwxt/l5LxV8+8hd3dY6o7SqDitkmum67dRW4=; b=LjT41MUL4ZR3B/quVmm4BqFLWxGjWTOkdEC4t+l68IgJmue2H+MuVMIdp2VJF56AkO nPnQPXVO2bpn0mOcrlv0idvQYhPjqomJrYiuR+1OD2Yga7qMD6pFSyAQJ+mnCrAS4CzO 43oiw5nSOrSSJk2jAHe6yqZxNlYf5+gn5/eR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735678479; x=1736283279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rcuytI6dwxt/l5LxV8+8hd3dY6o7SqDitkmum67dRW4=; b=AerhY9vQxuC5nBtIapnZ8fzYMJGEyTBNKKCG0aWhV2Ws20x7yu2KBQtjJeecyBoA10 qfIhcat2Hd4pOfPTriRZMHRz4aaojtTkWRcJWnBSpBEMTj7Wmg3QTDD/y/FHP4p+CUDu 5pq7cQ4HGP/Cv5pnaXi+yCzhUP9KiYbLomHGLD9/X8oRn4n7AUe/rZWKywS3urlEW86N N70pa3GGy4vzDCghz1dm7rgZN/xziQxic0hhztFXdOMO0Vn1pCaUI1U/TlgKLxm4AIVK LY+pg4em+kAa0+NSfcOJxcMpPgT6SERq00ygUF/LiNtRLTaPuE1RPU0ojwleO3zi2jVx AttQ== X-Gm-Message-State: AOJu0YyG0U0h3NHhhbC6Cf0a7VeWw0C8SQo60kjgF8JrhYG2Nr0GFA1+ IczJ+iMy3Sa/vhqKVb2sBY7JoaschZccFZvYVTt9piDXlMEfIfs/ZmnSLh8h/BVpb1iNusSV8zk 7cA== X-Gm-Gg: ASbGncuxCReGZ2aNejUKq4pO2TObeOBDWKjP8tAHu5IWRRLVFzu7/eLM/R6eircLDNz lB76S/jV3qNJKenmJ/rn/R9DaPAb9OCPn+NjkT808GIQx8x6qNih3gAYyOadxI4Jw5EGfqm6t7+ AN7iXAiEOnx+4AegT9dFlvvf0YWvBArU2W93appyC9vEgS8My5nwCx8h+fXrfZDkEuDWl/l/p6O PkkcBBarvE+WKQ3tXylJEkNO6pnkSvpDs2mL+BsfrEMbFU4hl7TsdaKjbTBJLrzUPTP7Q== X-Received: by 2002:a17:907:2d22:b0:a9a:e0b8:5bac with SMTP id a640c23a62f3a-aac08227fe0mr4017942966b.23.1735677995623; Tue, 31 Dec 2024 12:46:35 -0800 (PST) Received: from localhost (eduroam04.au.dk. [185.45.22.136]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e82ede9sm1598242066b.2.2024.12.31.12.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2024 12:46:34 -0800 (PST) To: openvpn-devel@lists.sourceforge.net Date: Tue, 31 Dec 2024 21:46:29 +0100 Message-ID: <20241231204629.1210040-2-ben.boeckel@kitware.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241231204629.1210040-1-ben.boeckel@kitware.com> References: <20241231204629.1210040-1-ben.boeckel@kitware.com> MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Without this, the password request will expire after 90 seconds leaving no way to provide the password without OpenVPN asking for it again. Given that interactive use will wait for input without a tim [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.44 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.208.44 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.208.44 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.44 listed in wl.mailspike.net] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1tSjGH-0001sT-K7 Subject: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password` X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ben Boeckel via Openvpn-devel From: Ben Boeckel Reply-To: Ben Boeckel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1819990821729914627?= X-GMAIL-MSGID: =?utf-8?q?1819990821729914627?= Without this, the password request will expire after 90 seconds leaving no way to provide the password without OpenVPN asking for it again. Given that interactive use will wait for input without a timeout, it makes sense to have non-interactive usage also wait until the user is ready instead of forcing users to race against the timeout. --- src/openvpn/console_systemd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c index cc91cd10..b208a614 100644 --- a/src/openvpn/console_systemd.c +++ b/src/openvpn/console_systemd.c @@ -71,6 +71,7 @@ get_console_input_systemd(const char *prompt, const bool echo, char *input, cons } #endif argv_printf_cat(&argv, "--icon network-vpn"); + argv_printf_cat(&argv, "--timeout=0"); argv_printf_cat(&argv, "%s", prompt); if ((std_out = openvpn_popen(&argv, NULL)) < 0)